[jira] [Created] (FLINK-13965) Keep hasDeprecatedKeys in ConfigOption and mark it with @Deprecated annotation

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-13965) Keep hasDeprecatedKeys in ConfigOption and mark it with @Deprecated annotation

Shang Yuanchun (Jira)
vinoyang created FLINK-13965:
--------------------------------

             Summary: Keep hasDeprecatedKeys in ConfigOption and mark it with @Deprecated annotation
                 Key: FLINK-13965
                 URL: https://issues.apache.org/jira/browse/FLINK-13965
             Project: Flink
          Issue Type: Test
    Affects Versions: 1.9.0
            Reporter: vinoyang


In our program based on Flink 1.7.2, we used method {{ConfigOption#hasDeprecatedKeys}}. But, this method was renamed to {{hasFallbackKeys }} in FLINK-10436. So after we bump our flink version to 1.9.0, we meet compile error.

 
It seems we replaced the deprecated key with an entity {{FallbackKey}}. However, I still see the method {{withDeprecatedKeys}}. Since we keep the method {{withDeprecatedKeys}}, why not keep the method {{hasDeprecatedKeys}}. Although, this public API did not marked as {{Public}} annotation. IMHO, {{ConfigOption}} is hosted in flink-core module, many users also use it, we should maintain the compatibility as far as possible.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)