[jira] [Created] (FLINK-12349) [Java] Improve performance of BaseValueVector#getValidityBufferSizeFromCount

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-12349) [Java] Improve performance of BaseValueVector#getValidityBufferSizeFromCount

Shang Yuanchun (Jira)
Ji Liu created FLINK-12349:
------------------------------

             Summary: [Java] Improve performance of BaseValueVector#getValidityBufferSizeFromCount
                 Key: FLINK-12349
                 URL: https://issues.apache.org/jira/browse/FLINK-12349
             Project: Flink
          Issue Type: Improvement
            Reporter: Ji Liu
            Assignee: Ji Liu


Now in _BaseValueVector#getValidityBufferSizeFromCount_ and _BitVectorHelper#getValidityBufferSize_, it uses _Math.ceil_ to calculate size which is not efficient (lots of unnecessary logic in _StrictMath#floorOrCeil_) since the value count is always not less than 0, we could simply replace Math.ceil with the following code:

_return valueCount % 8 > 0 ? valueCount / 8 + 1 : valueCount / 8;_



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)