[jira] [Created] (FLINK-12060) Unify change pom version scripts

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-12060) Unify change pom version scripts

Shang Yuanchun (Jira)
Ufuk Celebi created FLINK-12060:
-----------------------------------

             Summary: Unify change pom version scripts
                 Key: FLINK-12060
                 URL: https://issues.apache.org/jira/browse/FLINK-12060
             Project: Flink
          Issue Type: Bug
          Components: Deployment / Scripts
    Affects Versions: 1.8.0
            Reporter: Ufuk Celebi


We have three places in `tools` that we use to update the pom versions when releasing:
1. https://github.com/apache/flink/blob/048367b/tools/change-version.sh#L31
2. https://github.com/apache/flink/blob/048367b/tools/releasing/create_release_branch.sh#L60
3. https://github.com/apache/flink/blob/048367b/tools/releasing/update_branch_version.sh#L52

The 1st option is buggy (it does not work with the new versioning of the shaded Hadoop build, e.g. {{2.4.1-1.9-SNAPSHOT}} will not be replaced). The 2nd and 3rd work for pom files, but the 2nd one misses a change for the doc version that is present in the 3rd one.

I think we should unify these and call them where needed instead of duplicating this code in unexpected ways.

An initial quick fix could remove the 1st script and update the 2rd one to match the 3rd one.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)