[jira] [Created] (FLINK-11832) Convert some InternalType property related functions to InternalType's method

[Shang Yuanchun (Jira)]

Kurt Young created FLINK-11832:
----------------------------------

             Summary: Convert some InternalType property related functions to InternalType's method
                 Key: FLINK-11832
                 URL: https://issues.apache.org/jira/browse/FLINK-11832
             Project: Flink
          Issue Type: Improvement
          Components: SQL / Planner
            Reporter: Kurt Young


For example, in `CodeGenUtils` we have some utils methods like `needCopyForType` and `needCloneRefForType`. They are very error prone because there is no guarantee when someone add a new InternalType, he will check this functionality. 

There also exists some pattern-match style codes based on types, i think a feasible principle when to convert these to class's method and when to keep they as pattern-match is:

"If the pattern-match codes stand for all further changes, we can keep it as it is. Otherwise, we should convert it to class's method as much as possible". 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)