[jira] [Created] (FLINK-11663) Remove control flow break point from Execution#releaseAssignedResource

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-11663) Remove control flow break point from Execution#releaseAssignedResource

Shang Yuanchun (Jira)
Till Rohrmann created FLINK-11663:
-------------------------------------

             Summary: Remove control flow break point from Execution#releaseAssignedResource
                 Key: FLINK-11663
                 URL: https://issues.apache.org/jira/browse/FLINK-11663
             Project: Flink
          Issue Type: Improvement
          Components: Distributed Coordination
    Affects Versions: 1.8.0
            Reporter: Till Rohrmann
            Assignee: Till Rohrmann
             Fix For: 1.8.0


In {{Execution#releaseAssignedResource}} we release the assigned resource by calling {{LogicalSlot#releaseSlot}} and use {{FutureUtils.whenCompleteAsyncIfNotDone}} to merge the future back into the main thread in order to complete the {{Execution#releaseFuture}}. This is no longer necessary since the returned future is always completed from within the main thread (with the changes from FLINK-10431).

In fact this control flow break point makes it hard to properly suspend the {{ExecutionGraph}} atomically as required for FLINK-11537.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)