[jira] [Created] (FLINK-10468) Potential missing break for PARTITION_CUSTOM in OutputEmitter ctor

[Shang Yuanchun (Jira)]

Ted Yu created FLINK-10468:
------------------------------

             Summary: Potential missing break for PARTITION_CUSTOM in OutputEmitter ctor
                 Key: FLINK-10468
                 URL: https://issues.apache.org/jira/browse/FLINK-10468
             Project: Flink
          Issue Type: Bug
            Reporter: Ted Yu


Here is related code:
{code}
    switch (strategy) {
    case PARTITION_CUSTOM:
      extractedKeys = new Object[1];
    case FORWARD:
{code}
It seems a 'break' is missing prior to FORWARD case.
{code}
    if (strategy == ShipStrategyType.PARTITION_CUSTOM && partitioner == null) {
      throw new NullPointerException("Partitioner must not be null when the ship strategy is set to custom partitioning.");
    }
{code}
Since the above check is for PARTITION_CUSTOM, it seems we can place the check in the switch statement.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)