[
https://issues.apache.org/jira/browse/FLINK-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034552#comment-14034552 ]
ASF GitHub Bot commented on FLINK-943:
--------------------------------------
GitHub user uce opened a pull request:
https://github.com/apache/incubator-flink/pull/26 [FLINK-943] Remove leading and ending double quotes from 'env.java.opts' config value
This is [FLINK-943](
https://issues.apache.org/jira/browse/FLINK-943).
The parsing works correctly but the leading/ending double quotes need to be removed before the value is given to the `java` run command, e.g. `java -Xmx1g "-D ..."` does not work.
I've tested: 1. with double quotes, 2. without double quotes, and 3. not set.
You can merge this pull request into a Git repository by running:
$ git pull
https://github.com/uce/incubator-flink FLINK-943
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/26.patchTo close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
----
commit c29e74399d4c02ac613bb3811afd44e23fd73786
Author: uce <
[hidden email]>
Date: 2014-06-17T22:48:15Z
[FLINK-943] Remove leading and ending double quotes from 'env.java.opts' config value in startup scripts
----
> Configured values with double quotes are not parsed correctly in bash scripts
> -----------------------------------------------------------------------------
>
> Key: FLINK-943
> URL:
https://issues.apache.org/jira/browse/FLINK-943> Project: Flink
> Issue Type: Bug
> Reporter: Ufuk Celebi
>
> In FLINK-942 I noticed that {{env.java.opts}} are not read by the startup scripts. While doing the fix I discovered a related problem:
> This works fine:
> {code}
> env.java.opts: -Dio.netty.leakDetectionLevel=paranoid
> {code}
> If you use it with double quotes, the startup scripts get messed up and don't even start up the JobManager/TaskManagers anymore:
> {code}
> env.java.opts: "-Dio.netty.leakDetectionLevel=paranoid"
> {code}
> This applies to all configuration values with double quotes and is there a seperate issue than FLINK-942. I just noticed it by chance for the JVM args.
--
This message was sent by Atlassian JIRA
(v6.2#6252)