[
https://issues.apache.org/jira/browse/FLINK-934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14030470#comment-14030470 ]
ASF GitHub Bot commented on FLINK-934:
--------------------------------------
Github user uce commented on the pull request:
https://github.com/apache/incubator-flink/pull/14#issuecomment-45997673
Yes, the other flags are set as before. The `Xms` and `Xmx` flags are only set, when they are found in `stratosphere-conf.yaml`.
While doing the PR, I came to the same conclusion as your second comment. But we can actually also do something more fancy and figure out the available memory ourselves and set it (thereby circumventing the defaults).
> Job and TaskManager startup scripts always set JVM heap size
> ------------------------------------------------------------
>
> Key: FLINK-934
> URL:
https://issues.apache.org/jira/browse/FLINK-934> Project: Flink
> Issue Type: Improvement
> Reporter: Ufuk Celebi
>
> The default distribution config {{stratosphere-conf.yaml}} contains keys {{jobmanager.heap.mb}} and {{taskmanager.heap.mb}} for the heap sizes of the JobManager and TaskManager JVMs. If they are not set, {{config.sh}} has default values for them.
> We _always_ use one of these values and set the {{Xms}} and {{Xmx}} properties. After a short discussion with [~rmetzger] and [~StephanEwen] we actually expected that they should not be set if not found in {{stratosphere-conf.yaml}}. This would result in a fall back to the respective JVM default (imho 1/4th of the physical memory since Java 6).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Locked
