[jira] [Commented] (FLINK-930) Netty Initialization is sometimes very slow

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (FLINK-930) Netty Initialization is sometimes very slow

Shang Yuanchun (Jira)

    [ https://issues.apache.org/jira/browse/FLINK-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033499#comment-14033499 ]

ASF GitHub Bot commented on FLINK-930:
--------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/19#discussion_r13845277
 
    --- Diff: stratosphere-runtime/src/main/java/eu/stratosphere/runtime/io/network/ChannelManager.java ---
    @@ -99,8 +95,13 @@ public ChannelManager(ChannelLookupProtocol channelLookupService, InstanceConnec
      this.discardBufferPool = new DiscardBufferPool();
      }
     
    - public void shutdown() {
    - this.nettyConnectionManager.shutdown();
    + public void shutdown()  {
    + try {
    + this.networkConnectionManager.shutdown();
    + } catch (IOException e) {
    + LOG.warn("NetworkConnectionManager did not shutdown properly.");
    --- End diff --
   
    I think we should log the exception as well here (I guess the error is unlikely and needs review by the user)


> Netty Initialization is sometimes very slow
> -------------------------------------------
>
>                 Key: FLINK-930
>                 URL: https://issues.apache.org/jira/browse/FLINK-930
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Stephan Ewen
>            Assignee: Ufuk Celebi
>              Labels: performance
>
> I often see the initialization of Netty taking 3 seconds and then failing with the message
> "WARN  io.netty.util.internal.ThreadLocalRandom                      - Failed to generate a seed from SecureRandom within 3 seconds. Not enough entrophy?"
> This adds to every single run a 3 seconds delay, which is often more than the test time and causes our builds to run out of time.



--
This message was sent by Atlassian JIRA
(v6.2#6252)