[
https://issues.apache.org/jira/browse/FLINK-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036022#comment-14036022 ]
ASF GitHub Bot commented on FLINK-758:
--------------------------------------
Github user uce commented on the pull request:
https://github.com/apache/incubator-flink/pull/20#issuecomment-46469440
I also find it clumsy. Will change it as you suggested. I'm not sure why I didn't think of this myself.
Sent from my iPhone
> On 18 Jun 2014, at 19:32, Stephan Ewen <
[hidden email]> wrote:
>
> Why do you add the "setInitialValue()" method to the reduce function? I think that is a bit clumsy. Is that for getting the value into the runtime?
>
> Why not add it as part of the user parameters? That keeps the user-facing APIs clean.
>
> —
> Reply to this email directly or view it on GitHub.
> Add count method to DataSet and implement CountOperator
> -------------------------------------------------------
>
> Key: FLINK-758
> URL:
https://issues.apache.org/jira/browse/FLINK-758> Project: Flink
> Issue Type: Improvement
> Reporter: GitHub Import
> Labels: github-import
> Fix For: pre-apache
>
> Attachments: pull-request-758-7518001488867571817.patch
>
>
> At the request of @twalthr. This is the count operator I've implemented some time ago to get the to know the new Java API. It introduces `DataSet.count()`, which is executed as a map (to ones) and reduce (sum up the ones). I initially didn't do the PR, because of the following problem: empty DataSets don't work as the first map won't have any input to operate on.
> If more people think that we should include this operator we can think about a possible solution to the problem.
> ---------------- Imported from GitHub ----------------
> Url:
https://github.com/stratosphere/stratosphere/pull/758> Created by: [uce|
https://github.com/uce]
> Labels: enhancement, java api,
> Milestone: Release 0.6 (unplanned)
> Created at: Tue May 06 10:42:33 CEST 2014
> State: open
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Locked
