[jira] [Commented] (FLINK-758) Add count method to DataSet and implement CountOperator

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (FLINK-758) Add count method to DataSet and implement CountOperator

Shang Yuanchun (Jira)

    [ https://issues.apache.org/jira/browse/FLINK-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031996#comment-14031996 ]

ASF GitHub Bot commented on FLINK-758:
--------------------------------------

GitHub user uce opened a pull request:

    https://github.com/apache/incubator-flink/pull/20

    [FLINK-758] Add initial value to GenericReduce and adjust AllReduceDriver

    This is an initial version of introducing an initial value to the reduce functions. Thanks to @fhueske for suggesting to add the initial value to `GenericReduce`.
   
    It is only implemented for `AllReduce` (ungrouped reduce). Please give feedback. If everything is OK, I would continue (~ 1 hr) with the remaining reduce variants (grouped reduce, ungrouped groupreduce, and grouped groupreduce).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/incubator-flink FLINK-758

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20
   
----
commit 9ef87ff169f602ad41f61192c2872bfadaaa94d9
Author: uce <[hidden email]>
Date:   2014-06-15T18:24:17Z

    [FLINK-758] Add initial value to GenericReduce and adjust AllReduceDriver (first shot at reduce with initial value)

----


> Add count method to DataSet and implement CountOperator
> -------------------------------------------------------
>
>                 Key: FLINK-758
>                 URL: https://issues.apache.org/jira/browse/FLINK-758
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: GitHub Import
>              Labels: github-import
>             Fix For: pre-apache
>
>         Attachments: pull-request-758-7518001488867571817.patch
>
>
> At the request of @twalthr. This is the count operator I've implemented some time ago to get the to know the new Java API. It introduces `DataSet.count()`, which is executed as a map (to ones) and reduce (sum up the ones). I initially didn't do the PR, because of the following problem: empty DataSets don't work as the first map won't have any input to operate on.
> If more people think that we should include this operator we can think about a possible solution to the problem.
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/pull/758
> Created by: [uce|https://github.com/uce]
> Labels: enhancement, java api,
> Milestone: Release 0.6 (unplanned)
> Created at: Tue May 06 10:42:33 CEST 2014
> State: open



--
This message was sent by Atlassian JIRA
(v6.2#6252)