flink-shaded-hadoop modules disconnected from parent pom

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

flink-shaded-hadoop modules disconnected from parent pom

Nick Dimiduk
Hi folks,

I noticed today that the parent pom for the flink-shaded-hadoop pom (and
thus also it's children) are not using ${ROOT}/pom.xml as their parent.
However, ${ROOT}/pom.xml lists the hierarchy as a module. I'm curious to
know why this is. It seems one artifact of this disconnect is that
tools/create_release_files.sh uses find + sed to update the release
version, instead of mvn versions:set.

Just curious,
-n
Reply | Threaded
Open this post in threaded view
|

Re: flink-shaded-hadoop modules disconnected from parent pom

Till Rohrmann
Hi Nick,

I think the reason is to set some common settings for all flink shaded
hadoop child modules in flink-shaded-hadoop if I’m not mistaken. But this
might also be a historic artifact.

Cheers,
Till


On Fri, Jan 15, 2016 at 12:48 AM, Nick Dimiduk <[hidden email]> wrote:

> Hi folks,
>
> I noticed today that the parent pom for the flink-shaded-hadoop pom (and
> thus also it's children) are not using ${ROOT}/pom.xml as their parent.
> However, ${ROOT}/pom.xml lists the hierarchy as a module. I'm curious to
> know why this is. It seems one artifact of this disconnect is that
> tools/create_release_files.sh uses find + sed to update the release
> version, instead of mvn versions:set.
>
> Just curious,
> -n
>