Warning message in Scala type analysis

[Stephan Ewen]

Hi!

When running a recent build, I am seeing the following error message in the
"flink-tests" project.

[WARNING] warning: Class org.joda.convert.ToString not found - continuing
with a stub.

@aljoscha This is probably a message generated by the Scala type analyzer.
Can you elaborate what this means?

Greetings,
Stephan

[Aljoscha Krettek-2]

Yes, I will look into it.

Are you sure this happens in the Scala code?

On Sat, Jan 24, 2015 at 8:57 PM, Stephan Ewen <[hidden email]> wrote:

> Hi!
>
> When running a recent build, I am seeing the following error message in the
> "flink-tests" project.
>
> [WARNING] warning: Class org.joda.convert.ToString not found - continuing
> with a stub.
>
> @aljoscha This is probably a message generated by the Scala type analyzer.
> Can you elaborate what this means?
>
> Greetings,
> Stephan

[Stephan Ewen]

Not 100%

My guess is that it comes from the scala tests in flink-tests for POJOs
containing joda time classes (to test the custom serializers)

Stephan


On Sat, Jan 24, 2015 at 12:16 PM, Aljoscha Krettek <[hidden email]>
wrote:

> Yes, I will look into it.
>
> Are you sure this happens in the Scala code?
>
> On Sat, Jan 24, 2015 at 8:57 PM, Stephan Ewen <[hidden email]> wrote:
> > Hi!
> >
> > When running a recent build, I am seeing the following error message in
> the
> > "flink-tests" project.
> >
> > [WARNING] warning: Class org.joda.convert.ToString not found - continuing
> > with a stub.
> >
> > @aljoscha This is probably a message generated by the Scala type
> analyzer.
> > Can you elaborate what this means?
> >
> > Greetings,
> > Stephan
>

[Aljoscha Krettek-2]

The culprit seems to be this commit:
https://github.com/apache/flink/commit/020b282bdc5468aa51b231e9ae8d4d3a1a76e696

It seems you took a commit from an unmerged PR of mine and changed it.
Now the content does not match the Issue ID and also the LICENCE and
NOTICE file are not correct anymore. The warning pops up because of
the optional dependency joda-convert that we fail to include. See
here: http://stackoverflow.com/questions/13856266/class-broken-error-with-joda-time-using-scala

Cheers,
Aljoscha

On Sat, Jan 24, 2015 at 9:18 PM, Stephan Ewen <[hidden email]> wrote:

> Not 100%
>
> My guess is that it comes from the scala tests in flink-tests for POJOs
> containing joda time classes (to test the custom serializers)
>
> Stephan
>
>
> On Sat, Jan 24, 2015 at 12:16 PM, Aljoscha Krettek <[hidden email]>
> wrote:
>
>> Yes, I will look into it.
>>
>> Are you sure this happens in the Scala code?
>>
>> On Sat, Jan 24, 2015 at 8:57 PM, Stephan Ewen <[hidden email]> wrote:
>> > Hi!
>> >
>> > When running a recent build, I am seeing the following error message in
>> the
>> > "flink-tests" project.
>> >
>> > [WARNING] warning: Class org.joda.convert.ToString not found - continuing
>> > with a stub.
>> >
>> > @aljoscha This is probably a message generated by the Scala type
>> analyzer.
>> > Can you elaborate what this means?
>> >
>> > Greetings,
>> > Stephan
>>

[Stephan Ewen]

Ah, I see, thanks for the explanation.

I picked the commit because I wanted the Joda in Scala tests in the system,
but delay the serializer registration, as a discussion was still going on
on the mailing list.

So, the solution is simply to add the joda convert dependecy to the test
scope as well? Do you know why exactly that is needed?

The LICENSE and NOTICE files should be okay, since Joda Time is a test
scope dependency only, no?



On Mon, Jan 26, 2015 at 2:50 AM, Aljoscha Krettek <[hidden email]>
wrote:

> The culprit seems to be this commit:
>
> https://github.com/apache/flink/commit/020b282bdc5468aa51b231e9ae8d4d3a1a76e696
>
> It seems you took a commit from an unmerged PR of mine and changed it.
> Now the content does not match the Issue ID and also the LICENCE and
> NOTICE file are not correct anymore. The warning pops up because of
> the optional dependency joda-convert that we fail to include. See
> here:
> http://stackoverflow.com/questions/13856266/class-broken-error-with-joda-time-using-scala
>
> Cheers,
> Aljoscha
>
> On Sat, Jan 24, 2015 at 9:18 PM, Stephan Ewen <[hidden email]> wrote:
> > Not 100%
> >
> > My guess is that it comes from the scala tests in flink-tests for POJOs
> > containing joda time classes (to test the custom serializers)
> >
> > Stephan
> >
> >
> > On Sat, Jan 24, 2015 at 12:16 PM, Aljoscha Krettek <[hidden email]>
> > wrote:
> >
> >> Yes, I will look into it.
> >>
> >> Are you sure this happens in the Scala code?
> >>
> >> On Sat, Jan 24, 2015 at 8:57 PM, Stephan Ewen <[hidden email]> wrote:
> >> > Hi!
> >> >
> >> > When running a recent build, I am seeing the following error message
> in
> >> the
> >> > "flink-tests" project.
> >> >
> >> > [WARNING] warning: Class org.joda.convert.ToString not found -
> continuing
> >> > with a stub.
> >> >
> >> > @aljoscha This is probably a message generated by the Scala type
> >> analyzer.
> >> > Can you elaborate what this means?
> >> >
> >> > Greetings,
> >> > Stephan
> >>
>

[Aljoscha Krettek-2]

Ok, if it is only a testing dependency it should be alright. The
problem seems to be that some of the Joda classes have annotations
that reside in joda-convert. The java compiler seems to be OK with
missing annotations while the Scala compiler gives a warning. At least
that's how I understood it from the link I posted earlier.

On Mon, Jan 26, 2015 at 11:27 PM, Stephan Ewen <[hidden email]> wrote:

> Ah, I see, thanks for the explanation.
>
> I picked the commit because I wanted the Joda in Scala tests in the system,
> but delay the serializer registration, as a discussion was still going on
> on the mailing list.
>
> So, the solution is simply to add the joda convert dependecy to the test
> scope as well? Do you know why exactly that is needed?
>
> The LICENSE and NOTICE files should be okay, since Joda Time is a test
> scope dependency only, no?
>
>
>
> On Mon, Jan 26, 2015 at 2:50 AM, Aljoscha Krettek <[hidden email]>
> wrote:
>
>> The culprit seems to be this commit:
>>
>> https://github.com/apache/flink/commit/020b282bdc5468aa51b231e9ae8d4d3a1a76e696
>>
>> It seems you took a commit from an unmerged PR of mine and changed it.
>> Now the content does not match the Issue ID and also the LICENCE and
>> NOTICE file are not correct anymore. The warning pops up because of
>> the optional dependency joda-convert that we fail to include. See
>> here:
>> http://stackoverflow.com/questions/13856266/class-broken-error-with-joda-time-using-scala
>>
>> Cheers,
>> Aljoscha
>>
>> On Sat, Jan 24, 2015 at 9:18 PM, Stephan Ewen <[hidden email]> wrote:
>> > Not 100%
>> >
>> > My guess is that it comes from the scala tests in flink-tests for POJOs
>> > containing joda time classes (to test the custom serializers)
>> >
>> > Stephan
>> >
>> >
>> > On Sat, Jan 24, 2015 at 12:16 PM, Aljoscha Krettek <[hidden email]>
>> > wrote:
>> >
>> >> Yes, I will look into it.
>> >>
>> >> Are you sure this happens in the Scala code?
>> >>
>> >> On Sat, Jan 24, 2015 at 8:57 PM, Stephan Ewen <[hidden email]> wrote:
>> >> > Hi!
>> >> >
>> >> > When running a recent build, I am seeing the following error message
>> in
>> >> the
>> >> > "flink-tests" project.
>> >> >
>> >> > [WARNING] warning: Class org.joda.convert.ToString not found -
>> continuing
>> >> > with a stub.
>> >> >
>> >> > @aljoscha This is probably a message generated by the Scala type
>> >> analyzer.
>> >> > Can you elaborate what this means?
>> >> >
>> >> > Greetings,
>> >> > Stephan
>> >>
>>