[VOTE] Rename terminology "Time-windowed Join" to "Interval Join" in Table API & SQL

[Jark Wu-2]

Hi everyone,

As we discussed in the mailing list[1], the current "Time-windowed Join" in
Table API & SQL is a little misleading which is not the same to "Window
Join" in DataStream, but the same to "Interval Join" in DataStream.

So I would like to start a vote to rename the terminology of "Time-windowed
Join" to "Interval Join" in Table API & SQL **before 1.10 release**.

Note that this is a purely documentation change, no updates for public API
or Javadocs. Updates for implementation codes (e.g. rename
DataStreamWindowJoin) is not targeted to 1.10.

This vote will be open for at least 72 hours. Unless there is an objection.
This vote is required Consensus Approval which is the same to a FLIP vote.

Best,
Jark

[1]:
http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Correct-the-terminology-of-quot-Time-windowed-Join-quot-to-quot-Interval-Join-quot-in-Table-L-td36202.html

[Benchao Li]

+1

It's good to align the terminology between Table API & SQL and DataStream.

Jark Wu <[hidden email]> 于2020年1月3日周五 下午12:04写道：

> Hi everyone,
>
> As we discussed in the mailing list[1], the current "Time-windowed Join" in
> Table API & SQL is a little misleading which is not the same to "Window
> Join" in DataStream, but the same to "Interval Join" in DataStream.
>
> So I would like to start a vote to rename the terminology of "Time-windowed
> Join" to "Interval Join" in Table API & SQL **before 1.10 release**.
>
> Note that this is a purely documentation change, no updates for public API
> or Javadocs. Updates for implementation codes (e.g. rename
> DataStreamWindowJoin) is not targeted to 1.10.
>
> This vote will be open for at least 72 hours. Unless there is an objection.
> This vote is required Consensus Approval which is the same to a FLIP vote.
>
> Best,
> Jark
>
> [1]:
>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Correct-the-terminology-of-quot-Time-windowed-Join-quot-to-quot-Interval-Join-quot-in-Table-L-td36202.html
>

--

Benchao Li
School of Electronics Engineering and Computer Science, Peking University
Tel:[phone]
Email: [hidden email]; [hidden email]

[Jingsong Li]

+1 for this documentation change.
Hope less confuse to users.

Best,
Jingsong Lee

On Fri, Jan 3, 2020 at 12:09 PM Benchao Li <[hidden email]> wrote:

> +1
>
> It's good to align the terminology between Table API & SQL and DataStream.
>
> Jark Wu <[hidden email]> 于2020年1月3日周五 下午12:04写道：
>
> > Hi everyone,
> >
> > As we discussed in the mailing list[1], the current "Time-windowed Join"
> in
> > Table API & SQL is a little misleading which is not the same to "Window
> > Join" in DataStream, but the same to "Interval Join" in DataStream.
> >
> > So I would like to start a vote to rename the terminology of
> "Time-windowed
> > Join" to "Interval Join" in Table API & SQL **before 1.10 release**.
> >
> > Note that this is a purely documentation change, no updates for public
> API
> > or Javadocs. Updates for implementation codes (e.g. rename
> > DataStreamWindowJoin) is not targeted to 1.10.
> >
> > This vote will be open for at least 72 hours. Unless there is an
> objection.
> > This vote is required Consensus Approval which is the same to a FLIP
> vote.
> >
> > Best,
> > Jark
> >
> > [1]:
> >
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Correct-the-terminology-of-quot-Time-windowed-Join-quot-to-quot-Interval-Join-quot-in-Table-L-td36202.html
> >
>
>
> --
>
> Benchao Li
> School of Electronics Engineering and Computer Science, Peking University
> Tel:[phone]
> Email: [hidden email]; [hidden email]
>

--
Best, Jingsong Lee

[Zhenghua Gao]

+1 to align the terminology.

*Best Regards,*
*Zhenghua Gao*


On Fri, Jan 3, 2020 at 12:59 PM Jingsong Li <[hidden email]> wrote:

> +1 for this documentation change.
> Hope less confuse to users.
>
> Best,
> Jingsong Lee
>
> On Fri, Jan 3, 2020 at 12:09 PM Benchao Li <[hidden email]> wrote:
>
> > +1
> >
> > It's good to align the terminology between Table API & SQL and
> DataStream.
> >
> > Jark Wu <[hidden email]> 于2020年1月3日周五 下午12:04写道：
> >
> > > Hi everyone,
> > >
> > > As we discussed in the mailing list[1], the current "Time-windowed
> Join"
> > in
> > > Table API & SQL is a little misleading which is not the same to "Window
> > > Join" in DataStream, but the same to "Interval Join" in DataStream.
> > >
> > > So I would like to start a vote to rename the terminology of
> > "Time-windowed
> > > Join" to "Interval Join" in Table API & SQL **before 1.10 release**.
> > >
> > > Note that this is a purely documentation change, no updates for public
> > API
> > > or Javadocs. Updates for implementation codes (e.g. rename
> > > DataStreamWindowJoin) is not targeted to 1.10.
> > >
> > > This vote will be open for at least 72 hours. Unless there is an
> > objection.
> > > This vote is required Consensus Approval which is the same to a FLIP
> > vote.
> > >
> > > Best,
> > > Jark
> > >
> > > [1]:
> > >
> > >
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Correct-the-terminology-of-quot-Time-windowed-Join-quot-to-quot-Interval-Join-quot-in-Table-L-td36202.html
> > >
> >
> >
> > --
> >
> > Benchao Li
> > School of Electronics Engineering and Computer Science, Peking University
> > Tel:[phone]
> > Email: [hidden email]; [hidden email]
> >
>
>
> --
> Best, Jingsong Lee
>

[Timo Walther-2]

If the semantics of both APIs are 100% equivalent, I'm fine with the
renaming. Have you checked that?

Regards,
Timo

On 06.01.20 10:46, Zhenghua Gao wrote:

> +1 to align the terminology.
>
> *Best Regards,*
> *Zhenghua Gao*
>
>
> On Fri, Jan 3, 2020 at 12:59 PM Jingsong Li <[hidden email]> wrote:
>
>> +1 for this documentation change.
>> Hope less confuse to users.
>>
>> Best,
>> Jingsong Lee
>>
>> On Fri, Jan 3, 2020 at 12:09 PM Benchao Li <[hidden email]> wrote:
>>
>>> +1
>>>
>>> It's good to align the terminology between Table API & SQL and
>> DataStream.
>>>
>>> Jark Wu <[hidden email]> 于2020年1月3日周五 下午12:04写道：
>>>
>>>> Hi everyone,
>>>>
>>>> As we discussed in the mailing list[1], the current "Time-windowed
>> Join"
>>> in
>>>> Table API & SQL is a little misleading which is not the same to "Window
>>>> Join" in DataStream, but the same to "Interval Join" in DataStream.
>>>>
>>>> So I would like to start a vote to rename the terminology of
>>> "Time-windowed
>>>> Join" to "Interval Join" in Table API & SQL **before 1.10 release**.
>>>>
>>>> Note that this is a purely documentation change, no updates for public
>>> API
>>>> or Javadocs. Updates for implementation codes (e.g. rename
>>>> DataStreamWindowJoin) is not targeted to 1.10.
>>>>
>>>> This vote will be open for at least 72 hours. Unless there is an
>>> objection.
>>>> This vote is required Consensus Approval which is the same to a FLIP
>>> vote.
>>>>
>>>> Best,
>>>> Jark
>>>>
>>>> [1]:
>>>>
>>>>
>>>
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Correct-the-terminology-of-quot-Time-windowed-Join-quot-to-quot-Interval-Join-quot-in-Table-L-td36202.html
>>>>
>>>
>>>
>>> --
>>>
>>> Benchao Li
>>> School of Electronics Engineering and Computer Science, Peking University
>>> Tel:[phone]
>>> Email: [hidden email]; [hidden email]
>>>
>>
>>
>> --
>> Best, Jingsong Lee
>>
>

[Jark Wu-2]

Hi Timo,

Yest. I have checked that, they are the same thing in the concept from the
documentation[1][2].
From the desciption of the umbrella issue [FLINK-8478] of DataStream
interval join, we can also find that they are the same:

> The goal is to implement a DataStream API to join together two streams
based on a key and user defined time boundaries.
> This feature should mirror what is already possible in Flink SQL:
> SELECT s1.value, s2.value FROM Table s1 JOIN Table s2 ON o.key = s.key
AND o.rowtime BETWEEN s.rowtime AND s.rowtime + INTERVAL '1' HOUR;

Best,
Jark

[1]:
https://ci.apache.org/projects/flink/flink-docs-master/dev/stream/operators/joining.html#interval-join
[2]:
https://ci.apache.org/projects/flink/flink-docs-master/dev/table/streaming/joins.html#time-windowed-joins
[3]: https://issues.apache.org/jira/browse/FLINK-8478

On Mon, 6 Jan 2020 at 18:33, Timo Walther <[hidden email]> wrote:

> If the semantics of both APIs are 100% equivalent, I'm fine with the
> renaming. Have you checked that?
>
> Regards,
> Timo
>
> On 06.01.20 10:46, Zhenghua Gao wrote:
> > +1 to align the terminology.
> >
> > *Best Regards,*
> > *Zhenghua Gao*
> >
> >
> > On Fri, Jan 3, 2020 at 12:59 PM Jingsong Li <[hidden email]>
> wrote:
> >
> >> +1 for this documentation change.
> >> Hope less confuse to users.
> >>
> >> Best,
> >> Jingsong Lee
> >>
> >> On Fri, Jan 3, 2020 at 12:09 PM Benchao Li <[hidden email]> wrote:
> >>
> >>> +1
> >>>
> >>> It's good to align the terminology between Table API & SQL and
> >> DataStream.
> >>>
> >>> Jark Wu <[hidden email]> 于2020年1月3日周五 下午12:04写道：
> >>>
> >>>> Hi everyone,
> >>>>
> >>>> As we discussed in the mailing list[1], the current "Time-windowed
> >> Join"
> >>> in
> >>>> Table API & SQL is a little misleading which is not the same to
> "Window
> >>>> Join" in DataStream, but the same to "Interval Join" in DataStream.
> >>>>
> >>>> So I would like to start a vote to rename the terminology of
> >>> "Time-windowed
> >>>> Join" to "Interval Join" in Table API & SQL **before 1.10 release**.
> >>>>
> >>>> Note that this is a purely documentation change, no updates for public
> >>> API
> >>>> or Javadocs. Updates for implementation codes (e.g. rename
> >>>> DataStreamWindowJoin) is not targeted to 1.10.
> >>>>
> >>>> This vote will be open for at least 72 hours. Unless there is an
> >>> objection.
> >>>> This vote is required Consensus Approval which is the same to a FLIP
> >>> vote.
> >>>>
> >>>> Best,
> >>>> Jark
> >>>>
> >>>> [1]:
> >>>>
> >>>>
> >>>
> >>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Correct-the-terminology-of-quot-Time-windowed-Join-quot-to-quot-Interval-Join-quot-in-Table-L-td36202.html
> >>>>
> >>>
> >>>
> >>> --
> >>>
> >>> Benchao Li
> >>> School of Electronics Engineering and Computer Science, Peking
> University
> >>> Tel:[phone]
> >>> Email: [hidden email]; [hidden email]
> >>>
> >>
> >>
> >> --
> >> Best, Jingsong Lee
> >>
> >
>
>