[VOTE] Release flink-shaded 7.0, release candidate 1

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release flink-shaded 7.0, release candidate 1

jincheng sun
Hi everyone,

Please review and vote on the release candidate #1 for the version 7.0, as
follows:

[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org [2],
which are signed with the key with fingerprint 8FEA1EE9 [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag "release-7.0-rc1" [5],
* website pull request listing the new release [6].

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

NOTE:
After I finished RC1, we found that
https://issues.apache.org/jira/browse/FLINK-11580, Chesnay Schepler, Nico
and Me had reached an agreement. It was better to put FLINK-11580 in
flink-shaded-7.0.
But in order to find out other problems earlier, we vote on RC1 first. If
FLINK-11580 is completed in a week, I will be very willing to prepare RC2.
If it takes a long time, we will release FLINK-11580 again later. Please
let me know what do you think?

Thanks,
Jincheng

[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345226&styleName=Html&projectId=12315522&Create=Create&atl_token=A5KQ-2QAV-T4JA-FDED%7C8ba061049bec0c5a72dc0191c47bb53a73b82cb4%7Clin
[2] https://dist.apache.org/repos/dist/dev/flink/flink-shaded-7.0-rc1/
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1217
[5] https://github.com/apache/flink-shaded/tree/release-7.0-rc1
[6] https://github.com/apache/flink-web/pull/209
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release flink-shaded 7.0, release candidate 1

Chesnay Schepler-3
-1

We forgot to account for the dependencyManagement section of the root
pom when moving the modules. Multiple dependencies are now no longer
matching.
Just to reduce the risk of something breaking I think we should make
sure that the dependency set remains the same.

On 08/05/2019 15:39, jincheng sun wrote:

> Hi everyone,
>
> Please review and vote on the release candidate #1 for the version 7.0, as
> follows:
>
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org [2],
> which are signed with the key with fingerprint 8FEA1EE9 [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag "release-7.0-rc1" [5],
> * website pull request listing the new release [6].
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> NOTE:
> After I finished RC1, we found that
> https://issues.apache.org/jira/browse/FLINK-11580, Chesnay Schepler, Nico
> and Me had reached an agreement. It was better to put FLINK-11580 in
> flink-shaded-7.0.
> But in order to find out other problems earlier, we vote on RC1 first. If
> FLINK-11580 is completed in a week, I will be very willing to prepare RC2.
> If it takes a long time, we will release FLINK-11580 again later. Please
> let me know what do you think?
>
> Thanks,
> Jincheng
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345226&styleName=Html&projectId=12315522&Create=Create&atl_token=A5KQ-2QAV-T4JA-FDED%7C8ba061049bec0c5a72dc0191c47bb53a73b82cb4%7Clin
> [2] https://dist.apache.org/repos/dist/dev/flink/flink-shaded-7.0-rc1/
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/orgapacheflink-1217
> [5] https://github.com/apache/flink-shaded/tree/release-7.0-rc1
> [6] https://github.com/apache/flink-web/pull/209
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release flink-shaded 7.0, release candidate 1

jincheng sun
Thanks for your vote! @Chesnay Schepler <[hidden email]>!

When moving the modules, we copy the dependency version of the
dependencyManagement in the `flink-parent` pom in the specific sub-module
inside the `flink-shaded`, do you meant that we should add
`dependencyManagement` section in flink-shaded? I don't fully understand
the problem you are talking about, so can you create a JIRA for the problem
and make a corresponding description and suggested solution? I will take
the JIRA and try to solve it :)

Best,
Jincheng

Chesnay Schepler <[hidden email]> 于2019年5月10日周五 下午8:35写道:

> -1
>
> We forgot to account for the dependencyManagement section of the root
> pom when moving the modules. Multiple dependencies are now no longer
> matching.
> Just to reduce the risk of something breaking I think we should make
> sure that the dependency set remains the same.
>
> On 08/05/2019 15:39, jincheng sun wrote:
> > Hi everyone,
> >
> > Please review and vote on the release candidate #1 for the version 7.0,
> as
> > follows:
> >
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to dist.apache.org
> [2],
> > which are signed with the key with fingerprint 8FEA1EE9 [3],
> > * all artifacts to be deployed to the Maven Central Repository [4],
> > * source code tag "release-7.0-rc1" [5],
> > * website pull request listing the new release [6].
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > NOTE:
> > After I finished RC1, we found that
> > https://issues.apache.org/jira/browse/FLINK-11580, Chesnay Schepler,
> Nico
> > and Me had reached an agreement. It was better to put FLINK-11580 in
> > flink-shaded-7.0.
> > But in order to find out other problems earlier, we vote on RC1 first. If
> > FLINK-11580 is completed in a week, I will be very willing to prepare
> RC2.
> > If it takes a long time, we will release FLINK-11580 again later. Please
> > let me know what do you think?
> >
> > Thanks,
> > Jincheng
> >
> > [1]
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345226&styleName=Html&projectId=12315522&Create=Create&atl_token=A5KQ-2QAV-T4JA-FDED%7C8ba061049bec0c5a72dc0191c47bb53a73b82cb4%7Clin
> > [2] https://dist.apache.org/repos/dist/dev/flink/flink-shaded-7.0-rc1/
> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1217
> > [5] https://github.com/apache/flink-shaded/tree/release-7.0-rc1
> > [6] https://github.com/apache/flink-web/pull/209
> >
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release flink-shaded 7.0, release candidate 1

Chesnay Schepler-3
I've opened a JIRA: https://issues.apache.org/jira/browse/FLINK-12515

On 13/05/2019 12:03, jincheng sun wrote:

> Thanks for your vote! @Chesnay Schepler <[hidden email]>!
>
> When moving the modules, we copy the dependency version of the
> dependencyManagement in the `flink-parent` pom in the specific sub-module
> inside the `flink-shaded`, do you meant that we should add
> `dependencyManagement` section in flink-shaded? I don't fully understand
> the problem you are talking about, so can you create a JIRA for the problem
> and make a corresponding description and suggested solution? I will take
> the JIRA and try to solve it :)
>
> Best,
> Jincheng
>
> Chesnay Schepler <[hidden email]> 于2019年5月10日周五 下午8:35写道:
>
>> -1
>>
>> We forgot to account for the dependencyManagement section of the root
>> pom when moving the modules. Multiple dependencies are now no longer
>> matching.
>> Just to reduce the risk of something breaking I think we should make
>> sure that the dependency set remains the same.
>>
>> On 08/05/2019 15:39, jincheng sun wrote:
>>> Hi everyone,
>>>
>>> Please review and vote on the release candidate #1 for the version 7.0,
>> as
>>> follows:
>>>
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>
>>> The complete staging area is available for your review, which includes:
>>> * JIRA release notes [1],
>>> * the official Apache source release to be deployed to dist.apache.org
>> [2],
>>> which are signed with the key with fingerprint 8FEA1EE9 [3],
>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>> * source code tag "release-7.0-rc1" [5],
>>> * website pull request listing the new release [6].
>>>
>>> The vote will be open for at least 72 hours. It is adopted by majority
>>> approval, with at least 3 PMC affirmative votes.
>>>
>>> NOTE:
>>> After I finished RC1, we found that
>>> https://issues.apache.org/jira/browse/FLINK-11580, Chesnay Schepler,
>> Nico
>>> and Me had reached an agreement. It was better to put FLINK-11580 in
>>> flink-shaded-7.0.
>>> But in order to find out other problems earlier, we vote on RC1 first. If
>>> FLINK-11580 is completed in a week, I will be very willing to prepare
>> RC2.
>>> If it takes a long time, we will release FLINK-11580 again later. Please
>>> let me know what do you think?
>>>
>>> Thanks,
>>> Jincheng
>>>
>>> [1]
>>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345226&styleName=Html&projectId=12315522&Create=Create&atl_token=A5KQ-2QAV-T4JA-FDED%7C8ba061049bec0c5a72dc0191c47bb53a73b82cb4%7Clin
>>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-shaded-7.0-rc1/
>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>> [4]
>> https://repository.apache.org/content/repositories/orgapacheflink-1217
>>> [5] https://github.com/apache/flink-shaded/tree/release-7.0-rc1
>>> [6] https://github.com/apache/flink-web/pull/209
>>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release flink-shaded 7.0, release candidate 1

jincheng sun
Thanks a lot for open the JIRA @Chesnay Schepler <[hidden email]> , I
will try to fix it ASAP.  :)

Chesnay Schepler <[hidden email]> 于2019年5月15日周三 下午5:40写道:

> I've opened a JIRA: https://issues.apache.org/jira/browse/FLINK-12515
>
> On 13/05/2019 12:03, jincheng sun wrote:
> > Thanks for your vote! @Chesnay Schepler <[hidden email]>!
> >
> > When moving the modules, we copy the dependency version of the
> > dependencyManagement in the `flink-parent` pom in the specific sub-module
> > inside the `flink-shaded`, do you meant that we should add
> > `dependencyManagement` section in flink-shaded? I don't fully understand
> > the problem you are talking about, so can you create a JIRA for the
> problem
> > and make a corresponding description and suggested solution? I will take
> > the JIRA and try to solve it :)
> >
> > Best,
> > Jincheng
> >
> > Chesnay Schepler <[hidden email]> 于2019年5月10日周五 下午8:35写道:
> >
> >> -1
> >>
> >> We forgot to account for the dependencyManagement section of the root
> >> pom when moving the modules. Multiple dependencies are now no longer
> >> matching.
> >> Just to reduce the risk of something breaking I think we should make
> >> sure that the dependency set remains the same.
> >>
> >> On 08/05/2019 15:39, jincheng sun wrote:
> >>> Hi everyone,
> >>>
> >>> Please review and vote on the release candidate #1 for the version 7.0,
> >> as
> >>> follows:
> >>>
> >>> [ ] +1, Approve the release
> >>> [ ] -1, Do not approve the release (please provide specific comments)
> >>>
> >>> The complete staging area is available for your review, which includes:
> >>> * JIRA release notes [1],
> >>> * the official Apache source release to be deployed to dist.apache.org
> >> [2],
> >>> which are signed with the key with fingerprint 8FEA1EE9 [3],
> >>> * all artifacts to be deployed to the Maven Central Repository [4],
> >>> * source code tag "release-7.0-rc1" [5],
> >>> * website pull request listing the new release [6].
> >>>
> >>> The vote will be open for at least 72 hours. It is adopted by majority
> >>> approval, with at least 3 PMC affirmative votes.
> >>>
> >>> NOTE:
> >>> After I finished RC1, we found that
> >>> https://issues.apache.org/jira/browse/FLINK-11580, Chesnay Schepler,
> >> Nico
> >>> and Me had reached an agreement. It was better to put FLINK-11580 in
> >>> flink-shaded-7.0.
> >>> But in order to find out other problems earlier, we vote on RC1 first.
> If
> >>> FLINK-11580 is completed in a week, I will be very willing to prepare
> >> RC2.
> >>> If it takes a long time, we will release FLINK-11580 again later.
> Please
> >>> let me know what do you think?
> >>>
> >>> Thanks,
> >>> Jincheng
> >>>
> >>> [1]
> >>>
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345226&styleName=Html&projectId=12315522&Create=Create&atl_token=A5KQ-2QAV-T4JA-FDED%7C8ba061049bec0c5a72dc0191c47bb53a73b82cb4%7Clin
> >>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-shaded-7.0-rc1/
> >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> >>> [4]
> >> https://repository.apache.org/content/repositories/orgapacheflink-1217
> >>> [5] https://github.com/apache/flink-shaded/tree/release-7.0-rc1
> >>> [6] https://github.com/apache/flink-web/pull/209
> >>>
> >>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release flink-shaded 7.0, release candidate 1

jincheng sun
Hi All,

Currently,  https://issues.apache.org/jira/browse/FLINK-11580 has
merged by @Chesnay
Schepler <[hidden email]>! Great thanks!
And I have opened the PR(https://github.com/apache/flink-shaded/pull/62
) for FLINK-12515 <https://issues.apache.org/jira/browse/FLINK-12515>.  I
appreciate if you can review the changes.

After the FLINK-12515 <https://issues.apache.org/jira/browse/FLINK-12515> is
merged, I'll prepare the RC2 for flink-shaded 7.0, And It's better to find
out more potential problems before the RC2,
So,Please help to check the RC1 as much as possible. :)

Regards,
Jincheng





jincheng sun <[hidden email]> 于2019年5月15日周三 下午7:13写道:

> Thanks a lot for open the JIRA @Chesnay Schepler <[hidden email]> , I
> will try to fix it ASAP.  :)
>
> Chesnay Schepler <[hidden email]> 于2019年5月15日周三 下午5:40写道:
>
>> I've opened a JIRA: https://issues.apache.org/jira/browse/FLINK-12515
>>
>> On 13/05/2019 12:03, jincheng sun wrote:
>> > Thanks for your vote! @Chesnay Schepler <[hidden email]>!
>> >
>> > When moving the modules, we copy the dependency version of the
>> > dependencyManagement in the `flink-parent` pom in the specific
>> sub-module
>> > inside the `flink-shaded`, do you meant that we should add
>> > `dependencyManagement` section in flink-shaded? I don't fully understand
>> > the problem you are talking about, so can you create a JIRA for the
>> problem
>> > and make a corresponding description and suggested solution? I will take
>> > the JIRA and try to solve it :)
>> >
>> > Best,
>> > Jincheng
>> >
>> > Chesnay Schepler <[hidden email]> 于2019年5月10日周五 下午8:35写道:
>> >
>> >> -1
>> >>
>> >> We forgot to account for the dependencyManagement section of the root
>> >> pom when moving the modules. Multiple dependencies are now no longer
>> >> matching.
>> >> Just to reduce the risk of something breaking I think we should make
>> >> sure that the dependency set remains the same.
>> >>
>> >> On 08/05/2019 15:39, jincheng sun wrote:
>> >>> Hi everyone,
>> >>>
>> >>> Please review and vote on the release candidate #1 for the version
>> 7.0,
>> >> as
>> >>> follows:
>> >>>
>> >>> [ ] +1, Approve the release
>> >>> [ ] -1, Do not approve the release (please provide specific comments)
>> >>>
>> >>> The complete staging area is available for your review, which
>> includes:
>> >>> * JIRA release notes [1],
>> >>> * the official Apache source release to be deployed to
>> dist.apache.org
>> >> [2],
>> >>> which are signed with the key with fingerprint 8FEA1EE9 [3],
>> >>> * all artifacts to be deployed to the Maven Central Repository [4],
>> >>> * source code tag "release-7.0-rc1" [5],
>> >>> * website pull request listing the new release [6].
>> >>>
>> >>> The vote will be open for at least 72 hours. It is adopted by majority
>> >>> approval, with at least 3 PMC affirmative votes.
>> >>>
>> >>> NOTE:
>> >>> After I finished RC1, we found that
>> >>> https://issues.apache.org/jira/browse/FLINK-11580, Chesnay Schepler,
>> >> Nico
>> >>> and Me had reached an agreement. It was better to put FLINK-11580 in
>> >>> flink-shaded-7.0.
>> >>> But in order to find out other problems earlier, we vote on RC1
>> first. If
>> >>> FLINK-11580 is completed in a week, I will be very willing to prepare
>> >> RC2.
>> >>> If it takes a long time, we will release FLINK-11580 again later.
>> Please
>> >>> let me know what do you think?
>> >>>
>> >>> Thanks,
>> >>> Jincheng
>> >>>
>> >>> [1]
>> >>>
>> >>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345226&styleName=Html&projectId=12315522&Create=Create&atl_token=A5KQ-2QAV-T4JA-FDED%7C8ba061049bec0c5a72dc0191c47bb53a73b82cb4%7Clin
>> >>> [2]
>> https://dist.apache.org/repos/dist/dev/flink/flink-shaded-7.0-rc1/
>> >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>> >>> [4]
>> >> https://repository.apache.org/content/repositories/orgapacheflink-1217
>> >>> [5] https://github.com/apache/flink-shaded/tree/release-7.0-rc1
>> >>> [6] https://github.com/apache/flink-web/pull/209
>> >>>
>> >>
>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release flink-shaded 7.0, release candidate 1

jincheng sun
Hi All,

I’m hereby canceling the vote for RC1 of Flink flink-shaded 7.0 because of
FLINK-12414 and FLINK-11580 already merged and no other issues jump up.
And the RC2 of flink-shaded 7.0 will be coming!

Regards,
Jincheng


jincheng sun <[hidden email]> 于2019年5月16日周四 下午4:42写道:

> Hi All,
>
> Currently,  https://issues.apache.org/jira/browse/FLINK-11580 has merged
> by @Chesnay Schepler <[hidden email]>! Great thanks!
> And I have opened the PR(https://github.com/apache/flink-shaded/pull/62
> ) for FLINK-12515 <https://issues.apache.org/jira/browse/FLINK-12515>.  I
> appreciate if you can review the changes.
>
> After the FLINK-12515 <https://issues.apache.org/jira/browse/FLINK-12515> is
> merged, I'll prepare the RC2 for flink-shaded 7.0, And It's better to find
> out more potential problems before the RC2,
> So,Please help to check the RC1 as much as possible. :)
>
> Regards,
> Jincheng
>
>
>
>
>
> jincheng sun <[hidden email]> 于2019年5月15日周三 下午7:13写道:
>
>> Thanks a lot for open the JIRA @Chesnay Schepler <[hidden email]> ,
>> I will try to fix it ASAP.  :)
>>
>> Chesnay Schepler <[hidden email]> 于2019年5月15日周三 下午5:40写道:
>>
>>> I've opened a JIRA: https://issues.apache.org/jira/browse/FLINK-12515
>>>
>>> On 13/05/2019 12:03, jincheng sun wrote:
>>> > Thanks for your vote! @Chesnay Schepler <[hidden email]>!
>>> >
>>> > When moving the modules, we copy the dependency version of the
>>> > dependencyManagement in the `flink-parent` pom in the specific
>>> sub-module
>>> > inside the `flink-shaded`, do you meant that we should add
>>> > `dependencyManagement` section in flink-shaded? I don't fully
>>> understand
>>> > the problem you are talking about, so can you create a JIRA for the
>>> problem
>>> > and make a corresponding description and suggested solution? I will
>>> take
>>> > the JIRA and try to solve it :)
>>> >
>>> > Best,
>>> > Jincheng
>>> >
>>> > Chesnay Schepler <[hidden email]> 于2019年5月10日周五 下午8:35写道:
>>> >
>>> >> -1
>>> >>
>>> >> We forgot to account for the dependencyManagement section of the root
>>> >> pom when moving the modules. Multiple dependencies are now no longer
>>> >> matching.
>>> >> Just to reduce the risk of something breaking I think we should make
>>> >> sure that the dependency set remains the same.
>>> >>
>>> >> On 08/05/2019 15:39, jincheng sun wrote:
>>> >>> Hi everyone,
>>> >>>
>>> >>> Please review and vote on the release candidate #1 for the version
>>> 7.0,
>>> >> as
>>> >>> follows:
>>> >>>
>>> >>> [ ] +1, Approve the release
>>> >>> [ ] -1, Do not approve the release (please provide specific comments)
>>> >>>
>>> >>> The complete staging area is available for your review, which
>>> includes:
>>> >>> * JIRA release notes [1],
>>> >>> * the official Apache source release to be deployed to
>>> dist.apache.org
>>> >> [2],
>>> >>> which are signed with the key with fingerprint 8FEA1EE9 [3],
>>> >>> * all artifacts to be deployed to the Maven Central Repository [4],
>>> >>> * source code tag "release-7.0-rc1" [5],
>>> >>> * website pull request listing the new release [6].
>>> >>>
>>> >>> The vote will be open for at least 72 hours. It is adopted by
>>> majority
>>> >>> approval, with at least 3 PMC affirmative votes.
>>> >>>
>>> >>> NOTE:
>>> >>> After I finished RC1, we found that
>>> >>> https://issues.apache.org/jira/browse/FLINK-11580, Chesnay Schepler,
>>> >> Nico
>>> >>> and Me had reached an agreement. It was better to put FLINK-11580 in
>>> >>> flink-shaded-7.0.
>>> >>> But in order to find out other problems earlier, we vote on RC1
>>> first. If
>>> >>> FLINK-11580 is completed in a week, I will be very willing to prepare
>>> >> RC2.
>>> >>> If it takes a long time, we will release FLINK-11580 again later.
>>> Please
>>> >>> let me know what do you think?
>>> >>>
>>> >>> Thanks,
>>> >>> Jincheng
>>> >>>
>>> >>> [1]
>>> >>>
>>> >>
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345226&styleName=Html&projectId=12315522&Create=Create&atl_token=A5KQ-2QAV-T4JA-FDED%7C8ba061049bec0c5a72dc0191c47bb53a73b82cb4%7Clin
>>> >>> [2]
>>> https://dist.apache.org/repos/dist/dev/flink/flink-shaded-7.0-rc1/
>>> >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>> >>> [4]
>>> >>
>>> https://repository.apache.org/content/repositories/orgapacheflink-1217
>>> >>> [5] https://github.com/apache/flink-shaded/tree/release-7.0-rc1
>>> >>> [6] https://github.com/apache/flink-web/pull/209
>>> >>>
>>> >>
>>>
>>>