[VOTE] Release flink-shaded 4.0, release candidate #1

[Chesnay Schepler-3]

|Hi everyone,|
|Please review and vote on the release candidate #1 for the version 4.0,
as follows:|
|[ ] +1, Approve the release|
|[ ] -1, Do not approve the release (please provide specific comments)|

|The complete staging area is available for your review, which includes:|
|* GitHub release notes [1],|
|* the official Apache source release to be deployed to dist.apache.org
<https://cwiki.apache.org/confluence/display/FLINK/dist.apache.org> [2],
which are signed with the key with fingerprint 11D464BA [3],|
|* all artifacts to be deployed to the Maven Central Repository [4],|
|* source code tag "release-4.0-rc1" [5]. |
|The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.|
|Thanks,|
|Chesnay|
|[1] https://github.com/apache/flink-shaded/milestone/4?closed=1|
|[2] https://dist.apache.org/repos/dist/dev/flink/flink-shaded-4.0-rc1/|
|[3] https://dist.apache.org/repos/dist/release/flink/KEYS|
|[4]
https://repository.apache.org/content/repositories/orgapacheflink-1165/|
|[5]
https://github.com/apache/flink-shaded/commit/2014030963fe8e8a7414fd14afa86dd5c91e2745|

[Chesnay Schepler-3]

+1

- original jackson dependencies are now properly hidden
- verified with the help of Piotr that the native netty library
relocation works
- netty version bump did not change the dependency tree
- all classes in the netty jar are still relocated properly

I used the reworked release scripts for this release; unless we find a
release-process related issue they should be fine.

On 30.05.2018 13:33, Chesnay Schepler wrote:

> |Hi everyone,|
> |Please review and vote on the release candidate #1 for the version
> 4.0, as follows:|
> |[ ] +1, Approve the release|
> |[ ] -1, Do not approve the release (please provide specific comments)|
>
> |The complete staging area is available for your review, which includes:|
> |* GitHub release notes [1],|
> |* the official Apache source release to be deployed to
> dist.apache.org
> <https://cwiki.apache.org/confluence/display/FLINK/dist.apache.org>
> [2], which are signed with the key with fingerprint 11D464BA [3],|
> |* all artifacts to be deployed to the Maven Central Repository [4],|
> |* source code tag "release-4.0-rc1" [5]. |
> |The vote will be open for at least 72 hours. It is adopted by
> majority approval, with at least 3 PMC affirmative votes.|
> |Thanks,|
> |Chesnay|
> |[1] https://github.com/apache/flink-shaded/milestone/4?closed=1|
> |[2] https://dist.apache.org/repos/dist/dev/flink/flink-shaded-4.0-rc1/|
> |[3] https://dist.apache.org/repos/dist/release/flink/KEYS|
> |[4]
> https://repository.apache.org/content/repositories/orgapacheflink-1165/|
> |[5]
> https://github.com/apache/flink-shaded/commit/2014030963fe8e8a7414fd14afa86dd5c91e2745|
>

[Piotr Nowojski]

+1 (non binding)

I’m working locally with 4.0 for some time and didn’t find any issues.

Piotrek

> On 30 May 2018, at 13:41, Chesnay Schepler <[hidden email]> wrote:
>
> +1
>
> - original jackson dependencies are now properly hidden
> - verified with the help of Piotr that the native netty library relocation works
> - netty version bump did not change the dependency tree
> - all classes in the netty jar are still relocated properly
>
> I used the reworked release scripts for this release; unless we find a release-process related issue they should be fine.
>
> On 30.05.2018 13:33, Chesnay Schepler wrote:
>> |Hi everyone,|
>> |Please review and vote on the release candidate #1 for the version 4.0, as follows:|
>> |[ ] +1, Approve the release|
>> |[ ] -1, Do not approve the release (please provide specific comments)|
>>
>> |The complete staging area is available for your review, which includes:|
>> |* GitHub release notes [1],|
>> |* the official Apache source release to be deployed to dist.apache.org <https://cwiki.apache.org/confluence/display/FLINK/dist.apache.org> [2], which are signed with the key with fingerprint 11D464BA [3],|
>> |* all artifacts to be deployed to the Maven Central Repository [4],|
>> |* source code tag "release-4.0-rc1" [5]. |
>> |The vote will be open for at least 72 hours. It is adopted by majority approval, with at least 3 PMC affirmative votes.|
>> |Thanks,|
>> |Chesnay|
>> |[1] https://github.com/apache/flink-shaded/milestone/4?closed=1|
>> |[2] https://dist.apache.org/repos/dist/dev/flink/flink-shaded-4.0-rc1/|
>> |[3] https://dist.apache.org/repos/dist/release/flink/KEYS|
>> |[4] https://repository.apache.org/content/repositories/orgapacheflink-1165/|
>> |[5] https://github.com/apache/flink-shaded/commit/2014030963fe8e8a7414fd14afa86dd5c91e2745|
>>
>

[Chesnay Schepler-3]

one issue that i did find is that the shade-plugin relocation still
refers to netty-router (which we dropped in this release), and the
licenses for netty-router are still included in the jar.

On 30.05.2018 13:46, Piotr Nowojski wrote:

> +1 (non binding)
>
> I’m working locally with 4.0 for some time and didn’t find any issues.
>
> Piotrek
>
>> On 30 May 2018, at 13:41, Chesnay Schepler <[hidden email]> wrote:
>>
>> +1
>>
>> - original jackson dependencies are now properly hidden
>> - verified with the help of Piotr that the native netty library relocation works
>> - netty version bump did not change the dependency tree
>> - all classes in the netty jar are still relocated properly
>>
>> I used the reworked release scripts for this release; unless we find a release-process related issue they should be fine.
>>
>> On 30.05.2018 13:33, Chesnay Schepler wrote:
>>> |Hi everyone,|
>>> |Please review and vote on the release candidate #1 for the version 4.0, as follows:|
>>> |[ ] +1, Approve the release|
>>> |[ ] -1, Do not approve the release (please provide specific comments)|
>>>
>>> |The complete staging area is available for your review, which includes:|
>>> |* GitHub release notes [1],|
>>> |* the official Apache source release to be deployed to dist.apache.org <https://cwiki.apache.org/confluence/display/FLINK/dist.apache.org> [2], which are signed with the key with fingerprint 11D464BA [3],|
>>> |* all artifacts to be deployed to the Maven Central Repository [4],|
>>> |* source code tag "release-4.0-rc1" [5]. |
>>> |The vote will be open for at least 72 hours. It is adopted by majority approval, with at least 3 PMC affirmative votes.|
>>> |Thanks,|
>>> |Chesnay|
>>> |[1] https://github.com/apache/flink-shaded/milestone/4?closed=1|
>>> |[2] https://dist.apache.org/repos/dist/dev/flink/flink-shaded-4.0-rc1/|
>>> |[3] https://dist.apache.org/repos/dist/release/flink/KEYS|
>>> |[4] https://repository.apache.org/content/repositories/orgapacheflink-1165/|
>>> |[5] https://github.com/apache/flink-shaded/commit/2014030963fe8e8a7414fd14afa86dd5c91e2745|
>>>
>

[Chesnay Schepler-3]

Canceling the vote to fix the license issue.

On 30.05.2018 14:04, Chesnay Schepler wrote:

> one issue that i did find is that the shade-plugin relocation still
> refers to netty-router (which we dropped in this release), and the
> licenses for netty-router are still included in the jar.
>
> On 30.05.2018 13:46, Piotr Nowojski wrote:
>> +1 (non binding)
>>
>> I’m working locally with 4.0 for some time and didn’t find any issues.
>>
>> Piotrek
>>
>>> On 30 May 2018, at 13:41, Chesnay Schepler <[hidden email]> wrote:
>>>
>>> +1
>>>
>>> - original jackson dependencies are now properly hidden
>>> - verified with the help of Piotr that the native netty library
>>> relocation works
>>> - netty version bump did not change the dependency tree
>>> - all classes in the netty jar are still relocated properly
>>>
>>> I used the reworked release scripts for this release; unless we find
>>> a release-process related issue they should be fine.
>>>
>>> On 30.05.2018 13:33, Chesnay Schepler wrote:
>>>> |Hi everyone,|
>>>> |Please review and vote on the release candidate #1 for the version
>>>> 4.0, as follows:|
>>>> |[ ] +1, Approve the release|
>>>> |[ ] -1, Do not approve the release (please provide specific
>>>> comments)|
>>>>
>>>> |The complete staging area is available for your review, which
>>>> includes:|
>>>> |* GitHub release notes [1],|
>>>> |* the official Apache source release to be deployed to
>>>> dist.apache.org
>>>> <https://cwiki.apache.org/confluence/display/FLINK/dist.apache.org>
>>>> [2], which are signed with the key with fingerprint 11D464BA [3],|
>>>> |* all artifacts to be deployed to the Maven Central Repository [4],|
>>>> |* source code tag "release-4.0-rc1" [5]. |
>>>> |The vote will be open for at least 72 hours. It is adopted by
>>>> majority approval, with at least 3 PMC affirmative votes.|
>>>> |Thanks,|
>>>> |Chesnay|
>>>> |[1] https://github.com/apache/flink-shaded/milestone/4?closed=1|
>>>> |[2]
>>>> https://dist.apache.org/repos/dist/dev/flink/flink-shaded-4.0-rc1/|
>>>> |[3] https://dist.apache.org/repos/dist/release/flink/KEYS|
>>>> |[4]
>>>> https://repository.apache.org/content/repositories/orgapacheflink-1165/|
>>>>
>>>> |[5]
>>>> https://github.com/apache/flink-shaded/commit/2014030963fe8e8a7414fd14afa86dd5c91e2745|
>>>>
>>
>
>