[VOTE] Release flink-shaded 3.0, release candidate #2

[Chesnay Schepler-3]

Hi everyone,
Please review and vote on the release candidate #2 for the version 3.0
of flink-shaded, as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
The complete staging area is available for your review, which includes:
* GitHub release notes [1],
* the official Apache source release to be deployed to dist.apache.org
[2], which are signed with the key with
fingerprint19F2195E1B4816D765A2C324C2EED7B111D464BA [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag “release-3.0-rc2”[5].
* A complete list of all new commits in release-3.0-rc2, since
release-2.0 [6]


The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Chesnay
[1] https://github.com/apache/flink-shaded/milestone/3?closed=1
[2] http://people.apache.org/~chesnay/flink-shaded-3.0-rc2/ 
<http://people.apache.org/%7Echesnay/flink-shaded-3.0-rc2/>
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1147/
[5]
https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=commit;h=fd0f8cc5b555bf17e0af7599c0976585da24cec3
[6]
fd0f8cc5b555bf17e0af7599c0976585da24cec3 (#38) Include missing javax
validation-api dependency
7b4fe16f8a8217771b39495cd8f14af86041c8f5 (#37) Include
jackson-dataformat-yaml and snakeyaml
1233f1bb0e2b9fafa4260603aa130b7eb9995a7a (#35) Bump netty to 4.0.56
eb064f6e24e98f3ae91bdfd91fc96a32c821620d (#31) Hard-code jackson-parent
version
f7f3eca859b417a1dcb2aa4c53b1bd9076fce43e (#31) Add extended
flink-shadaed-jackson-module-jsonSchema module
36dc4840b3624fd83a0d00295013a933297801b7 (#32) Add
flink-shaded-force-shading
2b69aa648a7d5c689c1e3c2709d7e55cb765b0a2 (#28) Bump maven-shade-plugin
version to 3.0.0
0c4e83f87d36060c0a5c6c139e00b9afec4f5d19 Increment version to 3.0

[Chesnay Schepler-3]

+1

  * compiles without error
  * every jar is self-contained
  * all classes are properly relocated
  * jackson services are properly relocated
  * all added dependencies use the Apache License 2.0
      o com.fasterxml.jackson.module:jackson-module-jsonSchema
          + javax.validation:validation-api
      o com.fasterxml.jackson.dataformat:jackson-dataformat-yaml
          + org.yaml:snakeyaml
  * verified compatibility with Flink
      o force-shading can be replaced
      o REST docs are correctly generated
      o flink-sql-client tests ran successfully

On 19.02.2018 14:13, Chesnay Schepler wrote:

> Hi everyone,
> Please review and vote on the release candidate #2 for the version 3.0
> of flink-shaded, as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
> The complete staging area is available for your review, which includes:
> * GitHub release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2], which are signed with the key with
> fingerprint19F2195E1B4816D765A2C324C2EED7B111D464BA [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag “release-3.0-rc2”[5].
> * A complete list of all new commits in release-3.0-rc2, since
> release-2.0 [6]
>
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Chesnay
> [1] https://github.com/apache/flink-shaded/milestone/3?closed=1
> [2] http://people.apache.org/~chesnay/flink-shaded-3.0-rc2/ 
> <http://people.apache.org/%7Echesnay/flink-shaded-3.0-rc2/>
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1147/
> [5]
> https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=commit;h=fd0f8cc5b555bf17e0af7599c0976585da24cec3
> [6]
> fd0f8cc5b555bf17e0af7599c0976585da24cec3 (#38) Include missing javax
> validation-api dependency
> 7b4fe16f8a8217771b39495cd8f14af86041c8f5 (#37) Include
> jackson-dataformat-yaml and snakeyaml
> 1233f1bb0e2b9fafa4260603aa130b7eb9995a7a (#35) Bump netty to 4.0.56
> eb064f6e24e98f3ae91bdfd91fc96a32c821620d (#31) Hard-code
> jackson-parent version
> f7f3eca859b417a1dcb2aa4c53b1bd9076fce43e (#31) Add extended
> flink-shadaed-jackson-module-jsonSchema module
> 36dc4840b3624fd83a0d00295013a933297801b7 (#32) Add
> flink-shaded-force-shading
> 2b69aa648a7d5c689c1e3c2709d7e55cb765b0a2 (#28) Bump maven-shade-plugin
> version to 3.0.0
> 0c4e83f87d36060c0a5c6c139e00b9afec4f5d19 Increment version to 3.0
>
>
>
>

[Aljoscha Krettek-2]

+1

 - verified hashes and signatures
 - verified that we didn't add dependencies with incompatible licenses

> On 19. Feb 2018, at 14:40, Chesnay Schepler <[hidden email]> wrote:
>
> +1
>
> * compiles without error
> * every jar is self-contained
> * all classes are properly relocated
> * jackson services are properly relocated
> * all added dependencies use the Apache License 2.0
>     o com.fasterxml.jackson.module:jackson-module-jsonSchema
>         + javax.validation:validation-api
>     o com.fasterxml.jackson.dataformat:jackson-dataformat-yaml
>         + org.yaml:snakeyaml
> * verified compatibility with Flink
>     o force-shading can be replaced
>     o REST docs are correctly generated
>     o flink-sql-client tests ran successfully
>
> On 19.02.2018 14:13, Chesnay Schepler wrote:
>> Hi everyone,
>> Please review and vote on the release candidate #2 for the version 3.0 of flink-shaded, as follows:
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>> The complete staging area is available for your review, which includes:
>> * GitHub release notes [1],
>> * the official Apache source release to be deployed to dist.apache.org [2], which are signed with the key with fingerprint19F2195E1B4816D765A2C324C2EED7B111D464BA [3],
>> * all artifacts to be deployed to the Maven Central Repository [4],
>> * source code tag “release-3.0-rc2”[5].
>> * A complete list of all new commits in release-3.0-rc2, since release-2.0 [6]
>>
>>
>> The vote will be open for at least 72 hours. It is adopted by majority approval, with at least 3 PMC affirmative votes.
>>
>> Thanks,
>> Chesnay
>> [1] https://github.com/apache/flink-shaded/milestone/3?closed=1
>> [2] http://people.apache.org/~chesnay/flink-shaded-3.0-rc2/ <http://people.apache.org/%7Echesnay/flink-shaded-3.0-rc2/>
>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>> [4] https://repository.apache.org/content/repositories/orgapacheflink-1147/
>> [5] https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=commit;h=fd0f8cc5b555bf17e0af7599c0976585da24cec3
>> [6]
>> fd0f8cc5b555bf17e0af7599c0976585da24cec3 (#38) Include missing javax validation-api dependency
>> 7b4fe16f8a8217771b39495cd8f14af86041c8f5 (#37) Include jackson-dataformat-yaml and snakeyaml
>> 1233f1bb0e2b9fafa4260603aa130b7eb9995a7a (#35) Bump netty to 4.0.56
>> eb064f6e24e98f3ae91bdfd91fc96a32c821620d (#31) Hard-code jackson-parent version
>> f7f3eca859b417a1dcb2aa4c53b1bd9076fce43e (#31) Add extended flink-shadaed-jackson-module-jsonSchema module
>> 36dc4840b3624fd83a0d00295013a933297801b7 (#32) Add flink-shaded-force-shading
>> 2b69aa648a7d5c689c1e3c2709d7e55cb765b0a2 (#28) Bump maven-shade-plugin version to 3.0.0
>> 0c4e83f87d36060c0a5c6c139e00b9afec4f5d19 Increment version to 3.0
>>
>>
>>
>>
>

[Timo Walther-2]

+1

I verified the included commits. The changes look good to me.

Am 2/20/18 um 4:32 PM schrieb Aljoscha Krettek:

> +1
>
>   - verified hashes and signatures
>   - verified that we didn't add dependencies with incompatible licenses
>
>> On 19. Feb 2018, at 14:40, Chesnay Schepler <[hidden email]> wrote:
>>
>> +1
>>
>> * compiles without error
>> * every jar is self-contained
>> * all classes are properly relocated
>> * jackson services are properly relocated
>> * all added dependencies use the Apache License 2.0
>>      o com.fasterxml.jackson.module:jackson-module-jsonSchema
>>          + javax.validation:validation-api
>>      o com.fasterxml.jackson.dataformat:jackson-dataformat-yaml
>>          + org.yaml:snakeyaml
>> * verified compatibility with Flink
>>      o force-shading can be replaced
>>      o REST docs are correctly generated
>>      o flink-sql-client tests ran successfully
>>
>> On 19.02.2018 14:13, Chesnay Schepler wrote:
>>> Hi everyone,
>>> Please review and vote on the release candidate #2 for the version 3.0 of flink-shaded, as follows:
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>> The complete staging area is available for your review, which includes:
>>> * GitHub release notes [1],
>>> * the official Apache source release to be deployed to dist.apache.org [2], which are signed with the key with fingerprint19F2195E1B4816D765A2C324C2EED7B111D464BA [3],
>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>> * source code tag “release-3.0-rc2”[5].
>>> * A complete list of all new commits in release-3.0-rc2, since release-2.0 [6]
>>>
>>>
>>> The vote will be open for at least 72 hours. It is adopted by majority approval, with at least 3 PMC affirmative votes.
>>>
>>> Thanks,
>>> Chesnay
>>> [1] https://github.com/apache/flink-shaded/milestone/3?closed=1
>>> [2] http://people.apache.org/~chesnay/flink-shaded-3.0-rc2/ <http://people.apache.org/%7Echesnay/flink-shaded-3.0-rc2/>
>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>> [4] https://repository.apache.org/content/repositories/orgapacheflink-1147/
>>> [5] https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=commit;h=fd0f8cc5b555bf17e0af7599c0976585da24cec3
>>> [6]
>>> fd0f8cc5b555bf17e0af7599c0976585da24cec3 (#38) Include missing javax validation-api dependency
>>> 7b4fe16f8a8217771b39495cd8f14af86041c8f5 (#37) Include jackson-dataformat-yaml and snakeyaml
>>> 1233f1bb0e2b9fafa4260603aa130b7eb9995a7a (#35) Bump netty to 4.0.56
>>> eb064f6e24e98f3ae91bdfd91fc96a32c821620d (#31) Hard-code jackson-parent version
>>> f7f3eca859b417a1dcb2aa4c53b1bd9076fce43e (#31) Add extended flink-shadaed-jackson-module-jsonSchema module
>>> 36dc4840b3624fd83a0d00295013a933297801b7 (#32) Add flink-shaded-force-shading
>>> 2b69aa648a7d5c689c1e3c2709d7e55cb765b0a2 (#28) Bump maven-shade-plugin version to 3.0.0
>>> 0c4e83f87d36060c0a5c6c139e00b9afec4f5d19 Increment version to 3.0
>>>
>>>
>>>
>>>

[Chesnay Schepler-3]

The vote time (+ 3-4 days) has passed. We have collected 3 +1 votes (all
binding) and no 0 or -1 votes.

+1  votes:
- Aljoscha
- Timo
- Chesnay

As such RC2 will be released as flink-shaded 3.0.

On 28.02.2018 10:12, Timo Walther wrote:

> +1
>
> I verified the included commits. The changes look good to me.
>
> Am 2/20/18 um 4:32 PM schrieb Aljoscha Krettek:
>> +1
>>
>>   - verified hashes and signatures
>>   - verified that we didn't add dependencies with incompatible licenses
>>
>>> On 19. Feb 2018, at 14:40, Chesnay Schepler <[hidden email]> wrote:
>>>
>>> +1
>>>
>>> * compiles without error
>>> * every jar is self-contained
>>> * all classes are properly relocated
>>> * jackson services are properly relocated
>>> * all added dependencies use the Apache License 2.0
>>>      o com.fasterxml.jackson.module:jackson-module-jsonSchema
>>>          + javax.validation:validation-api
>>>      o com.fasterxml.jackson.dataformat:jackson-dataformat-yaml
>>>          + org.yaml:snakeyaml
>>> * verified compatibility with Flink
>>>      o force-shading can be replaced
>>>      o REST docs are correctly generated
>>>      o flink-sql-client tests ran successfully
>>>
>>> On 19.02.2018 14:13, Chesnay Schepler wrote:
>>>> Hi everyone,
>>>> Please review and vote on the release candidate #2 for the version
>>>> 3.0 of flink-shaded, as follows:
>>>> [ ] +1, Approve the release
>>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>> The complete staging area is available for your review, which
>>>> includes:
>>>> * GitHub release notes [1],
>>>> * the official Apache source release to be deployed to
>>>> dist.apache.org [2], which are signed with the key with
>>>> fingerprint19F2195E1B4816D765A2C324C2EED7B111D464BA [3],
>>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>>> * source code tag “release-3.0-rc2”[5].
>>>> * A complete list of all new commits in release-3.0-rc2, since
>>>> release-2.0 [6]
>>>>
>>>>
>>>> The vote will be open for at least 72 hours. It is adopted by
>>>> majority approval, with at least 3 PMC affirmative votes.
>>>>
>>>> Thanks,
>>>> Chesnay
>>>> [1] https://github.com/apache/flink-shaded/milestone/3?closed=1
>>>> [2] http://people.apache.org/~chesnay/flink-shaded-3.0-rc2/ 
>>>> <http://people.apache.org/%7Echesnay/flink-shaded-3.0-rc2/>
>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>>> [4]
>>>> https://repository.apache.org/content/repositories/orgapacheflink-1147/ 
>>>>
>>>> [5]
>>>> https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=commit;h=fd0f8cc5b555bf17e0af7599c0976585da24cec3
>>>> [6]
>>>> fd0f8cc5b555bf17e0af7599c0976585da24cec3 (#38) Include missing
>>>> javax validation-api dependency
>>>> 7b4fe16f8a8217771b39495cd8f14af86041c8f5 (#37) Include
>>>> jackson-dataformat-yaml and snakeyaml
>>>> 1233f1bb0e2b9fafa4260603aa130b7eb9995a7a (#35) Bump netty to 4.0.56
>>>> eb064f6e24e98f3ae91bdfd91fc96a32c821620d (#31) Hard-code
>>>> jackson-parent version
>>>> f7f3eca859b417a1dcb2aa4c53b1bd9076fce43e (#31) Add extended
>>>> flink-shadaed-jackson-module-jsonSchema module
>>>> 36dc4840b3624fd83a0d00295013a933297801b7 (#32) Add
>>>> flink-shaded-force-shading
>>>> 2b69aa648a7d5c689c1e3c2709d7e55cb765b0a2 (#28) Bump
>>>> maven-shade-plugin version to 3.0.0
>>>> 0c4e83f87d36060c0a5c6c139e00b9afec4f5d19 Increment version to 3.0
>>>>
>>>>
>>>>
>>>>
>
>