[VOTE] Release flink-shaded 3.0, release candidate #1

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release flink-shaded 3.0, release candidate #1

Chesnay Schepler-3
|Hi everyone,|
|Please review and vote on the release candidate #1 for the version 3.0
of flink-shaded, as follows:|
|[ ] +1, Approve the release|
|[ ] -1, Do not approve the release (please provide specific comments)|
|The complete staging area is available for your review, which includes:
* GitHub release notes [1],
|
|* the official Apache source release to be deployed to dist.apache.org
[2], which are signed with the key with
fingerprint|19F2195E1B4816D765A2C324C2EED7B111D464BA |[3],|||
|* all artifacts to be deployed to the Maven Central Repository [4],
* |source code tag “release-3.0-rc1”|||[5].|
* A complete list of all new commits in release-3.0-rc1, since
release-2.0 [6]


|The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.
|
|Thanks,|
|Chesnay|
|[1] https://github.com/apache/flink-shaded/milestone/3?closed=1
[2] http://people.apache.org/~chesnay/flink-shaded-3.0-rc1/ 
<http://people.apache.org/%7Echesnay/flink-shaded-3.0-rc1/>|
|[3] https://dist.apache.org/repos/dist/release/flink/KEYS|
|[4]
https://repository.apache.org/content/repositories/orgapacheflink-1146/|
|[5]
https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=commit;h=1233f1bb0e2b9fafa4260603aa130b7eb9995a7a|
[6]
1233f1bb0e2b9fafa4260603aa130b7eb9995a7a (#35) Bump netty to 4.0.56
eb064f6e24e98f3ae91bdfd91fc96a32c821620d (#31) Hard-code jackson-parent
version
f7f3eca859b417a1dcb2aa4c53b1bd9076fce43e (#31) Add extended
flink-shadaed-jackson-module-jsonSchema module
36dc4840b3624fd83a0d00295013a933297801b7 (#32) Add
flink-shaded-force-shading
2b69aa648a7d5c689c1e3c2709d7e55cb765b0a2 (#28) Bump maven-shade-plugin
version to 3.0.0
0c4e83f87d36060c0a5c6c139e00b9afec4f5d19 Increment version to 3.0
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release flink-shaded 3.0, release candidate #1

Chesnay Schepler-3
Previous mail contained some funky pipes, let's try this again...

Hi everyone,
Please review and vote on the release candidate #1 for the version 3.0
of flink-shaded, as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
The complete staging area is available for your review, which includes:
* GitHub release notes [1],

* the official Apache source release to be deployed to dist.apache.org
[2], which are signed with the key with
fingerprint19F2195E1B4816D765A2C324C2EED7B111D464BA [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag “release-3.0-rc1”[5].
* A complete list of all new commits in release-3.0-rc1, since
release-2.0 [6]


The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Chesnay
[1] https://github.com/apache/flink-shaded/milestone/3?closed=1
[2] http://people.apache.org/~chesnay/flink-shaded-3.0-rc1/ 
<http://people.apache.org/%7Echesnay/flink-shaded-3.0-rc1/>
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1146/
[5]
https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=commit;h=1233f1bb0e2b9fafa4260603aa130b7eb9995a7a
[6]
1233f1bb0e2b9fafa4260603aa130b7eb9995a7a (#35) Bump netty to 4.0.56
eb064f6e24e98f3ae91bdfd91fc96a32c821620d (#31) Hard-code jackson-parent
version
f7f3eca859b417a1dcb2aa4c53b1bd9076fce43e (#31) Add extended
flink-shadaed-jackson-module-jsonSchema module
36dc4840b3624fd83a0d00295013a933297801b7 (#32) Add
flink-shaded-force-shading
2b69aa648a7d5c689c1e3c2709d7e55cb765b0a2 (#28) Bump maven-shade-plugin
version to 3.0.0
0c4e83f87d36060c0a5c6c139e00b9afec4f5d19 Increment version to 3.0


Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release flink-shaded 3.0, release candidate #1

Timo Walther-2
Hi Chesnay,

thanks for working on a new flink-shaded version. I just had an offline
discussion with Stephan Ewen about shading Jackson also in
flink-sql-client. The problem is that we use jackson-dataformat-yaml
there which is incompatible with our shaded version. Would it be
possible to include this as well in the next shaded version in order to
have a cleaner 1.5 release?

Regards,
Timo

Am 2/19/18 um 1:29 PM schrieb Chesnay Schepler:

> Previous mail contained some funky pipes, let's try this again...
>
> Hi everyone,
> Please review and vote on the release candidate #1 for the version 3.0
> of flink-shaded, as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
> The complete staging area is available for your review, which includes:
> * GitHub release notes [1],
>
> * the official Apache source release to be deployed to dist.apache.org
> [2], which are signed with the key with
> fingerprint19F2195E1B4816D765A2C324C2EED7B111D464BA [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag “release-3.0-rc1”[5].
> * A complete list of all new commits in release-3.0-rc1, since
> release-2.0 [6]
>
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Chesnay
> [1] https://github.com/apache/flink-shaded/milestone/3?closed=1
> [2] http://people.apache.org/~chesnay/flink-shaded-3.0-rc1/ 
> <http://people.apache.org/%7Echesnay/flink-shaded-3.0-rc1/>
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1146/
> [5]
> https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=commit;h=1233f1bb0e2b9fafa4260603aa130b7eb9995a7a
> [6]
> 1233f1bb0e2b9fafa4260603aa130b7eb9995a7a (#35) Bump netty to 4.0.56
> eb064f6e24e98f3ae91bdfd91fc96a32c821620d (#31) Hard-code
> jackson-parent version
> f7f3eca859b417a1dcb2aa4c53b1bd9076fce43e (#31) Add extended
> flink-shadaed-jackson-module-jsonSchema module
> 36dc4840b3624fd83a0d00295013a933297801b7 (#32) Add
> flink-shaded-force-shading
> 2b69aa648a7d5c689c1e3c2709d7e55cb765b0a2 (#28) Bump maven-shade-plugin
> version to 3.0.0
> 0c4e83f87d36060c0a5c6c139e00b9afec4f5d19 Increment version to 3.0
>

Reply | Threaded
Open this post in threaded view
|

[CANCEL] Release flink-shaded 3.0, release candidate #1

Chesnay Schepler-3
I'll cancel the vote to include jackson-dataformats-yaml in
flink-shaded-jackson.

This comes at no overhead btw. since I found another issue:
     flink-shaded-jackson-module-jsonSchema is not self-contained as it
is missing javax.validation:validation-api

On 19.02.2018 13:39, Timo Walther wrote:

> Hi Chesnay,
>
> thanks for working on a new flink-shaded version. I just had an
> offline discussion with Stephan Ewen about shading Jackson also in
> flink-sql-client. The problem is that we use jackson-dataformat-yaml
> there which is incompatible with our shaded version. Would it be
> possible to include this as well in the next shaded version in order
> to have a cleaner 1.5 release?
>
> Regards,
> Timo
>
> Am 2/19/18 um 1:29 PM schrieb Chesnay Schepler:
>> Previous mail contained some funky pipes, let's try this again...
>>
>> Hi everyone,
>> Please review and vote on the release candidate #1 for the version
>> 3.0 of flink-shaded, as follows:
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>> The complete staging area is available for your review, which includes:
>> * GitHub release notes [1],
>>
>> * the official Apache source release to be deployed to
>> dist.apache.org [2], which are signed with the key with
>> fingerprint19F2195E1B4816D765A2C324C2EED7B111D464BA [3],
>> * all artifacts to be deployed to the Maven Central Repository [4],
>> * source code tag “release-3.0-rc1”[5].
>> * A complete list of all new commits in release-3.0-rc1, since
>> release-2.0 [6]
>>
>>
>> The vote will be open for at least 72 hours. It is adopted by
>> majority approval, with at least 3 PMC affirmative votes.
>>
>> Thanks,
>> Chesnay
>> [1] https://github.com/apache/flink-shaded/milestone/3?closed=1
>> [2] http://people.apache.org/~chesnay/flink-shaded-3.0-rc1/ 
>> <http://people.apache.org/%7Echesnay/flink-shaded-3.0-rc1/>
>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>> [4]
>> https://repository.apache.org/content/repositories/orgapacheflink-1146/
>> [5]
>> https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=commit;h=1233f1bb0e2b9fafa4260603aa130b7eb9995a7a
>> [6]
>> 1233f1bb0e2b9fafa4260603aa130b7eb9995a7a (#35) Bump netty to 4.0.56
>> eb064f6e24e98f3ae91bdfd91fc96a32c821620d (#31) Hard-code
>> jackson-parent version
>> f7f3eca859b417a1dcb2aa4c53b1bd9076fce43e (#31) Add extended
>> flink-shadaed-jackson-module-jsonSchema module
>> 36dc4840b3624fd83a0d00295013a933297801b7 (#32) Add
>> flink-shaded-force-shading
>> 2b69aa648a7d5c689c1e3c2709d7e55cb765b0a2 (#28) Bump
>> maven-shade-plugin version to 3.0.0
>> 0c4e83f87d36060c0a5c6c139e00b9afec4f5d19 Increment version to 3.0
>>
>
>