[VOTE] Release flink-shaded 10.0, release candidate #3

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release flink-shaded 10.0, release candidate #3

Chesnay Schepler-3
Hi everyone,
Please review and vote on the release candidate #3 for the version 10.0,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)


The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org
[2], which are signed with the key with fingerprint 11D464BA [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag "release-10.0-rc3 [5],
* website pull request listing the new release [6].

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Chesnay

[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346746
[2] https://dist.apache.org/repos/dist/dev/flink/flink-shaded-10.0-rc3/
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1337
[5]
https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=tag;h=refs/tags/release-10.0-rc3
[6] https://github.com/apache/flink-web/pull/304



Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release flink-shaded 10.0, release candidate #3

Yu Li
+1 (non-binding)

Checked issues listed in release notes: ok
Checked sums and signatures: ok
Checked the maven central artifices: ok
Built from source: ok (8u101, 11.0.4)
Built from source (with -Dshade-sources): ok (8u101, 11.0.4)
Checked contents of zookeeper shaded jars: ok
- no unshaded classes
- shading pattern is correct
Checked website pull request listing the new release: ok

Best Regards,
Yu


On Wed, 12 Feb 2020 at 22:09, Chesnay Schepler <[hidden email]> wrote:

> Hi everyone,
> Please review and vote on the release candidate #3 for the version 10.0,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2], which are signed with the key with fingerprint 11D464BA [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag "release-10.0-rc3 [5],
> * website pull request listing the new release [6].
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Chesnay
>
> [1]
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346746
> [2] https://dist.apache.org/repos/dist/dev/flink/flink-shaded-10.0-rc3/
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/orgapacheflink-1337
> [5]
>
> https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=tag;h=refs/tags/release-10.0-rc3
> [6] https://github.com/apache/flink-web/pull/304
>
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release flink-shaded 10.0, release candidate #3

Ufuk Celebi-2
Hey Chensay,

+1 (binding).

- Verified checksum ✅
- Verified signature ✅
- Jira changelog looks good to me ✅
- Website PR looks good to me ✅
- Verified no unshaded dependencies (except the Hadoop modules which I
think is expected) ✅
- Verified dependency management fix FLINK-15540 (commons-collections:3.2.2
as expected) ✅
- Verified pom exclusion fix FLINK-15815 (no META-INF/maven except for
flink-shaded-force-shading and the Hadoop modules which I think is
expected) ✅

– Ufuk

On Thu, Feb 13, 2020 at 3:08 PM Yu Li <[hidden email]> wrote:

>
> +1 (non-binding)
>
> Checked issues listed in release notes: ok
> Checked sums and signatures: ok
> Checked the maven central artifices: ok
> Built from source: ok (8u101, 11.0.4)
> Built from source (with -Dshade-sources): ok (8u101, 11.0.4)
> Checked contents of zookeeper shaded jars: ok
> - no unshaded classes
> - shading pattern is correct
> Checked website pull request listing the new release: ok
>
> Best Regards,
> Yu
>
>
> On Wed, 12 Feb 2020 at 22:09, Chesnay Schepler <[hidden email]> wrote:
>
> > Hi everyone,
> > Please review and vote on the release candidate #3 for the version 10.0,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> >
> > The complete staging area is available for your review, which includes:
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to dist.apache.org
> > [2], which are signed with the key with fingerprint 11D464BA [3],
> > * all artifacts to be deployed to the Maven Central Repository [4],
> > * source code tag "release-10.0-rc3 [5],
> > * website pull request listing the new release [6].
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Chesnay
> >
> > [1]
> >
> >
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346746
> > [2] https://dist.apache.org/repos/dist/dev/flink/flink-shaded-10.0-rc3/
> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [4]
https://repository.apache.org/content/repositories/orgapacheflink-1337
> > [5]
> >
> >
https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=tag;h=refs/tags/release-10.0-rc3
> > [6] https://github.com/apache/flink-web/pull/304
> >
> >
> >
> >
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release flink-shaded 10.0, release candidate #3

Ufuk Celebi-2
PS: Also verified the NOTICE changes since the last RC.

On Thu, Feb 13, 2020 at 5:25 PM Ufuk Celebi <[hidden email]> wrote:

> Hey Chensay,
>
> +1 (binding).
>
> - Verified checksum ✅
> - Verified signature ✅
> - Jira changelog looks good to me ✅
> - Website PR looks good to me ✅
> - Verified no unshaded dependencies (except the Hadoop modules which I
> think is expected) ✅
> - Verified dependency management fix FLINK-15540
> (commons-collections:3.2.2 as expected) ✅
> - Verified pom exclusion fix FLINK-15815 (no META-INF/maven except for
> flink-shaded-force-shading and the Hadoop modules which I think is
> expected) ✅
>
> – Ufuk
>
> On Thu, Feb 13, 2020 at 3:08 PM Yu Li <[hidden email]> wrote:
> >
> > +1 (non-binding)
> >
> > Checked issues listed in release notes: ok
> > Checked sums and signatures: ok
> > Checked the maven central artifices: ok
> > Built from source: ok (8u101, 11.0.4)
> > Built from source (with -Dshade-sources): ok (8u101, 11.0.4)
> > Checked contents of zookeeper shaded jars: ok
> > - no unshaded classes
> > - shading pattern is correct
> > Checked website pull request listing the new release: ok
> >
> > Best Regards,
> > Yu
> >
> >
> > On Wed, 12 Feb 2020 at 22:09, Chesnay Schepler <[hidden email]>
> wrote:
> >
> > > Hi everyone,
> > > Please review and vote on the release candidate #3 for the version
> 10.0,
> > > as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > >
> > > The complete staging area is available for your review, which includes:
> > > * JIRA release notes [1],
> > > * the official Apache source release to be deployed to dist.apache.org
> > > [2], which are signed with the key with fingerprint 11D464BA [3],
> > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > * source code tag "release-10.0-rc3 [5],
> > > * website pull request listing the new release [6].
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Thanks,
> > > Chesnay
> > >
> > > [1]
> > >
> > >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346746
> > > [2]
> https://dist.apache.org/repos/dist/dev/flink/flink-shaded-10.0-rc3/
> > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1337
> > > [5]
> > >
> > >
> https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=tag;h=refs/tags/release-10.0-rc3
> > > [6] https://github.com/apache/flink-web/pull/304
> > >
> > >
> > >
> > >
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release flink-shaded 10.0, release candidate #3

Zhu Zhu
+1 (non-binding)

- checked release notes, JIRA tickets and commit history
- verified the signature and checksum
- checked the maven central artifacts
  * examined the zookeeper shaded jars (both 3.4.10 and 3.5.6), curator and
zookeeper classes are there and shaded
- built from the source archive as well as the git tag
- checked the website pull request

Thanks,
Zhu Zhu

Ufuk Celebi <[hidden email]> 于2020年2月14日周五 上午12:32写道:

> PS: Also verified the NOTICE changes since the last RC.
>
> On Thu, Feb 13, 2020 at 5:25 PM Ufuk Celebi <[hidden email]> wrote:
>
> > Hey Chensay,
> >
> > +1 (binding).
> >
> > - Verified checksum ✅
> > - Verified signature ✅
> > - Jira changelog looks good to me ✅
> > - Website PR looks good to me ✅
> > - Verified no unshaded dependencies (except the Hadoop modules which I
> > think is expected) ✅
> > - Verified dependency management fix FLINK-15540
> > (commons-collections:3.2.2 as expected) ✅
> > - Verified pom exclusion fix FLINK-15815 (no META-INF/maven except for
> > flink-shaded-force-shading and the Hadoop modules which I think is
> > expected) ✅
> >
> > – Ufuk
> >
> > On Thu, Feb 13, 2020 at 3:08 PM Yu Li <[hidden email]> wrote:
> > >
> > > +1 (non-binding)
> > >
> > > Checked issues listed in release notes: ok
> > > Checked sums and signatures: ok
> > > Checked the maven central artifices: ok
> > > Built from source: ok (8u101, 11.0.4)
> > > Built from source (with -Dshade-sources): ok (8u101, 11.0.4)
> > > Checked contents of zookeeper shaded jars: ok
> > > - no unshaded classes
> > > - shading pattern is correct
> > > Checked website pull request listing the new release: ok
> > >
> > > Best Regards,
> > > Yu
> > >
> > >
> > > On Wed, 12 Feb 2020 at 22:09, Chesnay Schepler <[hidden email]>
> > wrote:
> > >
> > > > Hi everyone,
> > > > Please review and vote on the release candidate #3 for the version
> > 10.0,
> > > > as follows:
> > > > [ ] +1, Approve the release
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > >
> > > >
> > > > The complete staging area is available for your review, which
> includes:
> > > > * JIRA release notes [1],
> > > > * the official Apache source release to be deployed to
> dist.apache.org
> > > > [2], which are signed with the key with fingerprint 11D464BA [3],
> > > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > > * source code tag "release-10.0-rc3 [5],
> > > > * website pull request listing the new release [6].
> > > >
> > > > The vote will be open for at least 72 hours. It is adopted by
> majority
> > > > approval, with at least 3 PMC affirmative votes.
> > > >
> > > > Thanks,
> > > > Chesnay
> > > >
> > > > [1]
> > > >
> > > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346746
> > > > [2]
> > https://dist.apache.org/repos/dist/dev/flink/flink-shaded-10.0-rc3/
> > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > [4]
> > https://repository.apache.org/content/repositories/orgapacheflink-1337
> > > > [5]
> > > >
> > > >
> >
> https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=tag;h=refs/tags/release-10.0-rc3
> > > > [6] https://github.com/apache/flink-web/pull/304
> > > >
> > > >
> > > >
> > > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release flink-shaded 10.0, release candidate #3

Hequn Cheng-2
Thank you Chesnay for the release!

+1 (non-binding)

- The problem that exists in RC1 has been resolved.
- Release notes looks good.
- Built from source archive successfully.
- Check commit history manually. Nothing looks weird.
- Signatures and hash are correct.
- All artifacts have been deployed to the maven central repository.
- The website pull request looks good

Best, Hequn

On Fri, Feb 14, 2020 at 1:14 AM Zhu Zhu <[hidden email]> wrote:

> +1 (non-binding)
>
> - checked release notes, JIRA tickets and commit history
> - verified the signature and checksum
> - checked the maven central artifacts
>   * examined the zookeeper shaded jars (both 3.4.10 and 3.5.6), curator and
> zookeeper classes are there and shaded
> - built from the source archive as well as the git tag
> - checked the website pull request
>
> Thanks,
> Zhu Zhu
>
> Ufuk Celebi <[hidden email]> 于2020年2月14日周五 上午12:32写道:
>
> > PS: Also verified the NOTICE changes since the last RC.
> >
> > On Thu, Feb 13, 2020 at 5:25 PM Ufuk Celebi <[hidden email]> wrote:
> >
> > > Hey Chensay,
> > >
> > > +1 (binding).
> > >
> > > - Verified checksum ✅
> > > - Verified signature ✅
> > > - Jira changelog looks good to me ✅
> > > - Website PR looks good to me ✅
> > > - Verified no unshaded dependencies (except the Hadoop modules which I
> > > think is expected) ✅
> > > - Verified dependency management fix FLINK-15540
> > > (commons-collections:3.2.2 as expected) ✅
> > > - Verified pom exclusion fix FLINK-15815 (no META-INF/maven except for
> > > flink-shaded-force-shading and the Hadoop modules which I think is
> > > expected) ✅
> > >
> > > – Ufuk
> > >
> > > On Thu, Feb 13, 2020 at 3:08 PM Yu Li <[hidden email]> wrote:
> > > >
> > > > +1 (non-binding)
> > > >
> > > > Checked issues listed in release notes: ok
> > > > Checked sums and signatures: ok
> > > > Checked the maven central artifices: ok
> > > > Built from source: ok (8u101, 11.0.4)
> > > > Built from source (with -Dshade-sources): ok (8u101, 11.0.4)
> > > > Checked contents of zookeeper shaded jars: ok
> > > > - no unshaded classes
> > > > - shading pattern is correct
> > > > Checked website pull request listing the new release: ok
> > > >
> > > > Best Regards,
> > > > Yu
> > > >
> > > >
> > > > On Wed, 12 Feb 2020 at 22:09, Chesnay Schepler <[hidden email]>
> > > wrote:
> > > >
> > > > > Hi everyone,
> > > > > Please review and vote on the release candidate #3 for the version
> > > 10.0,
> > > > > as follows:
> > > > > [ ] +1, Approve the release
> > > > > [ ] -1, Do not approve the release (please provide specific
> comments)
> > > > >
> > > > >
> > > > > The complete staging area is available for your review, which
> > includes:
> > > > > * JIRA release notes [1],
> > > > > * the official Apache source release to be deployed to
> > dist.apache.org
> > > > > [2], which are signed with the key with fingerprint 11D464BA [3],
> > > > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > > > * source code tag "release-10.0-rc3 [5],
> > > > > * website pull request listing the new release [6].
> > > > >
> > > > > The vote will be open for at least 72 hours. It is adopted by
> > majority
> > > > > approval, with at least 3 PMC affirmative votes.
> > > > >
> > > > > Thanks,
> > > > > Chesnay
> > > > >
> > > > > [1]
> > > > >
> > > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346746
> > > > > [2]
> > > https://dist.apache.org/repos/dist/dev/flink/flink-shaded-10.0-rc3/
> > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > > [4]
> > > https://repository.apache.org/content/repositories/orgapacheflink-1337
> > > > > [5]
> > > > >
> > > > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=tag;h=refs/tags/release-10.0-rc3
> > > > > [6] https://github.com/apache/flink-web/pull/304
> > > > >
> > > > >
> > > > >
> > > > >
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release flink-shaded 10.0, release candidate #3

Dian Fu-2
+1 (non-binding)

- Verified the signature and checksum
- Checked the release note that all the tickets included in this release are there
- Checked the website PR and it LGTM
- Checked the notice file of the newly added module flink-shade-zookeeper-3 and it LGTM

Regards,
Dian

> 在 2020年2月14日,下午2:58,Hequn Cheng <[hidden email]> 写道:
>
> Thank you Chesnay for the release!
>
> +1 (non-binding)
>
> - The problem that exists in RC1 has been resolved.
> - Release notes looks good.
> - Built from source archive successfully.
> - Check commit history manually. Nothing looks weird.
> - Signatures and hash are correct.
> - All artifacts have been deployed to the maven central repository.
> - The website pull request looks good
>
> Best, Hequn
>
> On Fri, Feb 14, 2020 at 1:14 AM Zhu Zhu <[hidden email]> wrote:
>
>> +1 (non-binding)
>>
>> - checked release notes, JIRA tickets and commit history
>> - verified the signature and checksum
>> - checked the maven central artifacts
>>  * examined the zookeeper shaded jars (both 3.4.10 and 3.5.6), curator and
>> zookeeper classes are there and shaded
>> - built from the source archive as well as the git tag
>> - checked the website pull request
>>
>> Thanks,
>> Zhu Zhu
>>
>> Ufuk Celebi <[hidden email]> 于2020年2月14日周五 上午12:32写道:
>>
>>> PS: Also verified the NOTICE changes since the last RC.
>>>
>>> On Thu, Feb 13, 2020 at 5:25 PM Ufuk Celebi <[hidden email]> wrote:
>>>
>>>> Hey Chensay,
>>>>
>>>> +1 (binding).
>>>>
>>>> - Verified checksum ✅
>>>> - Verified signature ✅
>>>> - Jira changelog looks good to me ✅
>>>> - Website PR looks good to me ✅
>>>> - Verified no unshaded dependencies (except the Hadoop modules which I
>>>> think is expected) ✅
>>>> - Verified dependency management fix FLINK-15540
>>>> (commons-collections:3.2.2 as expected) ✅
>>>> - Verified pom exclusion fix FLINK-15815 (no META-INF/maven except for
>>>> flink-shaded-force-shading and the Hadoop modules which I think is
>>>> expected) ✅
>>>>
>>>> – Ufuk
>>>>
>>>> On Thu, Feb 13, 2020 at 3:08 PM Yu Li <[hidden email]> wrote:
>>>>>
>>>>> +1 (non-binding)
>>>>>
>>>>> Checked issues listed in release notes: ok
>>>>> Checked sums and signatures: ok
>>>>> Checked the maven central artifices: ok
>>>>> Built from source: ok (8u101, 11.0.4)
>>>>> Built from source (with -Dshade-sources): ok (8u101, 11.0.4)
>>>>> Checked contents of zookeeper shaded jars: ok
>>>>> - no unshaded classes
>>>>> - shading pattern is correct
>>>>> Checked website pull request listing the new release: ok
>>>>>
>>>>> Best Regards,
>>>>> Yu
>>>>>
>>>>>
>>>>> On Wed, 12 Feb 2020 at 22:09, Chesnay Schepler <[hidden email]>
>>>> wrote:
>>>>>
>>>>>> Hi everyone,
>>>>>> Please review and vote on the release candidate #3 for the version
>>>> 10.0,
>>>>>> as follows:
>>>>>> [ ] +1, Approve the release
>>>>>> [ ] -1, Do not approve the release (please provide specific
>> comments)
>>>>>>
>>>>>>
>>>>>> The complete staging area is available for your review, which
>>> includes:
>>>>>> * JIRA release notes [1],
>>>>>> * the official Apache source release to be deployed to
>>> dist.apache.org
>>>>>> [2], which are signed with the key with fingerprint 11D464BA [3],
>>>>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>>>>> * source code tag "release-10.0-rc3 [5],
>>>>>> * website pull request listing the new release [6].
>>>>>>
>>>>>> The vote will be open for at least 72 hours. It is adopted by
>>> majority
>>>>>> approval, with at least 3 PMC affirmative votes.
>>>>>>
>>>>>> Thanks,
>>>>>> Chesnay
>>>>>>
>>>>>> [1]
>>>>>>
>>>>>>
>>>>
>>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346746
>>>>>> [2]
>>>> https://dist.apache.org/repos/dist/dev/flink/flink-shaded-10.0-rc3/
>>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>>>>> [4]
>>>> https://repository.apache.org/content/repositories/orgapacheflink-1337
>>>>>> [5]
>>>>>>
>>>>>>
>>>>
>>>
>> https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=tag;h=refs/tags/release-10.0-rc3
>>>>>> [6] https://github.com/apache/flink-web/pull/304
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>
>>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release flink-shaded 10.0, release candidate #3

Robert Metzger
+1 (binding)

- Checked some artifacts in the staging repo
 - checked license documentation
- source release is binary free

On Fri, Feb 14, 2020 at 8:01 AM Dian Fu <[hidden email]> wrote:

> +1 (non-binding)
>
> - Verified the signature and checksum
> - Checked the release note that all the tickets included in this release
> are there
> - Checked the website PR and it LGTM
> - Checked the notice file of the newly added module
> flink-shade-zookeeper-3 and it LGTM
>
> Regards,
> Dian
>
> > 在 2020年2月14日,下午2:58,Hequn Cheng <[hidden email]> 写道:
> >
> > Thank you Chesnay for the release!
> >
> > +1 (non-binding)
> >
> > - The problem that exists in RC1 has been resolved.
> > - Release notes looks good.
> > - Built from source archive successfully.
> > - Check commit history manually. Nothing looks weird.
> > - Signatures and hash are correct.
> > - All artifacts have been deployed to the maven central repository.
> > - The website pull request looks good
> >
> > Best, Hequn
> >
> > On Fri, Feb 14, 2020 at 1:14 AM Zhu Zhu <[hidden email]> wrote:
> >
> >> +1 (non-binding)
> >>
> >> - checked release notes, JIRA tickets and commit history
> >> - verified the signature and checksum
> >> - checked the maven central artifacts
> >>  * examined the zookeeper shaded jars (both 3.4.10 and 3.5.6), curator
> and
> >> zookeeper classes are there and shaded
> >> - built from the source archive as well as the git tag
> >> - checked the website pull request
> >>
> >> Thanks,
> >> Zhu Zhu
> >>
> >> Ufuk Celebi <[hidden email]> 于2020年2月14日周五 上午12:32写道:
> >>
> >>> PS: Also verified the NOTICE changes since the last RC.
> >>>
> >>> On Thu, Feb 13, 2020 at 5:25 PM Ufuk Celebi <[hidden email]> wrote:
> >>>
> >>>> Hey Chensay,
> >>>>
> >>>> +1 (binding).
> >>>>
> >>>> - Verified checksum ✅
> >>>> - Verified signature ✅
> >>>> - Jira changelog looks good to me ✅
> >>>> - Website PR looks good to me ✅
> >>>> - Verified no unshaded dependencies (except the Hadoop modules which I
> >>>> think is expected) ✅
> >>>> - Verified dependency management fix FLINK-15540
> >>>> (commons-collections:3.2.2 as expected) ✅
> >>>> - Verified pom exclusion fix FLINK-15815 (no META-INF/maven except for
> >>>> flink-shaded-force-shading and the Hadoop modules which I think is
> >>>> expected) ✅
> >>>>
> >>>> – Ufuk
> >>>>
> >>>> On Thu, Feb 13, 2020 at 3:08 PM Yu Li <[hidden email]> wrote:
> >>>>>
> >>>>> +1 (non-binding)
> >>>>>
> >>>>> Checked issues listed in release notes: ok
> >>>>> Checked sums and signatures: ok
> >>>>> Checked the maven central artifices: ok
> >>>>> Built from source: ok (8u101, 11.0.4)
> >>>>> Built from source (with -Dshade-sources): ok (8u101, 11.0.4)
> >>>>> Checked contents of zookeeper shaded jars: ok
> >>>>> - no unshaded classes
> >>>>> - shading pattern is correct
> >>>>> Checked website pull request listing the new release: ok
> >>>>>
> >>>>> Best Regards,
> >>>>> Yu
> >>>>>
> >>>>>
> >>>>> On Wed, 12 Feb 2020 at 22:09, Chesnay Schepler <[hidden email]>
> >>>> wrote:
> >>>>>
> >>>>>> Hi everyone,
> >>>>>> Please review and vote on the release candidate #3 for the version
> >>>> 10.0,
> >>>>>> as follows:
> >>>>>> [ ] +1, Approve the release
> >>>>>> [ ] -1, Do not approve the release (please provide specific
> >> comments)
> >>>>>>
> >>>>>>
> >>>>>> The complete staging area is available for your review, which
> >>> includes:
> >>>>>> * JIRA release notes [1],
> >>>>>> * the official Apache source release to be deployed to
> >>> dist.apache.org
> >>>>>> [2], which are signed with the key with fingerprint 11D464BA [3],
> >>>>>> * all artifacts to be deployed to the Maven Central Repository [4],
> >>>>>> * source code tag "release-10.0-rc3 [5],
> >>>>>> * website pull request listing the new release [6].
> >>>>>>
> >>>>>> The vote will be open for at least 72 hours. It is adopted by
> >>> majority
> >>>>>> approval, with at least 3 PMC affirmative votes.
> >>>>>>
> >>>>>> Thanks,
> >>>>>> Chesnay
> >>>>>>
> >>>>>> [1]
> >>>>>>
> >>>>>>
> >>>>
> >>>
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346746
> >>>>>> [2]
> >>>> https://dist.apache.org/repos/dist/dev/flink/flink-shaded-10.0-rc3/
> >>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> >>>>>> [4]
> >>>>
> https://repository.apache.org/content/repositories/orgapacheflink-1337
> >>>>>> [5]
> >>>>>>
> >>>>>>
> >>>>
> >>>
> >>
> https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=tag;h=refs/tags/release-10.0-rc3
> >>>>>> [6] https://github.com/apache/flink-web/pull/304
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>
> >>>
> >>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release flink-shaded 10.0, release candidate #3

Zhijiang(wangzhijiang999)
+1 (non-binding)

- Checked the release notes
- Downloaded the source and built successfully
- Verified the signature and checksum
- Verified the artifacts in the Maven Central Repository

Best,
Zhijiang


------------------------------------------------------------------
From:Robert Metzger <[hidden email]>
Send Time:2020 Feb. 14 (Fri.) 21:35
To:dev <[hidden email]>
Subject:Re: [VOTE] Release flink-shaded 10.0, release candidate #3

+1 (binding)

- Checked some artifacts in the staging repo
 - checked license documentation
- source release is binary free

On Fri, Feb 14, 2020 at 8:01 AM Dian Fu <[hidden email]> wrote:

> +1 (non-binding)
>
> - Verified the signature and checksum
> - Checked the release note that all the tickets included in this release
> are there
> - Checked the website PR and it LGTM
> - Checked the notice file of the newly added module
> flink-shade-zookeeper-3 and it LGTM
>
> Regards,
> Dian
>
> > 在 2020年2月14日,下午2:58,Hequn Cheng <[hidden email]> 写道:
> >
> > Thank you Chesnay for the release!
> >
> > +1 (non-binding)
> >
> > - The problem that exists in RC1 has been resolved.
> > - Release notes looks good.
> > - Built from source archive successfully.
> > - Check commit history manually. Nothing looks weird.
> > - Signatures and hash are correct.
> > - All artifacts have been deployed to the maven central repository.
> > - The website pull request looks good
> >
> > Best, Hequn
> >
> > On Fri, Feb 14, 2020 at 1:14 AM Zhu Zhu <[hidden email]> wrote:
> >
> >> +1 (non-binding)
> >>
> >> - checked release notes, JIRA tickets and commit history
> >> - verified the signature and checksum
> >> - checked the maven central artifacts
> >>  * examined the zookeeper shaded jars (both 3.4.10 and 3.5.6), curator
> and
> >> zookeeper classes are there and shaded
> >> - built from the source archive as well as the git tag
> >> - checked the website pull request
> >>
> >> Thanks,
> >> Zhu Zhu
> >>
> >> Ufuk Celebi <[hidden email]> 于2020年2月14日周五 上午12:32写道:
> >>
> >>> PS: Also verified the NOTICE changes since the last RC.
> >>>
> >>> On Thu, Feb 13, 2020 at 5:25 PM Ufuk Celebi <[hidden email]> wrote:
> >>>
> >>>> Hey Chensay,
> >>>>
> >>>> +1 (binding).
> >>>>
> >>>> - Verified checksum ✅
> >>>> - Verified signature ✅
> >>>> - Jira changelog looks good to me ✅
> >>>> - Website PR looks good to me ✅
> >>>> - Verified no unshaded dependencies (except the Hadoop modules which I
> >>>> think is expected) ✅
> >>>> - Verified dependency management fix FLINK-15540
> >>>> (commons-collections:3.2.2 as expected) ✅
> >>>> - Verified pom exclusion fix FLINK-15815 (no META-INF/maven except for
> >>>> flink-shaded-force-shading and the Hadoop modules which I think is
> >>>> expected) ✅
> >>>>
> >>>> – Ufuk
> >>>>
> >>>> On Thu, Feb 13, 2020 at 3:08 PM Yu Li <[hidden email]> wrote:
> >>>>>
> >>>>> +1 (non-binding)
> >>>>>
> >>>>> Checked issues listed in release notes: ok
> >>>>> Checked sums and signatures: ok
> >>>>> Checked the maven central artifices: ok
> >>>>> Built from source: ok (8u101, 11.0.4)
> >>>>> Built from source (with -Dshade-sources): ok (8u101, 11.0.4)
> >>>>> Checked contents of zookeeper shaded jars: ok
> >>>>> - no unshaded classes
> >>>>> - shading pattern is correct
> >>>>> Checked website pull request listing the new release: ok
> >>>>>
> >>>>> Best Regards,
> >>>>> Yu
> >>>>>
> >>>>>
> >>>>> On Wed, 12 Feb 2020 at 22:09, Chesnay Schepler <[hidden email]>
> >>>> wrote:
> >>>>>
> >>>>>> Hi everyone,
> >>>>>> Please review and vote on the release candidate #3 for the version
> >>>> 10.0,
> >>>>>> as follows:
> >>>>>> [ ] +1, Approve the release
> >>>>>> [ ] -1, Do not approve the release (please provide specific
> >> comments)
> >>>>>>
> >>>>>>
> >>>>>> The complete staging area is available for your review, which
> >>> includes:
> >>>>>> * JIRA release notes [1],
> >>>>>> * the official Apache source release to be deployed to
> >>> dist.apache.org
> >>>>>> [2], which are signed with the key with fingerprint 11D464BA [3],
> >>>>>> * all artifacts to be deployed to the Maven Central Repository [4],
> >>>>>> * source code tag "release-10.0-rc3 [5],
> >>>>>> * website pull request listing the new release [6].
> >>>>>>
> >>>>>> The vote will be open for at least 72 hours. It is adopted by
> >>> majority
> >>>>>> approval, with at least 3 PMC affirmative votes.
> >>>>>>
> >>>>>> Thanks,
> >>>>>> Chesnay
> >>>>>>
> >>>>>> [1]
> >>>>>>
> >>>>>>
> >>>>
> >>>
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346746
> >>>>>> [2]
> >>>> https://dist.apache.org/repos/dist/dev/flink/flink-shaded-10.0-rc3/
> >>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> >>>>>> [4]
> >>>>
> https://repository.apache.org/content/repositories/orgapacheflink-1337
> >>>>>> [5]
> >>>>>>
> >>>>>>
> >>>>
> >>>
> >>
> https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=tag;h=refs/tags/release-10.0-rc3
> >>>>>> [6] https://github.com/apache/flink-web/pull/304
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>
> >>>
> >>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release flink-shaded 10.0, release candidate #3

jincheng sun
+1 (binding)

With simple check;
  - Downloaded the source and built successfully
  - Verified the signature and checksum

Best,
Jincheng


Zhijiang <[hidden email]> 于2020年2月16日周日 上午12:11写道:

> +1 (non-binding)
>
> - Checked the release notes
> - Downloaded the source and built successfully
> - Verified the signature and checksum
> - Verified the artifacts in the Maven Central Repository
>
> Best,
> Zhijiang
>
>
> ------------------------------------------------------------------
> From:Robert Metzger <[hidden email]>
> Send Time:2020 Feb. 14 (Fri.) 21:35
> To:dev <[hidden email]>
> Subject:Re: [VOTE] Release flink-shaded 10.0, release candidate #3
>
> +1 (binding)
>
> - Checked some artifacts in the staging repo
>  - checked license documentation
> - source release is binary free
>
> On Fri, Feb 14, 2020 at 8:01 AM Dian Fu <[hidden email]> wrote:
>
> > +1 (non-binding)
> >
> > - Verified the signature and checksum
> > - Checked the release note that all the tickets included in this release
> > are there
> > - Checked the website PR and it LGTM
> > - Checked the notice file of the newly added module
> > flink-shade-zookeeper-3 and it LGTM
> >
> > Regards,
> > Dian
> >
> > > 在 2020年2月14日,下午2:58,Hequn Cheng <[hidden email]> 写道:
> > >
> > > Thank you Chesnay for the release!
> > >
> > > +1 (non-binding)
> > >
> > > - The problem that exists in RC1 has been resolved.
> > > - Release notes looks good.
> > > - Built from source archive successfully.
> > > - Check commit history manually. Nothing looks weird.
> > > - Signatures and hash are correct.
> > > - All artifacts have been deployed to the maven central repository.
> > > - The website pull request looks good
> > >
> > > Best, Hequn
> > >
> > > On Fri, Feb 14, 2020 at 1:14 AM Zhu Zhu <[hidden email]> wrote:
> > >
> > >> +1 (non-binding)
> > >>
> > >> - checked release notes, JIRA tickets and commit history
> > >> - verified the signature and checksum
> > >> - checked the maven central artifacts
> > >>  * examined the zookeeper shaded jars (both 3.4.10 and 3.5.6), curator
> > and
> > >> zookeeper classes are there and shaded
> > >> - built from the source archive as well as the git tag
> > >> - checked the website pull request
> > >>
> > >> Thanks,
> > >> Zhu Zhu
> > >>
> > >> Ufuk Celebi <[hidden email]> 于2020年2月14日周五 上午12:32写道:
> > >>
> > >>> PS: Also verified the NOTICE changes since the last RC.
> > >>>
> > >>> On Thu, Feb 13, 2020 at 5:25 PM Ufuk Celebi <[hidden email]> wrote:
> > >>>
> > >>>> Hey Chensay,
> > >>>>
> > >>>> +1 (binding).
> > >>>>
> > >>>> - Verified checksum ✅
> > >>>> - Verified signature ✅
> > >>>> - Jira changelog looks good to me ✅
> > >>>> - Website PR looks good to me ✅
> > >>>> - Verified no unshaded dependencies (except the Hadoop modules
> which I
> > >>>> think is expected) ✅
> > >>>> - Verified dependency management fix FLINK-15540
> > >>>> (commons-collections:3.2.2 as expected) ✅
> > >>>> - Verified pom exclusion fix FLINK-15815 (no META-INF/maven except
> for
> > >>>> flink-shaded-force-shading and the Hadoop modules which I think is
> > >>>> expected) ✅
> > >>>>
> > >>>> – Ufuk
> > >>>>
> > >>>> On Thu, Feb 13, 2020 at 3:08 PM Yu Li <[hidden email]> wrote:
> > >>>>>
> > >>>>> +1 (non-binding)
> > >>>>>
> > >>>>> Checked issues listed in release notes: ok
> > >>>>> Checked sums and signatures: ok
> > >>>>> Checked the maven central artifices: ok
> > >>>>> Built from source: ok (8u101, 11.0.4)
> > >>>>> Built from source (with -Dshade-sources): ok (8u101, 11.0.4)
> > >>>>> Checked contents of zookeeper shaded jars: ok
> > >>>>> - no unshaded classes
> > >>>>> - shading pattern is correct
> > >>>>> Checked website pull request listing the new release: ok
> > >>>>>
> > >>>>> Best Regards,
> > >>>>> Yu
> > >>>>>
> > >>>>>
> > >>>>> On Wed, 12 Feb 2020 at 22:09, Chesnay Schepler <[hidden email]
> >
> > >>>> wrote:
> > >>>>>
> > >>>>>> Hi everyone,
> > >>>>>> Please review and vote on the release candidate #3 for the version
> > >>>> 10.0,
> > >>>>>> as follows:
> > >>>>>> [ ] +1, Approve the release
> > >>>>>> [ ] -1, Do not approve the release (please provide specific
> > >> comments)
> > >>>>>>
> > >>>>>>
> > >>>>>> The complete staging area is available for your review, which
> > >>> includes:
> > >>>>>> * JIRA release notes [1],
> > >>>>>> * the official Apache source release to be deployed to
> > >>> dist.apache.org
> > >>>>>> [2], which are signed with the key with fingerprint 11D464BA [3],
> > >>>>>> * all artifacts to be deployed to the Maven Central Repository
> [4],
> > >>>>>> * source code tag "release-10.0-rc3 [5],
> > >>>>>> * website pull request listing the new release [6].
> > >>>>>>
> > >>>>>> The vote will be open for at least 72 hours. It is adopted by
> > >>> majority
> > >>>>>> approval, with at least 3 PMC affirmative votes.
> > >>>>>>
> > >>>>>> Thanks,
> > >>>>>> Chesnay
> > >>>>>>
> > >>>>>> [1]
> > >>>>>>
> > >>>>>>
> > >>>>
> > >>>
> > >>
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346746
> > >>>>>> [2]
> > >>>> https://dist.apache.org/repos/dist/dev/flink/flink-shaded-10.0-rc3/
> > >>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > >>>>>> [4]
> > >>>>
> > https://repository.apache.org/content/repositories/orgapacheflink-1337
> > >>>>>> [5]
> > >>>>>>
> > >>>>>>
> > >>>>
> > >>>
> > >>
> >
> https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=tag;h=refs/tags/release-10.0-rc3
> > >>>>>> [6] https://github.com/apache/flink-web/pull/304
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>
> > >>>
> > >>
> >
> >
>
>
Reply | Threaded
Open this post in threaded view
|

[RESULT][VOTE] Release flink-shaded 10.0, release candidate #3

Chesnay Schepler-3
I'm happy to announce that we have unanimously approved this release.

There are XXX approving votes, XXX of which are binding:

- Yu (non-binding)
- Ufuk (binding)
- Zhu (non-binding)
- Hequn (non-binding)
- Dian (non-binding)
- Robert (binding)
- Zhijiang (non-binding)
- Jincheng (binding)

There are no disapproving votes.

Thanks everyone!

On 17/02/2020 08:12, jincheng sun wrote:

> +1 (binding)
>
> With simple check;
>    - Downloaded the source and built successfully
>    - Verified the signature and checksum
>
> Best,
> Jincheng
>
>
> Zhijiang <[hidden email]> 于2020年2月16日周日 上午12:11写道:
>
>> +1 (non-binding)
>>
>> - Checked the release notes
>> - Downloaded the source and built successfully
>> - Verified the signature and checksum
>> - Verified the artifacts in the Maven Central Repository
>>
>> Best,
>> Zhijiang
>>
>>
>> ------------------------------------------------------------------
>> From:Robert Metzger <[hidden email]>
>> Send Time:2020 Feb. 14 (Fri.) 21:35
>> To:dev <[hidden email]>
>> Subject:Re: [VOTE] Release flink-shaded 10.0, release candidate #3
>>
>> +1 (binding)
>>
>> - Checked some artifacts in the staging repo
>>   - checked license documentation
>> - source release is binary free
>>
>> On Fri, Feb 14, 2020 at 8:01 AM Dian Fu <[hidden email]> wrote:
>>
>>> +1 (non-binding)
>>>
>>> - Verified the signature and checksum
>>> - Checked the release note that all the tickets included in this release
>>> are there
>>> - Checked the website PR and it LGTM
>>> - Checked the notice file of the newly added module
>>> flink-shade-zookeeper-3 and it LGTM
>>>
>>> Regards,
>>> Dian
>>>
>>>> 在 2020年2月14日,下午2:58,Hequn Cheng <[hidden email]> 写道:
>>>>
>>>> Thank you Chesnay for the release!
>>>>
>>>> +1 (non-binding)
>>>>
>>>> - The problem that exists in RC1 has been resolved.
>>>> - Release notes looks good.
>>>> - Built from source archive successfully.
>>>> - Check commit history manually. Nothing looks weird.
>>>> - Signatures and hash are correct.
>>>> - All artifacts have been deployed to the maven central repository.
>>>> - The website pull request looks good
>>>>
>>>> Best, Hequn
>>>>
>>>> On Fri, Feb 14, 2020 at 1:14 AM Zhu Zhu <[hidden email]> wrote:
>>>>
>>>>> +1 (non-binding)
>>>>>
>>>>> - checked release notes, JIRA tickets and commit history
>>>>> - verified the signature and checksum
>>>>> - checked the maven central artifacts
>>>>>   * examined the zookeeper shaded jars (both 3.4.10 and 3.5.6), curator
>>> and
>>>>> zookeeper classes are there and shaded
>>>>> - built from the source archive as well as the git tag
>>>>> - checked the website pull request
>>>>>
>>>>> Thanks,
>>>>> Zhu Zhu
>>>>>
>>>>> Ufuk Celebi <[hidden email]> 于2020年2月14日周五 上午12:32写道:
>>>>>
>>>>>> PS: Also verified the NOTICE changes since the last RC.
>>>>>>
>>>>>> On Thu, Feb 13, 2020 at 5:25 PM Ufuk Celebi <[hidden email]> wrote:
>>>>>>
>>>>>>> Hey Chensay,
>>>>>>>
>>>>>>> +1 (binding).
>>>>>>>
>>>>>>> - Verified checksum ✅
>>>>>>> - Verified signature ✅
>>>>>>> - Jira changelog looks good to me ✅
>>>>>>> - Website PR looks good to me ✅
>>>>>>> - Verified no unshaded dependencies (except the Hadoop modules
>> which I
>>>>>>> think is expected) ✅
>>>>>>> - Verified dependency management fix FLINK-15540
>>>>>>> (commons-collections:3.2.2 as expected) ✅
>>>>>>> - Verified pom exclusion fix FLINK-15815 (no META-INF/maven except
>> for
>>>>>>> flink-shaded-force-shading and the Hadoop modules which I think is
>>>>>>> expected) ✅
>>>>>>>
>>>>>>> – Ufuk
>>>>>>>
>>>>>>> On Thu, Feb 13, 2020 at 3:08 PM Yu Li <[hidden email]> wrote:
>>>>>>>> +1 (non-binding)
>>>>>>>>
>>>>>>>> Checked issues listed in release notes: ok
>>>>>>>> Checked sums and signatures: ok
>>>>>>>> Checked the maven central artifices: ok
>>>>>>>> Built from source: ok (8u101, 11.0.4)
>>>>>>>> Built from source (with -Dshade-sources): ok (8u101, 11.0.4)
>>>>>>>> Checked contents of zookeeper shaded jars: ok
>>>>>>>> - no unshaded classes
>>>>>>>> - shading pattern is correct
>>>>>>>> Checked website pull request listing the new release: ok
>>>>>>>>
>>>>>>>> Best Regards,
>>>>>>>> Yu
>>>>>>>>
>>>>>>>>
>>>>>>>> On Wed, 12 Feb 2020 at 22:09, Chesnay Schepler <[hidden email]
>>>>>>> wrote:
>>>>>>>>> Hi everyone,
>>>>>>>>> Please review and vote on the release candidate #3 for the version
>>>>>>> 10.0,
>>>>>>>>> as follows:
>>>>>>>>> [ ] +1, Approve the release
>>>>>>>>> [ ] -1, Do not approve the release (please provide specific
>>>>> comments)
>>>>>>>>>
>>>>>>>>> The complete staging area is available for your review, which
>>>>>> includes:
>>>>>>>>> * JIRA release notes [1],
>>>>>>>>> * the official Apache source release to be deployed to
>>>>>> dist.apache.org
>>>>>>>>> [2], which are signed with the key with fingerprint 11D464BA [3],
>>>>>>>>> * all artifacts to be deployed to the Maven Central Repository
>> [4],
>>>>>>>>> * source code tag "release-10.0-rc3 [5],
>>>>>>>>> * website pull request listing the new release [6].
>>>>>>>>>
>>>>>>>>> The vote will be open for at least 72 hours. It is adopted by
>>>>>> majority
>>>>>>>>> approval, with at least 3 PMC affirmative votes.
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Chesnay
>>>>>>>>>
>>>>>>>>> [1]
>>>>>>>>>
>>>>>>>>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346746
>>>>>>>>> [2]
>>>>>>> https://dist.apache.org/repos/dist/dev/flink/flink-shaded-10.0-rc3/
>>>>>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>>>>>>>> [4]
>>> https://repository.apache.org/content/repositories/orgapacheflink-1337
>>>>>>>>> [5]
>>>>>>>>>
>>>>>>>>>
>> https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=tag;h=refs/tags/release-10.0-rc3
>>>>>>>>> [6] https://github.com/apache/flink-web/pull/304
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>
>>