[VOTE] Release Apache Flink 0.10.0 (release-0.10.0-rc5)

[mxm]

Please vote on releasing the following candidate as Apache Flink version
0.10.0:

The commit to be voted on:
347c2b00d4c32da118460a8da0a417f752f9177e

Branch:
release-0.10.0-rc5 (see
https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git)

The release artifacts to be voted on can be found at:
http://people.apache.org/~mxm/flink-0.10.0-rc5/

The release artifacts are signed with the key with fingerprint C2909CBF:
http://www.apache.org/dist/flink/KEYS

The staging repository for this release can be found at:
https://repository.apache.org/content/repositories/orgapacheflink-1052

-------------------------------------------------------------

The vote is open for the next 72 hours and passes if a majority of at least
three +1 PMC votes are cast.

The vote ends on Friday November 6, 2015.

[ ] +1 Release this package as Apache Flink 0.10.0
[ ] -1 Do not release this package because ...

===================================

The following commits have been added on top of release-0.10.0-rc4:

a77d21d [web-frontend] Fix README to to reflect the latest changes
8a4f6f0 [FLINK-2939] add cancel button to web frontend
2009ca1 [FLINK-2953] fix chaining of sortPartition() calls in Scala DataSet
API
ccddf5d [hotfix] remove Special LICENSE/NOTICE for binary release
0c5ba1f remove flink-benchmark due to licensing issues

[mxm]

Here is the testing document:
https://docs.google.com/document/d/1BYtis1Xg2Z9UpeV5UuH2kB6DnisnneOB19L1YBIw4Zs/edit

On Tue, Nov 3, 2015 at 12:24 PM, Maximilian Michels <[hidden email]> wrote:

> Please vote on releasing the following candidate as Apache Flink version
> 0.10.0:
>
> The commit to be voted on:
> 347c2b00d4c32da118460a8da0a417f752f9177e
>
> Branch:
> release-0.10.0-rc5 (see
> https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git)
>
> The release artifacts to be voted on can be found at:
> http://people.apache.org/~mxm/flink-0.10.0-rc5/
>
> The release artifacts are signed with the key with fingerprint C2909CBF:
> http://www.apache.org/dist/flink/KEYS
>
> The staging repository for this release can be found at:
> https://repository.apache.org/content/repositories/orgapacheflink-1052
>
> -------------------------------------------------------------
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> The vote ends on Friday November 6, 2015.
>
> [ ] +1 Release this package as Apache Flink 0.10.0
> [ ] -1 Do not release this package because ...
>
> ===================================
>
> The following commits have been added on top of release-0.10.0-rc4:
>
> a77d21d [web-frontend] Fix README to to reflect the latest changes
> 8a4f6f0 [FLINK-2939] add cancel button to web frontend
> 2009ca1 [FLINK-2953] fix chaining of sortPartition() calls in Scala
> DataSet API
> ccddf5d [hotfix] remove Special LICENSE/NOTICE for binary release
> 0c5ba1f remove flink-benchmark due to licensing issues
>

[Till Rohrmann]

I fear that I have to give another -1.

The reason is that in the current RC Flink fails when spilling partitions
of the MutableHashTable when performing a join operation with many records
which are also large in size. Thus, effectively the join operation is
broken.

The underlying problem is that the HashPartition does not count the used
memory segments by the BuildSideBuffer when it calculates the number of
occupied memory segments. It the partition in addition does not have any
overflow segments for the table structure, then the assertion that at least
2 memory segments have to be available is violated. See
https://issues.apache.org/jira/browse/FLINK-2964 for more details.
​

On Tue, Nov 3, 2015 at 12:43 PM, Maximilian Michels <[hidden email]> wrote:

> Here is the testing document:
>
> https://docs.google.com/document/d/1BYtis1Xg2Z9UpeV5UuH2kB6DnisnneOB19L1YBIw4Zs/edit
>
> On Tue, Nov 3, 2015 at 12:24 PM, Maximilian Michels <[hidden email]>
> wrote:
>
> > Please vote on releasing the following candidate as Apache Flink version
> > 0.10.0:
> >
> > The commit to be voted on:
> > 347c2b00d4c32da118460a8da0a417f752f9177e
> >
> > Branch:
> > release-0.10.0-rc5 (see
> > https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git)
> >
> > The release artifacts to be voted on can be found at:
> > http://people.apache.org/~mxm/flink-0.10.0-rc5/
> >
> > The release artifacts are signed with the key with fingerprint C2909CBF:
> > http://www.apache.org/dist/flink/KEYS
> >
> > The staging repository for this release can be found at:
> > https://repository.apache.org/content/repositories/orgapacheflink-1052
> >
> > -------------------------------------------------------------
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> > least three +1 PMC votes are cast.
> >
> > The vote ends on Friday November 6, 2015.
> >
> > [ ] +1 Release this package as Apache Flink 0.10.0
> > [ ] -1 Do not release this package because ...
> >
> > ===================================
> >
> > The following commits have been added on top of release-0.10.0-rc4:
> >
> > a77d21d [web-frontend] Fix README to to reflect the latest changes
> > 8a4f6f0 [FLINK-2939] add cancel button to web frontend
> > 2009ca1 [FLINK-2953] fix chaining of sortPartition() calls in Scala
> > DataSet API
> > ccddf5d [hotfix] remove Special LICENSE/NOTICE for binary release
> > 0c5ba1f remove flink-benchmark due to licensing issues
> >
>

[mxm]

That's a big release blocker. Thanks for the fix, Till! I'm really glad we
managed to fix this subtle bug.

On Wed, Nov 4, 2015 at 2:19 AM, Till Rohrmann <[hidden email]> wrote:

> I fear that I have to give another -1.
>
> The reason is that in the current RC Flink fails when spilling partitions
> of the MutableHashTable when performing a join operation with many records
> which are also large in size. Thus, effectively the join operation is
> broken.
>
> The underlying problem is that the HashPartition does not count the used
> memory segments by the BuildSideBuffer when it calculates the number of
> occupied memory segments. It the partition in addition does not have any
> overflow segments for the table structure, then the assertion that at least
> 2 memory segments have to be available is violated. See
> https://issues.apache.org/jira/browse/FLINK-2964 for more details.
> ​
>
> On Tue, Nov 3, 2015 at 12:43 PM, Maximilian Michels <[hidden email]>
> wrote:
>
> > Here is the testing document:
> >
> >
> https://docs.google.com/document/d/1BYtis1Xg2Z9UpeV5UuH2kB6DnisnneOB19L1YBIw4Zs/edit
> >
> > On Tue, Nov 3, 2015 at 12:24 PM, Maximilian Michels <[hidden email]>
> > wrote:
> >
> > > Please vote on releasing the following candidate as Apache Flink
> version
> > > 0.10.0:
> > >
> > > The commit to be voted on:
> > > 347c2b00d4c32da118460a8da0a417f752f9177e
> > >
> > > Branch:
> > > release-0.10.0-rc5 (see
> > > https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git)
> > >
> > > The release artifacts to be voted on can be found at:
> > > http://people.apache.org/~mxm/flink-0.10.0-rc5/
> > >
> > > The release artifacts are signed with the key with fingerprint
> C2909CBF:
> > > http://www.apache.org/dist/flink/KEYS
> > >
> > > The staging repository for this release can be found at:
> > > https://repository.apache.org/content/repositories/orgapacheflink-1052
> > >
> > > -------------------------------------------------------------
> > >
> > > The vote is open for the next 72 hours and passes if a majority of at
> > > least three +1 PMC votes are cast.
> > >
> > > The vote ends on Friday November 6, 2015.
> > >
> > > [ ] +1 Release this package as Apache Flink 0.10.0
> > > [ ] -1 Do not release this package because ...
> > >
> > > ===================================
> > >
> > > The following commits have been added on top of release-0.10.0-rc4:
> > >
> > > a77d21d [web-frontend] Fix README to to reflect the latest changes
> > > 8a4f6f0 [FLINK-2939] add cancel button to web frontend
> > > 2009ca1 [FLINK-2953] fix chaining of sortPartition() calls in Scala
> > > DataSet API
> > > ccddf5d [hotfix] remove Special LICENSE/NOTICE for binary release
> > > 0c5ba1f remove flink-benchmark due to licensing issues
> > >
> >
>