Hi everyone,
Please review and vote on the release candidate #1 for the version 1.5.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], * the official Apache source release and binary convenience releases to be deployed to dist.apache.org [2], which are signed with the key with fingerprint 1F302569A96CFFD5 [3], * all artifacts to be deployed to the Maven Central Repository [4], * source code tag "release-1.5.0-rc1" [5], Please use this document for coordinating testing efforts: [6] The vote will be open for at least 72 hours. It is adopted by majority approval, with at least 3 PMC affirmative votes. Thanks, Your friendly Release Manager [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12341764 [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc1/ [3] https://dist.apache.org/repos/dist/release/flink/KEYS [4] https://repository.apache.org/content/repositories/orgapacheflink-1154 [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=commit;h=2af481a0fa88dd2f7964c9105cf4d735c3ac8303 [6] https://docs.google.com/document/d/1Y-tB6yxs9HHoUxQKdTLPzJiJeNxx_uoPIvOVV9dlrPw/edit?usp=sharing Pro-tip: you can create a settings.xml file with these contents: <settings> <activeProfiles> <activeProfile>flink-1.5.0</activeProfile> </activeProfiles> <profiles> <profile> <id>flink-1.5.0</id> <repositories> <repository> <id>flink-1.5.0</id> <url> https://repository.apache.org/content/repositories/orgapacheflink-1154/ </url> </repository> <repository> <id>archetype</id> <url> https://repository.apache.org/content/repositories/orgapacheflink-1154/ </url> </repository> </repositories> </profile> </profiles> </settings> And reference that in you maven commands via --settings path/to/settings.xml. This is useful for creating a quickstart based on the staged release and for building against the staged jars. |
Hi Till,
Thanks for raising this candidate, I found this https://github.com/apache/flink/pull/5705 is still not merged, should we get it into flink-1.5, I ask this because I found it on the bug list on the JIRA release notes that you provided. Best Regards, Sihua Zhou 发自网易邮箱大师 On 04/3/2018 03:47,Till Rohrmann<[hidden email]> wrote: Hi everyone, Please review and vote on the release candidate #1 for the version 1.5.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], * the official Apache source release and binary convenience releases to be deployed to dist.apache.org [2], which are signed with the key with fingerprint 1F302569A96CFFD5 [3], * all artifacts to be deployed to the Maven Central Repository [4], * source code tag "release-1.5.0-rc1" [5], Please use this document for coordinating testing efforts: [6] The vote will be open for at least 72 hours. It is adopted by majority approval, with at least 3 PMC affirmative votes. Thanks, Your friendly Release Manager [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12341764 [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc1/ [3] https://dist.apache.org/repos/dist/release/flink/KEYS [4] https://repository.apache.org/content/repositories/orgapacheflink-1154 [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=commit;h=2af481a0fa88dd2f7964c9105cf4d735c3ac8303 [6] https://docs.google.com/document/d/1Y-tB6yxs9HHoUxQKdTLPzJiJeNxx_uoPIvOVV9dlrPw/edit?usp=sharing Pro-tip: you can create a settings.xml file with these contents: <settings> <activeProfiles> <activeProfile>flink-1.5.0</activeProfile> </activeProfiles> <profiles> <profile> <id>flink-1.5.0</id> <repositories> <repository> <id>flink-1.5.0</id> <url> https://repository.apache.org/content/repositories/orgapacheflink-1154/ </url> </repository> <repository> <id>archetype</id> <url> https://repository.apache.org/content/repositories/orgapacheflink-1154/ </url> </repository> </repositories> </profile> </profiles> </settings> And reference that in you maven commands via --settings path/to/settings.xml. This is useful for creating a quickstart based on the staged release and for building against the staged jars. |
Just one note.
There are 2 suggested ways of compiling Flink: 1. From github Readme: mvn clean package -DskipTests ( https://github.com/apache/flink <https://github.com/apache/flink>) 2. From site documentation: mvn clean install -DskipTests ( https://ci.apache.org/projects/flink/flink-docs- release-1.5/start/building.html <https://ci.apache.org/projects/flink/flink-docs-release-1.5/start/building.html> ) The first one doesn't work with maven 3.0.x while the second one works with both (3.0.x and 3.3.x) On Tue, Apr 3, 2018 at 7:59 AM, 周思华 <[hidden email]> wrote: > Hi Till, > Thanks for raising this candidate, I found this https://github.com/apache/ > flink/pull/5705 is still not merged, should we get it into flink-1.5, I > ask this because I found it on the bug list on the JIRA release notes that > you provided. > > > Best Regards, > Sihua Zhou > > > 发自网易邮箱大师 > > > On 04/3/2018 03:47,Till Rohrmann<[hidden email]> wrote: > Hi everyone, > Please review and vote on the release candidate #1 for the version 1.5.0, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > > The complete staging area is available for your review, which includes: > * JIRA release notes [1], > * the official Apache source release and binary convenience releases to be > deployed to dist.apache.org [2], which are signed with the key with > fingerprint 1F302569A96CFFD5 [3], > * all artifacts to be deployed to the Maven Central Repository [4], > * source code tag "release-1.5.0-rc1" [5], > > Please use this document for coordinating testing efforts: [6] > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > Thanks, > Your friendly Release Manager > > [1] > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12315522&version=12341764 > [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc1/ > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > [4] https://repository.apache.org/content/repositories/orgapacheflink-1154 > [5] > https://git-wip-us.apache.org/repos/asf?p=flink.git;a=commit;h= > 2af481a0fa88dd2f7964c9105cf4d735c3ac8303 > [6] > https://docs.google.com/document/d/1Y-tB6yxs9HHoUxQKdTLPzJiJeNxx_ > uoPIvOVV9dlrPw/edit?usp=sharing > > Pro-tip: you can create a settings.xml file with these contents: > > <settings> > <activeProfiles> > <activeProfile>flink-1.5.0</activeProfile> > </activeProfiles> > <profiles> > <profile> > <id>flink-1.5.0</id> > <repositories> > <repository> > <id>flink-1.5.0</id> > <url> > > https://repository.apache.org/content/repositories/orgapacheflink-1154/ > </url> > </repository> > <repository> > <id>archetype</id> > <url> > > https://repository.apache.org/content/repositories/orgapacheflink-1154/ > </url> > </repository> > </repositories> > </profile> > </profiles> > </settings> > > And reference that in you maven commands via --settings > path/to/settings.xml. This is useful for creating a quickstart based on the > staged release and for building against the staged jars. > -- Flavio Pompermaier Development Department OKKAM S.r.l. Tel. +(39) 0461 041809 |
Hi Sihua,
Stefan will look into FLINK-8699 and then we will decide whether it should be part of 1.5.0 or not. The issue should, however, not block others from testing the RC. @Flavio, what exactly is the problem with maven 3.0.x when running `mvn clean package -DskipTests`? Cheers, Till On Tue, Apr 3, 2018 at 10:34 AM, Flavio Pompermaier <[hidden email]> wrote: > Just one note. > There are 2 suggested ways of compiling Flink: > > 1. From github Readme: mvn clean package -DskipTests ( > https://github.com/apache/flink <https://github.com/apache/flink>) > 2. From site documentation: mvn clean install -DskipTests ( > https://ci.apache.org/projects/flink/flink-docs- > release-1.5/start/building.html > <https://ci.apache.org/projects/flink/flink-docs- > release-1.5/start/building.html> > ) > > The first one doesn't work with maven 3.0.x while the second one works with > both (3.0.x and 3.3.x) > > On Tue, Apr 3, 2018 at 7:59 AM, 周思华 <[hidden email]> wrote: > > > Hi Till, > > Thanks for raising this candidate, I found this > https://github.com/apache/ > > flink/pull/5705 is still not merged, should we get it into flink-1.5, I > > ask this because I found it on the bug list on the JIRA release notes > that > > you provided. > > > > > > Best Regards, > > Sihua Zhou > > > > > > 发自网易邮箱大师 > > > > > > On 04/3/2018 03:47,Till Rohrmann<[hidden email]> wrote: > > Hi everyone, > > Please review and vote on the release candidate #1 for the version 1.5.0, > > as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > The complete staging area is available for your review, which includes: > > * JIRA release notes [1], > > * the official Apache source release and binary convenience releases to > be > > deployed to dist.apache.org [2], which are signed with the key with > > fingerprint 1F302569A96CFFD5 [3], > > * all artifacts to be deployed to the Maven Central Repository [4], > > * source code tag "release-1.5.0-rc1" [5], > > > > Please use this document for coordinating testing efforts: [6] > > > > The vote will be open for at least 72 hours. It is adopted by majority > > approval, with at least 3 PMC affirmative votes. > > > > Thanks, > > Your friendly Release Manager > > > > [1] > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > projectId=12315522&version=12341764 > > [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc1/ > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > [4] https://repository.apache.org/content/repositories/ > orgapacheflink-1154 > > [5] > > https://git-wip-us.apache.org/repos/asf?p=flink.git;a=commit;h= > > 2af481a0fa88dd2f7964c9105cf4d735c3ac8303 > > [6] > > https://docs.google.com/document/d/1Y-tB6yxs9HHoUxQKdTLPzJiJeNxx_ > > uoPIvOVV9dlrPw/edit?usp=sharing > > > > Pro-tip: you can create a settings.xml file with these contents: > > > > <settings> > > <activeProfiles> > > <activeProfile>flink-1.5.0</activeProfile> > > </activeProfiles> > > <profiles> > > <profile> > > <id>flink-1.5.0</id> > > <repositories> > > <repository> > > <id>flink-1.5.0</id> > > <url> > > > > https://repository.apache.org/content/repositories/orgapacheflink-1154/ > > </url> > > </repository> > > <repository> > > <id>archetype</id> > > <url> > > > > https://repository.apache.org/content/repositories/orgapacheflink-1154/ > > </url> > > </repository> > > </repositories> > > </profile> > > </profiles> > > </settings> > > > > And reference that in you maven commands via --settings > > path/to/settings.xml. This is useful for creating a quickstart based on > the > > staged release and for building against the staged jars. > > > > > > -- > Flavio Pompermaier > Development Department > > OKKAM S.r.l. > Tel. +(39) 0461 041809 > |
Sorry Till but we had an error the first time we've tried to build Flink
using mvn clean package...now we're trying to replicate the error but no luck.. :) So for the moment don't consider my note... On Tue, Apr 3, 2018 at 10:56 AM, Till Rohrmann <[hidden email]> wrote: > Hi Sihua, > > Stefan will look into FLINK-8699 and then we will decide whether it should > be part of 1.5.0 or not. The issue should, however, not block others from > testing the RC. > > @Flavio, what exactly is the problem with maven 3.0.x when running `mvn > clean package -DskipTests`? > > Cheers, > Till > > On Tue, Apr 3, 2018 at 10:34 AM, Flavio Pompermaier <[hidden email]> > wrote: > > > Just one note. > > There are 2 suggested ways of compiling Flink: > > > > 1. From github Readme: mvn clean package -DskipTests ( > > https://github.com/apache/flink <https://github.com/apache/flink>) > > 2. From site documentation: mvn clean install -DskipTests ( > > https://ci.apache.org/projects/flink/flink-docs- > > release-1.5/start/building.html > > <https://ci.apache.org/projects/flink/flink-docs- > > release-1.5/start/building.html> > > ) > > > > The first one doesn't work with maven 3.0.x while the second one works > with > > both (3.0.x and 3.3.x) > > > > On Tue, Apr 3, 2018 at 7:59 AM, 周思华 <[hidden email]> wrote: > > > > > Hi Till, > > > Thanks for raising this candidate, I found this > > https://github.com/apache/ > > > flink/pull/5705 is still not merged, should we get it into flink-1.5, I > > > ask this because I found it on the bug list on the JIRA release notes > > that > > > you provided. > > > > > > > > > Best Regards, > > > Sihua Zhou > > > > > > > > > 发自网易邮箱大师 > > > > > > > > > On 04/3/2018 03:47,Till Rohrmann<[hidden email]> wrote: > > > Hi everyone, > > > Please review and vote on the release candidate #1 for the version > 1.5.0, > > > as follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > > > > The complete staging area is available for your review, which includes: > > > * JIRA release notes [1], > > > * the official Apache source release and binary convenience releases to > > be > > > deployed to dist.apache.org [2], which are signed with the key with > > > fingerprint 1F302569A96CFFD5 [3], > > > * all artifacts to be deployed to the Maven Central Repository [4], > > > * source code tag "release-1.5.0-rc1" [5], > > > > > > Please use this document for coordinating testing efforts: [6] > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Thanks, > > > Your friendly Release Manager > > > > > > [1] > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > > projectId=12315522&version=12341764 > > > [2] http://people.apache.org/~trohrmann/flink-1.5.0-rc1/ > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > [4] https://repository.apache.org/content/repositories/ > > orgapacheflink-1154 > > > [5] > > > https://git-wip-us.apache.org/repos/asf?p=flink.git;a=commit;h= > > > 2af481a0fa88dd2f7964c9105cf4d735c3ac8303 > > > [6] > > > https://docs.google.com/document/d/1Y-tB6yxs9HHoUxQKdTLPzJiJeNxx_ > > > uoPIvOVV9dlrPw/edit?usp=sharing > > > > > > Pro-tip: you can create a settings.xml file with these contents: > > > > > > <settings> > > > <activeProfiles> > > > <activeProfile>flink-1.5.0</activeProfile> > > > </activeProfiles> > > > <profiles> > > > <profile> > > > <id>flink-1.5.0</id> > > > <repositories> > > > <repository> > > > <id>flink-1.5.0</id> > > > <url> > > > > > > https://repository.apache.org/content/repositories/ > orgapacheflink-1154/ > > > </url> > > > </repository> > > > <repository> > > > <id>archetype</id> > > > <url> > > > > > > https://repository.apache.org/content/repositories/ > orgapacheflink-1154/ > > > </url> > > > </repository> > > > </repositories> > > > </profile> > > > </profiles> > > > </settings> > > > > > > And reference that in you maven commands via --settings > > > path/to/settings.xml. This is useful for creating a quickstart based on > > the > > > staged release and for building against the staged jars. > > > > > > > > > > > -- > > Flavio Pompermaier > > Development Department > > > > OKKAM S.r.l. > > Tel. +(39) 0461 041809 > > > -- Flavio Pompermaier Development Department OKKAM S.r.l. Tel. +(39) 0461 041809 |
In reply to this post by Till Rohrmann
I tried to run a simple batch job (it tooks about 5 minutes with flink
1.3.1 on single machine), but it seems to run forever with flink 1.5-SNAPSHOT (I stopped it after about 2-3 hours multiple times). If you want to try to replicate this, here are the java classes: https://github.com/xseris/Flink-test-union/tree/master/src/main/java/okkam/it/flink/flink150SNAPSHOT (you first need to generate the test input csv [8 GB] through the RandomCsvGenerator.javaclass). With flink 1.3.1 all works. Is it only my behavior or is there any problem in the architecture introduced in 1.5? Thanks, Simone. |
On 03/04/2018 17:40, simone wrote: > > I tried to run a simple batch job (it tooks about 5 minutes with flink > 1.3.1 on single machine), but it seems to run forever with flink > 1.5-SNAPSHOT (I stopped it after about 2-3 hours multiple times). If > you want to try to replicate this, here are the java classes: > https://github.com/xseris/Flink-test-union/tree/master/src/main/java/okkam/it/flink/flink150SNAPSHOT > (you first need to generate the test input csv [8 GB] through the > RandomCsvGenerator.javaclass). > > With flink 1.3.1 all works. Is it only my behavior or is there any > problem in the architecture introduced in 1.5? > > Thanks, > Simone. > |
Hi Till,
FLINK-8837 <https://issues.apache.org/jira/browse/FLINK-8837> is marked as a blocker for release 1.5.0. I've opened a PR for it, can you please take a look at it? Bowen On Tue, Apr 3, 2018 at 8:45 AM, simone <[hidden email]> wrote: > > On 03/04/2018 17:40, simone wrote: > >> >> I tried to run a simple batch job (it tooks about 5 minutes with flink >> 1.3.1 on single machine), but it seems to run forever with flink >> 1.5-SNAPSHOT (I stopped it after about 2-3 hours multiple times). If you >> want to try to replicate this, here are the java classes: >> https://github.com/xseris/Flink-test-union/tree/master/src/ >> main/java/okkam/it/flink/flink150SNAPSHOT (you first need to generate >> the test input csv [8 GB] through the RandomCsvGenerator.javaclass). >> >> With flink 1.3.1 all works. Is it only my behavior or is there any >> problem in the architecture introduced in 1.5? >> >> Thanks, >> Simone. >> >> > |
Hi Simone,
thanks for testing the RC and reporting the issue. I will investigate the problem with the code you've provided. @Bowen, I will take a look at Flink-8837. Cheers, Till On Thu, Apr 5, 2018 at 8:54 AM, Bowen Li <[hidden email]> wrote: > Hi Till, > > FLINK-8837 <https://issues.apache.org/jira/browse/FLINK-8837> is marked as > a blocker for release 1.5.0. I've opened a PR for it, can you please take a > look at it? > > Bowen > > On Tue, Apr 3, 2018 at 8:45 AM, simone <[hidden email]> > wrote: > > > > > On 03/04/2018 17:40, simone wrote: > > > >> > >> I tried to run a simple batch job (it tooks about 5 minutes with flink > >> 1.3.1 on single machine), but it seems to run forever with flink > >> 1.5-SNAPSHOT (I stopped it after about 2-3 hours multiple times). If you > >> want to try to replicate this, here are the java classes: > >> https://github.com/xseris/Flink-test-union/tree/master/src/ > >> main/java/okkam/it/flink/flink150SNAPSHOT (you first need to generate > >> the test input csv [8 GB] through the RandomCsvGenerator.javaclass). > >> > >> With flink 1.3.1 all works. Is it only my behavior or is there any > >> problem in the architecture introduced in 1.5? > >> > >> Thanks, > >> Simone. > >> > >> > > > |
I could reproduce the problem Simone reported with the provided batch job.
It is definitely a regression with respect to Flink 1.4.2. I suspect that it has something to do with spilling because it is independent of Flip-6 and only occurs if the input data size is big enough. Moreover, we made some changes to the SpillableSubpartition which might have introduced a problem with spilling. Due to this regression I will cancel the current release candidate. Once we have fixed this problem, I will create a new RC. Cheers, Till On Thu, Apr 5, 2018 at 4:56 PM, Till Rohrmann <[hidden email]> wrote: > Hi Simone, > > thanks for testing the RC and reporting the issue. I will investigate the > problem with the code you've provided. > > @Bowen, I will take a look at Flink-8837. > > Cheers, > Till > > On Thu, Apr 5, 2018 at 8:54 AM, Bowen Li <[hidden email]> wrote: > >> Hi Till, >> >> FLINK-8837 <https://issues.apache.org/jira/browse/FLINK-8837> is marked >> as >> a blocker for release 1.5.0. I've opened a PR for it, can you please take >> a >> look at it? >> >> Bowen >> >> On Tue, Apr 3, 2018 at 8:45 AM, simone <[hidden email]> >> wrote: >> >> > >> > On 03/04/2018 17:40, simone wrote: >> > >> >> >> >> I tried to run a simple batch job (it tooks about 5 minutes with flink >> >> 1.3.1 on single machine), but it seems to run forever with flink >> >> 1.5-SNAPSHOT (I stopped it after about 2-3 hours multiple times). If >> you >> >> want to try to replicate this, here are the java classes: >> >> https://github.com/xseris/Flink-test-union/tree/master/src/ >> >> main/java/okkam/it/flink/flink150SNAPSHOT (you first need to generate >> >> the test input csv [8 GB] through the RandomCsvGenerator.javaclass). >> >> >> >> With flink 1.3.1 all works. Is it only my behavior or is there any >> >> problem in the architecture introduced in 1.5? >> >> >> >> Thanks, >> >> Simone. >> >> >> >> >> > >> > > |
FYI: I created https://issues.apache.org/jira/browse/FLINK-9144 for this
and will work on a fix Nico On 05/04/18 20:19, Till Rohrmann wrote: > I could reproduce the problem Simone reported with the provided batch job. > It is definitely a regression with respect to Flink 1.4.2. I suspect that > it has something to do with spilling because it is independent of Flip-6 > and only occurs if the input data size is big enough. Moreover, we made > some changes to the SpillableSubpartition which might have introduced a > problem with spilling. > > Due to this regression I will cancel the current release candidate. Once we > have fixed this problem, I will create a new RC. > > Cheers, > Till > > > > On Thu, Apr 5, 2018 at 4:56 PM, Till Rohrmann <[hidden email]> wrote: > >> Hi Simone, >> >> thanks for testing the RC and reporting the issue. I will investigate the >> problem with the code you've provided. >> >> @Bowen, I will take a look at Flink-8837. >> >> Cheers, >> Till >> >> On Thu, Apr 5, 2018 at 8:54 AM, Bowen Li <[hidden email]> wrote: >> >>> Hi Till, >>> >>> FLINK-8837 <https://issues.apache.org/jira/browse/FLINK-8837> is marked >>> as >>> a blocker for release 1.5.0. I've opened a PR for it, can you please take >>> a >>> look at it? >>> >>> Bowen >>> >>> On Tue, Apr 3, 2018 at 8:45 AM, simone <[hidden email]> >>> wrote: >>> >>>> >>>> On 03/04/2018 17:40, simone wrote: >>>> >>>>> >>>>> I tried to run a simple batch job (it tooks about 5 minutes with flink >>>>> 1.3.1 on single machine), but it seems to run forever with flink >>>>> 1.5-SNAPSHOT (I stopped it after about 2-3 hours multiple times). If >>> you >>>>> want to try to replicate this, here are the java classes: >>>>> https://github.com/xseris/Flink-test-union/tree/master/src/ >>>>> main/java/okkam/it/flink/flink150SNAPSHOT (you first need to generate >>>>> the test input csv [8 GB] through the RandomCsvGenerator.javaclass). >>>>> >>>>> With flink 1.3.1 all works. Is it only my behavior or is there any >>>>> problem in the architecture introduced in 1.5? >>>>> >>>>> Thanks, >>>>> Simone. >>>>> >>>>> >>>> >>> >> >> > Nico Kruber | Software Engineer data Artisans Follow us @dataArtisans -- Join Flink Forward - The Apache Flink Conference Stream Processing | Event Driven | Real Time -- Data Artisans GmbH | Stresemannstr. 121A,10963 Berlin, Germany data Artisans, Inc. | 1161 Mission Street, San Francisco, CA-94103, USA -- Data Artisans GmbH Registered at Amtsgericht Charlottenburg: HRB 158244 B Managing Directors: Dr. Kostas Tzoumas, Dr. Stephan Ewen |
Free forum by Nabble | Edit this page |