[VOTE] Release 1.12.4, release candidate #1

[Arvid Heise-4]

Hi everyone,

Please review and vote on the release candidate #1 for the version 1.12.4,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release and binary convenience releases to be
deployed to dist.apache.org [2], which are signed with the key with
fingerprint 476DAA5D1FF08189 [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag "release-1.12.4-rc1" [5],
* website pull request listing the new release and adding announcement blog
post [6].

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Your friendly release manager Arvid

[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12350110
[2] https://dist.apache.org/repos/dist/dev/flink/flink-1.12.4-rc1/
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1421
[5] https://github.com/apache/flink/releases/tag/release-1.12.4-rc1
[6] https://github.com/apache/flink-web/pull/446

[roman]

Thanks for managing the release.

+1 (non-binding)

I've checked the artifacts:
- Verified checksums and GPG of artifacts in [2]
- Built the sources locally without errors
- Verified that the source archives do not contain any binaries
- Checked that all POM files point to the same version.

Regards,
Roman

On Mon, May 10, 2021 at 11:34 PM Arvid Heise <[hidden email]> wrote:

>
> Hi everyone,
>
> Please review and vote on the release candidate #1 for the version 1.12.4,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release and binary convenience releases to be
> deployed to dist.apache.org [2], which are signed with the key with
> fingerprint 476DAA5D1FF08189 [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag "release-1.12.4-rc1" [5],
> * website pull request listing the new release and adding announcement blog
> post [6].
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Your friendly release manager Arvid
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12350110
> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.12.4-rc1/
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/orgapacheflink-1421
> [5] https://github.com/apache/flink/releases/tag/release-1.12.4-rc1
> [6] https://github.com/apache/flink-web/pull/446

[dwysakowicz]

+1 (binding)

• Verified checksums and signatures
• Checked no significant version changes compared to 1.12.3 (one new test scope dependency)
• Checked no changes to the NOTICE files
• Built from sources
• Run example using binary 2.12 distribution
• verified a random class in flink-scala_2.11 and _2.12 if it was compiled with the correct scala version

Best,

Dawid

On 10/05/2021 23:34, Arvid Heise wrote:

Hi everyone,

Please review and vote on the release candidate #1 for the version 1.12.4,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release and binary convenience releases to be
deployed to dist.apache.org [2], which are signed with the key with
fingerprint 476DAA5D1FF08189 [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag "release-1.12.4-rc1" [5],
* website pull request listing the new release and adding announcement blog
post [6].

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PMC affirmative votes.

Thanks,
Your friendly release manager Arvid

[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12350110
[2] https://dist.apache.org/repos/dist/dev/flink/flink-1.12.4-rc1/
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1421
[5] https://github.com/apache/flink/releases/tag/release-1.12.4-rc1
[6] https://github.com/apache/flink-web/pull/446

[Robert Metzger]

+1 (binding)

- Checked diff to 1.12.3:
https://github.com/apache/flink/compare/release-1.12.3-rc1...release-1.12.4-rc1
- checked some jars in the staging repo
- checked contents of flink-dist jar of 2.11 release
- Submitted demo job


On Sun, May 16, 2021 at 8:40 PM Dawid Wysakowicz <[hidden email]>
wrote:

> +1 (binding)
>
>    - Verified checksums and signatures
>    - Checked no significant version changes compared to 1.12.3 (one new
>    test scope dependency)
>    - Checked no changes to the NOTICE files
>    - Built from sources
>    - Run example using binary 2.12 distribution
>    - verified a random class in flink-scala_2.11 and _2.12 if it was
>    compiled with the correct scala version
>
> Best,
>
> Dawid
> On 10/05/2021 23:34, Arvid Heise wrote:
>
> Hi everyone,
>
> Please review and vote on the release candidate #1 for the version 1.12.4,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release and binary convenience releases to be
> deployed to dist.apache.org [2], which are signed with the key with
> fingerprint 476DAA5D1FF08189 [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag "release-1.12.4-rc1" [5],
> * website pull request listing the new release and adding announcement blog
> post [6].
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Your friendly release manager Arvid
>
> [1]https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12350110
> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.12.4-rc1/
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/orgapacheflink-1421
> [5] https://github.com/apache/flink/releases/tag/release-1.12.4-rc1
> [6] https://github.com/apache/flink-web/pull/446
>
>

[Xingbo Huang]

+1 (non-binding)

- Verified checksums and signatures
- Check python package contents
- Pip install python wheel package
- Run python udf job in python shell

Best,
Xingbo

Robert Metzger <[hidden email]> 于2021年5月17日周一 下午4:07写道：

> +1 (binding)
>
> - Checked diff to 1.12.3:
>
> https://github.com/apache/flink/compare/release-1.12.3-rc1...release-1.12.4-rc1
> - checked some jars in the staging repo
> - checked contents of flink-dist jar of 2.11 release
> - Submitted demo job
>
>
> On Sun, May 16, 2021 at 8:40 PM Dawid Wysakowicz <[hidden email]>
> wrote:
>
> > +1 (binding)
> >
> >    - Verified checksums and signatures
> >    - Checked no significant version changes compared to 1.12.3 (one new
> >    test scope dependency)
> >    - Checked no changes to the NOTICE files
> >    - Built from sources
> >    - Run example using binary 2.12 distribution
> >    - verified a random class in flink-scala_2.11 and _2.12 if it was
> >    compiled with the correct scala version
> >
> > Best,
> >
> > Dawid
> > On 10/05/2021 23:34, Arvid Heise wrote:
> >
> > Hi everyone,
> >
> > Please review and vote on the release candidate #1 for the version
> 1.12.4,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> > * JIRA release notes [1],
> > * the official Apache source release and binary convenience releases to
> be
> > deployed to dist.apache.org [2], which are signed with the key with
> > fingerprint 476DAA5D1FF08189 [3],
> > * all artifacts to be deployed to the Maven Central Repository [4],
> > * source code tag "release-1.12.4-rc1" [5],
> > * website pull request listing the new release and adding announcement
> blog
> > post [6].
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Your friendly release manager Arvid
> >
> > [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12350110
> > [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.12.4-rc1/
> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1421
> > [5] https://github.com/apache/flink/releases/tag/release-1.12.4-rc1
> > [6] https://github.com/apache/flink-web/pull/446
> >
> >
>

[Chesnay Schepler-3]

+1 (binding)

- checked repository contents
- reviewed flink-web PR

On 5/17/2021 11:40 AM, Xingbo Huang wrote:

> +1 (non-binding)
>
> - Verified checksums and signatures
> - Check python package contents
> - Pip install python wheel package
> - Run python udf job in python shell
>
> Best,
> Xingbo
>
> Robert Metzger <[hidden email]> 于2021年5月17日周一 下午4:07写道：
>
>> +1 (binding)
>>
>> - Checked diff to 1.12.3:
>>
>> https://github.com/apache/flink/compare/release-1.12.3-rc1...release-1.12.4-rc1
>> - checked some jars in the staging repo
>> - checked contents of flink-dist jar of 2.11 release
>> - Submitted demo job
>>
>>
>> On Sun, May 16, 2021 at 8:40 PM Dawid Wysakowicz <[hidden email]>
>> wrote:
>>
>>> +1 (binding)
>>>
>>>     - Verified checksums and signatures
>>>     - Checked no significant version changes compared to 1.12.3 (one new
>>>     test scope dependency)
>>>     - Checked no changes to the NOTICE files
>>>     - Built from sources
>>>     - Run example using binary 2.12 distribution
>>>     - verified a random class in flink-scala_2.11 and _2.12 if it was
>>>     compiled with the correct scala version
>>>
>>> Best,
>>>
>>> Dawid
>>> On 10/05/2021 23:34, Arvid Heise wrote:
>>>
>>> Hi everyone,
>>>
>>> Please review and vote on the release candidate #1 for the version
>> 1.12.4,
>>> as follows:
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>
>>> The complete staging area is available for your review, which includes:
>>> * JIRA release notes [1],
>>> * the official Apache source release and binary convenience releases to
>> be
>>> deployed to dist.apache.org [2], which are signed with the key with
>>> fingerprint 476DAA5D1FF08189 [3],
>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>> * source code tag "release-1.12.4-rc1" [5],
>>> * website pull request listing the new release and adding announcement
>> blog
>>> post [6].
>>>
>>> The vote will be open for at least 72 hours. It is adopted by majority
>>> approval, with at least 3 PMC affirmative votes.
>>>
>>> Thanks,
>>> Your friendly release manager Arvid
>>>
>>> [1]
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12350110
>>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.12.4-rc1/
>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>> [4]
>> https://repository.apache.org/content/repositories/orgapacheflink-1421
>>> [5] https://github.com/apache/flink/releases/tag/release-1.12.4-rc1
>>> [6] https://github.com/apache/flink-web/pull/446
>>>
>>>

[Leonard Xu]

+1 (non-binding)

- verified signatures and hashes
- started a cluster, WebUI was accessible
- ran some queries in SQL Client, no suspicious log output
- the web PR looks good

Best,
Leonard Xu

> 在 2021年5月19日，18:42，Chesnay Schepler <[hidden email]> 写道：
>
> +1 (binding)
>
> - checked repository contents
> - reviewed flink-web PR
>
> On 5/17/2021 11:40 AM, Xingbo Huang wrote:
>> +1 (non-binding)
>>
>> - Verified checksums and signatures
>> - Check python package contents
>> - Pip install python wheel package
>> - Run python udf job in python shell
>>
>> Best,
>> Xingbo
>>
>> Robert Metzger <[hidden email]> 于2021年5月17日周一 下午4:07写道：
>>
>>> +1 (binding)
>>>
>>> - Checked diff to 1.12.3:
>>>
>>> https://github.com/apache/flink/compare/release-1.12.3-rc1...release-1.12.4-rc1
>>> - checked some jars in the staging repo
>>> - checked contents of flink-dist jar of 2.11 release
>>> - Submitted demo job
>>>
>>>
>>> On Sun, May 16, 2021 at 8:40 PM Dawid Wysakowicz <[hidden email]>
>>> wrote:
>>>
>>>> +1 (binding)
>>>>
>>>>    - Verified checksums and signatures
>>>>    - Checked no significant version changes compared to 1.12.3 (one new
>>>>    test scope dependency)
>>>>    - Checked no changes to the NOTICE files
>>>>    - Built from sources
>>>>    - Run example using binary 2.12 distribution
>>>>    - verified a random class in flink-scala_2.11 and _2.12 if it was
>>>>    compiled with the correct scala version
>>>>
>>>> Best,
>>>>
>>>> Dawid
>>>> On 10/05/2021 23:34, Arvid Heise wrote:
>>>>
>>>> Hi everyone,
>>>>
>>>> Please review and vote on the release candidate #1 for the version
>>> 1.12.4,
>>>> as follows:
>>>> [ ] +1, Approve the release
>>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>>
>>>> The complete staging area is available for your review, which includes:
>>>> * JIRA release notes [1],
>>>> * the official Apache source release and binary convenience releases to
>>> be
>>>> deployed to dist.apache.org [2], which are signed with the key with
>>>> fingerprint 476DAA5D1FF08189 [3],
>>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>>> * source code tag "release-1.12.4-rc1" [5],
>>>> * website pull request listing the new release and adding announcement
>>> blog
>>>> post [6].
>>>>
>>>> The vote will be open for at least 72 hours. It is adopted by majority
>>>> approval, with at least 3 PMC affirmative votes.
>>>>
>>>> Thanks,
>>>> Your friendly release manager Arvid
>>>>
>>>> [1]
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12350110
>>>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.12.4-rc1/
>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>>> [4]
>>> https://repository.apache.org/content/repositories/orgapacheflink-1421
>>>> [5] https://github.com/apache/flink/releases/tag/release-1.12.4-rc1
>>>> [6] https://github.com/apache/flink-web/pull/446
>>>>
>>>>
>

[Thomas Weise]

+1 (binding)

- built from source
- run internal tests
- run job on provided convenience binaries

Thanks for managing the release, Arvid!


On Wed, May 19, 2021 at 9:36 PM Leonard Xu <[hidden email]> wrote:

> +1 (non-binding)
>
> - verified signatures and hashes
> - started a cluster, WebUI was accessible
> - ran some queries in SQL Client, no suspicious log output
> - the web PR looks good
>
> Best,
> Leonard Xu
>
> > 在 2021年5月19日，18:42，Chesnay Schepler <[hidden email]> 写道：
> >
> > +1 (binding)
> >
> > - checked repository contents
> > - reviewed flink-web PR
> >
> > On 5/17/2021 11:40 AM, Xingbo Huang wrote:
> >> +1 (non-binding)
> >>
> >> - Verified checksums and signatures
> >> - Check python package contents
> >> - Pip install python wheel package
> >> - Run python udf job in python shell
> >>
> >> Best,
> >> Xingbo
> >>
> >> Robert Metzger <[hidden email]> 于2021年5月17日周一 下午4:07写道：
> >>
> >>> +1 (binding)
> >>>
> >>> - Checked diff to 1.12.3:
> >>>
> >>>
> https://github.com/apache/flink/compare/release-1.12.3-rc1...release-1.12.4-rc1
> >>> - checked some jars in the staging repo
> >>> - checked contents of flink-dist jar of 2.11 release
> >>> - Submitted demo job
> >>>
> >>>
> >>> On Sun, May 16, 2021 at 8:40 PM Dawid Wysakowicz <
> [hidden email]>
> >>> wrote:
> >>>
> >>>> +1 (binding)
> >>>>
> >>>>    - Verified checksums and signatures
> >>>>    - Checked no significant version changes compared to 1.12.3 (one
> new
> >>>>    test scope dependency)
> >>>>    - Checked no changes to the NOTICE files
> >>>>    - Built from sources
> >>>>    - Run example using binary 2.12 distribution
> >>>>    - verified a random class in flink-scala_2.11 and _2.12 if it was
> >>>>    compiled with the correct scala version
> >>>>
> >>>> Best,
> >>>>
> >>>> Dawid
> >>>> On 10/05/2021 23:34, Arvid Heise wrote:
> >>>>
> >>>> Hi everyone,
> >>>>
> >>>> Please review and vote on the release candidate #1 for the version
> >>> 1.12.4,
> >>>> as follows:
> >>>> [ ] +1, Approve the release
> >>>> [ ] -1, Do not approve the release (please provide specific comments)
> >>>>
> >>>> The complete staging area is available for your review, which
> includes:
> >>>> * JIRA release notes [1],
> >>>> * the official Apache source release and binary convenience releases
> to
> >>> be
> >>>> deployed to dist.apache.org [2], which are signed with the key with
> >>>> fingerprint 476DAA5D1FF08189 [3],
> >>>> * all artifacts to be deployed to the Maven Central Repository [4],
> >>>> * source code tag "release-1.12.4-rc1" [5],
> >>>> * website pull request listing the new release and adding announcement
> >>> blog
> >>>> post [6].
> >>>>
> >>>> The vote will be open for at least 72 hours. It is adopted by majority
> >>>> approval, with at least 3 PMC affirmative votes.
> >>>>
> >>>> Thanks,
> >>>> Your friendly release manager Arvid
> >>>>
> >>>> [1]
> >>>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12350110
> >>>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.12.4-rc1/
> >>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> >>>> [4]
> >>> https://repository.apache.org/content/repositories/orgapacheflink-1421
> >>>> [5] https://github.com/apache/flink/releases/tag/release-1.12.4-rc1
> >>>> [6] https://github.com/apache/flink-web/pull/446
> >>>>
> >>>>
> >
>
>

[Arvid Heise-4]

Dear devs,

I'm happy to announce that we have unanimously approved this release.

There are 7 approving votes, 4 of which are binding:
* Roman Khachatryan
* Dawid Wysakowicz (binding)
* Robert Metzger (binding)
* Xingbo Huang
* Chesnay Schepler (binding)
* Leonard Xu
* Thomas Weise (binding)

There are no disapproving votes.

Thanks everyone!

Your friendly release manager Arvid

On Thu, May 20, 2021 at 7:51 AM Thomas Weise <[hidden email]> wrote:

> +1 (binding)
>
> - built from source
> - run internal tests
> - run job on provided convenience binaries
>
> Thanks for managing the release, Arvid!
>
>
> On Wed, May 19, 2021 at 9:36 PM Leonard Xu <[hidden email]> wrote:
>
> > +1 (non-binding)
> >
> > - verified signatures and hashes
> > - started a cluster, WebUI was accessible
> > - ran some queries in SQL Client, no suspicious log output
> > - the web PR looks good
> >
> > Best,
> > Leonard Xu
> >
> > > 在 2021年5月19日，18:42，Chesnay Schepler <[hidden email]> 写道：
> > >
> > > +1 (binding)
> > >
> > > - checked repository contents
> > > - reviewed flink-web PR
> > >
> > > On 5/17/2021 11:40 AM, Xingbo Huang wrote:
> > >> +1 (non-binding)
> > >>
> > >> - Verified checksums and signatures
> > >> - Check python package contents
> > >> - Pip install python wheel package
> > >> - Run python udf job in python shell
> > >>
> > >> Best,
> > >> Xingbo
> > >>
> > >> Robert Metzger <[hidden email]> 于2021年5月17日周一 下午4:07写道：
> > >>
> > >>> +1 (binding)
> > >>>
> > >>> - Checked diff to 1.12.3:
> > >>>
> > >>>
> >
> https://github.com/apache/flink/compare/release-1.12.3-rc1...release-1.12.4-rc1
> > >>> - checked some jars in the staging repo
> > >>> - checked contents of flink-dist jar of 2.11 release
> > >>> - Submitted demo job
> > >>>
> > >>>
> > >>> On Sun, May 16, 2021 at 8:40 PM Dawid Wysakowicz <
> > [hidden email]>
> > >>> wrote:
> > >>>
> > >>>> +1 (binding)
> > >>>>
> > >>>>    - Verified checksums and signatures
> > >>>>    - Checked no significant version changes compared to 1.12.3 (one
> > new
> > >>>>    test scope dependency)
> > >>>>    - Checked no changes to the NOTICE files
> > >>>>    - Built from sources
> > >>>>    - Run example using binary 2.12 distribution
> > >>>>    - verified a random class in flink-scala_2.11 and _2.12 if it was
> > >>>>    compiled with the correct scala version
> > >>>>
> > >>>> Best,
> > >>>>
> > >>>> Dawid
> > >>>> On 10/05/2021 23:34, Arvid Heise wrote:
> > >>>>
> > >>>> Hi everyone,
> > >>>>
> > >>>> Please review and vote on the release candidate #1 for the version
> > >>> 1.12.4,
> > >>>> as follows:
> > >>>> [ ] +1, Approve the release
> > >>>> [ ] -1, Do not approve the release (please provide specific
> comments)
> > >>>>
> > >>>> The complete staging area is available for your review, which
> > includes:
> > >>>> * JIRA release notes [1],
> > >>>> * the official Apache source release and binary convenience releases
> > to
> > >>> be
> > >>>> deployed to dist.apache.org [2], which are signed with the key with
> > >>>> fingerprint 476DAA5D1FF08189 [3],
> > >>>> * all artifacts to be deployed to the Maven Central Repository [4],
> > >>>> * source code tag "release-1.12.4-rc1" [5],
> > >>>> * website pull request listing the new release and adding
> announcement
> > >>> blog
> > >>>> post [6].
> > >>>>
> > >>>> The vote will be open for at least 72 hours. It is adopted by
> majority
> > >>>> approval, with at least 3 PMC affirmative votes.
> > >>>>
> > >>>> Thanks,
> > >>>> Your friendly release manager Arvid
> > >>>>
> > >>>> [1]
> > >>>
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12350110
> > >>>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.12.4-rc1/
> > >>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > >>>> [4]
> > >>>
> https://repository.apache.org/content/repositories/orgapacheflink-1421
> > >>>> [5] https://github.com/apache/flink/releases/tag/release-1.12.4-rc1
> > >>>> [6] https://github.com/apache/flink-web/pull/446
> > >>>>
> > >>>>
> > >
> >
> >
>