Hi everyone,
Please review and vote on the release candidate #1 for the version 1.11.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], * the official Apache source release and binary convenience releases to be deployed to dist.apache.org [2], which are signed with the key with fingerprint 6B6291A8502BA8F0913AE04DDEB95B05BF075300 [3], * all artifacts to be deployed to the Maven Central Repository [4], * source code tag "release-1.11.1-rc1" [5], * website pull request listing the new release and adding announcement blog post [6]. The vote will be open for at least 72 hours. It is adopted by majority approval, with at least 3 PMC affirmative votes. Thanks, Dian [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12348323 [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.11.1-rc1/ [3] https://dist.apache.org/repos/dist/release/flink/KEYS [4] https://repository.apache.org/content/repositories/orgapacheflink-1378/ [5] https://github.com/apache/flink/commit/7eb514a59f6fd117c3535ec4bebc40a375f30b63 [6] https://github.com/apache/flink-web/pull/359 |
Hey,
I understand it's a little bit late to bring this up, but we have a Hive dialect bug for which the PR [1] is ready to merge. So I wonder whether we could include it in 1.11.1? The issue is not a blocker, but I believe it's good to have in the bug fix release. [1] https://github.com/apache/flink/pull/12888 On Wed, Jul 15, 2020 at 6:02 PM Dian Fu <[hidden email]> wrote: > Hi everyone, > > Please review and vote on the release candidate #1 for the version 1.11.1, > as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > > The complete staging area is available for your review, which includes: > * JIRA release notes [1], > * the official Apache source release and binary convenience releases to be > deployed to dist.apache.org [2], which are signed with the key with > fingerprint 6B6291A8502BA8F0913AE04DDEB95B05BF075300 [3], > * all artifacts to be deployed to the Maven Central Repository [4], > * source code tag "release-1.11.1-rc1" [5], > * website pull request listing the new release and adding announcement > blog post [6]. > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > Thanks, > Dian > > [1] > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12348323 > [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.11.1-rc1/ > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > [4] > https://repository.apache.org/content/repositories/orgapacheflink-1378/ > [5] > https://github.com/apache/flink/commit/7eb514a59f6fd117c3535ec4bebc40a375f30b63 > [6] https://github.com/apache/flink-web/pull/359 -- Best regards! Rui Li |
Generally, I tend to continue the vote if this is not a blocking issue for the following reasons:
- As discussed in the discussion thread[1], this release is mainly to fix the CDC bug to provide a complete CDC feature. - We are still in an early stage after 1.11.0 release, so I think there will always be more issues raised. However, I'm glad to hear more opinions. We can cancel the current RC if most people think so. Besides, we can still make it into 1.11.1 if we found some other blocking issue. [1] http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Releasing-Flink-1-11-1-soon-td43065.html <http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Releasing-Flink-1-11-1-soon-td43065.html> > 在 2020年7月17日,下午2:09,Rui Li <[hidden email]> 写道: > > Hey, > > I understand it's a little bit late to bring this up, but we have a Hive > dialect bug for which the PR [1] is ready to merge. So I wonder whether we > could include it in 1.11.1? The issue is not a blocker, but I believe it's > good to have in the bug fix release. > > [1] https://github.com/apache/flink/pull/12888 > > On Wed, Jul 15, 2020 at 6:02 PM Dian Fu <[hidden email]> wrote: > >> Hi everyone, >> >> Please review and vote on the release candidate #1 for the version 1.11.1, >> as follows: >> [ ] +1, Approve the release >> [ ] -1, Do not approve the release (please provide specific comments) >> >> >> The complete staging area is available for your review, which includes: >> * JIRA release notes [1], >> * the official Apache source release and binary convenience releases to be >> deployed to dist.apache.org [2], which are signed with the key with >> fingerprint 6B6291A8502BA8F0913AE04DDEB95B05BF075300 [3], >> * all artifacts to be deployed to the Maven Central Repository [4], >> * source code tag "release-1.11.1-rc1" [5], >> * website pull request listing the new release and adding announcement >> blog post [6]. >> >> The vote will be open for at least 72 hours. It is adopted by majority >> approval, with at least 3 PMC affirmative votes. >> >> Thanks, >> Dian >> >> [1] >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12348323 >> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.11.1-rc1/ >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >> [4] >> https://repository.apache.org/content/repositories/orgapacheflink-1378/ >> [5] >> https://github.com/apache/flink/commit/7eb514a59f6fd117c3535ec4bebc40a375f30b63 >> [6] https://github.com/apache/flink-web/pull/359 > > > > -- > Best regards! > Rui Li |
I agree with Dian. We can release a 1.11.2 shortly afterwards. Only
regressions compared to 1.11.0 should block this vote. Regards, Timo On 17.07.20 10:48, Dian Fu wrote: > Generally, I tend to continue the vote if this is not a blocking issue for the following reasons: > - As discussed in the discussion thread[1], this release is mainly to fix the CDC bug to provide a complete CDC feature. > - We are still in an early stage after 1.11.0 release, so I think there will always be more issues raised. > > However, I'm glad to hear more opinions. We can cancel the current RC if most people think so. > > Besides, we can still make it into 1.11.1 if we found some other blocking issue. > > [1] http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Releasing-Flink-1-11-1-soon-td43065.html <http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Releasing-Flink-1-11-1-soon-td43065.html> >> 在 2020年7月17日,下午2:09,Rui Li <[hidden email]> 写道: >> >> Hey, >> >> I understand it's a little bit late to bring this up, but we have a Hive >> dialect bug for which the PR [1] is ready to merge. So I wonder whether we >> could include it in 1.11.1? The issue is not a blocker, but I believe it's >> good to have in the bug fix release. >> >> [1] https://github.com/apache/flink/pull/12888 >> >> On Wed, Jul 15, 2020 at 6:02 PM Dian Fu <[hidden email]> wrote: >> >>> Hi everyone, >>> >>> Please review and vote on the release candidate #1 for the version 1.11.1, >>> as follows: >>> [ ] +1, Approve the release >>> [ ] -1, Do not approve the release (please provide specific comments) >>> >>> >>> The complete staging area is available for your review, which includes: >>> * JIRA release notes [1], >>> * the official Apache source release and binary convenience releases to be >>> deployed to dist.apache.org [2], which are signed with the key with >>> fingerprint 6B6291A8502BA8F0913AE04DDEB95B05BF075300 [3], >>> * all artifacts to be deployed to the Maven Central Repository [4], >>> * source code tag "release-1.11.1-rc1" [5], >>> * website pull request listing the new release and adding announcement >>> blog post [6]. >>> >>> The vote will be open for at least 72 hours. It is adopted by majority >>> approval, with at least 3 PMC affirmative votes. >>> >>> Thanks, >>> Dian >>> >>> [1] >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12348323 >>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.11.1-rc1/ >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >>> [4] >>> https://repository.apache.org/content/repositories/orgapacheflink-1378/ >>> [5] >>> https://github.com/apache/flink/commit/7eb514a59f6fd117c3535ec4bebc40a375f30b63 >>> [6] https://github.com/apache/flink-web/pull/359 >> >> >> >> -- >> Best regards! >> Rui Li > > |
+1 (non-binding)
- checked/verified signatures and hashes - built from source code with scala 2.11 succeeded - checked that there are no missing artifacts - started a cluster, the Web UI was accessible, submitted a wordcount job and ran succeeded, no suspicious log output - test using SQL Client to submit job and the query result is expected - go through all issues which fix version property is 1.11.1, all issues are closed except FLINK-15794, and FLINK-15794 has fixed in master and 1.11.1 just wait for being fixed in 1.10.2. - the web PR looks good For FLINK-18588, I also agree with Timo to put it to 1.11.2 because it's a `Major` bug rather than `Blocker`. Best, Leonard |
OK, I agree FLINK-18588 can wait for the next release.
On Fri, Jul 17, 2020 at 11:56 PM Leonard Xu <[hidden email]> wrote: > +1 (non-binding) > > - checked/verified signatures and hashes > - built from source code with scala 2.11 succeeded > - checked that there are no missing artifacts > - started a cluster, the Web UI was accessible, submitted a wordcount job > and ran succeeded, no suspicious log output > - test using SQL Client to submit job and the query result is expected > - go through all issues which fix version property is 1.11.1, all issues > are closed except FLINK-15794, > and FLINK-15794 has fixed in master and 1.11.1 just wait for being fixed > in 1.10.2. > - the web PR looks good > > For FLINK-18588, I also agree with Timo to put it to 1.11.2 because it's > a `Major` bug rather than `Blocker`. > > Best, > Leonard -- Best regards! Rui Li |
+1 (non-binding)
- Built from source - Verified hive connector tests for all hive versions - Played some simple cases with hive connector and everything seems fine On Sat, Jul 18, 2020 at 12:24 AM Rui Li <[hidden email]> wrote: > OK, I agree FLINK-18588 can wait for the next release. > > On Fri, Jul 17, 2020 at 11:56 PM Leonard Xu <[hidden email]> wrote: > >> +1 (non-binding) >> >> - checked/verified signatures and hashes >> - built from source code with scala 2.11 succeeded >> - checked that there are no missing artifacts >> - started a cluster, the Web UI was accessible, submitted a wordcount job >> and ran succeeded, no suspicious log output >> - test using SQL Client to submit job and the query result is expected >> - go through all issues which fix version property is 1.11.1, all issues >> are closed except FLINK-15794, >> and FLINK-15794 has fixed in master and 1.11.1 just wait for being >> fixed in 1.10.2. >> - the web PR looks good >> >> For FLINK-18588, I also agree with Timo to put it to 1.11.2 because >> it's a `Major` bug rather than `Blocker`. >> >> Best, >> Leonard > > > > -- > Best regards! > Rui Li > -- Best regards! Rui Li |
+1 (non-binding)
I found that the fix version of FLINK-18544 is 1.11.1, and the release did not contain it. I think we should fix it in the release note. checked - build from source, ok - sha512 sum, ok - gpg key, ok - License seem ok(checked the change of all pom.xml between 1.11.0 and 1.11.1 https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1 - Run some demo locally Best, Congxian Rui Li <[hidden email]> 于2020年7月18日周六 下午7:04写道: > +1 (non-binding) > > - Built from source > - Verified hive connector tests for all hive versions > - Played some simple cases with hive connector and everything seems fine > > On Sat, Jul 18, 2020 at 12:24 AM Rui Li <[hidden email]> wrote: > > > OK, I agree FLINK-18588 can wait for the next release. > > > > On Fri, Jul 17, 2020 at 11:56 PM Leonard Xu <[hidden email]> wrote: > > > >> +1 (non-binding) > >> > >> - checked/verified signatures and hashes > >> - built from source code with scala 2.11 succeeded > >> - checked that there are no missing artifacts > >> - started a cluster, the Web UI was accessible, submitted a wordcount > job > >> and ran succeeded, no suspicious log output > >> - test using SQL Client to submit job and the query result is expected > >> - go through all issues which fix version property is 1.11.1, all issues > >> are closed except FLINK-15794, > >> and FLINK-15794 has fixed in master and 1.11.1 just wait for being > >> fixed in 1.10.2. > >> - the web PR looks good > >> > >> For FLINK-18588, I also agree with Timo to put it to 1.11.2 because > >> it's a `Major` bug rather than `Blocker`. > >> > >> Best, > >> Leonard > > > > > > > > -- > > Best regards! > > Rui Li > > > > > -- > Best regards! > Rui Li > |
+1 (non-binding)
- checked the checksum and signature - installed PyFlink package on MacOS and run some tests Regards, Dian > 在 2020年7月20日,上午11:11,Congxian Qiu <[hidden email]> 写道: > > +1 (non-binding) > > I found that the fix version of FLINK-18544 is 1.11.1, and the release did not contain it. I think we should fix it in the release note. > > checked > - build from source, ok > - sha512 sum, ok > - gpg key, ok > - License seem ok(checked the change of all pom.xml between 1.11.0 and 1.11.1 https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1 <https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1> > - Run some demo locally > > Best, > Congxian > > > Rui Li <[hidden email] <mailto:[hidden email]>> 于2020年7月18日周六 下午7:04写道: > +1 (non-binding) > > - Built from source > - Verified hive connector tests for all hive versions > - Played some simple cases with hive connector and everything seems fine > > On Sat, Jul 18, 2020 at 12:24 AM Rui Li <[hidden email] <mailto:[hidden email]>> wrote: > > > OK, I agree FLINK-18588 can wait for the next release. > > > > On Fri, Jul 17, 2020 at 11:56 PM Leonard Xu <[hidden email] <mailto:[hidden email]>> wrote: > > > >> +1 (non-binding) > >> > >> - checked/verified signatures and hashes > >> - built from source code with scala 2.11 succeeded > >> - checked that there are no missing artifacts > >> - started a cluster, the Web UI was accessible, submitted a wordcount job > >> and ran succeeded, no suspicious log output > >> - test using SQL Client to submit job and the query result is expected > >> - go through all issues which fix version property is 1.11.1, all issues > >> are closed except FLINK-15794, > >> and FLINK-15794 has fixed in master and 1.11.1 just wait for being > >> fixed in 1.10.2. > >> - the web PR looks good > >> > >> For FLINK-18588, I also agree with Timo to put it to 1.11.2 because > >> it's a `Major` bug rather than `Blocker`. > >> > >> Best, > >> Leonard > > > > > > > > -- > > Best regards! > > Rui Li > > > > > -- > Best regards! > Rui Li |
Hi Congxian,
FLINK-18544 was to fix an issue introduced in 1.11.1 and so it should not appear in the release note according to the release guide[1]. [1] https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-ReviewReleaseNotesinJIRA <https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-ReviewReleaseNotesinJIRA> Regards, Dian > 在 2020年7月20日,上午11:32,Dian Fu <[hidden email]> 写道: > > +1 (non-binding) > > - checked the checksum and signature > - installed PyFlink package on MacOS and run some tests > > Regards, > Dian > >> 在 2020年7月20日,上午11:11,Congxian Qiu <[hidden email] <mailto:[hidden email]>> 写道: >> >> +1 (non-binding) >> >> I found that the fix version of FLINK-18544 is 1.11.1, and the release did not contain it. I think we should fix it in the release note. >> >> checked >> - build from source, ok >> - sha512 sum, ok >> - gpg key, ok >> - License seem ok(checked the change of all pom.xml between 1.11.0 and 1.11.1 https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1 <https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1> >> - Run some demo locally >> >> Best, >> Congxian >> >> >> Rui Li <[hidden email] <mailto:[hidden email]>> 于2020年7月18日周六 下午7:04写道: >> +1 (non-binding) >> >> - Built from source >> - Verified hive connector tests for all hive versions >> - Played some simple cases with hive connector and everything seems fine >> >> On Sat, Jul 18, 2020 at 12:24 AM Rui Li <[hidden email] <mailto:[hidden email]>> wrote: >> >> > OK, I agree FLINK-18588 can wait for the next release. >> > >> > On Fri, Jul 17, 2020 at 11:56 PM Leonard Xu <[hidden email] <mailto:[hidden email]>> wrote: >> > >> >> +1 (non-binding) >> >> >> >> - checked/verified signatures and hashes >> >> - built from source code with scala 2.11 succeeded >> >> - checked that there are no missing artifacts >> >> - started a cluster, the Web UI was accessible, submitted a wordcount job >> >> and ran succeeded, no suspicious log output >> >> - test using SQL Client to submit job and the query result is expected >> >> - go through all issues which fix version property is 1.11.1, all issues >> >> are closed except FLINK-15794, >> >> and FLINK-15794 has fixed in master and 1.11.1 just wait for being >> >> fixed in 1.10.2. >> >> - the web PR looks good >> >> >> >> For FLINK-18588, I also agree with Timo to put it to 1.11.2 because >> >> it's a `Major` bug rather than `Blocker`. >> >> >> >> Best, >> >> Leonard >> > >> > >> > >> > -- >> > Best regards! >> > Rui Li >> > >> >> >> -- >> Best regards! >> Rui Li > |
Hi Dian
Thanks for the information. Best, Congxian Dian Fu <[hidden email]> 于2020年7月20日周一 上午11:44写道: > Hi Congxian, > > FLINK-18544 was to fix an issue introduced in 1.11.1 and so it should not > appear in the release note according to the release guide[1]. > > [1] > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-ReviewReleaseNotesinJIRA > < > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-ReviewReleaseNotesinJIRA > > > > Regards, > Dian > > > 在 2020年7月20日,上午11:32,Dian Fu <[hidden email]> 写道: > > > > +1 (non-binding) > > > > - checked the checksum and signature > > - installed PyFlink package on MacOS and run some tests > > > > Regards, > > Dian > > > >> 在 2020年7月20日,上午11:11,Congxian Qiu <[hidden email] <mailto: > [hidden email]>> 写道: > >> > >> +1 (non-binding) > >> > >> I found that the fix version of FLINK-18544 is 1.11.1, and the release > did not contain it. I think we should fix it in the release note. > >> > >> checked > >> - build from source, ok > >> - sha512 sum, ok > >> - gpg key, ok > >> - License seem ok(checked the change of all pom.xml between 1.11.0 and > 1.11.1 > https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1 > < > https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1 > > > >> - Run some demo locally > >> > >> Best, > >> Congxian > >> > >> > >> Rui Li <[hidden email] <mailto:[hidden email]>> > 于2020年7月18日周六 下午7:04写道: > >> +1 (non-binding) > >> > >> - Built from source > >> - Verified hive connector tests for all hive versions > >> - Played some simple cases with hive connector and everything seems fine > >> > >> On Sat, Jul 18, 2020 at 12:24 AM Rui Li <[hidden email] <mailto: > [hidden email]>> wrote: > >> > >> > OK, I agree FLINK-18588 can wait for the next release. > >> > > >> > On Fri, Jul 17, 2020 at 11:56 PM Leonard Xu <[hidden email] > <mailto:[hidden email]>> wrote: > >> > > >> >> +1 (non-binding) > >> >> > >> >> - checked/verified signatures and hashes > >> >> - built from source code with scala 2.11 succeeded > >> >> - checked that there are no missing artifacts > >> >> - started a cluster, the Web UI was accessible, submitted a > wordcount job > >> >> and ran succeeded, no suspicious log output > >> >> - test using SQL Client to submit job and the query result is > expected > >> >> - go through all issues which fix version property is 1.11.1, all > issues > >> >> are closed except FLINK-15794, > >> >> and FLINK-15794 has fixed in master and 1.11.1 just wait for being > >> >> fixed in 1.10.2. > >> >> - the web PR looks good > >> >> > >> >> For FLINK-18588, I also agree with Timo to put it to 1.11.2 because > >> >> it's a `Major` bug rather than `Blocker`. > >> >> > >> >> Best, > >> >> Leonard > >> > > >> > > >> > > >> > -- > >> > Best regards! > >> > Rui Li > >> > > >> > >> > >> -- > >> Best regards! > >> Rui Li > > > > |
Thanks Dian for kicking off the RC.
+1 from my side: I heavily tested CDC use cases end-to-end and it works well. - checked/verified signatures and hashes - manually verified the diff pom and NOTICE files between 1.11.0 and 1.11.1 to check dependencies, looks good - no missing artifacts in release staging area compared to the 1.11.0 release - started cluster and ran some table examples, verified web ui and log output, nothing unexpected - started cluster to run e2e SQL queries with millions of records with Kafka, MySQL, Elasticsearch as sources/lookup/sinks. Works well and the results are as expected. - use SQL CLI to read from Kafka with debezium data, and MySQL binlog source, and write into MySQL and Elasticsearch. Nothing unexpected - review the release PR Best, Jark On Mon, 20 Jul 2020 at 13:55, Congxian Qiu <[hidden email]> wrote: > Hi Dian > > Thanks for the information. > > Best, > Congxian > > > Dian Fu <[hidden email]> 于2020年7月20日周一 上午11:44写道: > > > Hi Congxian, > > > > FLINK-18544 was to fix an issue introduced in 1.11.1 and so it should not > > appear in the release note according to the release guide[1]. > > > > [1] > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-ReviewReleaseNotesinJIRA > > < > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-ReviewReleaseNotesinJIRA > > > > > > > Regards, > > Dian > > > > > 在 2020年7月20日,上午11:32,Dian Fu <[hidden email]> 写道: > > > > > > +1 (non-binding) > > > > > > - checked the checksum and signature > > > - installed PyFlink package on MacOS and run some tests > > > > > > Regards, > > > Dian > > > > > >> 在 2020年7月20日,上午11:11,Congxian Qiu <[hidden email] <mailto: > > [hidden email]>> 写道: > > >> > > >> +1 (non-binding) > > >> > > >> I found that the fix version of FLINK-18544 is 1.11.1, and the release > > did not contain it. I think we should fix it in the release note. > > >> > > >> checked > > >> - build from source, ok > > >> - sha512 sum, ok > > >> - gpg key, ok > > >> - License seem ok(checked the change of all pom.xml between 1.11.0 and > > 1.11.1 > > > https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1 > > < > > > https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1 > > > > > >> - Run some demo locally > > >> > > >> Best, > > >> Congxian > > >> > > >> > > >> Rui Li <[hidden email] <mailto:[hidden email]>> > > 于2020年7月18日周六 下午7:04写道: > > >> +1 (non-binding) > > >> > > >> - Built from source > > >> - Verified hive connector tests for all hive versions > > >> - Played some simple cases with hive connector and everything seems > fine > > >> > > >> On Sat, Jul 18, 2020 at 12:24 AM Rui Li <[hidden email] > <mailto: > > [hidden email]>> wrote: > > >> > > >> > OK, I agree FLINK-18588 can wait for the next release. > > >> > > > >> > On Fri, Jul 17, 2020 at 11:56 PM Leonard Xu <[hidden email] > > <mailto:[hidden email]>> wrote: > > >> > > > >> >> +1 (non-binding) > > >> >> > > >> >> - checked/verified signatures and hashes > > >> >> - built from source code with scala 2.11 succeeded > > >> >> - checked that there are no missing artifacts > > >> >> - started a cluster, the Web UI was accessible, submitted a > > wordcount job > > >> >> and ran succeeded, no suspicious log output > > >> >> - test using SQL Client to submit job and the query result is > > expected > > >> >> - go through all issues which fix version property is 1.11.1, all > > issues > > >> >> are closed except FLINK-15794, > > >> >> and FLINK-15794 has fixed in master and 1.11.1 just wait for > being > > >> >> fixed in 1.10.2. > > >> >> - the web PR looks good > > >> >> > > >> >> For FLINK-18588, I also agree with Timo to put it to 1.11.2 > because > > >> >> it's a `Major` bug rather than `Blocker`. > > >> >> > > >> >> Best, > > >> >> Leonard > > >> > > > >> > > > >> > > > >> > -- > > >> > Best regards! > > >> > Rui Li > > >> > > > >> > > >> > > >> -- > > >> Best regards! > > >> Rui Li > > > > > > > > |
+1 (binding)
- Checked diff to last RC: OK ( https://github.com/apache/flink/compare/release-1.11.0...release-1.11.1-rc1) - All dependency related changes are properly documented - Checked release notes: OK - Minor: there're 2 open issues left, please remember to scope them out if this vote passes (the website PR already excludes them) - Checked sums and signatures: OK - Source release - contains no binaries: OK - contains no 1.11-SNAPSHOT references: OK - build from source: OK (8u101) - mvn clean verify: OK (8u101) - Binary release - no examples appear to be missing - started a cluster, WebUI reachable, several streaming and batch examples ran successfully (11.0.4) - Repository appears to contain all expected artifacts - Website PR looks good Best Regards, Yu On Mon, 20 Jul 2020 at 18:00, Jark Wu <[hidden email]> wrote: > Thanks Dian for kicking off the RC. > > +1 from my side: > > I heavily tested CDC use cases end-to-end and it works well. > > - checked/verified signatures and hashes > - manually verified the diff pom and NOTICE files between 1.11.0 and 1.11.1 > to check dependencies, looks good > - no missing artifacts in release staging area compared to the 1.11.0 > release > - started cluster and ran some table examples, verified web ui and log > output, nothing unexpected > - started cluster to run e2e SQL queries with millions of records with > Kafka, MySQL, Elasticsearch as sources/lookup/sinks. Works well and the > results are as expected. > - use SQL CLI to read from Kafka with debezium data, and MySQL binlog > source, and write into MySQL and Elasticsearch. Nothing unexpected > - review the release PR > > Best, > Jark > > On Mon, 20 Jul 2020 at 13:55, Congxian Qiu <[hidden email]> wrote: > > > Hi Dian > > > > Thanks for the information. > > > > Best, > > Congxian > > > > > > Dian Fu <[hidden email]> 于2020年7月20日周一 上午11:44写道: > > > > > Hi Congxian, > > > > > > FLINK-18544 was to fix an issue introduced in 1.11.1 and so it should > not > > > appear in the release note according to the release guide[1]. > > > > > > [1] > > > > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-ReviewReleaseNotesinJIRA > > > < > > > > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-ReviewReleaseNotesinJIRA > > > > > > > > > > Regards, > > > Dian > > > > > > > 在 2020年7月20日,上午11:32,Dian Fu <[hidden email]> 写道: > > > > > > > > +1 (non-binding) > > > > > > > > - checked the checksum and signature > > > > - installed PyFlink package on MacOS and run some tests > > > > > > > > Regards, > > > > Dian > > > > > > > >> 在 2020年7月20日,上午11:11,Congxian Qiu <[hidden email] <mailto: > > > [hidden email]>> 写道: > > > >> > > > >> +1 (non-binding) > > > >> > > > >> I found that the fix version of FLINK-18544 is 1.11.1, and the > release > > > did not contain it. I think we should fix it in the release note. > > > >> > > > >> checked > > > >> - build from source, ok > > > >> - sha512 sum, ok > > > >> - gpg key, ok > > > >> - License seem ok(checked the change of all pom.xml between 1.11.0 > and > > > 1.11.1 > > > > > > https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1 > > > < > > > > > > https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1 > > > > > > > >> - Run some demo locally > > > >> > > > >> Best, > > > >> Congxian > > > >> > > > >> > > > >> Rui Li <[hidden email] <mailto:[hidden email]>> > > > 于2020年7月18日周六 下午7:04写道: > > > >> +1 (non-binding) > > > >> > > > >> - Built from source > > > >> - Verified hive connector tests for all hive versions > > > >> - Played some simple cases with hive connector and everything seems > > fine > > > >> > > > >> On Sat, Jul 18, 2020 at 12:24 AM Rui Li <[hidden email] > > <mailto: > > > [hidden email]>> wrote: > > > >> > > > >> > OK, I agree FLINK-18588 can wait for the next release. > > > >> > > > > >> > On Fri, Jul 17, 2020 at 11:56 PM Leonard Xu <[hidden email] > > > <mailto:[hidden email]>> wrote: > > > >> > > > > >> >> +1 (non-binding) > > > >> >> > > > >> >> - checked/verified signatures and hashes > > > >> >> - built from source code with scala 2.11 succeeded > > > >> >> - checked that there are no missing artifacts > > > >> >> - started a cluster, the Web UI was accessible, submitted a > > > wordcount job > > > >> >> and ran succeeded, no suspicious log output > > > >> >> - test using SQL Client to submit job and the query result is > > > expected > > > >> >> - go through all issues which fix version property is 1.11.1, all > > > issues > > > >> >> are closed except FLINK-15794, > > > >> >> and FLINK-15794 has fixed in master and 1.11.1 just wait for > > being > > > >> >> fixed in 1.10.2. > > > >> >> - the web PR looks good > > > >> >> > > > >> >> For FLINK-18588, I also agree with Timo to put it to 1.11.2 > > because > > > >> >> it's a `Major` bug rather than `Blocker`. > > > >> >> > > > >> >> Best, > > > >> >> Leonard > > > >> > > > > >> > > > > >> > > > > >> > -- > > > >> > Best regards! > > > >> > Rui Li > > > >> > > > > >> > > > >> > > > >> -- > > > >> Best regards! > > > >> Rui Li > > > > > > > > > > > > > |
+1 (binding)
- Checked checksums and GPG files matching: OK - Verified that the source does not contain any binaries: OK - Checked that all the POMs point to the same version: OK - Build the source with Maven: OK - Review the Web PR: OK - Checked the artifacts in repo: OK - Execute the WordCount example by starting the cluster: Success, Web UI OK, logs OK. Best, Zhijiang ------------------------------------------------------------------ From:Yu Li <[hidden email]> Send Time:2020年7月20日(星期一) 19:57 To:dev <[hidden email]> Subject:Re: [VOTE] Release 1.11.1, release candidate #1 +1 (binding) - Checked diff to last RC: OK ( https://github.com/apache/flink/compare/release-1.11.0...release-1.11.1-rc1) - All dependency related changes are properly documented - Checked release notes: OK - Minor: there're 2 open issues left, please remember to scope them out if this vote passes (the website PR already excludes them) - Checked sums and signatures: OK - Source release - contains no binaries: OK - contains no 1.11-SNAPSHOT references: OK - build from source: OK (8u101) - mvn clean verify: OK (8u101) - Binary release - no examples appear to be missing - started a cluster, WebUI reachable, several streaming and batch examples ran successfully (11.0.4) - Repository appears to contain all expected artifacts - Website PR looks good Best Regards, Yu On Mon, 20 Jul 2020 at 18:00, Jark Wu <[hidden email]> wrote: > Thanks Dian for kicking off the RC. > > +1 from my side: > > I heavily tested CDC use cases end-to-end and it works well. > > - checked/verified signatures and hashes > - manually verified the diff pom and NOTICE files between 1.11.0 and 1.11.1 > to check dependencies, looks good > - no missing artifacts in release staging area compared to the 1.11.0 > release > - started cluster and ran some table examples, verified web ui and log > output, nothing unexpected > - started cluster to run e2e SQL queries with millions of records with > Kafka, MySQL, Elasticsearch as sources/lookup/sinks. Works well and the > results are as expected. > - use SQL CLI to read from Kafka with debezium data, and MySQL binlog > source, and write into MySQL and Elasticsearch. Nothing unexpected > - review the release PR > > Best, > Jark > > On Mon, 20 Jul 2020 at 13:55, Congxian Qiu <[hidden email]> wrote: > > > Hi Dian > > > > Thanks for the information. > > > > Best, > > Congxian > > > > > > Dian Fu <[hidden email]> 于2020年7月20日周一 上午11:44写道: > > > > > Hi Congxian, > > > > > > FLINK-18544 was to fix an issue introduced in 1.11.1 and so it should > not > > > appear in the release note according to the release guide[1]. > > > > > > [1] > > > > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-ReviewReleaseNotesinJIRA > > > < > > > > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-ReviewReleaseNotesinJIRA > > > > > > > > > > Regards, > > > Dian > > > > > > > 在 2020年7月20日,上午11:32,Dian Fu <[hidden email]> 写道: > > > > > > > > +1 (non-binding) > > > > > > > > - checked the checksum and signature > > > > - installed PyFlink package on MacOS and run some tests > > > > > > > > Regards, > > > > Dian > > > > > > > >> 在 2020年7月20日,上午11:11,Congxian Qiu <[hidden email] <mailto: > > > [hidden email]>> 写道: > > > >> > > > >> +1 (non-binding) > > > >> > > > >> I found that the fix version of FLINK-18544 is 1.11.1, and the > release > > > did not contain it. I think we should fix it in the release note. > > > >> > > > >> checked > > > >> - build from source, ok > > > >> - sha512 sum, ok > > > >> - gpg key, ok > > > >> - License seem ok(checked the change of all pom.xml between 1.11.0 > and > > > 1.11.1 > > > > > > https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1 > > > < > > > > > > https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1 > > > > > > > >> - Run some demo locally > > > >> > > > >> Best, > > > >> Congxian > > > >> > > > >> > > > >> Rui Li <[hidden email] <mailto:[hidden email]>> > > > 于2020年7月18日周六 下午7:04写道: > > > >> +1 (non-binding) > > > >> > > > >> - Built from source > > > >> - Verified hive connector tests for all hive versions > > > >> - Played some simple cases with hive connector and everything seems > > fine > > > >> > > > >> On Sat, Jul 18, 2020 at 12:24 AM Rui Li <[hidden email] > > <mailto: > > > [hidden email]>> wrote: > > > >> > > > >> > OK, I agree FLINK-18588 can wait for the next release. > > > >> > > > > >> > On Fri, Jul 17, 2020 at 11:56 PM Leonard Xu <[hidden email] > > > <mailto:[hidden email]>> wrote: > > > >> > > > > >> >> +1 (non-binding) > > > >> >> > > > >> >> - checked/verified signatures and hashes > > > >> >> - built from source code with scala 2.11 succeeded > > > >> >> - checked that there are no missing artifacts > > > >> >> - started a cluster, the Web UI was accessible, submitted a > > > wordcount job > > > >> >> and ran succeeded, no suspicious log output > > > >> >> - test using SQL Client to submit job and the query result is > > > expected > > > >> >> - go through all issues which fix version property is 1.11.1, all > > > issues > > > >> >> are closed except FLINK-15794, > > > >> >> and FLINK-15794 has fixed in master and 1.11.1 just wait for > > being > > > >> >> fixed in 1.10.2. > > > >> >> - the web PR looks good > > > >> >> > > > >> >> For FLINK-18588, I also agree with Timo to put it to 1.11.2 > > because > > > >> >> it's a `Major` bug rather than `Blocker`. > > > >> >> > > > >> >> Best, > > > >> >> Leonard > > > >> > > > > >> > > > > >> > > > > >> > -- > > > >> > Best regards! > > > >> > Rui Li > > > >> > > > > >> > > > >> > > > >> -- > > > >> Best regards! > > > >> Rui Li > > > > > > > > > > > > > |
+1 (non-binding)
- checked release notes - checked signatures - built from source - submitted an example job on yarn cluster - WebUI and logs look good Thanks, Zhu Zhu Zhijiang <[hidden email]> 于2020年7月21日周二 上午11:06写道: > +1 (binding) > > - Checked checksums and GPG files matching: OK > - Verified that the source does not contain any binaries: OK > - Checked that all the POMs point to the same version: OK > - Build the source with Maven: OK > - Review the Web PR: OK > - Checked the artifacts in repo: OK > - Execute the WordCount example by starting the cluster: Success, Web UI > OK, logs OK. > > > Best, > Zhijiang > > > ------------------------------------------------------------------ > From:Yu Li <[hidden email]> > Send Time:2020年7月20日(星期一) 19:57 > To:dev <[hidden email]> > Subject:Re: [VOTE] Release 1.11.1, release candidate #1 > > +1 (binding) > > - Checked diff to last RC: OK ( > https://github.com/apache/flink/compare/release-1.11.0...release-1.11.1-rc1 > ) > - All dependency related changes are properly documented > - Checked release notes: OK > - Minor: there're 2 open issues left, please remember to scope them out > if this vote passes (the website PR already excludes them) > - Checked sums and signatures: OK > - Source release > - contains no binaries: OK > - contains no 1.11-SNAPSHOT references: OK > - build from source: OK (8u101) > - mvn clean verify: OK (8u101) > - Binary release > - no examples appear to be missing > - started a cluster, WebUI reachable, several streaming and batch > examples ran successfully (11.0.4) > - Repository appears to contain all expected artifacts > - Website PR looks good > > Best Regards, > Yu > > > On Mon, 20 Jul 2020 at 18:00, Jark Wu <[hidden email]> wrote: > > > Thanks Dian for kicking off the RC. > > > > +1 from my side: > > > > I heavily tested CDC use cases end-to-end and it works well. > > > > - checked/verified signatures and hashes > > - manually verified the diff pom and NOTICE files between 1.11.0 and > 1.11.1 > > to check dependencies, looks good > > - no missing artifacts in release staging area compared to the 1.11.0 > > release > > - started cluster and ran some table examples, verified web ui and log > > output, nothing unexpected > > - started cluster to run e2e SQL queries with millions of records with > > Kafka, MySQL, Elasticsearch as sources/lookup/sinks. Works well and the > > results are as expected. > > - use SQL CLI to read from Kafka with debezium data, and MySQL binlog > > source, and write into MySQL and Elasticsearch. Nothing unexpected > > - review the release PR > > > > Best, > > Jark > > > > On Mon, 20 Jul 2020 at 13:55, Congxian Qiu <[hidden email]> > wrote: > > > > > Hi Dian > > > > > > Thanks for the information. > > > > > > Best, > > > Congxian > > > > > > > > > Dian Fu <[hidden email]> 于2020年7月20日周一 上午11:44写道: > > > > > > > Hi Congxian, > > > > > > > > FLINK-18544 was to fix an issue introduced in 1.11.1 and so it should > > not > > > > appear in the release note according to the release guide[1]. > > > > > > > > [1] > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-ReviewReleaseNotesinJIRA > > > > < > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-ReviewReleaseNotesinJIRA > > > > > > > > > > > > > Regards, > > > > Dian > > > > > > > > > 在 2020年7月20日,上午11:32,Dian Fu <[hidden email]> 写道: > > > > > > > > > > +1 (non-binding) > > > > > > > > > > - checked the checksum and signature > > > > > - installed PyFlink package on MacOS and run some tests > > > > > > > > > > Regards, > > > > > Dian > > > > > > > > > >> 在 2020年7月20日,上午11:11,Congxian Qiu <[hidden email] > <mailto: > > > > [hidden email]>> 写道: > > > > >> > > > > >> +1 (non-binding) > > > > >> > > > > >> I found that the fix version of FLINK-18544 is 1.11.1, and the > > release > > > > did not contain it. I think we should fix it in the release note. > > > > >> > > > > >> checked > > > > >> - build from source, ok > > > > >> - sha512 sum, ok > > > > >> - gpg key, ok > > > > >> - License seem ok(checked the change of all pom.xml between 1.11.0 > > and > > > > 1.11.1 > > > > > > > > > > https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1 > > > > < > > > > > > > > > > https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1 > > > > > > > > > >> - Run some demo locally > > > > >> > > > > >> Best, > > > > >> Congxian > > > > >> > > > > >> > > > > >> Rui Li <[hidden email] <mailto:[hidden email]>> > > > > 于2020年7月18日周六 下午7:04写道: > > > > >> +1 (non-binding) > > > > >> > > > > >> - Built from source > > > > >> - Verified hive connector tests for all hive versions > > > > >> - Played some simple cases with hive connector and everything > seems > > > fine > > > > >> > > > > >> On Sat, Jul 18, 2020 at 12:24 AM Rui Li <[hidden email] > > > <mailto: > > > > [hidden email]>> wrote: > > > > >> > > > > >> > OK, I agree FLINK-18588 can wait for the next release. > > > > >> > > > > > >> > On Fri, Jul 17, 2020 at 11:56 PM Leonard Xu <[hidden email] > > > > <mailto:[hidden email]>> wrote: > > > > >> > > > > > >> >> +1 (non-binding) > > > > >> >> > > > > >> >> - checked/verified signatures and hashes > > > > >> >> - built from source code with scala 2.11 succeeded > > > > >> >> - checked that there are no missing artifacts > > > > >> >> - started a cluster, the Web UI was accessible, submitted a > > > > wordcount job > > > > >> >> and ran succeeded, no suspicious log output > > > > >> >> - test using SQL Client to submit job and the query result is > > > > expected > > > > >> >> - go through all issues which fix version property is 1.11.1, > all > > > > issues > > > > >> >> are closed except FLINK-15794, > > > > >> >> and FLINK-15794 has fixed in master and 1.11.1 just wait for > > > being > > > > >> >> fixed in 1.10.2. > > > > >> >> - the web PR looks good > > > > >> >> > > > > >> >> For FLINK-18588, I also agree with Timo to put it to 1.11.2 > > > because > > > > >> >> it's a `Major` bug rather than `Blocker`. > > > > >> >> > > > > >> >> Best, > > > > >> >> Leonard > > > > >> > > > > > >> > > > > > >> > > > > > >> > -- > > > > >> > Best regards! > > > > >> > Rui Li > > > > >> > > > > > >> > > > > >> > > > > >> -- > > > > >> Best regards! > > > > >> Rui Li > > > > > > > > > > > > > > > > > > > > |
+1(binding)
Checks: - checked the signature and checksum - test the built from the wheel package - check wheel package consistency - pip installed the Python package and run a word count example successfully Best, Jincheng Zhu Zhu <[hidden email]> 于2020年7月21日周二 上午11:25写道: > +1 (non-binding) > > - checked release notes > - checked signatures > - built from source > - submitted an example job on yarn cluster > - WebUI and logs look good > > Thanks, > Zhu Zhu > > Zhijiang <[hidden email]> 于2020年7月21日周二 上午11:06写道: > > > +1 (binding) > > > > - Checked checksums and GPG files matching: OK > > - Verified that the source does not contain any binaries: OK > > - Checked that all the POMs point to the same version: OK > > - Build the source with Maven: OK > > - Review the Web PR: OK > > - Checked the artifacts in repo: OK > > - Execute the WordCount example by starting the cluster: Success, Web UI > > OK, logs OK. > > > > > > Best, > > Zhijiang > > > > > > ------------------------------------------------------------------ > > From:Yu Li <[hidden email]> > > Send Time:2020年7月20日(星期一) 19:57 > > To:dev <[hidden email]> > > Subject:Re: [VOTE] Release 1.11.1, release candidate #1 > > > > +1 (binding) > > > > - Checked diff to last RC: OK ( > > > https://github.com/apache/flink/compare/release-1.11.0...release-1.11.1-rc1 > > ) > > - All dependency related changes are properly documented > > - Checked release notes: OK > > - Minor: there're 2 open issues left, please remember to scope them out > > if this vote passes (the website PR already excludes them) > > - Checked sums and signatures: OK > > - Source release > > - contains no binaries: OK > > - contains no 1.11-SNAPSHOT references: OK > > - build from source: OK (8u101) > > - mvn clean verify: OK (8u101) > > - Binary release > > - no examples appear to be missing > > - started a cluster, WebUI reachable, several streaming and batch > > examples ran successfully (11.0.4) > > - Repository appears to contain all expected artifacts > > - Website PR looks good > > > > Best Regards, > > Yu > > > > > > On Mon, 20 Jul 2020 at 18:00, Jark Wu <[hidden email]> wrote: > > > > > Thanks Dian for kicking off the RC. > > > > > > +1 from my side: > > > > > > I heavily tested CDC use cases end-to-end and it works well. > > > > > > - checked/verified signatures and hashes > > > - manually verified the diff pom and NOTICE files between 1.11.0 and > > 1.11.1 > > > to check dependencies, looks good > > > - no missing artifacts in release staging area compared to the 1.11.0 > > > release > > > - started cluster and ran some table examples, verified web ui and log > > > output, nothing unexpected > > > - started cluster to run e2e SQL queries with millions of records with > > > Kafka, MySQL, Elasticsearch as sources/lookup/sinks. Works well and the > > > results are as expected. > > > - use SQL CLI to read from Kafka with debezium data, and MySQL binlog > > > source, and write into MySQL and Elasticsearch. Nothing unexpected > > > - review the release PR > > > > > > Best, > > > Jark > > > > > > On Mon, 20 Jul 2020 at 13:55, Congxian Qiu <[hidden email]> > > wrote: > > > > > > > Hi Dian > > > > > > > > Thanks for the information. > > > > > > > > Best, > > > > Congxian > > > > > > > > > > > > Dian Fu <[hidden email]> 于2020年7月20日周一 上午11:44写道: > > > > > > > > > Hi Congxian, > > > > > > > > > > FLINK-18544 was to fix an issue introduced in 1.11.1 and so it > should > > > not > > > > > appear in the release note according to the release guide[1]. > > > > > > > > > > [1] > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-ReviewReleaseNotesinJIRA > > > > > < > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-ReviewReleaseNotesinJIRA > > > > > > > > > > > > > > > > Regards, > > > > > Dian > > > > > > > > > > > 在 2020年7月20日,上午11:32,Dian Fu <[hidden email]> 写道: > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > - checked the checksum and signature > > > > > > - installed PyFlink package on MacOS and run some tests > > > > > > > > > > > > Regards, > > > > > > Dian > > > > > > > > > > > >> 在 2020年7月20日,上午11:11,Congxian Qiu <[hidden email] > > <mailto: > > > > > [hidden email]>> 写道: > > > > > >> > > > > > >> +1 (non-binding) > > > > > >> > > > > > >> I found that the fix version of FLINK-18544 is 1.11.1, and the > > > release > > > > > did not contain it. I think we should fix it in the release note. > > > > > >> > > > > > >> checked > > > > > >> - build from source, ok > > > > > >> - sha512 sum, ok > > > > > >> - gpg key, ok > > > > > >> - License seem ok(checked the change of all pom.xml between > 1.11.0 > > > and > > > > > 1.11.1 > > > > > > > > > > > > > > > https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1 > > > > > < > > > > > > > > > > > > > > > https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1 > > > > > > > > > > > >> - Run some demo locally > > > > > >> > > > > > >> Best, > > > > > >> Congxian > > > > > >> > > > > > >> > > > > > >> Rui Li <[hidden email] <mailto:[hidden email]>> > > > > > 于2020年7月18日周六 下午7:04写道: > > > > > >> +1 (non-binding) > > > > > >> > > > > > >> - Built from source > > > > > >> - Verified hive connector tests for all hive versions > > > > > >> - Played some simple cases with hive connector and everything > > seems > > > > fine > > > > > >> > > > > > >> On Sat, Jul 18, 2020 at 12:24 AM Rui Li <[hidden email] > > > > <mailto: > > > > > [hidden email]>> wrote: > > > > > >> > > > > > >> > OK, I agree FLINK-18588 can wait for the next release. > > > > > >> > > > > > > >> > On Fri, Jul 17, 2020 at 11:56 PM Leonard Xu < > [hidden email] > > > > > <mailto:[hidden email]>> wrote: > > > > > >> > > > > > > >> >> +1 (non-binding) > > > > > >> >> > > > > > >> >> - checked/verified signatures and hashes > > > > > >> >> - built from source code with scala 2.11 succeeded > > > > > >> >> - checked that there are no missing artifacts > > > > > >> >> - started a cluster, the Web UI was accessible, submitted a > > > > > wordcount job > > > > > >> >> and ran succeeded, no suspicious log output > > > > > >> >> - test using SQL Client to submit job and the query result is > > > > > expected > > > > > >> >> - go through all issues which fix version property is 1.11.1, > > all > > > > > issues > > > > > >> >> are closed except FLINK-15794, > > > > > >> >> and FLINK-15794 has fixed in master and 1.11.1 just wait > for > > > > being > > > > > >> >> fixed in 1.10.2. > > > > > >> >> - the web PR looks good > > > > > >> >> > > > > > >> >> For FLINK-18588, I also agree with Timo to put it to 1.11.2 > > > > because > > > > > >> >> it's a `Major` bug rather than `Blocker`. > > > > > >> >> > > > > > >> >> Best, > > > > > >> >> Leonard > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > -- > > > > > >> > Best regards! > > > > > >> > Rui Li > > > > > >> > > > > > > >> > > > > > >> > > > > > >> -- > > > > > >> Best regards! > > > > > >> Rui Li > > > > > > > > > > > > > > > > > > > > > > > > > > > > |
Hi all,
Thanks a lot for checking and voting for this release! I’ll summarize the result in another email. Thanks, Dian > 在 2020年7月21日,下午12:06,jincheng sun <[hidden email]> 写道: > > +1(binding) > > Checks: > > - checked the signature and checksum > - test the built from the wheel package > - check wheel package consistency > - pip installed the Python package and run a word count example > successfully > > Best, > Jincheng > > > Zhu Zhu <[hidden email]> 于2020年7月21日周二 上午11:25写道: > >> +1 (non-binding) >> >> - checked release notes >> - checked signatures >> - built from source >> - submitted an example job on yarn cluster >> - WebUI and logs look good >> >> Thanks, >> Zhu Zhu >> >> Zhijiang <[hidden email]> 于2020年7月21日周二 上午11:06写道: >> >>> +1 (binding) >>> >>> - Checked checksums and GPG files matching: OK >>> - Verified that the source does not contain any binaries: OK >>> - Checked that all the POMs point to the same version: OK >>> - Build the source with Maven: OK >>> - Review the Web PR: OK >>> - Checked the artifacts in repo: OK >>> - Execute the WordCount example by starting the cluster: Success, Web UI >>> OK, logs OK. >>> >>> >>> Best, >>> Zhijiang >>> >>> >>> ------------------------------------------------------------------ >>> From:Yu Li <[hidden email]> >>> Send Time:2020年7月20日(星期一) 19:57 >>> To:dev <[hidden email]> >>> Subject:Re: [VOTE] Release 1.11.1, release candidate #1 >>> >>> +1 (binding) >>> >>> - Checked diff to last RC: OK ( >>> >> https://github.com/apache/flink/compare/release-1.11.0...release-1.11.1-rc1 >>> ) >>> - All dependency related changes are properly documented >>> - Checked release notes: OK >>> - Minor: there're 2 open issues left, please remember to scope them out >>> if this vote passes (the website PR already excludes them) >>> - Checked sums and signatures: OK >>> - Source release >>> - contains no binaries: OK >>> - contains no 1.11-SNAPSHOT references: OK >>> - build from source: OK (8u101) >>> - mvn clean verify: OK (8u101) >>> - Binary release >>> - no examples appear to be missing >>> - started a cluster, WebUI reachable, several streaming and batch >>> examples ran successfully (11.0.4) >>> - Repository appears to contain all expected artifacts >>> - Website PR looks good >>> >>> Best Regards, >>> Yu >>> >>> >>> On Mon, 20 Jul 2020 at 18:00, Jark Wu <[hidden email]> wrote: >>> >>>> Thanks Dian for kicking off the RC. >>>> >>>> +1 from my side: >>>> >>>> I heavily tested CDC use cases end-to-end and it works well. >>>> >>>> - checked/verified signatures and hashes >>>> - manually verified the diff pom and NOTICE files between 1.11.0 and >>> 1.11.1 >>>> to check dependencies, looks good >>>> - no missing artifacts in release staging area compared to the 1.11.0 >>>> release >>>> - started cluster and ran some table examples, verified web ui and log >>>> output, nothing unexpected >>>> - started cluster to run e2e SQL queries with millions of records with >>>> Kafka, MySQL, Elasticsearch as sources/lookup/sinks. Works well and the >>>> results are as expected. >>>> - use SQL CLI to read from Kafka with debezium data, and MySQL binlog >>>> source, and write into MySQL and Elasticsearch. Nothing unexpected >>>> - review the release PR >>>> >>>> Best, >>>> Jark >>>> >>>> On Mon, 20 Jul 2020 at 13:55, Congxian Qiu <[hidden email]> >>> wrote: >>>> >>>>> Hi Dian >>>>> >>>>> Thanks for the information. >>>>> >>>>> Best, >>>>> Congxian >>>>> >>>>> >>>>> Dian Fu <[hidden email]> 于2020年7月20日周一 上午11:44写道: >>>>> >>>>>> Hi Congxian, >>>>>> >>>>>> FLINK-18544 was to fix an issue introduced in 1.11.1 and so it >> should >>>> not >>>>>> appear in the release note according to the release guide[1]. >>>>>> >>>>>> [1] >>>>>> >>>>> >>>> >>> >> https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-ReviewReleaseNotesinJIRA >>>>>> < >>>>>> >>>>> >>>> >>> >> https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-ReviewReleaseNotesinJIRA >>>>>>> >>>>>> >>>>>> Regards, >>>>>> Dian >>>>>> >>>>>>> 在 2020年7月20日,上午11:32,Dian Fu <[hidden email]> 写道: >>>>>>> >>>>>>> +1 (non-binding) >>>>>>> >>>>>>> - checked the checksum and signature >>>>>>> - installed PyFlink package on MacOS and run some tests >>>>>>> >>>>>>> Regards, >>>>>>> Dian >>>>>>> >>>>>>>> 在 2020年7月20日,上午11:11,Congxian Qiu <[hidden email] >>> <mailto: >>>>>> [hidden email]>> 写道: >>>>>>>> >>>>>>>> +1 (non-binding) >>>>>>>> >>>>>>>> I found that the fix version of FLINK-18544 is 1.11.1, and the >>>> release >>>>>> did not contain it. I think we should fix it in the release note. >>>>>>>> >>>>>>>> checked >>>>>>>> - build from source, ok >>>>>>>> - sha512 sum, ok >>>>>>>> - gpg key, ok >>>>>>>> - License seem ok(checked the change of all pom.xml between >> 1.11.0 >>>> and >>>>>> 1.11.1 >>>>>> >>>>> >>>> >>> >> https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1 >>>>>> < >>>>>> >>>>> >>>> >>> >> https://github.com/apache/flink/compare/release-1.11.0..release-1.11.1-rc1 >>>>>>> >>>>>>>> - Run some demo locally >>>>>>>> >>>>>>>> Best, >>>>>>>> Congxian >>>>>>>> >>>>>>>> >>>>>>>> Rui Li <[hidden email] <mailto:[hidden email]>> >>>>>> 于2020年7月18日周六 下午7:04写道: >>>>>>>> +1 (non-binding) >>>>>>>> >>>>>>>> - Built from source >>>>>>>> - Verified hive connector tests for all hive versions >>>>>>>> - Played some simple cases with hive connector and everything >>> seems >>>>> fine >>>>>>>> >>>>>>>> On Sat, Jul 18, 2020 at 12:24 AM Rui Li <[hidden email] >>>>> <mailto: >>>>>> [hidden email]>> wrote: >>>>>>>> >>>>>>>>> OK, I agree FLINK-18588 can wait for the next release. >>>>>>>>> >>>>>>>>> On Fri, Jul 17, 2020 at 11:56 PM Leonard Xu < >> [hidden email] >>>>>> <mailto:[hidden email]>> wrote: >>>>>>>>> >>>>>>>>>> +1 (non-binding) >>>>>>>>>> >>>>>>>>>> - checked/verified signatures and hashes >>>>>>>>>> - built from source code with scala 2.11 succeeded >>>>>>>>>> - checked that there are no missing artifacts >>>>>>>>>> - started a cluster, the Web UI was accessible, submitted a >>>>>> wordcount job >>>>>>>>>> and ran succeeded, no suspicious log output >>>>>>>>>> - test using SQL Client to submit job and the query result is >>>>>> expected >>>>>>>>>> - go through all issues which fix version property is 1.11.1, >>> all >>>>>> issues >>>>>>>>>> are closed except FLINK-15794, >>>>>>>>>> and FLINK-15794 has fixed in master and 1.11.1 just wait >> for >>>>> being >>>>>>>>>> fixed in 1.10.2. >>>>>>>>>> - the web PR looks good >>>>>>>>>> >>>>>>>>>> For FLINK-18588, I also agree with Timo to put it to 1.11.2 >>>>> because >>>>>>>>>> it's a `Major` bug rather than `Blocker`. >>>>>>>>>> >>>>>>>>>> Best, >>>>>>>>>> Leonard >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Best regards! >>>>>>>>> Rui Li >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Best regards! >>>>>>>> Rui Li >>>>>>> >>>>>> >>>>>> >>>>> >>>> >>> >>> >> |
Free forum by Nabble | Edit this page |