[VOTE] Guarantee that @PublicEvolving classes are API and binary compatible across bug fix releases (x.y.u and x.y.v)

classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Guarantee that @PublicEvolving classes are API and binary compatible across bug fix releases (x.y.u and x.y.v)

Piotr Nowojski-3
+1

> On 18 May 2020, at 10:43, Canbin Zheng <[hidden email]> wrote:
>
> +1 (non-binding)
>
> Regards,
> Canbin Zheng
>
> Till Rohrmann <[hidden email]> 于2020年5月18日周一 下午4:40写道:
>
>> +1 (binding)
>>
>> On Mon, May 18, 2020 at 6:02 AM Tzu-Li (Gordon) Tai <[hidden email]>
>> wrote:
>>
>>> +1
>>>
>>> On Mon, May 18, 2020 at 11:47 AM Xintong Song <[hidden email]>
>>> wrote:
>>>
>>>> +1 (non-binding)
>>>>
>>>> Thank you~
>>>>
>>>> Xintong Song
>>>>
>>>>
>>>>
>>>> On Mon, May 18, 2020 at 10:58 AM Leonard Xu <[hidden email]> wrote:
>>>>
>>>>> +1 (non-binding)
>>>>>
>>>>> Best,
>>>>> Leonard Xu
>>>>>> 在 2020年5月17日,00:30,Zhu Zhu <[hidden email]> 写道:
>>>>>>
>>>>>> +1
>>>>>>
>>>>>> Thanks,
>>>>>> Zhu Zhu
>>>>>>
>>>>>> Yun Tang <[hidden email]> 于2020年5月16日周六 下午11:18写道:
>>>>>>
>>>>>>>
>>>>>>> +1 (non-binding)
>>>>>>>
>>>>>>> Yun Tang
>>>>>>> ________________________________
>>>>>>> From: Benchao Li <[hidden email]>
>>>>>>> Sent: Saturday, May 16, 2020 22:00
>>>>>>> To: dev <[hidden email]>
>>>>>>> Subject: Re: [VOTE] Guarantee that @PublicEvolving classes are API
>>> and
>>>>>>> binary compatible across bug fix releases (x.y.u and x.y.v)
>>>>>>>
>>>>>>> +1 (non-binding)
>>>>>>>
>>>>>>> Piotr Nowojski <[hidden email]> 于2020年5月16日周六 下午8:10写道:
>>>>>>>
>>>>>>>> +1
>>>>>>>>
>>>>>>>> Piotrek
>>>>>>>>
>>>>>>>>> On 16 May 2020, at 13:21, Yu Li <[hidden email]> wrote:
>>>>>>>>>
>>>>>>>>> +1 (not sure whether my vote is binding, I guess yes since this
>>> is a
>>>>>>>>> development-oriented vote?)
>>>>>>>>>
>>>>>>>>> Minor:
>>>>>>>>> bq. This means that a version x.y.u is API and binary compatible
>>> to
>>>>>>> x.y.v
>>>>>>>>> with u <= v wrt all @PublicEvolving classes.
>>>>>>>>> I guess you mean "with u *>* v" to keep backward compatibility
>>>> instead
>>>>>>> of
>>>>>>>>> forward?
>>>>>>>>>
>>>>>>>>> Thanks.
>>>>>>>>>
>>>>>>>>> Best Regards,
>>>>>>>>> Yu
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Sat, 16 May 2020 at 18:40, Jeff Zhang <[hidden email]>
>>> wrote:
>>>>>>>>>
>>>>>>>>>> Definitely +1
>>>>>>>>>>
>>>>>>>>>> Dian Fu <[hidden email]> 于2020年5月16日周六 下午5:48写道:
>>>>>>>>>>
>>>>>>>>>>> +1 (non-binding)
>>>>>>>>>>>
>>>>>>>>>>> Regards,
>>>>>>>>>>> Dian
>>>>>>>>>>>
>>>>>>>>>>>> 在 2020年5月16日,下午2:33,Congxian Qiu <[hidden email]>
>> 写道:
>>>>>>>>>>>>
>>>>>>>>>>>> +1 (non-binding)
>>>>>>>>>>>> Best,
>>>>>>>>>>>> Congxian
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Yangze Guo <[hidden email]> 于2020年5月16日周六 上午12:51写道:
>>>>>>>>>>>>
>>>>>>>>>>>>> +1
>>>>>>>>>>>>>
>>>>>>>>>>>>> Best,
>>>>>>>>>>>>> Yangze Guo
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Sat, May 16, 2020 at 12:26 AM Yuan Mei <
>>>> [hidden email]
>>>>>>
>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> +1
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Sat, May 16, 2020 at 12:21 AM Ufuk Celebi <
>> [hidden email]
>>>>
>>>>>>>> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> +1
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> – Ufuk
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Fri, May 15, 2020 at 4:54 PM Zhijiang <
>>>>>>>>>> [hidden email]
>>>>>>>>>>>>>>> .invalid>
>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Sounds good, +1.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Best,
>>>>>>>>>>>>>>>> Zhijiang
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>> ------------------------------------------------------------------
>>>>>>>>>>>>>>>> From:Thomas Weise <[hidden email]>
>>>>>>>>>>>>>>>> Send Time:2020年5月15日(星期五) 21:33
>>>>>>>>>>>>>>>> To:dev <[hidden email]>
>>>>>>>>>>>>>>>> Subject:Re: [VOTE] Guarantee that @PublicEvolving classes
>>> are
>>>>>>> API
>>>>>>>>>> and
>>>>>>>>>>>>>>>> binary compatible across bug fix releases (x.y.u and
>> x.y.v)
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> +1
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Fri, May 15, 2020 at 6:15 AM Till Rohrmann <
>>>>>>>>>> [hidden email]>
>>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Dear community,
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> with reference to the dev ML thread about guaranteeing
>> API
>>>> and
>>>>>>>>>>>>> binary
>>>>>>>>>>>>>>>>> compatibility for @PublicEvolving classes across bug fix
>>>>>>> releases
>>>>>>>>>>>>> [1] I
>>>>>>>>>>>>>>>>> would like to start a vote about it.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> The proposal is that the Flink community starts to
>>> guarantee
>>>>>>>>>>>>>>>>> that @PublicEvolving classes will be API and binary
>>>> compatible
>>>>>>>>>>>>> across
>>>>>>>>>>>>>>> bug
>>>>>>>>>>>>>>>>> fix releases of the same minor version. This means that
>> a
>>>>>>> version
>>>>>>>>>>>>> x.y.u
>>>>>>>>>>>>>>>> is
>>>>>>>>>>>>>>>>> API and binary compatible to x.y.v with u <= v wrt all
>>>>>>>>>>>>> @PublicEvolving
>>>>>>>>>>>>>>>>> classes.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> The voting options are the following:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> * +1, Provide the above described guarantees
>>>>>>>>>>>>>>>>> * -1, Do not provide the above described guarantees
>>> (please
>>>>>>>>>> provide
>>>>>>>>>>>>>>>>> specific comments)
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> The vote will be open for at least 72 hours. It is
>> adopted
>>>> by
>>>>>>>>>>>>> majority
>>>>>>>>>>>>>>>>> approval with at least 3 PMC affirmative votes.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> [1]
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>
>>>>
>>>
>> https://lists.apache.org/thread.html/rb0d0f887b291a490ed3773352c90ddf5f11e3d882dc501e3b8cf0ed0%40%3Cdev.flink.apache.org%3E
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Cheers,
>>>>>>>>>>>>>>>>> Till
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Best Regards
>>>>>>>>>>
>>>>>>>>>> Jeff Zhang
>>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>>
>>>>>>> Benchao Li
>>>>>>> School of Electronics Engineering and Computer Science, Peking
>>>>> University
>>>>>>> Tel:+86-15650713730
>>>>>>> Email: [hidden email]; [hidden email]
>>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Guarantee that @PublicEvolving classes are API and binary compatible across bug fix releases (x.y.u and x.y.v)

Till Rohrmann
Thanks everyone for voting. I will post the result of the vote in a
separate email.

Cheers,
Till

On Mon, May 18, 2020 at 1:03 PM Piotr Nowojski <[hidden email]> wrote:

> +1
>
> > On 18 May 2020, at 10:43, Canbin Zheng <[hidden email]> wrote:
> >
> > +1 (non-binding)
> >
> > Regards,
> > Canbin Zheng
> >
> > Till Rohrmann <[hidden email]> 于2020年5月18日周一 下午4:40写道:
> >
> >> +1 (binding)
> >>
> >> On Mon, May 18, 2020 at 6:02 AM Tzu-Li (Gordon) Tai <
> [hidden email]>
> >> wrote:
> >>
> >>> +1
> >>>
> >>> On Mon, May 18, 2020 at 11:47 AM Xintong Song <[hidden email]>
> >>> wrote:
> >>>
> >>>> +1 (non-binding)
> >>>>
> >>>> Thank you~
> >>>>
> >>>> Xintong Song
> >>>>
> >>>>
> >>>>
> >>>> On Mon, May 18, 2020 at 10:58 AM Leonard Xu <[hidden email]>
> wrote:
> >>>>
> >>>>> +1 (non-binding)
> >>>>>
> >>>>> Best,
> >>>>> Leonard Xu
> >>>>>> 在 2020年5月17日,00:30,Zhu Zhu <[hidden email]> 写道:
> >>>>>>
> >>>>>> +1
> >>>>>>
> >>>>>> Thanks,
> >>>>>> Zhu Zhu
> >>>>>>
> >>>>>> Yun Tang <[hidden email]> 于2020年5月16日周六 下午11:18写道:
> >>>>>>
> >>>>>>>
> >>>>>>> +1 (non-binding)
> >>>>>>>
> >>>>>>> Yun Tang
> >>>>>>> ________________________________
> >>>>>>> From: Benchao Li <[hidden email]>
> >>>>>>> Sent: Saturday, May 16, 2020 22:00
> >>>>>>> To: dev <[hidden email]>
> >>>>>>> Subject: Re: [VOTE] Guarantee that @PublicEvolving classes are API
> >>> and
> >>>>>>> binary compatible across bug fix releases (x.y.u and x.y.v)
> >>>>>>>
> >>>>>>> +1 (non-binding)
> >>>>>>>
> >>>>>>> Piotr Nowojski <[hidden email]> 于2020年5月16日周六 下午8:10写道:
> >>>>>>>
> >>>>>>>> +1
> >>>>>>>>
> >>>>>>>> Piotrek
> >>>>>>>>
> >>>>>>>>> On 16 May 2020, at 13:21, Yu Li <[hidden email]> wrote:
> >>>>>>>>>
> >>>>>>>>> +1 (not sure whether my vote is binding, I guess yes since this
> >>> is a
> >>>>>>>>> development-oriented vote?)
> >>>>>>>>>
> >>>>>>>>> Minor:
> >>>>>>>>> bq. This means that a version x.y.u is API and binary compatible
> >>> to
> >>>>>>> x.y.v
> >>>>>>>>> with u <= v wrt all @PublicEvolving classes.
> >>>>>>>>> I guess you mean "with u *>* v" to keep backward compatibility
> >>>> instead
> >>>>>>> of
> >>>>>>>>> forward?
> >>>>>>>>>
> >>>>>>>>> Thanks.
> >>>>>>>>>
> >>>>>>>>> Best Regards,
> >>>>>>>>> Yu
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> On Sat, 16 May 2020 at 18:40, Jeff Zhang <[hidden email]>
> >>> wrote:
> >>>>>>>>>
> >>>>>>>>>> Definitely +1
> >>>>>>>>>>
> >>>>>>>>>> Dian Fu <[hidden email]> 于2020年5月16日周六 下午5:48写道:
> >>>>>>>>>>
> >>>>>>>>>>> +1 (non-binding)
> >>>>>>>>>>>
> >>>>>>>>>>> Regards,
> >>>>>>>>>>> Dian
> >>>>>>>>>>>
> >>>>>>>>>>>> 在 2020年5月16日,下午2:33,Congxian Qiu <[hidden email]>
> >> 写道:
> >>>>>>>>>>>>
> >>>>>>>>>>>> +1 (non-binding)
> >>>>>>>>>>>> Best,
> >>>>>>>>>>>> Congxian
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>> Yangze Guo <[hidden email]> 于2020年5月16日周六 上午12:51写道:
> >>>>>>>>>>>>
> >>>>>>>>>>>>> +1
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Best,
> >>>>>>>>>>>>> Yangze Guo
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> On Sat, May 16, 2020 at 12:26 AM Yuan Mei <
> >>>> [hidden email]
> >>>>>>
> >>>>>>>>>>> wrote:
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> +1
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> On Sat, May 16, 2020 at 12:21 AM Ufuk Celebi <
> >> [hidden email]
> >>>>
> >>>>>>>> wrote:
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> +1
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> – Ufuk
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> On Fri, May 15, 2020 at 4:54 PM Zhijiang <
> >>>>>>>>>> [hidden email]
> >>>>>>>>>>>>>>> .invalid>
> >>>>>>>>>>>>>>> wrote:
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> Sounds good, +1.
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> Best,
> >>>>>>>>>>>>>>>> Zhijiang
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>> ------------------------------------------------------------------
> >>>>>>>>>>>>>>>> From:Thomas Weise <[hidden email]>
> >>>>>>>>>>>>>>>> Send Time:2020年5月15日(星期五) 21:33
> >>>>>>>>>>>>>>>> To:dev <[hidden email]>
> >>>>>>>>>>>>>>>> Subject:Re: [VOTE] Guarantee that @PublicEvolving classes
> >>> are
> >>>>>>> API
> >>>>>>>>>> and
> >>>>>>>>>>>>>>>> binary compatible across bug fix releases (x.y.u and
> >> x.y.v)
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> +1
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> On Fri, May 15, 2020 at 6:15 AM Till Rohrmann <
> >>>>>>>>>> [hidden email]>
> >>>>>>>>>>>>>>>> wrote:
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>> Dear community,
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>> with reference to the dev ML thread about guaranteeing
> >> API
> >>>> and
> >>>>>>>>>>>>> binary
> >>>>>>>>>>>>>>>>> compatibility for @PublicEvolving classes across bug fix
> >>>>>>> releases
> >>>>>>>>>>>>> [1] I
> >>>>>>>>>>>>>>>>> would like to start a vote about it.
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>> The proposal is that the Flink community starts to
> >>> guarantee
> >>>>>>>>>>>>>>>>> that @PublicEvolving classes will be API and binary
> >>>> compatible
> >>>>>>>>>>>>> across
> >>>>>>>>>>>>>>> bug
> >>>>>>>>>>>>>>>>> fix releases of the same minor version. This means that
> >> a
> >>>>>>> version
> >>>>>>>>>>>>> x.y.u
> >>>>>>>>>>>>>>>> is
> >>>>>>>>>>>>>>>>> API and binary compatible to x.y.v with u <= v wrt all
> >>>>>>>>>>>>> @PublicEvolving
> >>>>>>>>>>>>>>>>> classes.
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>> The voting options are the following:
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>> * +1, Provide the above described guarantees
> >>>>>>>>>>>>>>>>> * -1, Do not provide the above described guarantees
> >>> (please
> >>>>>>>>>> provide
> >>>>>>>>>>>>>>>>> specific comments)
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>> The vote will be open for at least 72 hours. It is
> >> adopted
> >>>> by
> >>>>>>>>>>>>> majority
> >>>>>>>>>>>>>>>>> approval with at least 3 PMC affirmative votes.
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>> [1]
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>
> >>>>
> >>>
> >>
> https://lists.apache.org/thread.html/rb0d0f887b291a490ed3773352c90ddf5f11e3d882dc501e3b8cf0ed0%40%3Cdev.flink.apache.org%3E
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>> Cheers,
> >>>>>>>>>>>>>>>>> Till
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> --
> >>>>>>>>>> Best Regards
> >>>>>>>>>>
> >>>>>>>>>> Jeff Zhang
> >>>>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>> --
> >>>>>>>
> >>>>>>> Benchao Li
> >>>>>>> School of Electronics Engineering and Computer Science, Peking
> >>>>> University
> >>>>>>> Tel:+86-15650713730
> >>>>>>> Email: [hidden email]; [hidden email]
> >>>>>>>
> >>>>>
> >>>>>
> >>>>
> >>>
> >>
>
>
12