[VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

godfreyhe
Hi everyone,

I'd like to start the vote of FLIP-84[1] again, because we have some
feedbacks. The feedbacks are all about new introduced methods, here is the
discussion thread [2].

The vote will be open for at least 72 hours. Unless there is an objection,
I will try to close it by Apr 3, 2020 06:30 UTC if we have received
sufficient votes.


[1]
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878

[2]
http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html


Bests,
Godfrey
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

Timo Walther-2
-1

The current discussion has not completed. The last comments were sent
less than 24h ago.

Let's wait a bit longer to collect feedback from all stakeholders.

Thanks,
Timo

On 31.03.20 08:31, godfrey he wrote:

> Hi everyone,
>
> I'd like to start the vote of FLIP-84[1] again, because we have some
> feedbacks. The feedbacks are all about new introduced methods, here is the
> discussion thread [2].
>
> The vote will be open for at least 72 hours. Unless there is an objection,
> I will try to close it by Apr 3, 2020 06:30 UTC if we have received
> sufficient votes.
>
>
> [1]
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
>
> [2]
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
>
>
> Bests,
> Godfrey
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

godfreyhe
Hi, Timo

So sorry about that, I'm in a little hurry. Let's wait for 24h.

Best,
Godfrey

Timo Walther <[hidden email]> 于2020年3月31日周二 下午5:26写道:

> -1
>
> The current discussion has not completed. The last comments were sent
> less than 24h ago.
>
> Let's wait a bit longer to collect feedback from all stakeholders.
>
> Thanks,
> Timo
>
> On 31.03.20 08:31, godfrey he wrote:
> > Hi everyone,
> >
> > I'd like to start the vote of FLIP-84[1] again, because we have some
> > feedbacks. The feedbacks are all about new introduced methods, here is
> the
> > discussion thread [2].
> >
> > The vote will be open for at least 72 hours. Unless there is an
> objection,
> > I will try to close it by Apr 3, 2020 06:30 UTC if we have received
> > sufficient votes.
> >
> >
> > [1]
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
> >
> > [2]
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
> >
> >
> > Bests,
> > Godfrey
> >
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

godfreyhe
Hi everyone,

I'd like to start the vote of FLIP-84[1] again, which is discussed and
reached consensus in the discussion thread[2].

The vote will be open for at least 72 hours. Unless there is an objection,
I will try to close it by Apr 6, 2020 13:10 UTC if we have received
sufficient votes.


[1]
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878

[2]
http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html


Bests,
Godfrey

godfrey he <[hidden email]> 于2020年3月31日周二 下午8:42写道:

> Hi, Timo
>
> So sorry about that, I'm in a little hurry. Let's wait for 24h.
>
> Best,
> Godfrey
>
> Timo Walther <[hidden email]> 于2020年3月31日周二 下午5:26写道:
>
>> -1
>>
>> The current discussion has not completed. The last comments were sent
>> less than 24h ago.
>>
>> Let's wait a bit longer to collect feedback from all stakeholders.
>>
>> Thanks,
>> Timo
>>
>> On 31.03.20 08:31, godfrey he wrote:
>> > Hi everyone,
>> >
>> > I'd like to start the vote of FLIP-84[1] again, because we have some
>> > feedbacks. The feedbacks are all about new introduced methods, here is
>> the
>> > discussion thread [2].
>> >
>> > The vote will be open for at least 72 hours. Unless there is an
>> objection,
>> > I will try to close it by Apr 3, 2020 06:30 UTC if we have received
>> > sufficient votes.
>> >
>> >
>> > [1]
>> >
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
>> >
>> > [2]
>> >
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
>> >
>> >
>> > Bests,
>> > Godfrey
>> >
>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

Terry Wang
+1 (non-binding)
Looks great to me, Thanks for driving on this.

Best,
Terry Wang



> 2020年4月3日 21:07,godfrey he <[hidden email]> 写道:
>
> Hi everyone,
>
> I'd like to start the vote of FLIP-84[1] again, which is discussed and
> reached consensus in the discussion thread[2].
>
> The vote will be open for at least 72 hours. Unless there is an objection,
> I will try to close it by Apr 6, 2020 13:10 UTC if we have received
> sufficient votes.
>
>
> [1]
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
>
> [2]
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
>
>
> Bests,
> Godfrey
>
> godfrey he <[hidden email]> 于2020年3月31日周二 下午8:42写道:
>
>> Hi, Timo
>>
>> So sorry about that, I'm in a little hurry. Let's wait for 24h.
>>
>> Best,
>> Godfrey
>>
>> Timo Walther <[hidden email]> 于2020年3月31日周二 下午5:26写道:
>>
>>> -1
>>>
>>> The current discussion has not completed. The last comments were sent
>>> less than 24h ago.
>>>
>>> Let's wait a bit longer to collect feedback from all stakeholders.
>>>
>>> Thanks,
>>> Timo
>>>
>>> On 31.03.20 08:31, godfrey he wrote:
>>>> Hi everyone,
>>>>
>>>> I'd like to start the vote of FLIP-84[1] again, because we have some
>>>> feedbacks. The feedbacks are all about new introduced methods, here is
>>> the
>>>> discussion thread [2].
>>>>
>>>> The vote will be open for at least 72 hours. Unless there is an
>>> objection,
>>>> I will try to close it by Apr 3, 2020 06:30 UTC if we have received
>>>> sufficient votes.
>>>>
>>>>
>>>> [1]
>>>>
>>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
>>>>
>>>> [2]
>>>>
>>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
>>>>
>>>>
>>>> Bests,
>>>> Godfrey
>>>>
>>>
>>>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

Timo Walther-2
Hi Godfrey,

did you see my remaining feedback in the discussion thread? We could
finish this FLIP if this gets resolved.

Thanks,
Timo

On 03.04.20 15:12, Terry Wang wrote:

> +1 (non-binding)
> Looks great to me, Thanks for driving on this.
>
> Best,
> Terry Wang
>
>
>
>> 2020年4月3日 21:07,godfrey he <[hidden email]> 写道:
>>
>> Hi everyone,
>>
>> I'd like to start the vote of FLIP-84[1] again, which is discussed and
>> reached consensus in the discussion thread[2].
>>
>> The vote will be open for at least 72 hours. Unless there is an objection,
>> I will try to close it by Apr 6, 2020 13:10 UTC if we have received
>> sufficient votes.
>>
>>
>> [1]
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
>>
>> [2]
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
>>
>>
>> Bests,
>> Godfrey
>>
>> godfrey he <[hidden email]> 于2020年3月31日周二 下午8:42写道:
>>
>>> Hi, Timo
>>>
>>> So sorry about that, I'm in a little hurry. Let's wait for 24h.
>>>
>>> Best,
>>> Godfrey
>>>
>>> Timo Walther <[hidden email]> 于2020年3月31日周二 下午5:26写道:
>>>
>>>> -1
>>>>
>>>> The current discussion has not completed. The last comments were sent
>>>> less than 24h ago.
>>>>
>>>> Let's wait a bit longer to collect feedback from all stakeholders.
>>>>
>>>> Thanks,
>>>> Timo
>>>>
>>>> On 31.03.20 08:31, godfrey he wrote:
>>>>> Hi everyone,
>>>>>
>>>>> I'd like to start the vote of FLIP-84[1] again, because we have some
>>>>> feedbacks. The feedbacks are all about new introduced methods, here is
>>>> the
>>>>> discussion thread [2].
>>>>>
>>>>> The vote will be open for at least 72 hours. Unless there is an
>>>> objection,
>>>>> I will try to close it by Apr 3, 2020 06:30 UTC if we have received
>>>>> sufficient votes.
>>>>>
>>>>>
>>>>> [1]
>>>>>
>>>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
>>>>>
>>>>> [2]
>>>>>
>>>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
>>>>>
>>>>>
>>>>> Bests,
>>>>> Godfrey
>>>>>
>>>>
>>>>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

godfreyhe
Hi Timo,

Sorry for late reply, and thanks for your correction. I have fixed the typo
and updated the document.

Best,
Godfrey

Timo Walther <[hidden email]> 于2020年4月6日周一 下午6:05写道:

> Hi Godfrey,
>
> did you see my remaining feedback in the discussion thread? We could
> finish this FLIP if this gets resolved.
>
> Thanks,
> Timo
>
> On 03.04.20 15:12, Terry Wang wrote:
> > +1 (non-binding)
> > Looks great to me, Thanks for driving on this.
> >
> > Best,
> > Terry Wang
> >
> >
> >
> >> 2020年4月3日 21:07,godfrey he <[hidden email]> 写道:
> >>
> >> Hi everyone,
> >>
> >> I'd like to start the vote of FLIP-84[1] again, which is discussed and
> >> reached consensus in the discussion thread[2].
> >>
> >> The vote will be open for at least 72 hours. Unless there is an
> objection,
> >> I will try to close it by Apr 6, 2020 13:10 UTC if we have received
> >> sufficient votes.
> >>
> >>
> >> [1]
> >>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
> >>
> >> [2]
> >>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
> >>
> >>
> >> Bests,
> >> Godfrey
> >>
> >> godfrey he <[hidden email]> 于2020年3月31日周二 下午8:42写道:
> >>
> >>> Hi, Timo
> >>>
> >>> So sorry about that, I'm in a little hurry. Let's wait for 24h.
> >>>
> >>> Best,
> >>> Godfrey
> >>>
> >>> Timo Walther <[hidden email]> 于2020年3月31日周二 下午5:26写道:
> >>>
> >>>> -1
> >>>>
> >>>> The current discussion has not completed. The last comments were sent
> >>>> less than 24h ago.
> >>>>
> >>>> Let's wait a bit longer to collect feedback from all stakeholders.
> >>>>
> >>>> Thanks,
> >>>> Timo
> >>>>
> >>>> On 31.03.20 08:31, godfrey he wrote:
> >>>>> Hi everyone,
> >>>>>
> >>>>> I'd like to start the vote of FLIP-84[1] again, because we have some
> >>>>> feedbacks. The feedbacks are all about new introduced methods, here
> is
> >>>> the
> >>>>> discussion thread [2].
> >>>>>
> >>>>> The vote will be open for at least 72 hours. Unless there is an
> >>>> objection,
> >>>>> I will try to close it by Apr 3, 2020 06:30 UTC if we have received
> >>>>> sufficient votes.
> >>>>>
> >>>>>
> >>>>> [1]
> >>>>>
> >>>>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
> >>>>>
> >>>>> [2]
> >>>>>
> >>>>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
> >>>>>
> >>>>>
> >>>>> Bests,
> >>>>> Godfrey
> >>>>>
> >>>>
> >>>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

Timo Walther-2
Thanks, for the update.

+1 (binding) for this FLIP

Regards,
Timo


On 06.04.20 16:47, godfrey he wrote:

> Hi Timo,
>
> Sorry for late reply, and thanks for your correction. I have fixed the typo
> and updated the document.
>
> Best,
> Godfrey
>
> Timo Walther <[hidden email]> 于2020年4月6日周一 下午6:05写道:
>
>> Hi Godfrey,
>>
>> did you see my remaining feedback in the discussion thread? We could
>> finish this FLIP if this gets resolved.
>>
>> Thanks,
>> Timo
>>
>> On 03.04.20 15:12, Terry Wang wrote:
>>> +1 (non-binding)
>>> Looks great to me, Thanks for driving on this.
>>>
>>> Best,
>>> Terry Wang
>>>
>>>
>>>
>>>> 2020年4月3日 21:07,godfrey he <[hidden email]> 写道:
>>>>
>>>> Hi everyone,
>>>>
>>>> I'd like to start the vote of FLIP-84[1] again, which is discussed and
>>>> reached consensus in the discussion thread[2].
>>>>
>>>> The vote will be open for at least 72 hours. Unless there is an
>> objection,
>>>> I will try to close it by Apr 6, 2020 13:10 UTC if we have received
>>>> sufficient votes.
>>>>
>>>>
>>>> [1]
>>>>
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
>>>>
>>>> [2]
>>>>
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
>>>>
>>>>
>>>> Bests,
>>>> Godfrey
>>>>
>>>> godfrey he <[hidden email]> 于2020年3月31日周二 下午8:42写道:
>>>>
>>>>> Hi, Timo
>>>>>
>>>>> So sorry about that, I'm in a little hurry. Let's wait for 24h.
>>>>>
>>>>> Best,
>>>>> Godfrey
>>>>>
>>>>> Timo Walther <[hidden email]> 于2020年3月31日周二 下午5:26写道:
>>>>>
>>>>>> -1
>>>>>>
>>>>>> The current discussion has not completed. The last comments were sent
>>>>>> less than 24h ago.
>>>>>>
>>>>>> Let's wait a bit longer to collect feedback from all stakeholders.
>>>>>>
>>>>>> Thanks,
>>>>>> Timo
>>>>>>
>>>>>> On 31.03.20 08:31, godfrey he wrote:
>>>>>>> Hi everyone,
>>>>>>>
>>>>>>> I'd like to start the vote of FLIP-84[1] again, because we have some
>>>>>>> feedbacks. The feedbacks are all about new introduced methods, here
>> is
>>>>>> the
>>>>>>> discussion thread [2].
>>>>>>>
>>>>>>> The vote will be open for at least 72 hours. Unless there is an
>>>>>> objection,
>>>>>>> I will try to close it by Apr 3, 2020 06:30 UTC if we have received
>>>>>>> sufficient votes.
>>>>>>>
>>>>>>>
>>>>>>> [1]
>>>>>>>
>>>>>>
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
>>>>>>>
>>>>>>> [2]
>>>>>>>
>>>>>>
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
>>>>>>>
>>>>>>>
>>>>>>> Bests,
>>>>>>> Godfrey
>>>>>>>
>>>>>>
>>>>>>
>>
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

Kurt Young
+1 (binding)

The latest doc looks good to me. One minor comment is with the latest
changes, it seems also very easy
to support running SELECT query in TableEnvironement#executeSql method.
Will this also be supported?

Best,
Kurt


On Mon, Apr 6, 2020 at 10:49 PM Timo Walther <[hidden email]> wrote:

> Thanks, for the update.
>
> +1 (binding) for this FLIP
>
> Regards,
> Timo
>
>
> On 06.04.20 16:47, godfrey he wrote:
> > Hi Timo,
> >
> > Sorry for late reply, and thanks for your correction. I have fixed the
> typo
> > and updated the document.
> >
> > Best,
> > Godfrey
> >
> > Timo Walther <[hidden email]> 于2020年4月6日周一 下午6:05写道:
> >
> >> Hi Godfrey,
> >>
> >> did you see my remaining feedback in the discussion thread? We could
> >> finish this FLIP if this gets resolved.
> >>
> >> Thanks,
> >> Timo
> >>
> >> On 03.04.20 15:12, Terry Wang wrote:
> >>> +1 (non-binding)
> >>> Looks great to me, Thanks for driving on this.
> >>>
> >>> Best,
> >>> Terry Wang
> >>>
> >>>
> >>>
> >>>> 2020年4月3日 21:07,godfrey he <[hidden email]> 写道:
> >>>>
> >>>> Hi everyone,
> >>>>
> >>>> I'd like to start the vote of FLIP-84[1] again, which is discussed and
> >>>> reached consensus in the discussion thread[2].
> >>>>
> >>>> The vote will be open for at least 72 hours. Unless there is an
> >> objection,
> >>>> I will try to close it by Apr 6, 2020 13:10 UTC if we have received
> >>>> sufficient votes.
> >>>>
> >>>>
> >>>> [1]
> >>>>
> >>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
> >>>>
> >>>> [2]
> >>>>
> >>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
> >>>>
> >>>>
> >>>> Bests,
> >>>> Godfrey
> >>>>
> >>>> godfrey he <[hidden email]> 于2020年3月31日周二 下午8:42写道:
> >>>>
> >>>>> Hi, Timo
> >>>>>
> >>>>> So sorry about that, I'm in a little hurry. Let's wait for 24h.
> >>>>>
> >>>>> Best,
> >>>>> Godfrey
> >>>>>
> >>>>> Timo Walther <[hidden email]> 于2020年3月31日周二 下午5:26写道:
> >>>>>
> >>>>>> -1
> >>>>>>
> >>>>>> The current discussion has not completed. The last comments were
> sent
> >>>>>> less than 24h ago.
> >>>>>>
> >>>>>> Let's wait a bit longer to collect feedback from all stakeholders.
> >>>>>>
> >>>>>> Thanks,
> >>>>>> Timo
> >>>>>>
> >>>>>> On 31.03.20 08:31, godfrey he wrote:
> >>>>>>> Hi everyone,
> >>>>>>>
> >>>>>>> I'd like to start the vote of FLIP-84[1] again, because we have
> some
> >>>>>>> feedbacks. The feedbacks are all about new introduced methods, here
> >> is
> >>>>>> the
> >>>>>>> discussion thread [2].
> >>>>>>>
> >>>>>>> The vote will be open for at least 72 hours. Unless there is an
> >>>>>> objection,
> >>>>>>> I will try to close it by Apr 3, 2020 06:30 UTC if we have received
> >>>>>>> sufficient votes.
> >>>>>>>
> >>>>>>>
> >>>>>>> [1]
> >>>>>>>
> >>>>>>
> >>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
> >>>>>>>
> >>>>>>> [2]
> >>>>>>>
> >>>>>>
> >>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
> >>>>>>>
> >>>>>>>
> >>>>>>> Bests,
> >>>>>>> Godfrey
> >>>>>>>
> >>>>>>
> >>>>>>
> >>
> >>
> >
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

godfreyhe
Hi, Kurt

yes. `TableEnvironement#executeSql` also could execute `SELECT` statement,
which is similar to `Table#execute`.
I add this to the document.

Best,
Godfrey

Kurt Young <[hidden email]> 于2020年4月7日周二 上午11:52写道:

> +1 (binding)
>
> The latest doc looks good to me. One minor comment is with the latest
> changes, it seems also very easy
> to support running SELECT query in TableEnvironement#executeSql method.
> Will this also be supported?
>
> Best,
> Kurt
>
>
> On Mon, Apr 6, 2020 at 10:49 PM Timo Walther <[hidden email]> wrote:
>
> > Thanks, for the update.
> >
> > +1 (binding) for this FLIP
> >
> > Regards,
> > Timo
> >
> >
> > On 06.04.20 16:47, godfrey he wrote:
> > > Hi Timo,
> > >
> > > Sorry for late reply, and thanks for your correction. I have fixed the
> > typo
> > > and updated the document.
> > >
> > > Best,
> > > Godfrey
> > >
> > > Timo Walther <[hidden email]> 于2020年4月6日周一 下午6:05写道:
> > >
> > >> Hi Godfrey,
> > >>
> > >> did you see my remaining feedback in the discussion thread? We could
> > >> finish this FLIP if this gets resolved.
> > >>
> > >> Thanks,
> > >> Timo
> > >>
> > >> On 03.04.20 15:12, Terry Wang wrote:
> > >>> +1 (non-binding)
> > >>> Looks great to me, Thanks for driving on this.
> > >>>
> > >>> Best,
> > >>> Terry Wang
> > >>>
> > >>>
> > >>>
> > >>>> 2020年4月3日 21:07,godfrey he <[hidden email]> 写道:
> > >>>>
> > >>>> Hi everyone,
> > >>>>
> > >>>> I'd like to start the vote of FLIP-84[1] again, which is discussed
> and
> > >>>> reached consensus in the discussion thread[2].
> > >>>>
> > >>>> The vote will be open for at least 72 hours. Unless there is an
> > >> objection,
> > >>>> I will try to close it by Apr 6, 2020 13:10 UTC if we have received
> > >>>> sufficient votes.
> > >>>>
> > >>>>
> > >>>> [1]
> > >>>>
> > >>
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
> > >>>>
> > >>>> [2]
> > >>>>
> > >>
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
> > >>>>
> > >>>>
> > >>>> Bests,
> > >>>> Godfrey
> > >>>>
> > >>>> godfrey he <[hidden email]> 于2020年3月31日周二 下午8:42写道:
> > >>>>
> > >>>>> Hi, Timo
> > >>>>>
> > >>>>> So sorry about that, I'm in a little hurry. Let's wait for 24h.
> > >>>>>
> > >>>>> Best,
> > >>>>> Godfrey
> > >>>>>
> > >>>>> Timo Walther <[hidden email]> 于2020年3月31日周二 下午5:26写道:
> > >>>>>
> > >>>>>> -1
> > >>>>>>
> > >>>>>> The current discussion has not completed. The last comments were
> > sent
> > >>>>>> less than 24h ago.
> > >>>>>>
> > >>>>>> Let's wait a bit longer to collect feedback from all stakeholders.
> > >>>>>>
> > >>>>>> Thanks,
> > >>>>>> Timo
> > >>>>>>
> > >>>>>> On 31.03.20 08:31, godfrey he wrote:
> > >>>>>>> Hi everyone,
> > >>>>>>>
> > >>>>>>> I'd like to start the vote of FLIP-84[1] again, because we have
> > some
> > >>>>>>> feedbacks. The feedbacks are all about new introduced methods,
> here
> > >> is
> > >>>>>> the
> > >>>>>>> discussion thread [2].
> > >>>>>>>
> > >>>>>>> The vote will be open for at least 72 hours. Unless there is an
> > >>>>>> objection,
> > >>>>>>> I will try to close it by Apr 3, 2020 06:30 UTC if we have
> received
> > >>>>>>> sufficient votes.
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> [1]
> > >>>>>>>
> > >>>>>>
> > >>
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
> > >>>>>>>
> > >>>>>>> [2]
> > >>>>>>>
> > >>>>>>
> > >>
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
> > >>>>>>>
> > >>>>>>>
> > >>>>>>> Bests,
> > >>>>>>> Godfrey
> > >>>>>>>
> > >>>>>>
> > >>>>>>
> > >>
> > >>
> > >
> >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

dwysakowicz
+1

Best,

Dawid

On 07/04/2020 07:44, godfrey he wrote:

> Hi, Kurt
>
> yes. `TableEnvironement#executeSql` also could execute `SELECT` statement,
> which is similar to `Table#execute`.
> I add this to the document.
>
> Best,
> Godfrey
>
> Kurt Young <[hidden email]> 于2020年4月7日周二 上午11:52写道:
>
>> +1 (binding)
>>
>> The latest doc looks good to me. One minor comment is with the latest
>> changes, it seems also very easy
>> to support running SELECT query in TableEnvironement#executeSql method.
>> Will this also be supported?
>>
>> Best,
>> Kurt
>>
>>
>> On Mon, Apr 6, 2020 at 10:49 PM Timo Walther <[hidden email]> wrote:
>>
>>> Thanks, for the update.
>>>
>>> +1 (binding) for this FLIP
>>>
>>> Regards,
>>> Timo
>>>
>>>
>>> On 06.04.20 16:47, godfrey he wrote:
>>>> Hi Timo,
>>>>
>>>> Sorry for late reply, and thanks for your correction. I have fixed the
>>> typo
>>>> and updated the document.
>>>>
>>>> Best,
>>>> Godfrey
>>>>
>>>> Timo Walther <[hidden email]> 于2020年4月6日周一 下午6:05写道:
>>>>
>>>>> Hi Godfrey,
>>>>>
>>>>> did you see my remaining feedback in the discussion thread? We could
>>>>> finish this FLIP if this gets resolved.
>>>>>
>>>>> Thanks,
>>>>> Timo
>>>>>
>>>>> On 03.04.20 15:12, Terry Wang wrote:
>>>>>> +1 (non-binding)
>>>>>> Looks great to me, Thanks for driving on this.
>>>>>>
>>>>>> Best,
>>>>>> Terry Wang
>>>>>>
>>>>>>
>>>>>>
>>>>>>> 2020年4月3日 21:07,godfrey he <[hidden email]> 写道:
>>>>>>>
>>>>>>> Hi everyone,
>>>>>>>
>>>>>>> I'd like to start the vote of FLIP-84[1] again, which is discussed
>> and
>>>>>>> reached consensus in the discussion thread[2].
>>>>>>>
>>>>>>> The vote will be open for at least 72 hours. Unless there is an
>>>>> objection,
>>>>>>> I will try to close it by Apr 6, 2020 13:10 UTC if we have received
>>>>>>> sufficient votes.
>>>>>>>
>>>>>>>
>>>>>>> [1]
>>>>>>>
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
>>>>>>> [2]
>>>>>>>
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
>>>>>>>
>>>>>>> Bests,
>>>>>>> Godfrey
>>>>>>>
>>>>>>> godfrey he <[hidden email]> 于2020年3月31日周二 下午8:42写道:
>>>>>>>
>>>>>>>> Hi, Timo
>>>>>>>>
>>>>>>>> So sorry about that, I'm in a little hurry. Let's wait for 24h.
>>>>>>>>
>>>>>>>> Best,
>>>>>>>> Godfrey
>>>>>>>>
>>>>>>>> Timo Walther <[hidden email]> 于2020年3月31日周二 下午5:26写道:
>>>>>>>>
>>>>>>>>> -1
>>>>>>>>>
>>>>>>>>> The current discussion has not completed. The last comments were
>>> sent
>>>>>>>>> less than 24h ago.
>>>>>>>>>
>>>>>>>>> Let's wait a bit longer to collect feedback from all stakeholders.
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Timo
>>>>>>>>>
>>>>>>>>> On 31.03.20 08:31, godfrey he wrote:
>>>>>>>>>> Hi everyone,
>>>>>>>>>>
>>>>>>>>>> I'd like to start the vote of FLIP-84[1] again, because we have
>>> some
>>>>>>>>>> feedbacks. The feedbacks are all about new introduced methods,
>> here
>>>>> is
>>>>>>>>> the
>>>>>>>>>> discussion thread [2].
>>>>>>>>>>
>>>>>>>>>> The vote will be open for at least 72 hours. Unless there is an
>>>>>>>>> objection,
>>>>>>>>>> I will try to close it by Apr 3, 2020 06:30 UTC if we have
>> received
>>>>>>>>>> sufficient votes.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> [1]
>>>>>>>>>>
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
>>>>>>>>>> [2]
>>>>>>>>>>
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
>>>>>>>>>>
>>>>>>>>>> Bests,
>>>>>>>>>> Godfrey
>>>>>>>>>>
>>>>>>>>>
>>>>>
>>>


signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-84: Improve & Refactor API of TableEnvironment & Table

godfreyhe
Hi everyone,

Thanks all for the votes.
So far, we have

   - 3 binding +1 votes (Timo, Kurt, Dawid)
   - 1 non-binding +1 votes (Terry)
   - No -1 votes

The voting time has past and there is enough +1 votes to consider the FLIP-84
approved.
Thank you all.


Best,
Godfrey

Dawid Wysakowicz <[hidden email]> 于2020年4月7日周二 下午2:29写道:

> +1
>
> Best,
>
> Dawid
>
> On 07/04/2020 07:44, godfrey he wrote:
> > Hi, Kurt
> >
> > yes. `TableEnvironement#executeSql` also could execute `SELECT`
> statement,
> > which is similar to `Table#execute`.
> > I add this to the document.
> >
> > Best,
> > Godfrey
> >
> > Kurt Young <[hidden email]> 于2020年4月7日周二 上午11:52写道:
> >
> >> +1 (binding)
> >>
> >> The latest doc looks good to me. One minor comment is with the latest
> >> changes, it seems also very easy
> >> to support running SELECT query in TableEnvironement#executeSql method.
> >> Will this also be supported?
> >>
> >> Best,
> >> Kurt
> >>
> >>
> >> On Mon, Apr 6, 2020 at 10:49 PM Timo Walther <[hidden email]>
> wrote:
> >>
> >>> Thanks, for the update.
> >>>
> >>> +1 (binding) for this FLIP
> >>>
> >>> Regards,
> >>> Timo
> >>>
> >>>
> >>> On 06.04.20 16:47, godfrey he wrote:
> >>>> Hi Timo,
> >>>>
> >>>> Sorry for late reply, and thanks for your correction. I have fixed the
> >>> typo
> >>>> and updated the document.
> >>>>
> >>>> Best,
> >>>> Godfrey
> >>>>
> >>>> Timo Walther <[hidden email]> 于2020年4月6日周一 下午6:05写道:
> >>>>
> >>>>> Hi Godfrey,
> >>>>>
> >>>>> did you see my remaining feedback in the discussion thread? We could
> >>>>> finish this FLIP if this gets resolved.
> >>>>>
> >>>>> Thanks,
> >>>>> Timo
> >>>>>
> >>>>> On 03.04.20 15:12, Terry Wang wrote:
> >>>>>> +1 (non-binding)
> >>>>>> Looks great to me, Thanks for driving on this.
> >>>>>>
> >>>>>> Best,
> >>>>>> Terry Wang
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>> 2020年4月3日 21:07,godfrey he <[hidden email]> 写道:
> >>>>>>>
> >>>>>>> Hi everyone,
> >>>>>>>
> >>>>>>> I'd like to start the vote of FLIP-84[1] again, which is discussed
> >> and
> >>>>>>> reached consensus in the discussion thread[2].
> >>>>>>>
> >>>>>>> The vote will be open for at least 72 hours. Unless there is an
> >>>>> objection,
> >>>>>>> I will try to close it by Apr 6, 2020 13:10 UTC if we have received
> >>>>>>> sufficient votes.
> >>>>>>>
> >>>>>>>
> >>>>>>> [1]
> >>>>>>>
> >>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
> >>>>>>> [2]
> >>>>>>>
> >>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
> >>>>>>>
> >>>>>>> Bests,
> >>>>>>> Godfrey
> >>>>>>>
> >>>>>>> godfrey he <[hidden email]> 于2020年3月31日周二 下午8:42写道:
> >>>>>>>
> >>>>>>>> Hi, Timo
> >>>>>>>>
> >>>>>>>> So sorry about that, I'm in a little hurry. Let's wait for 24h.
> >>>>>>>>
> >>>>>>>> Best,
> >>>>>>>> Godfrey
> >>>>>>>>
> >>>>>>>> Timo Walther <[hidden email]> 于2020年3月31日周二 下午5:26写道:
> >>>>>>>>
> >>>>>>>>> -1
> >>>>>>>>>
> >>>>>>>>> The current discussion has not completed. The last comments were
> >>> sent
> >>>>>>>>> less than 24h ago.
> >>>>>>>>>
> >>>>>>>>> Let's wait a bit longer to collect feedback from all
> stakeholders.
> >>>>>>>>>
> >>>>>>>>> Thanks,
> >>>>>>>>> Timo
> >>>>>>>>>
> >>>>>>>>> On 31.03.20 08:31, godfrey he wrote:
> >>>>>>>>>> Hi everyone,
> >>>>>>>>>>
> >>>>>>>>>> I'd like to start the vote of FLIP-84[1] again, because we have
> >>> some
> >>>>>>>>>> feedbacks. The feedbacks are all about new introduced methods,
> >> here
> >>>>> is
> >>>>>>>>> the
> >>>>>>>>>> discussion thread [2].
> >>>>>>>>>>
> >>>>>>>>>> The vote will be open for at least 72 hours. Unless there is an
> >>>>>>>>> objection,
> >>>>>>>>>> I will try to close it by Apr 3, 2020 06:30 UTC if we have
> >> received
> >>>>>>>>>> sufficient votes.
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> [1]
> >>>>>>>>>>
> >>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=134745878
> >>>>>>>>>> [2]
> >>>>>>>>>>
> >>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-84-Feedback-Summary-td39261.html
> >>>>>>>>>>
> >>>>>>>>>> Bests,
> >>>>>>>>>> Godfrey
> >>>>>>>>>>
> >>>>>>>>>
> >>>>>
> >>>
>
>