[VOTE] FLIP-63: Rework table partition support
Locked
[VOTE] FLIP-63: Rework table partition support
Re: [VOTE] FLIP-63: Rework table partition support
Re: [VOTE] FLIP-63: Rework table partition support
Re: [VOTE] FLIP-63: Rework table partition support
Re: [VOTE] FLIP-63: Rework table partition support
 
|
+1 from my side. Some implementation details could be revisited
again during code reviewing. Best, Kurt On Tue, Sep 24, 2019 at 3:14 PM Jingsong Li <[hidden email]> wrote: > Just to clarify: > > FLIP wiki: > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-63%3A+Rework+table+partition+support > > > Discussion thread: > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-63-Rework-table-partition-support-td32770.html > > > Google Doc: > > https://docs.google.com/document/d/15R3vZ1R_pAHcvJkRx_CWleXgl08WL3k_ZpnWSdzP7GY/edit?usp=sharing > > Best, > Jingsong Lee > > On Tue, Sep 24, 2019 at 11:43 AM Jingsong Lee <[hidden email]> > wrote: > > > Thank you for your reminder. > > Updated. > > > > Best, > > Jingsong Lee > > > > On Tue, Sep 24, 2019 at 11:36 AM Kurt Young <[hidden email]> wrote: > > > >> Looks like the wiki is not aligned with latest google doc, could > >> you update it first? > >> > >> Best, > >> Kurt > >> > >> > >> On Tue, Sep 24, 2019 at 10:19 AM Jingsong Lee <[hidden email]> > >> wrote: > >> > >> > Hi Flink devs, after another round of discussion. > >> > > >> > I would like to re-start the voting for FLIP-63 > >> > Rework table partition support. > >> > > >> > FLIP wiki: > >> > < > >> > > >> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-33%3A+Standardize+Connector+Metrics > >> > > > >> > < > >> > > >> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-51%3A+Rework+of+the+Expression+Design > >> > > > >> > > >> > > >> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-63%3A+Rework+table+partition+support > >> > > >> > Discussion thread: > >> > < > >> > > >> > https://lists.apache.org/thread.html/65078bad6e04bbbb7578d502e1e5d92026f13fd9648725f5b74ed330@%3Cdev.flink.apache.org%3E > >> > > > >> > < > >> > > >> > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-51-Rework-of-the-Expression-Design-td31653.html > >> > > > >> > > >> > > >> > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-63-Rework-table-partition-support-td32770.html > >> > > >> > Google Doc: > >> > < > >> > > >> > https://docs.google.com/document/d/1yFDyquMo_-VZ59vyhaMshpPtg7p87b9IYdAtMXv5XmM/edit?usp=sharing > >> > > > >> > > >> > > >> > https://docs.google.com/document/d/15R3vZ1R_pAHcvJkRx_CWleXgl08WL3k_ZpnWSdzP7GY/edit?usp=sharing > >> > > >> > Thanks, > >> > > >> > Best, > >> > Jingsong Lee > >> > > >> > > > > > > -- > > Best, Jingsong Lee > > > > > -- > Best, Jingsong Lee > |
Re: [VOTE] FLIP-63: Rework table partition support
|
|
+1, Overall looks good.
Best, Terry Wang > 在 2019年9月24日，下午5:02，Kurt Young <[hidden email]> 写道： > > +1 from my side. Some implementation details could be revisited > again during code reviewing. > > Best, > Kurt > > > On Tue, Sep 24, 2019 at 3:14 PM Jingsong Li <[hidden email]> wrote: > >> Just to clarify: >> >> FLIP wiki: >> >> >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-63%3A+Rework+table+partition+support >> >> >> Discussion thread: >> >> >> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-63-Rework-table-partition-support-td32770.html >> >> >> Google Doc: >> >> https://docs.google.com/document/d/15R3vZ1R_pAHcvJkRx_CWleXgl08WL3k_ZpnWSdzP7GY/edit?usp=sharing >> >> Best, >> Jingsong Lee >> >> On Tue, Sep 24, 2019 at 11:43 AM Jingsong Lee <[hidden email]> >> wrote: >> >>> Thank you for your reminder. >>> Updated. >>> >>> Best, >>> Jingsong Lee >>> >>> On Tue, Sep 24, 2019 at 11:36 AM Kurt Young <[hidden email]> wrote: >>> >>>> Looks like the wiki is not aligned with latest google doc, could >>>> you update it first? >>>> >>>> Best, >>>> Kurt >>>> >>>> >>>> On Tue, Sep 24, 2019 at 10:19 AM Jingsong Lee <[hidden email]> >>>> wrote: >>>> >>>>> Hi Flink devs, after another round of discussion. >>>>> >>>>> I would like to re-start the voting for FLIP-63 >>>>> Rework table partition support. >>>>> >>>>> FLIP wiki: >>>>> < >>>>> >>>> >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-33%3A+Standardize+Connector+Metrics >>>>>> >>>>> < >>>>> >>>> >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-51%3A+Rework+of+the+Expression+Design >>>>>> >>>>> >>>>> >>>> >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-63%3A+Rework+table+partition+support >>>>> >>>>> Discussion thread: >>>>> < >>>>> >>>> >> https://lists.apache.org/thread.html/65078bad6e04bbbb7578d502e1e5d92026f13fd9648725f5b74ed330@%3Cdev.flink.apache.org%3E >>>>>> >>>>> < >>>>> >>>> >> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-51-Rework-of-the-Expression-Design-td31653.html >>>>>> >>>>> >>>>> >>>> >> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-63-Rework-table-partition-support-td32770.html >>>>> >>>>> Google Doc: >>>>> < >>>>> >>>> >> https://docs.google.com/document/d/1yFDyquMo_-VZ59vyhaMshpPtg7p87b9IYdAtMXv5XmM/edit?usp=sharing >>>>>> >>>>> >>>>> >>>> >> https://docs.google.com/document/d/15R3vZ1R_pAHcvJkRx_CWleXgl08WL3k_ZpnWSdzP7GY/edit?usp=sharing >>>>> >>>>> Thanks, >>>>> >>>>> Best, >>>>> Jingsong Lee >>>>> >>>> >>> >>> >>> -- >>> Best, Jingsong Lee >>> >> >> >> -- >> Best, Jingsong Lee >> |
|
|
+1. Thanks, Jingsong!
Bowen On Tue, Sep 24, 2019 at 4:38 AM Terry Wang <[hidden email]> wrote: > +1, Overall looks good. > > Best, > Terry Wang > > > > > 在 2019年9月24日，下午5:02，Kurt Young <[hidden email]> 写道： > > > > +1 from my side. Some implementation details could be revisited > > again during code reviewing. > > > > Best, > > Kurt > > > > > > On Tue, Sep 24, 2019 at 3:14 PM Jingsong Li <[hidden email]> > wrote: > > > >> Just to clarify: > >> > >> FLIP wiki: > >> > >> > >> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-63%3A+Rework+table+partition+support > >> > >> > >> Discussion thread: > >> > >> > >> > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-63-Rework-table-partition-support-td32770.html > >> > >> > >> Google Doc: > >> > >> > https://docs.google.com/document/d/15R3vZ1R_pAHcvJkRx_CWleXgl08WL3k_ZpnWSdzP7GY/edit?usp=sharing > >> > >> Best, > >> Jingsong Lee > >> > >> On Tue, Sep 24, 2019 at 11:43 AM Jingsong Lee <[hidden email]> > >> wrote: > >> > >>> Thank you for your reminder. > >>> Updated. > >>> > >>> Best, > >>> Jingsong Lee > >>> > >>> On Tue, Sep 24, 2019 at 11:36 AM Kurt Young <[hidden email]> wrote: > >>> > >>>> Looks like the wiki is not aligned with latest google doc, could > >>>> you update it first? > >>>> > >>>> Best, > >>>> Kurt > >>>> > >>>> > >>>> On Tue, Sep 24, 2019 at 10:19 AM Jingsong Lee < > [hidden email]> > >>>> wrote: > >>>> > >>>>> Hi Flink devs, after another round of discussion. > >>>>> > >>>>> I would like to re-start the voting for FLIP-63 > >>>>> Rework table partition support. > >>>>> > >>>>> FLIP wiki: > >>>>> < > >>>>> > >>>> > >> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-33%3A+Standardize+Connector+Metrics > >>>>>> > >>>>> < > >>>>> > >>>> > >> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-51%3A+Rework+of+the+Expression+Design > >>>>>> > >>>>> > >>>>> > >>>> > >> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-63%3A+Rework+table+partition+support > >>>>> > >>>>> Discussion thread: > >>>>> < > >>>>> > >>>> > >> > https://lists.apache.org/thread.html/65078bad6e04bbbb7578d502e1e5d92026f13fd9648725f5b74ed330@%3Cdev.flink.apache.org%3E > >>>>>> > >>>>> < > >>>>> > >>>> > >> > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-51-Rework-of-the-Expression-Design-td31653.html > >>>>>> > >>>>> > >>>>> > >>>> > >> > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-63-Rework-table-partition-support-td32770.html > >>>>> > >>>>> Google Doc: > >>>>> < > >>>>> > >>>> > >> > https://docs.google.com/document/d/1yFDyquMo_-VZ59vyhaMshpPtg7p87b9IYdAtMXv5XmM/edit?usp=sharing > >>>>>> > >>>>> > >>>>> > >>>> > >> > https://docs.google.com/document/d/15R3vZ1R_pAHcvJkRx_CWleXgl08WL3k_ZpnWSdzP7GY/edit?usp=sharing > >>>>> > >>>>> Thanks, > >>>>> > >>>>> Best, > >>>>> Jingsong Lee > >>>>> > >>>> > >>> > >>> > >>> -- > >>> Best, Jingsong Lee > >>> > >> > >> > >> -- > >> Best, Jingsong Lee > >> > > |
|
|
+1. I understand that the FLIP probably covers more we can do in one
release, but let's proritize and start with the basics first. On Tue, Sep 24, 2019 at 10:42 AM Bowen Li <[hidden email]> wrote: > +1. Thanks, Jingsong! > > Bowen > > On Tue, Sep 24, 2019 at 4:38 AM Terry Wang <[hidden email]> wrote: > > > +1, Overall looks good. > > > > Best, > > Terry Wang > > > > > > > > > 在 2019年9月24日，下午5:02，Kurt Young <[hidden email]> 写道： > > > > > > +1 from my side. Some implementation details could be revisited > > > again during code reviewing. > > > > > > Best, > > > Kurt > > > > > > > > > On Tue, Sep 24, 2019 at 3:14 PM Jingsong Li <[hidden email]> > > wrote: > > > > > >> Just to clarify: > > >> > > >> FLIP wiki: > > >> > > >> > > >> > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-63%3A+Rework+table+partition+support > > >> > > >> > > >> Discussion thread: > > >> > > >> > > >> > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-63-Rework-table-partition-support-td32770.html > > >> > > >> > > >> Google Doc: > > >> > > >> > > > https://docs.google.com/document/d/15R3vZ1R_pAHcvJkRx_CWleXgl08WL3k_ZpnWSdzP7GY/edit?usp=sharing > > >> > > >> Best, > > >> Jingsong Lee > > >> > > >> On Tue, Sep 24, 2019 at 11:43 AM Jingsong Lee < > [hidden email]> > > >> wrote: > > >> > > >>> Thank you for your reminder. > > >>> Updated. > > >>> > > >>> Best, > > >>> Jingsong Lee > > >>> > > >>> On Tue, Sep 24, 2019 at 11:36 AM Kurt Young <[hidden email]> > wrote: > > >>> > > >>>> Looks like the wiki is not aligned with latest google doc, could > > >>>> you update it first? > > >>>> > > >>>> Best, > > >>>> Kurt > > >>>> > > >>>> > > >>>> On Tue, Sep 24, 2019 at 10:19 AM Jingsong Lee < > > [hidden email]> > > >>>> wrote: > > >>>> > > >>>>> Hi Flink devs, after another round of discussion. > > >>>>> > > >>>>> I would like to re-start the voting for FLIP-63 > > >>>>> Rework table partition support. > > >>>>> > > >>>>> FLIP wiki: > > >>>>> < > > >>>>> > > >>>> > > >> > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-33%3A+Standardize+Connector+Metrics > > >>>>>> > > >>>>> < > > >>>>> > > >>>> > > >> > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-51%3A+Rework+of+the+Expression+Design > > >>>>>> > > >>>>> > > >>>>> > > >>>> > > >> > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-63%3A+Rework+table+partition+support > > >>>>> > > >>>>> Discussion thread: > > >>>>> < > > >>>>> > > >>>> > > >> > > > https://lists.apache.org/thread.html/65078bad6e04bbbb7578d502e1e5d92026f13fd9648725f5b74ed330@%3Cdev.flink.apache.org%3E > > >>>>>> > > >>>>> < > > >>>>> > > >>>> > > >> > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-51-Rework-of-the-Expression-Design-td31653.html > > >>>>>> > > >>>>> > > >>>>> > > >>>> > > >> > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-63-Rework-table-partition-support-td32770.html > > >>>>> > > >>>>> Google Doc: > > >>>>> < > > >>>>> > > >>>> > > >> > > > https://docs.google.com/document/d/1yFDyquMo_-VZ59vyhaMshpPtg7p87b9IYdAtMXv5XmM/edit?usp=sharing > > >>>>>> > > >>>>> > > >>>>> > > >>>> > > >> > > > https://docs.google.com/document/d/15R3vZ1R_pAHcvJkRx_CWleXgl08WL3k_ZpnWSdzP7GY/edit?usp=sharing > > >>>>> > > >>>>> Thanks, > > >>>>> > > >>>>> Best, > > >>>>> Jingsong Lee > > >>>>> > > >>>> > > >>> > > >>> > > >>> -- > > >>> Best, Jingsong Lee > > >>> > > >> > > >> > > >> -- > > >> Best, Jingsong Lee > > >> > > > > > -- Xuefu Zhang "In Honey We Trust!" |
|
|
+1. Thanks Jingsong for the efforts.
On Wed, Sep 25, 2019 at 4:50 AM Xuefu Z <[hidden email]> wrote: > +1. I understand that the FLIP probably covers more we can do in one > release, but let's proritize and start with the basics first. > > On Tue, Sep 24, 2019 at 10:42 AM Bowen Li <[hidden email]> wrote: > > > +1. Thanks, Jingsong! > > > > Bowen > > > > On Tue, Sep 24, 2019 at 4:38 AM Terry Wang <[hidden email]> wrote: > > > > > +1, Overall looks good. > > > > > > Best, > > > Terry Wang > > > > > > > > > > > > > 在 2019年9月24日，下午5:02，Kurt Young <[hidden email]> 写道： > > > > > > > > +1 from my side. Some implementation details could be revisited > > > > again during code reviewing. > > > > > > > > Best, > > > > Kurt > > > > > > > > > > > > On Tue, Sep 24, 2019 at 3:14 PM Jingsong Li <[hidden email]> > > > wrote: > > > > > > > >> Just to clarify: > > > >> > > > >> FLIP wiki: > > > >> > > > >> > > > >> > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-63%3A+Rework+table+partition+support > > > >> > > > >> > > > >> Discussion thread: > > > >> > > > >> > > > >> > > > > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-63-Rework-table-partition-support-td32770.html > > > >> > > > >> > > > >> Google Doc: > > > >> > > > >> > > > > > > https://docs.google.com/document/d/15R3vZ1R_pAHcvJkRx_CWleXgl08WL3k_ZpnWSdzP7GY/edit?usp=sharing > > > >> > > > >> Best, > > > >> Jingsong Lee > > > >> > > > >> On Tue, Sep 24, 2019 at 11:43 AM Jingsong Lee < > > [hidden email]> > > > >> wrote: > > > >> > > > >>> Thank you for your reminder. > > > >>> Updated. > > > >>> > > > >>> Best, > > > >>> Jingsong Lee > > > >>> > > > >>> On Tue, Sep 24, 2019 at 11:36 AM Kurt Young <[hidden email]> > > wrote: > > > >>> > > > >>>> Looks like the wiki is not aligned with latest google doc, could > > > >>>> you update it first? > > > >>>> > > > >>>> Best, > > > >>>> Kurt > > > >>>> > > > >>>> > > > >>>> On Tue, Sep 24, 2019 at 10:19 AM Jingsong Lee < > > > [hidden email]> > > > >>>> wrote: > > > >>>> > > > >>>>> Hi Flink devs, after another round of discussion. > > > >>>>> > > > >>>>> I would like to re-start the voting for FLIP-63 > > > >>>>> Rework table partition support. > > > >>>>> > > > >>>>> FLIP wiki: > > > >>>>> < > > > >>>>> > > > >>>> > > > >> > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-33%3A+Standardize+Connector+Metrics > > > >>>>>> > > > >>>>> < > > > >>>>> > > > >>>> > > > >> > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-51%3A+Rework+of+the+Expression+Design > > > >>>>>> > > > >>>>> > > > >>>>> > > > >>>> > > > >> > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-63%3A+Rework+table+partition+support > > > >>>>> > > > >>>>> Discussion thread: > > > >>>>> < > > > >>>>> > > > >>>> > > > >> > > > > > > https://lists.apache.org/thread.html/65078bad6e04bbbb7578d502e1e5d92026f13fd9648725f5b74ed330@%3Cdev.flink.apache.org%3E > > > >>>>>> > > > >>>>> < > > > >>>>> > > > >>>> > > > >> > > > > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-51-Rework-of-the-Expression-Design-td31653.html > > > >>>>>> > > > >>>>> > > > >>>>> > > > >>>> > > > >> > > > > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-63-Rework-table-partition-support-td32770.html > > > >>>>> > > > >>>>> Google Doc: > > > >>>>> < > > > >>>>> > > > >>>> > > > >> > > > > > > https://docs.google.com/document/d/1yFDyquMo_-VZ59vyhaMshpPtg7p87b9IYdAtMXv5XmM/edit?usp=sharing > > > >>>>>> > > > >>>>> > > > >>>>> > > > >>>> > > > >> > > > > > > https://docs.google.com/document/d/15R3vZ1R_pAHcvJkRx_CWleXgl08WL3k_ZpnWSdzP7GY/edit?usp=sharing > > > >>>>> > > > >>>>> Thanks, > > > >>>>> > > > >>>>> Best, > > > >>>>> Jingsong Lee > > > >>>>> > > > >>>> > > > >>> > > > >>> > > > >>> -- > > > >>> Best, Jingsong Lee > > > >>> > > > >> > > > >> > > > >> -- > > > >> Best, Jingsong Lee > > > >> > > > > > > > > > > > -- > Xuefu Zhang > > "In Honey We Trust!" > -- Best regards! Rui Li |
|
|
Hi,
After some discussion with Jinsong, the FLIP is slightly updated with the following 2 changes, which will not take too much time to agree on. 1) the proposed create partition table grammar is **limited to hive dialect** (via `TableConfig.setSqlDialect(HIVE)`). Flink's create partition table grammar (like Spark SQL?) will be discussed in the future. 2) a better name/method for `PartitionableTableSink#configurePartitionGrouping` is excluded from this FLIP and will be discussed in the future. You can see the changes through the link [1]. With above changes, I'm +1 to the FLIP. Thanks Jingsong for driving this. Best, Jark [1] https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=127406488&selectedPageVersions=9&selectedPageVersions=7 On Wed, 25 Sep 2019 at 10:23, Rui Li <[hidden email]> wrote: > +1. Thanks Jingsong for the efforts. > > On Wed, Sep 25, 2019 at 4:50 AM Xuefu Z <[hidden email]> wrote: > > > +1. I understand that the FLIP probably covers more we can do in one > > release, but let's proritize and start with the basics first. > > > > On Tue, Sep 24, 2019 at 10:42 AM Bowen Li <[hidden email]> wrote: > > > > > +1. Thanks, Jingsong! > > > > > > Bowen > > > > > > On Tue, Sep 24, 2019 at 4:38 AM Terry Wang <[hidden email]> wrote: > > > > > > > +1, Overall looks good. > > > > > > > > Best, > > > > Terry Wang > > > > > > > > > > > > > > > > > 在 2019年9月24日，下午5:02，Kurt Young <[hidden email]> 写道： > > > > > > > > > > +1 from my side. Some implementation details could be revisited > > > > > again during code reviewing. > > > > > > > > > > Best, > > > > > Kurt > > > > > > > > > > > > > > > On Tue, Sep 24, 2019 at 3:14 PM Jingsong Li < > [hidden email]> > > > > wrote: > > > > > > > > > >> Just to clarify: > > > > >> > > > > >> FLIP wiki: > > > > >> > > > > >> > > > > >> > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-63%3A+Rework+table+partition+support > > > > >> > > > > >> > > > > >> Discussion thread: > > > > >> > > > > >> > > > > >> > > > > > > > > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-63-Rework-table-partition-support-td32770.html > > > > >> > > > > >> > > > > >> Google Doc: > > > > >> > > > > >> > > > > > > > > > > https://docs.google.com/document/d/15R3vZ1R_pAHcvJkRx_CWleXgl08WL3k_ZpnWSdzP7GY/edit?usp=sharing > > > > >> > > > > >> Best, > > > > >> Jingsong Lee > > > > >> > > > > >> On Tue, Sep 24, 2019 at 11:43 AM Jingsong Lee < > > > [hidden email]> > > > > >> wrote: > > > > >> > > > > >>> Thank you for your reminder. > > > > >>> Updated. > > > > >>> > > > > >>> Best, > > > > >>> Jingsong Lee > > > > >>> > > > > >>> On Tue, Sep 24, 2019 at 11:36 AM Kurt Young <[hidden email]> > > > wrote: > > > > >>> > > > > >>>> Looks like the wiki is not aligned with latest google doc, could > > > > >>>> you update it first? > > > > >>>> > > > > >>>> Best, > > > > >>>> Kurt > > > > >>>> > > > > >>>> > > > > >>>> On Tue, Sep 24, 2019 at 10:19 AM Jingsong Lee < > > > > [hidden email]> > > > > >>>> wrote: > > > > >>>> > > > > >>>>> Hi Flink devs, after another round of discussion. > > > > >>>>> > > > > >>>>> I would like to re-start the voting for FLIP-63 > > > > >>>>> Rework table partition support. > > > > >>>>> > > > > >>>>> FLIP wiki: > > > > >>>>> < > > > > >>>>> > > > > >>>> > > > > >> > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-33%3A+Standardize+Connector+Metrics > > > > >>>>>> > > > > >>>>> < > > > > >>>>> > > > > >>>> > > > > >> > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-51%3A+Rework+of+the+Expression+Design > > > > >>>>>> > > > > >>>>> > > > > >>>>> > > > > >>>> > > > > >> > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-63%3A+Rework+table+partition+support > > > > >>>>> > > > > >>>>> Discussion thread: > > > > >>>>> < > > > > >>>>> > > > > >>>> > > > > >> > > > > > > > > > > https://lists.apache.org/thread.html/65078bad6e04bbbb7578d502e1e5d92026f13fd9648725f5b74ed330@%3Cdev.flink.apache.org%3E > > > > >>>>>> > > > > >>>>> < > > > > >>>>> > > > > >>>> > > > > >> > > > > > > > > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-51-Rework-of-the-Expression-Design-td31653.html > > > > >>>>>> > > > > >>>>> > > > > >>>>> > > > > >>>> > > > > >> > > > > > > > > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-63-Rework-table-partition-support-td32770.html > > > > >>>>> > > > > >>>>> Google Doc: > > > > >>>>> < > > > > >>>>> > > > > >>>> > > > > >> > > > > > > > > > > https://docs.google.com/document/d/1yFDyquMo_-VZ59vyhaMshpPtg7p87b9IYdAtMXv5XmM/edit?usp=sharing > > > > >>>>>> > > > > >>>>> > > > > >>>>> > > > > >>>> > > > > >> > > > > > > > > > > https://docs.google.com/document/d/15R3vZ1R_pAHcvJkRx_CWleXgl08WL3k_ZpnWSdzP7GY/edit?usp=sharing > > > > >>>>> > > > > >>>>> Thanks, > > > > >>>>> > > > > >>>>> Best, > > > > >>>>> Jingsong Lee > > > > >>>>> > > > > >>>> > > > > >>> > > > > >>> > > > > >>> -- > > > > >>> Best, Jingsong Lee > > > > >>> > > > > >> > > > > >> > > > > >> -- > > > > >> Best, Jingsong Lee > > > > >> > > > > > > > > > > > > > > > > > -- > > Xuefu Zhang > > > > "In Honey We Trust!" > > > > > -- > Best regards! > Rui Li > |
Re: [VOTE] FLIP-63: Rework table partition support
|
|
Thanks for the votes!
We have 3 binding +1's from Kurt, Jark, Bowen. Have 3 non-binding +1's from xuefu, terry, rui. Thank you for the vote. Since there are no disapproving votes and the voting time has passed, I will see this FLIP as approved to be adopted into Apache Flink. Best, Jingsong Lee ------------------------------------------------------------------ From:Jark Wu <[hidden email]> Send Time:2019年9月26日(星期四) 11:02 To:dev <[hidden email]> Subject:Re: [VOTE] FLIP-63: Rework table partition support Hi, After some discussion with Jinsong, the FLIP is slightly updated with the following 2 changes, which will not take too much time to agree on. 1) the proposed create partition table grammar is **limited to hive dialect** (via `TableConfig.setSqlDialect(HIVE)`). Flink's create partition table grammar (like Spark SQL?) will be discussed in the future. 2) a better name/method for `PartitionableTableSink#configurePartitionGrouping` is excluded from this FLIP and will be discussed in the future. You can see the changes through the link [1]. With above changes, I'm +1 to the FLIP. Thanks Jingsong for driving this. Best, Jark [1] https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=127406488&selectedPageVersions=9&selectedPageVersions=7 On Wed, 25 Sep 2019 at 10:23, Rui Li <[hidden email]> wrote: > +1. Thanks Jingsong for the efforts. > > On Wed, Sep 25, 2019 at 4:50 AM Xuefu Z <[hidden email]> wrote: > > > +1. I understand that the FLIP probably covers more we can do in one > > release, but let's proritize and start with the basics first. > > > > On Tue, Sep 24, 2019 at 10:42 AM Bowen Li <[hidden email]> wrote: > > > > > +1. Thanks, Jingsong! > > > > > > Bowen > > > > > > On Tue, Sep 24, 2019 at 4:38 AM Terry Wang <[hidden email]> wrote: > > > > > > > +1, Overall looks good. > > > > > > > > Best, > > > > Terry Wang > > > > > > > > > > > > > > > > > 在 2019年9月24日，下午5:02，Kurt Young <[hidden email]> 写道： > > > > > > > > > > +1 from my side. Some implementation details could be revisited > > > > > again during code reviewing. > > > > > > > > > > Best, > > > > > Kurt > > > > > > > > > > > > > > > On Tue, Sep 24, 2019 at 3:14 PM Jingsong Li < > [hidden email]> > > > > wrote: > > > > > > > > > >> Just to clarify: > > > > >> > > > > >> FLIP wiki: > > > > >> > > > > >> > > > > >> > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-63%3A+Rework+table+partition+support > > > > >> > > > > >> > > > > >> Discussion thread: > > > > >> > > > > >> > > > > >> > > > > > > > > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-63-Rework-table-partition-support-td32770.html > > > > >> > > > > >> > > > > >> Google Doc: > > > > >> > > > > >> > > > > > > > > > > https://docs.google.com/document/d/15R3vZ1R_pAHcvJkRx_CWleXgl08WL3k_ZpnWSdzP7GY/edit?usp=sharing > > > > >> > > > > >> Best, > > > > >> Jingsong Lee > > > > >> > > > > >> On Tue, Sep 24, 2019 at 11:43 AM Jingsong Lee < > > > [hidden email]> > > > > >> wrote: > > > > >> > > > > >>> Thank you for your reminder. > > > > >>> Updated. > > > > >>> > > > > >>> Best, > > > > >>> Jingsong Lee > > > > >>> > > > > >>> On Tue, Sep 24, 2019 at 11:36 AM Kurt Young <[hidden email]> > > > wrote: > > > > >>> > > > > >>>> Looks like the wiki is not aligned with latest google doc, could > > > > >>>> you update it first? > > > > >>>> > > > > >>>> Best, > > > > >>>> Kurt > > > > >>>> > > > > >>>> > > > > >>>> On Tue, Sep 24, 2019 at 10:19 AM Jingsong Lee < > > > > [hidden email]> > > > > >>>> wrote: > > > > >>>> > > > > >>>>> Hi Flink devs, after another round of discussion. > > > > >>>>> > > > > >>>>> I would like to re-start the voting for FLIP-63 > > > > >>>>> Rework table partition support. > > > > >>>>> > > > > >>>>> FLIP wiki: > > > > >>>>> < > > > > >>>>> > > > > >>>> > > > > >> > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-33%3A+Standardize+Connector+Metrics > > > > >>>>>> > > > > >>>>> < > > > > >>>>> > > > > >>>> > > > > >> > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-51%3A+Rework+of+the+Expression+Design > > > > >>>>>> > > > > >>>>> > > > > >>>>> > > > > >>>> > > > > >> > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-63%3A+Rework+table+partition+support > > > > >>>>> > > > > >>>>> Discussion thread: > > > > >>>>> < > > > > >>>>> > > > > >>>> > > > > >> > > > > > > > > > > https://lists.apache.org/thread.html/65078bad6e04bbbb7578d502e1e5d92026f13fd9648725f5b74ed330@%3Cdev.flink.apache.org%3E > > > > >>>>>> > > > > >>>>> < > > > > >>>>> > > > > >>>> > > > > >> > > > > > > > > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-51-Rework-of-the-Expression-Design-td31653.html > > > > >>>>>> > > > > >>>>> > > > > >>>>> > > > > >>>> > > > > >> > > > > > > > > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-63-Rework-table-partition-support-td32770.html > > > > >>>>> > > > > >>>>> Google Doc: > > > > >>>>> < > > > > >>>>> > > > > >>>> > > > > >> > > > > > > > > > > https://docs.google.com/document/d/1yFDyquMo_-VZ59vyhaMshpPtg7p87b9IYdAtMXv5XmM/edit?usp=sharing > > > > >>>>>> > > > > >>>>> > > > > >>>>> > > > > >>>> > > > > >> > > > > > > > > > > https://docs.google.com/document/d/15R3vZ1R_pAHcvJkRx_CWleXgl08WL3k_ZpnWSdzP7GY/edit?usp=sharing > > > > >>>>> > > > > >>>>> Thanks, > > > > >>>>> > > > > >>>>> Best, > > > > >>>>> Jingsong Lee > > > > >>>>> > > > > >>>> > > > > >>> > > > > >>> > > > > >>> -- > > > > >>> Best, Jingsong Lee > > > > >>> > > > > >> > > > > >> > > > > >> -- > > > > >> Best, Jingsong Lee > > > > >> > > > > > > > > > > > > > > > > > -- > > Xuefu Zhang > > > > "In Honey We Trust!" > > > > > -- > Best regards! > Rui Li > |
«
Return to (DEPRECATED) Apache Flink Mailing List archive.
|
1 view|%1 views
| Free forum by Nabble | Edit this page |