[VOTE] FLIP-33: Standardize connector metrics

[Becket Qin]

Hi Flink devs,

I would like to start the voting for FLIP-33 which aims to standardize
connector metrics.

FLIP wiki:
https://cwiki.apache.org/confluence/display/FLINK/FLIP-33%3A+Standardize+Connector+Metrics

Discussion thread:
https://lists.apache.org/thread.html/65078bad6e04bbbb7578d502e1e5d92026f13fd9648725f5b74ed330@%3Cdev.flink.apache.org%3E

Thanks,

Jiangjie (Becket) Qin

[Chesnay Schepler-3]

The rate metrics should end in "PerSecond" instead of "PerSec" to be
consistent with existing metrics.

I'm a bit unsure whether it makes send to include the In/Out metrics in
this proposal, given that these metrics are standardized across all
operators already (at least in terms of _/existing/_). For these we
won't we adding new metrics but only (maybe) fix the existing behavior.

On 13/06/2019 03:23, Becket Qin wrote:

> Hi Flink devs,
>
> I would like to start the voting for FLIP-33 which aims to standardize
> connector metrics.
>
> FLIP wiki:
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-33%3A+Standardize+Connector+Metrics
>
> Discussion thread:
> https://lists.apache.org/thread.html/65078bad6e04bbbb7578d502e1e5d92026f13fd9648725f5b74ed330@%3Cdev.flink.apache.org%3E
>
> Thanks,
>
> Jiangjie (Becket) Qin
>

[Piotr Nowojski-3]

+1 from my side % Chesnay’s comment.

Piotrek

> On 13 Jun 2019, at 09:35, Chesnay Schepler <[hidden email]> wrote:
>
> The rate metrics should end in "PerSecond" instead of "PerSec" to be consistent with existing metrics.
>
> I'm a bit unsure whether it makes send to include the In/Out metrics in this proposal, given that these metrics are standardized across all operators already (at least in terms of _/existing/_). For these we won't we adding new metrics but only (maybe) fix the existing behavior.
>
> On 13/06/2019 03:23, Becket Qin wrote:
>> Hi Flink devs,
>>
>> I would like to start the voting for FLIP-33 which aims to standardize
>> connector metrics.
>>
>> FLIP wiki:
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP-33%3A+Standardize+Connector+Metrics
>>
>> Discussion thread:
>> https://lists.apache.org/thread.html/65078bad6e04bbbb7578d502e1e5d92026f13fd9648725f5b74ed330@%3Cdev.flink.apache.org%3E
>>
>> Thanks,
>>
>> Jiangjie (Becket) Qin
>>
>

[Becket Qin]

Hi Chesnay and Piotr,

Thanks for the reply. I have updated the wiki page to change rate metric
name from "PerSec" to "PerSecond".

And yes, the I/O metrics are sort of standardized across all the operators,
and probably for all the connectors in Flink as well. The reason I included
them into the convention was because those metrics are reported by each
connector's implementation. So when creating a connector for a system, one
need to ensure those metrics are reported correctly in order to use an
existing Flink monitoring tool. So I think it might still worth including
them into the convention so 3rd-party connector implementations outside of
Flink won't miss them.

Thanks,

Jiangjie (Becket) Qin

On Thu, Jun 13, 2019 at 3:52 PM Piotr Nowojski <[hidden email]> wrote:

> +1 from my side % Chesnay’s comment.
>
> Piotrek
>
> > On 13 Jun 2019, at 09:35, Chesnay Schepler <[hidden email]> wrote:
> >
> > The rate metrics should end in "PerSecond" instead of "PerSec" to be
> consistent with existing metrics.
> >
> > I'm a bit unsure whether it makes send to include the In/Out metrics in
> this proposal, given that these metrics are standardized across all
> operators already (at least in terms of _/existing/_). For these we won't
> we adding new metrics but only (maybe) fix the existing behavior.
> >
> > On 13/06/2019 03:23, Becket Qin wrote:
> >> Hi Flink devs,
> >>
> >> I would like to start the voting for FLIP-33 which aims to standardize
> >> connector metrics.
> >>
> >> FLIP wiki:
> >>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-33%3A+Standardize+Connector+Metrics
> >>
> >> Discussion thread:
> >>
> https://lists.apache.org/thread.html/65078bad6e04bbbb7578d502e1e5d92026f13fd9648725f5b74ed330@%3Cdev.flink.apache.org%3E
> >>
> >> Thanks,
> >>
> >> Jiangjie (Becket) Qin
> >>
> >
>
>