[VOTE] FLIP-111: Docker image unification

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] FLIP-111: Docker image unification

Andrey Zagrebin-4
Hi All,

As discussed in these threads [1] and [2],
we suggest to unify the docker topic in Flink for users [3].

This mainly means refactoring of the existing code and introducing more
docs as a first step.
The effort should enable further improvements and follow-ups for the docker
integration with Flink.

The integration with docker in Flink is currently addressed in many places
which often intersect, repeat each other or apply different approaches.
This makes it really hard to follow the whole topic for users and
maintainers. This FLIP suggests how to unify this topic. It means having
one place which has the *Dockerfile*, all necessary scripts and docs
following each other in a consistent way without any repetitions or
contradictions.

The idea is to keep all docker related resources in apache/flink-docker
<https://github.com/apache/flink-docker>. It already has a detailed
Dockerfile which is well suited for common use cases or at least serves as
a good starting point. The suggestion is to make it extensible for other
concerns which are currently addressed in other places.

Best,
Andrey

[1]
http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-111-Docker-image-unification-td38444.html#a39822
[2]
http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-111-Docker-image-unification-td38444i20.html#a39950
[3]
https://cwiki.apache.org/confluence/display/FLINK/FLIP-111%3A+Docker+image+unification
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-111: Docker image unification

Ufuk Celebi-2
Thanks for starting this FLIP.

+1

On Tue, Apr 7, 2020 at 11:29 AM Andrey Zagrebin <[hidden email]>
wrote:

> Hi All,
>
> As discussed in these threads [1] and [2],
> we suggest to unify the docker topic in Flink for users [3].
>
> This mainly means refactoring of the existing code and introducing more
> docs as a first step.
> The effort should enable further improvements and follow-ups for the docker
> integration with Flink.
>
> The integration with docker in Flink is currently addressed in many places
> which often intersect, repeat each other or apply different approaches.
> This makes it really hard to follow the whole topic for users and
> maintainers. This FLIP suggests how to unify this topic. It means having
> one place which has the *Dockerfile*, all necessary scripts and docs
> following each other in a consistent way without any repetitions or
> contradictions.
>
> The idea is to keep all docker related resources in apache/flink-docker
> <https://github.com/apache/flink-docker>. It already has a detailed
> Dockerfile which is well suited for common use cases or at least serves as
> a good starting point. The suggestion is to make it extensible for other
> concerns which are currently addressed in other places.
>
> Best,
> Andrey
>
> [1]
>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-111-Docker-image-unification-td38444.html#a39822
> [2]
>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-111-Docker-image-unification-td38444i20.html#a39950
> [3]
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-111%3A+Docker+image+unification
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-111: Docker image unification

Till Rohrmann
Thanks for driving this effort Andrey.

+1 (binding)

Cheers,
Till

On Tue, Apr 7, 2020 at 4:48 PM Ufuk Celebi <[hidden email]> wrote:

> Thanks for starting this FLIP.
>
> +1
>
> On Tue, Apr 7, 2020 at 11:29 AM Andrey Zagrebin <[hidden email]>
> wrote:
>
> > Hi All,
> >
> > As discussed in these threads [1] and [2],
> > we suggest to unify the docker topic in Flink for users [3].
> >
> > This mainly means refactoring of the existing code and introducing more
> > docs as a first step.
> > The effort should enable further improvements and follow-ups for the
> docker
> > integration with Flink.
> >
> > The integration with docker in Flink is currently addressed in many
> places
> > which often intersect, repeat each other or apply different approaches.
> > This makes it really hard to follow the whole topic for users and
> > maintainers. This FLIP suggests how to unify this topic. It means having
> > one place which has the *Dockerfile*, all necessary scripts and docs
> > following each other in a consistent way without any repetitions or
> > contradictions.
> >
> > The idea is to keep all docker related resources in apache/flink-docker
> > <https://github.com/apache/flink-docker>. It already has a detailed
> > Dockerfile which is well suited for common use cases or at least serves
> as
> > a good starting point. The suggestion is to make it extensible for other
> > concerns which are currently addressed in other places.
> >
> > Best,
> > Andrey
> >
> > [1]
> >
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-111-Docker-image-unification-td38444.html#a39822
> > [2]
> >
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-111-Docker-image-unification-td38444i20.html#a39950
> > [3]
> >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-111%3A+Docker+image+unification
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-111: Docker image unification

Yang Wang
Thanks Andrey for the efforts of docker image unification.

+1 (non-binding)

Best,
Yang

Till Rohrmann <[hidden email]> 于2020年4月7日周二 下午11:04写道:

> Thanks for driving this effort Andrey.
>
> +1 (binding)
>
> Cheers,
> Till
>
> On Tue, Apr 7, 2020 at 4:48 PM Ufuk Celebi <[hidden email]> wrote:
>
> > Thanks for starting this FLIP.
> >
> > +1
> >
> > On Tue, Apr 7, 2020 at 11:29 AM Andrey Zagrebin <[hidden email]>
> > wrote:
> >
> > > Hi All,
> > >
> > > As discussed in these threads [1] and [2],
> > > we suggest to unify the docker topic in Flink for users [3].
> > >
> > > This mainly means refactoring of the existing code and introducing more
> > > docs as a first step.
> > > The effort should enable further improvements and follow-ups for the
> > docker
> > > integration with Flink.
> > >
> > > The integration with docker in Flink is currently addressed in many
> > places
> > > which often intersect, repeat each other or apply different approaches.
> > > This makes it really hard to follow the whole topic for users and
> > > maintainers. This FLIP suggests how to unify this topic. It means
> having
> > > one place which has the *Dockerfile*, all necessary scripts and docs
> > > following each other in a consistent way without any repetitions or
> > > contradictions.
> > >
> > > The idea is to keep all docker related resources in apache/flink-docker
> > > <https://github.com/apache/flink-docker>. It already has a detailed
> > > Dockerfile which is well suited for common use cases or at least serves
> > as
> > > a good starting point. The suggestion is to make it extensible for
> other
> > > concerns which are currently addressed in other places.
> > >
> > > Best,
> > > Andrey
> > >
> > > [1]
> > >
> > >
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-111-Docker-image-unification-td38444.html#a39822
> > > [2]
> > >
> > >
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-111-Docker-image-unification-td38444i20.html#a39950
> > > [3]
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-111%3A+Docker+image+unification
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-111: Docker image unification

felixzheng
Thanks for the FLIP Andrey.

+1 (non-binding) from my side.

Regards,
Canbin Zheng

Yang Wang <[hidden email]> 于2020年4月8日周三 上午9:57写道:

> Thanks Andrey for the efforts of docker image unification.
>
> +1 (non-binding)
>
> Best,
> Yang
>
> Till Rohrmann <[hidden email]> 于2020年4月7日周二 下午11:04写道:
>
> > Thanks for driving this effort Andrey.
> >
> > +1 (binding)
> >
> > Cheers,
> > Till
> >
> > On Tue, Apr 7, 2020 at 4:48 PM Ufuk Celebi <[hidden email]> wrote:
> >
> > > Thanks for starting this FLIP.
> > >
> > > +1
> > >
> > > On Tue, Apr 7, 2020 at 11:29 AM Andrey Zagrebin <[hidden email]>
> > > wrote:
> > >
> > > > Hi All,
> > > >
> > > > As discussed in these threads [1] and [2],
> > > > we suggest to unify the docker topic in Flink for users [3].
> > > >
> > > > This mainly means refactoring of the existing code and introducing
> more
> > > > docs as a first step.
> > > > The effort should enable further improvements and follow-ups for the
> > > docker
> > > > integration with Flink.
> > > >
> > > > The integration with docker in Flink is currently addressed in many
> > > places
> > > > which often intersect, repeat each other or apply different
> approaches.
> > > > This makes it really hard to follow the whole topic for users and
> > > > maintainers. This FLIP suggests how to unify this topic. It means
> > having
> > > > one place which has the *Dockerfile*, all necessary scripts and docs
> > > > following each other in a consistent way without any repetitions or
> > > > contradictions.
> > > >
> > > > The idea is to keep all docker related resources in
> apache/flink-docker
> > > > <https://github.com/apache/flink-docker>. It already has a detailed
> > > > Dockerfile which is well suited for common use cases or at least
> serves
> > > as
> > > > a good starting point. The suggestion is to make it extensible for
> > other
> > > > concerns which are currently addressed in other places.
> > > >
> > > > Best,
> > > > Andrey
> > > >
> > > > [1]
> > > >
> > > >
> > >
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-111-Docker-image-unification-td38444.html#a39822
> > > > [2]
> > > >
> > > >
> > >
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-111-Docker-image-unification-td38444i20.html#a39950
> > > > [3]
> > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-111%3A+Docker+image+unification
> > > >
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-111: Docker image unification

Ismaël Mejía
+1 (non-binding)
Great work Andrey, pretty excited about this happening!


On Wed, Apr 8, 2020 at 4:20 AM Canbin Zheng <[hidden email]> wrote:

>
> Thanks for the FLIP Andrey.
>
> +1 (non-binding) from my side.
>
> Regards,
> Canbin Zheng
>
> Yang Wang <[hidden email]> 于2020年4月8日周三 上午9:57写道:
>
> > Thanks Andrey for the efforts of docker image unification.
> >
> > +1 (non-binding)
> >
> > Best,
> > Yang
> >
> > Till Rohrmann <[hidden email]> 于2020年4月7日周二 下午11:04写道:
> >
> > > Thanks for driving this effort Andrey.
> > >
> > > +1 (binding)
> > >
> > > Cheers,
> > > Till
> > >
> > > On Tue, Apr 7, 2020 at 4:48 PM Ufuk Celebi <[hidden email]> wrote:
> > >
> > > > Thanks for starting this FLIP.
> > > >
> > > > +1
> > > >
> > > > On Tue, Apr 7, 2020 at 11:29 AM Andrey Zagrebin <[hidden email]>
> > > > wrote:
> > > >
> > > > > Hi All,
> > > > >
> > > > > As discussed in these threads [1] and [2],
> > > > > we suggest to unify the docker topic in Flink for users [3].
> > > > >
> > > > > This mainly means refactoring of the existing code and introducing
> > more
> > > > > docs as a first step.
> > > > > The effort should enable further improvements and follow-ups for the
> > > > docker
> > > > > integration with Flink.
> > > > >
> > > > > The integration with docker in Flink is currently addressed in many
> > > > places
> > > > > which often intersect, repeat each other or apply different
> > approaches.
> > > > > This makes it really hard to follow the whole topic for users and
> > > > > maintainers. This FLIP suggests how to unify this topic. It means
> > > having
> > > > > one place which has the *Dockerfile*, all necessary scripts and docs
> > > > > following each other in a consistent way without any repetitions or
> > > > > contradictions.
> > > > >
> > > > > The idea is to keep all docker related resources in
> > apache/flink-docker
> > > > > <https://github.com/apache/flink-docker>. It already has a detailed
> > > > > Dockerfile which is well suited for common use cases or at least
> > serves
> > > > as
> > > > > a good starting point. The suggestion is to make it extensible for
> > > other
> > > > > concerns which are currently addressed in other places.
> > > > >
> > > > > Best,
> > > > > Andrey
> > > > >
> > > > > [1]
> > > > >
> > > > >
> > > >
> > >
> > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-111-Docker-image-unification-td38444.html#a39822
> > > > > [2]
> > > > >
> > > > >
> > > >
> > >
> > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-111-Docker-image-unification-td38444i20.html#a39950
> > > > > [3]
> > > > >
> > > > >
> > > >
> > >
> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-111%3A+Docker+image+unification
> > > > >
> > > >
> > >
> >
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-111: Docker image unification

Yangze Guo
+1 (non-binding)
Thanks for driving this, Andrey.

Best,
Yangze Guo

On Thu, Apr 9, 2020 at 11:33 PM Ismaël Mejía <[hidden email]> wrote:

>
> +1 (non-binding)
> Great work Andrey, pretty excited about this happening!
>
>
> On Wed, Apr 8, 2020 at 4:20 AM Canbin Zheng <[hidden email]> wrote:
> >
> > Thanks for the FLIP Andrey.
> >
> > +1 (non-binding) from my side.
> >
> > Regards,
> > Canbin Zheng
> >
> > Yang Wang <[hidden email]> 于2020年4月8日周三 上午9:57写道:
> >
> > > Thanks Andrey for the efforts of docker image unification.
> > >
> > > +1 (non-binding)
> > >
> > > Best,
> > > Yang
> > >
> > > Till Rohrmann <[hidden email]> 于2020年4月7日周二 下午11:04写道:
> > >
> > > > Thanks for driving this effort Andrey.
> > > >
> > > > +1 (binding)
> > > >
> > > > Cheers,
> > > > Till
> > > >
> > > > On Tue, Apr 7, 2020 at 4:48 PM Ufuk Celebi <[hidden email]> wrote:
> > > >
> > > > > Thanks for starting this FLIP.
> > > > >
> > > > > +1
> > > > >
> > > > > On Tue, Apr 7, 2020 at 11:29 AM Andrey Zagrebin <[hidden email]>
> > > > > wrote:
> > > > >
> > > > > > Hi All,
> > > > > >
> > > > > > As discussed in these threads [1] and [2],
> > > > > > we suggest to unify the docker topic in Flink for users [3].
> > > > > >
> > > > > > This mainly means refactoring of the existing code and introducing
> > > more
> > > > > > docs as a first step.
> > > > > > The effort should enable further improvements and follow-ups for the
> > > > > docker
> > > > > > integration with Flink.
> > > > > >
> > > > > > The integration with docker in Flink is currently addressed in many
> > > > > places
> > > > > > which often intersect, repeat each other or apply different
> > > approaches.
> > > > > > This makes it really hard to follow the whole topic for users and
> > > > > > maintainers. This FLIP suggests how to unify this topic. It means
> > > > having
> > > > > > one place which has the *Dockerfile*, all necessary scripts and docs
> > > > > > following each other in a consistent way without any repetitions or
> > > > > > contradictions.
> > > > > >
> > > > > > The idea is to keep all docker related resources in
> > > apache/flink-docker
> > > > > > <https://github.com/apache/flink-docker>. It already has a detailed
> > > > > > Dockerfile which is well suited for common use cases or at least
> > > serves
> > > > > as
> > > > > > a good starting point. The suggestion is to make it extensible for
> > > > other
> > > > > > concerns which are currently addressed in other places.
> > > > > >
> > > > > > Best,
> > > > > > Andrey
> > > > > >
> > > > > > [1]
> > > > > >
> > > > > >
> > > > >
> > > >
> > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-111-Docker-image-unification-td38444.html#a39822
> > > > > > [2]
> > > > > >
> > > > > >
> > > > >
> > > >
> > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-111-Docker-image-unification-td38444i20.html#a39950
> > > > > > [3]
> > > > > >
> > > > > >
> > > > >
> > > >
> > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-111%3A+Docker+image+unification
> > > > > >
> > > > >
> > > >
> > >
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] FLIP-111: Docker image unification

Andrey Zagrebin-4
Hi all,

My vote is +1 (binding).

Thanks for participating and giving your votes.

Hereby, the vote is closed and the FLIP is accepted with no -1/vetos.

+1's:
3 binding (Ufuk, Till, Andrey)
4 non-binding (Yang, Canbin, Ismaël, Yangze)

Thanks,
Andrey

On Fri, Apr 10, 2020 at 8:40 AM Yangze Guo <[hidden email]> wrote:

> +1 (non-binding)
> Thanks for driving this, Andrey.
>
> Best,
> Yangze Guo
>
> On Thu, Apr 9, 2020 at 11:33 PM Ismaël Mejía <[hidden email]> wrote:
> >
> > +1 (non-binding)
> > Great work Andrey, pretty excited about this happening!
> >
> >
> > On Wed, Apr 8, 2020 at 4:20 AM Canbin Zheng <[hidden email]>
> wrote:
> > >
> > > Thanks for the FLIP Andrey.
> > >
> > > +1 (non-binding) from my side.
> > >
> > > Regards,
> > > Canbin Zheng
> > >
> > > Yang Wang <[hidden email]> 于2020年4月8日周三 上午9:57写道:
> > >
> > > > Thanks Andrey for the efforts of docker image unification.
> > > >
> > > > +1 (non-binding)
> > > >
> > > > Best,
> > > > Yang
> > > >
> > > > Till Rohrmann <[hidden email]> 于2020年4月7日周二 下午11:04写道:
> > > >
> > > > > Thanks for driving this effort Andrey.
> > > > >
> > > > > +1 (binding)
> > > > >
> > > > > Cheers,
> > > > > Till
> > > > >
> > > > > On Tue, Apr 7, 2020 at 4:48 PM Ufuk Celebi <[hidden email]> wrote:
> > > > >
> > > > > > Thanks for starting this FLIP.
> > > > > >
> > > > > > +1
> > > > > >
> > > > > > On Tue, Apr 7, 2020 at 11:29 AM Andrey Zagrebin <
> [hidden email]>
> > > > > > wrote:
> > > > > >
> > > > > > > Hi All,
> > > > > > >
> > > > > > > As discussed in these threads [1] and [2],
> > > > > > > we suggest to unify the docker topic in Flink for users [3].
> > > > > > >
> > > > > > > This mainly means refactoring of the existing code and
> introducing
> > > > more
> > > > > > > docs as a first step.
> > > > > > > The effort should enable further improvements and follow-ups
> for the
> > > > > > docker
> > > > > > > integration with Flink.
> > > > > > >
> > > > > > > The integration with docker in Flink is currently addressed in
> many
> > > > > > places
> > > > > > > which often intersect, repeat each other or apply different
> > > > approaches.
> > > > > > > This makes it really hard to follow the whole topic for users
> and
> > > > > > > maintainers. This FLIP suggests how to unify this topic. It
> means
> > > > > having
> > > > > > > one place which has the *Dockerfile*, all necessary scripts
> and docs
> > > > > > > following each other in a consistent way without any
> repetitions or
> > > > > > > contradictions.
> > > > > > >
> > > > > > > The idea is to keep all docker related resources in
> > > > apache/flink-docker
> > > > > > > <https://github.com/apache/flink-docker>. It already has a
> detailed
> > > > > > > Dockerfile which is well suited for common use cases or at
> least
> > > > serves
> > > > > > as
> > > > > > > a good starting point. The suggestion is to make it extensible
> for
> > > > > other
> > > > > > > concerns which are currently addressed in other places.
> > > > > > >
> > > > > > > Best,
> > > > > > > Andrey
> > > > > > >
> > > > > > > [1]
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-111-Docker-image-unification-td38444.html#a39822
> > > > > > > [2]
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-111-Docker-image-unification-td38444i20.html#a39950
> > > > > > > [3]
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-111%3A+Docker+image+unification
> > > > > > >
> > > > > >
> > > > >
> > > >
>