[VOTE] Apache Flink Stateful Functions Release 2.0.0, release candidate #3

[Tzu-Li (Gordon) Tai]

Hi everyone,

Please review and vote on the *release candidate #3* for the version 2.0.0
of Apache Flink Stateful Functions,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

**Testing Guideline**

You can find here [1] a doc that we can use for collaborating testing
efforts.
The listed testing tasks in the doc also serve as a guideline in what to
test for this release.
If you wish to take ownership of a testing task, simply put your name down
in the "Checked by" field of the task.

**Release Overview**

As an overview, the release consists of the following:
a) Stateful Functions canonical source distribution, to be deployed to the
release repository at dist.apache.org
b) Stateful Functions Python SDK distributions to be deployed to PyPI
c) Maven artifacts to be deployed to the Maven Central Repository

**Staging Areas to Review**

The staging areas containing the above mentioned artifacts are as follows,
for your review:
* All artifacts for a) and b) can be found in the corresponding dev
repository at dist.apache.org [2]
* All artifacts for c) can be found at the Apache Nexus Repository [3]

All artifacts are singed with the
key 1C1E2394D3194E1944613488F320986D35C33D6A [4]

Other links for your review:
* JIRA release notes [5]
* source code tag "release-2.0.0-rc3" [6] [7]

**Extra Remarks**

* Part of the release is also official Docker images for Stateful
Functions. This can be a separate process, since the creation of those
relies on the fact that we have distribution jars already deployed to
Maven. I will follow-up with this after these artifacts are officially
released.
In the meantime, there is this discussion [8] ongoing about where to host
the StateFun Dockerfiles.
* The Flink Website and blog post is also being worked on (by Marta) as
part of the release, to incorporate the new Stateful Functions project. We
can follow up with a link to those changes afterwards in this vote thread,
but that would not block you to test and cast your votes already.
* Since the Flink website changes are still being worked on, you will not
yet be able to find the Stateful Functions docs from there. Here are the
links [9] [10].

**Vote Duration**

The vote will be open for at least 72 hours starting Monday
*(target end date is Wednesday, April 1st).*
It is adopted by majority approval, with at least 3 PMC affirmative votes.

Thanks,
Gordon

[1]
https://docs.google.com/document/d/1P9yjwSbPQtul0z2AXMnVolWQbzhxs68suJvzR6xMjcs/edit?usp=sharing
[2] https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc3/
[3] https://repository.apache.org/content/repositories/orgapacheflink-1342/
[4] https://dist.apache.org/repos/dist/release/flink/KEYS
[5]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346878
[6]
https://gitbox.apache.org/repos/asf?p=flink-statefun.git;a=commit;h=752e07fd9987ee430eb9d1c1d3fadff632ef9213
[7] https://github.com/apache/flink-statefun/tree/release-2.0.0-rc3
[8]
http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Creating-a-new-repo-to-host-Stateful-Functions-Dockerfiles-td39342.html
[9] https://ci.apache.org/projects/flink/flink-statefun-docs-master/
[10] https://ci.apache.org/projects/flink/flink-statefun-docs-release-2.0/

TIP: You can create a `settings.xml` file with these contents:

"""
<settings>
  <activeProfiles>
    <activeProfile>flink-statefun-2.0.0</activeProfile>
  </activeProfiles>
  <profiles>
    <profile>
      <id>flink-statefun-2.0.0</id>
      <repositories>
        <repository>
          <id>flink-statefun-2.0.0</id>
          <url>
https://repository.apache.org/content/repositories/orgapacheflink-1342/
</url>
        </repository>
        <repository>
          <id>archetype</id>
          <url>
https://repository.apache.org/content/repositories/orgapacheflink-1342/
</url>
        </repository>
      </repositories>
    </profile>
  </profiles>
</settings>
"""

And reference that in you maven commands via `--settings
path/to/settings.xml`.
This is useful for creating a quickstart based on the staged release and
for building against the staged jars.

[Hequn Cheng-2]

Hi Gordon,

Thanks a lot for the new RC. I found some new blockers about licenses:

- Module statefun-flink-distribution
com.google.protobuf:protobuf-java:3.8.0 (The version should be 3.7.1)

- Module statefun-ridesharing-example-simulator
com.google.code.findbugs:jsr305:3.0.2:compile (Remove compile)
org.hibernate.validator:hibernate-validator:6.0.17 (Version should be
6.0.17.Final)
org.jboss.logging:jboss-logging:3.3.2  (Version should be 3.3.2.Final)

Non-blocker feedback:
- py3 is added in the name of "whl dist" but it is missing in the "source
dist"[1]. Should we make them consistent?

Best,
Hequn

[1] https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc3/


On Sun, Mar 29, 2020 at 3:31 PM Tzu-Li (Gordon) Tai <[hidden email]>
wrote:

> Hi everyone,
>
> Please review and vote on the *release candidate #3* for the version 2.0.0
> of Apache Flink Stateful Functions,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> **Testing Guideline**
>
> You can find here [1] a doc that we can use for collaborating testing
> efforts.
> The listed testing tasks in the doc also serve as a guideline in what to
> test for this release.
> If you wish to take ownership of a testing task, simply put your name down
> in the "Checked by" field of the task.
>
> **Release Overview**
>
> As an overview, the release consists of the following:
> a) Stateful Functions canonical source distribution, to be deployed to the
> release repository at dist.apache.org
> b) Stateful Functions Python SDK distributions to be deployed to PyPI
> c) Maven artifacts to be deployed to the Maven Central Repository
>
> **Staging Areas to Review**
>
> The staging areas containing the above mentioned artifacts are as follows,
> for your review:
> * All artifacts for a) and b) can be found in the corresponding dev
> repository at dist.apache.org [2]
> * All artifacts for c) can be found at the Apache Nexus Repository [3]
>
> All artifacts are singed with the
> key 1C1E2394D3194E1944613488F320986D35C33D6A [4]
>
> Other links for your review:
> * JIRA release notes [5]
> * source code tag "release-2.0.0-rc3" [6] [7]
>
> **Extra Remarks**
>
> * Part of the release is also official Docker images for Stateful
> Functions. This can be a separate process, since the creation of those
> relies on the fact that we have distribution jars already deployed to
> Maven. I will follow-up with this after these artifacts are officially
> released.
> In the meantime, there is this discussion [8] ongoing about where to host
> the StateFun Dockerfiles.
> * The Flink Website and blog post is also being worked on (by Marta) as
> part of the release, to incorporate the new Stateful Functions project. We
> can follow up with a link to those changes afterwards in this vote thread,
> but that would not block you to test and cast your votes already.
> * Since the Flink website changes are still being worked on, you will not
> yet be able to find the Stateful Functions docs from there. Here are the
> links [9] [10].
>
> **Vote Duration**
>
> The vote will be open for at least 72 hours starting Monday
> *(target end date is Wednesday, April 1st).*
> It is adopted by majority approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Gordon
>
> [1]
>
> https://docs.google.com/document/d/1P9yjwSbPQtul0z2AXMnVolWQbzhxs68suJvzR6xMjcs/edit?usp=sharing
> [2] https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc3/
> [3]
> https://repository.apache.org/content/repositories/orgapacheflink-1342/
> [4] https://dist.apache.org/repos/dist/release/flink/KEYS
> [5]
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346878
> [6]
>
> https://gitbox.apache.org/repos/asf?p=flink-statefun.git;a=commit;h=752e07fd9987ee430eb9d1c1d3fadff632ef9213
> [7] https://github.com/apache/flink-statefun/tree/release-2.0.0-rc3
> [8]
>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Creating-a-new-repo-to-host-Stateful-Functions-Dockerfiles-td39342.html
> [9] https://ci.apache.org/projects/flink/flink-statefun-docs-master/
> [10] https://ci.apache.org/projects/flink/flink-statefun-docs-release-2.0/
>
> TIP: You can create a `settings.xml` file with these contents:
>
> """
> <settings>
>   <activeProfiles>
>     <activeProfile>flink-statefun-2.0.0</activeProfile>
>   </activeProfiles>
>   <profiles>
>     <profile>
>       <id>flink-statefun-2.0.0</id>
>       <repositories>
>         <repository>
>           <id>flink-statefun-2.0.0</id>
>           <url>
> https://repository.apache.org/content/repositories/orgapacheflink-1342/
> </url>
>         </repository>
>         <repository>
>           <id>archetype</id>
>           <url>
> https://repository.apache.org/content/repositories/orgapacheflink-1342/
> </url>
>         </repository>
>       </repositories>
>     </profile>
>   </profiles>
> </settings>
> """
>
> And reference that in you maven commands via `--settings
> path/to/settings.xml`.
> This is useful for creating a quickstart based on the staged release and
> for building against the staged jars.
>

[Tzu-Li (Gordon) Tai]

@Hequn Cheng <[hidden email]>
Good catches again!

Regarding the incorrect versions:
I think technically those would not be hard blockers, since what matters is
their inclusion and licenses being acknowledged.
It would still be good to fix those though - could you open a ticket for
those?

Regarding the names of the Python dists -
the name of those distributions are generated from the setup.py file, and
seems to be a convention used by PyPI.
@[hidden email] <[hidden email]>  can you confirm here?

On Sun, Mar 29, 2020 at 11:36 PM Hequn Cheng <[hidden email]> wrote:

> Hi Gordon,
>
> Thanks a lot for the new RC. I found some new blockers about licenses:
>
> - Module statefun-flink-distribution
> com.google.protobuf:protobuf-java:3.8.0 (The version should be 3.7.1)
>
> - Module statefun-ridesharing-example-simulator
> com.google.code.findbugs:jsr305:3.0.2:compile (Remove compile)
> org.hibernate.validator:hibernate-validator:6.0.17 (Version should be
> 6.0.17.Final)
> org.jboss.logging:jboss-logging:3.3.2  (Version should be 3.3.2.Final)
>
> Non-blocker feedback:
> - py3 is added in the name of "whl dist" but it is missing in the "source
> dist"[1]. Should we make them consistent?
>
> Best,
> Hequn
>
> [1] https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc3/
>
>
> On Sun, Mar 29, 2020 at 3:31 PM Tzu-Li (Gordon) Tai <[hidden email]>
> wrote:
>
> > Hi everyone,
> >
> > Please review and vote on the *release candidate #3* for the version
> 2.0.0
> > of Apache Flink Stateful Functions,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > **Testing Guideline**
> >
> > You can find here [1] a doc that we can use for collaborating testing
> > efforts.
> > The listed testing tasks in the doc also serve as a guideline in what to
> > test for this release.
> > If you wish to take ownership of a testing task, simply put your name
> down
> > in the "Checked by" field of the task.
> >
> > **Release Overview**
> >
> > As an overview, the release consists of the following:
> > a) Stateful Functions canonical source distribution, to be deployed to
> the
> > release repository at dist.apache.org
> > b) Stateful Functions Python SDK distributions to be deployed to PyPI
> > c) Maven artifacts to be deployed to the Maven Central Repository
> >
> > **Staging Areas to Review**
> >
> > The staging areas containing the above mentioned artifacts are as
> follows,
> > for your review:
> > * All artifacts for a) and b) can be found in the corresponding dev
> > repository at dist.apache.org [2]
> > * All artifacts for c) can be found at the Apache Nexus Repository [3]
> >
> > All artifacts are singed with the
> > key 1C1E2394D3194E1944613488F320986D35C33D6A [4]
> >
> > Other links for your review:
> > * JIRA release notes [5]
> > * source code tag "release-2.0.0-rc3" [6] [7]
> >
> > **Extra Remarks**
> >
> > * Part of the release is also official Docker images for Stateful
> > Functions. This can be a separate process, since the creation of those
> > relies on the fact that we have distribution jars already deployed to
> > Maven. I will follow-up with this after these artifacts are officially
> > released.
> > In the meantime, there is this discussion [8] ongoing about where to host
> > the StateFun Dockerfiles.
> > * The Flink Website and blog post is also being worked on (by Marta) as
> > part of the release, to incorporate the new Stateful Functions project.
> We
> > can follow up with a link to those changes afterwards in this vote
> thread,
> > but that would not block you to test and cast your votes already.
> > * Since the Flink website changes are still being worked on, you will not
> > yet be able to find the Stateful Functions docs from there. Here are the
> > links [9] [10].
> >
> > **Vote Duration**
> >
> > The vote will be open for at least 72 hours starting Monday
> > *(target end date is Wednesday, April 1st).*
> > It is adopted by majority approval, with at least 3 PMC affirmative
> votes.
> >
> > Thanks,
> > Gordon
> >
> > [1]
> >
> >
> https://docs.google.com/document/d/1P9yjwSbPQtul0z2AXMnVolWQbzhxs68suJvzR6xMjcs/edit?usp=sharing
> > [2]
> https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc3/
> > [3]
> > https://repository.apache.org/content/repositories/orgapacheflink-1342/
> > [4] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [5]
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346878
> > [6]
> >
> >
> https://gitbox.apache.org/repos/asf?p=flink-statefun.git;a=commit;h=752e07fd9987ee430eb9d1c1d3fadff632ef9213
> > [7] https://github.com/apache/flink-statefun/tree/release-2.0.0-rc3
> > [8]
> >
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Creating-a-new-repo-to-host-Stateful-Functions-Dockerfiles-td39342.html
> > [9] https://ci.apache.org/projects/flink/flink-statefun-docs-master/
> > [10]
> https://ci.apache.org/projects/flink/flink-statefun-docs-release-2.0/
> >
> > TIP: You can create a `settings.xml` file with these contents:
> >
> > """
> > <settings>
> >   <activeProfiles>
> >     <activeProfile>flink-statefun-2.0.0</activeProfile>
> >   </activeProfiles>
> >   <profiles>
> >     <profile>
> >       <id>flink-statefun-2.0.0</id>
> >       <repositories>
> >         <repository>
> >           <id>flink-statefun-2.0.0</id>
> >           <url>
> > https://repository.apache.org/content/repositories/orgapacheflink-1342/
> > </url>
> >         </repository>
> >         <repository>
> >           <id>archetype</id>
> >           <url>
> > https://repository.apache.org/content/repositories/orgapacheflink-1342/
> > </url>
> >         </repository>
> >       </repositories>
> >     </profile>
> >   </profiles>
> > </settings>
> > """
> >
> > And reference that in you maven commands via `--settings
> > path/to/settings.xml`.
> > This is useful for creating a quickstart based on the staged release and
> > for building against the staged jars.
> >
>

[Tzu-Li (Gordon) Tai]

On Mon, Mar 30, 2020 at 12:00 AM Tzu-Li (Gordon) Tai <[hidden email]>
wrote:

> @Hequn Cheng <[hidden email]>
> Good catches again!
>
> Regarding the incorrect versions:
> I think technically those would not be hard blockers, since what matters
> is their inclusion and licenses being acknowledged.
> It would still be good to fix those though - could you open a ticket for
> those?
>

Here, I mean to fix those in future bugfix releases (if this RC does indeed
pass the vote as the official release).

>
> Regarding the names of the Python dists -
> the name of those distributions are generated from the setup.py file, and
> seems to be a convention used by PyPI.
> @[hidden email] <[hidden email]>  can you confirm here?
>
> On Sun, Mar 29, 2020 at 11:36 PM Hequn Cheng <[hidden email]> wrote:
>
>> Hi Gordon,
>>
>> Thanks a lot for the new RC. I found some new blockers about licenses:
>>
>> - Module statefun-flink-distribution
>> com.google.protobuf:protobuf-java:3.8.0 (The version should be 3.7.1)
>>
>> - Module statefun-ridesharing-example-simulator
>> com.google.code.findbugs:jsr305:3.0.2:compile (Remove compile)
>> org.hibernate.validator:hibernate-validator:6.0.17 (Version should be
>> 6.0.17.Final)
>> org.jboss.logging:jboss-logging:3.3.2  (Version should be 3.3.2.Final)
>>
>> Non-blocker feedback:
>> - py3 is added in the name of "whl dist" but it is missing in the "source
>> dist"[1]. Should we make them consistent?
>>
>> Best,
>> Hequn
>>
>> [1]
>> https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc3/
>>
>>
>> On Sun, Mar 29, 2020 at 3:31 PM Tzu-Li (Gordon) Tai <[hidden email]>
>> wrote:
>>
>> > Hi everyone,
>> >
>> > Please review and vote on the *release candidate #3* for the version
>> 2.0.0
>> > of Apache Flink Stateful Functions,
>> > as follows:
>> > [ ] +1, Approve the release
>> > [ ] -1, Do not approve the release (please provide specific comments)
>> >
>> > **Testing Guideline**
>> >
>> > You can find here [1] a doc that we can use for collaborating testing
>> > efforts.
>> > The listed testing tasks in the doc also serve as a guideline in what to
>> > test for this release.
>> > If you wish to take ownership of a testing task, simply put your name
>> down
>> > in the "Checked by" field of the task.
>> >
>> > **Release Overview**
>> >
>> > As an overview, the release consists of the following:
>> > a) Stateful Functions canonical source distribution, to be deployed to
>> the
>> > release repository at dist.apache.org
>> > b) Stateful Functions Python SDK distributions to be deployed to PyPI
>> > c) Maven artifacts to be deployed to the Maven Central Repository
>> >
>> > **Staging Areas to Review**
>> >
>> > The staging areas containing the above mentioned artifacts are as
>> follows,
>> > for your review:
>> > * All artifacts for a) and b) can be found in the corresponding dev
>> > repository at dist.apache.org [2]
>> > * All artifacts for c) can be found at the Apache Nexus Repository [3]
>> >
>> > All artifacts are singed with the
>> > key 1C1E2394D3194E1944613488F320986D35C33D6A [4]
>> >
>> > Other links for your review:
>> > * JIRA release notes [5]
>> > * source code tag "release-2.0.0-rc3" [6] [7]
>> >
>> > **Extra Remarks**
>> >
>> > * Part of the release is also official Docker images for Stateful
>> > Functions. This can be a separate process, since the creation of those
>> > relies on the fact that we have distribution jars already deployed to
>> > Maven. I will follow-up with this after these artifacts are officially
>> > released.
>> > In the meantime, there is this discussion [8] ongoing about where to
>> host
>> > the StateFun Dockerfiles.
>> > * The Flink Website and blog post is also being worked on (by Marta) as
>> > part of the release, to incorporate the new Stateful Functions project.
>> We
>> > can follow up with a link to those changes afterwards in this vote
>> thread,
>> > but that would not block you to test and cast your votes already.
>> > * Since the Flink website changes are still being worked on, you will
>> not
>> > yet be able to find the Stateful Functions docs from there. Here are the
>> > links [9] [10].
>> >
>> > **Vote Duration**
>> >
>> > The vote will be open for at least 72 hours starting Monday
>> > *(target end date is Wednesday, April 1st).*
>> > It is adopted by majority approval, with at least 3 PMC affirmative
>> votes.
>> >
>> > Thanks,
>> > Gordon
>> >
>> > [1]
>> >
>> >
>> https://docs.google.com/document/d/1P9yjwSbPQtul0z2AXMnVolWQbzhxs68suJvzR6xMjcs/edit?usp=sharing
>> > [2]
>> https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc3/
>> > [3]
>> > https://repository.apache.org/content/repositories/orgapacheflink-1342/
>> > [4] https://dist.apache.org/repos/dist/release/flink/KEYS
>> > [5]
>> >
>> >
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346878
>> > [6]
>> >
>> >
>> https://gitbox.apache.org/repos/asf?p=flink-statefun.git;a=commit;h=752e07fd9987ee430eb9d1c1d3fadff632ef9213
>> > [7] https://github.com/apache/flink-statefun/tree/release-2.0.0-rc3
>> > [8]
>> >
>> >
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Creating-a-new-repo-to-host-Stateful-Functions-Dockerfiles-td39342.html
>> > [9] https://ci.apache.org/projects/flink/flink-statefun-docs-master/
>> > [10]
>> https://ci.apache.org/projects/flink/flink-statefun-docs-release-2.0/
>> >
>> > TIP: You can create a `settings.xml` file with these contents:
>> >
>> > """
>> > <settings>
>> >   <activeProfiles>
>> >     <activeProfile>flink-statefun-2.0.0</activeProfile>
>> >   </activeProfiles>
>> >   <profiles>
>> >     <profile>
>> >       <id>flink-statefun-2.0.0</id>
>> >       <repositories>
>> >         <repository>
>> >           <id>flink-statefun-2.0.0</id>
>> >           <url>
>> > https://repository.apache.org/content/repositories/orgapacheflink-1342/
>> > </url>
>> >         </repository>
>> >         <repository>
>> >           <id>archetype</id>
>> >           <url>
>> > https://repository.apache.org/content/repositories/orgapacheflink-1342/
>> > </url>
>> >         </repository>
>> >       </repositories>
>> >     </profile>
>> >   </profiles>
>> > </settings>
>> > """
>> >
>> > And reference that in you maven commands via `--settings
>> > path/to/settings.xml`.
>> > This is useful for creating a quickstart based on the staged release and
>> > for building against the staged jars.
>> >
>>
>

[Tzu-Li (Gordon) Tai]

@Hequn Cheng <[hidden email]>
On second thought I think it would not hurt to create a RC4 to fix the
version strings. Will fix those and create that now.

On Mon, Mar 30, 2020 at 12:06 AM Tzu-Li (Gordon) Tai <[hidden email]>
wrote:

>
>
> On Mon, Mar 30, 2020 at 12:00 AM Tzu-Li (Gordon) Tai <[hidden email]>
> wrote:
>
>> @Hequn Cheng <[hidden email]>
>> Good catches again!
>>
>> Regarding the incorrect versions:
>> I think technically those would not be hard blockers, since what matters
>> is their inclusion and licenses being acknowledged.
>> It would still be good to fix those though - could you open a ticket for
>> those?
>>
>
> Here, I mean to fix those in future bugfix releases (if this RC does
> indeed pass the vote as the official release).
>
>
>>
>> Regarding the names of the Python dists -
>> the name of those distributions are generated from the setup.py file, and
>> seems to be a convention used by PyPI.
>> @[hidden email] <[hidden email]>  can you confirm here?
>>
>> On Sun, Mar 29, 2020 at 11:36 PM Hequn Cheng <[hidden email]> wrote:
>>
>>> Hi Gordon,
>>>
>>> Thanks a lot for the new RC. I found some new blockers about licenses:
>>>
>>> - Module statefun-flink-distribution
>>> com.google.protobuf:protobuf-java:3.8.0 (The version should be 3.7.1)
>>>
>>> - Module statefun-ridesharing-example-simulator
>>> com.google.code.findbugs:jsr305:3.0.2:compile (Remove compile)
>>> org.hibernate.validator:hibernate-validator:6.0.17 (Version should be
>>> 6.0.17.Final)
>>> org.jboss.logging:jboss-logging:3.3.2  (Version should be 3.3.2.Final)
>>>
>>> Non-blocker feedback:
>>> - py3 is added in the name of "whl dist" but it is missing in the "source
>>> dist"[1]. Should we make them consistent?
>>>
>>> Best,
>>> Hequn
>>>
>>> [1]
>>> https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc3/
>>>
>>>
>>> On Sun, Mar 29, 2020 at 3:31 PM Tzu-Li (Gordon) Tai <[hidden email]
>>> >
>>> wrote:
>>>
>>> > Hi everyone,
>>> >
>>> > Please review and vote on the *release candidate #3* for the version
>>> 2.0.0
>>> > of Apache Flink Stateful Functions,
>>> > as follows:
>>> > [ ] +1, Approve the release
>>> > [ ] -1, Do not approve the release (please provide specific comments)
>>> >
>>> > **Testing Guideline**
>>> >
>>> > You can find here [1] a doc that we can use for collaborating testing
>>> > efforts.
>>> > The listed testing tasks in the doc also serve as a guideline in what
>>> to
>>> > test for this release.
>>> > If you wish to take ownership of a testing task, simply put your name
>>> down
>>> > in the "Checked by" field of the task.
>>> >
>>> > **Release Overview**
>>> >
>>> > As an overview, the release consists of the following:
>>> > a) Stateful Functions canonical source distribution, to be deployed to
>>> the
>>> > release repository at dist.apache.org
>>> > b) Stateful Functions Python SDK distributions to be deployed to PyPI
>>> > c) Maven artifacts to be deployed to the Maven Central Repository
>>> >
>>> > **Staging Areas to Review**
>>> >
>>> > The staging areas containing the above mentioned artifacts are as
>>> follows,
>>> > for your review:
>>> > * All artifacts for a) and b) can be found in the corresponding dev
>>> > repository at dist.apache.org [2]
>>> > * All artifacts for c) can be found at the Apache Nexus Repository [3]
>>> >
>>> > All artifacts are singed with the
>>> > key 1C1E2394D3194E1944613488F320986D35C33D6A [4]
>>> >
>>> > Other links for your review:
>>> > * JIRA release notes [5]
>>> > * source code tag "release-2.0.0-rc3" [6] [7]
>>> >
>>> > **Extra Remarks**
>>> >
>>> > * Part of the release is also official Docker images for Stateful
>>> > Functions. This can be a separate process, since the creation of those
>>> > relies on the fact that we have distribution jars already deployed to
>>> > Maven. I will follow-up with this after these artifacts are officially
>>> > released.
>>> > In the meantime, there is this discussion [8] ongoing about where to
>>> host
>>> > the StateFun Dockerfiles.
>>> > * The Flink Website and blog post is also being worked on (by Marta) as
>>> > part of the release, to incorporate the new Stateful Functions
>>> project. We
>>> > can follow up with a link to those changes afterwards in this vote
>>> thread,
>>> > but that would not block you to test and cast your votes already.
>>> > * Since the Flink website changes are still being worked on, you will
>>> not
>>> > yet be able to find the Stateful Functions docs from there. Here are
>>> the
>>> > links [9] [10].
>>> >
>>> > **Vote Duration**
>>> >
>>> > The vote will be open for at least 72 hours starting Monday
>>> > *(target end date is Wednesday, April 1st).*
>>> > It is adopted by majority approval, with at least 3 PMC affirmative
>>> votes.
>>> >
>>> > Thanks,
>>> > Gordon
>>> >
>>> > [1]
>>> >
>>> >
>>> https://docs.google.com/document/d/1P9yjwSbPQtul0z2AXMnVolWQbzhxs68suJvzR6xMjcs/edit?usp=sharing
>>> > [2]
>>> https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc3/
>>> > [3]
>>> >
>>> https://repository.apache.org/content/repositories/orgapacheflink-1342/
>>> > [4] https://dist.apache.org/repos/dist/release/flink/KEYS
>>> > [5]
>>> >
>>> >
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346878
>>> > [6]
>>> >
>>> >
>>> https://gitbox.apache.org/repos/asf?p=flink-statefun.git;a=commit;h=752e07fd9987ee430eb9d1c1d3fadff632ef9213
>>> > [7] https://github.com/apache/flink-statefun/tree/release-2.0.0-rc3
>>> > [8]
>>> >
>>> >
>>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Creating-a-new-repo-to-host-Stateful-Functions-Dockerfiles-td39342.html
>>> > [9] https://ci.apache.org/projects/flink/flink-statefun-docs-master/
>>> > [10]
>>> https://ci.apache.org/projects/flink/flink-statefun-docs-release-2.0/
>>> >
>>> > TIP: You can create a `settings.xml` file with these contents:
>>> >
>>> > """
>>> > <settings>
>>> >   <activeProfiles>
>>> >     <activeProfile>flink-statefun-2.0.0</activeProfile>
>>> >   </activeProfiles>
>>> >   <profiles>
>>> >     <profile>
>>> >       <id>flink-statefun-2.0.0</id>
>>> >       <repositories>
>>> >         <repository>
>>> >           <id>flink-statefun-2.0.0</id>
>>> >           <url>
>>> >
>>> https://repository.apache.org/content/repositories/orgapacheflink-1342/
>>> > </url>
>>> >         </repository>
>>> >         <repository>
>>> >           <id>archetype</id>
>>> >           <url>
>>> >
>>> https://repository.apache.org/content/repositories/orgapacheflink-1342/
>>> > </url>
>>> >         </repository>
>>> >       </repositories>
>>> >     </profile>
>>> >   </profiles>
>>> > </settings>
>>> > """
>>> >
>>> > And reference that in you maven commands via `--settings
>>> > path/to/settings.xml`.
>>> > This is useful for creating a quickstart based on the staged release
>>> and
>>> > for building against the staged jars.
>>> >
>>>
>>

[Igal Shilman]

Hi @Hequn Cheng <[hidden email]>, and @Tzu-Li (Gordon) Tai
<[hidden email]>
Indeed the names are generated automatically and are following a convention.

Cheers,
Igal.

On Sun, Mar 29, 2020 at 6:28 PM Tzu-Li (Gordon) Tai <[hidden email]>
wrote:

> @Hequn Cheng <[hidden email]>
> On second thought I think it would not hurt to create a RC4 to fix the
> version strings. Will fix those and create that now.
>
> On Mon, Mar 30, 2020 at 12:06 AM Tzu-Li (Gordon) Tai <[hidden email]>
> wrote:
>
>>
>>
>> On Mon, Mar 30, 2020 at 12:00 AM Tzu-Li (Gordon) Tai <[hidden email]>
>> wrote:
>>
>>> @Hequn Cheng <[hidden email]>
>>> Good catches again!
>>>
>>> Regarding the incorrect versions:
>>> I think technically those would not be hard blockers, since what matters
>>> is their inclusion and licenses being acknowledged.
>>> It would still be good to fix those though - could you open a ticket for
>>> those?
>>>
>>
>> Here, I mean to fix those in future bugfix releases (if this RC does
>> indeed pass the vote as the official release).
>>
>>
>>>
>>> Regarding the names of the Python dists -
>>> the name of those distributions are generated from the setup.py file,
>>> and seems to be a convention used by PyPI.
>>> @[hidden email] <[hidden email]>  can you confirm here?
>>>
>>> On Sun, Mar 29, 2020 at 11:36 PM Hequn Cheng <[hidden email]> wrote:
>>>
>>>> Hi Gordon,
>>>>
>>>> Thanks a lot for the new RC. I found some new blockers about licenses:
>>>>
>>>> - Module statefun-flink-distribution
>>>> com.google.protobuf:protobuf-java:3.8.0 (The version should be 3.7.1)
>>>>
>>>> - Module statefun-ridesharing-example-simulator
>>>> com.google.code.findbugs:jsr305:3.0.2:compile (Remove compile)
>>>> org.hibernate.validator:hibernate-validator:6.0.17 (Version should be
>>>> 6.0.17.Final)
>>>> org.jboss.logging:jboss-logging:3.3.2  (Version should be 3.3.2.Final)
>>>>
>>>> Non-blocker feedback:
>>>> - py3 is added in the name of "whl dist" but it is missing in the
>>>> "source
>>>> dist"[1]. Should we make them consistent?
>>>>
>>>> Best,
>>>> Hequn
>>>>
>>>> [1]
>>>> https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc3/
>>>>
>>>>
>>>> On Sun, Mar 29, 2020 at 3:31 PM Tzu-Li (Gordon) Tai <
>>>> [hidden email]>
>>>> wrote:
>>>>
>>>> > Hi everyone,
>>>> >
>>>> > Please review and vote on the *release candidate #3* for the version
>>>> 2.0.0
>>>> > of Apache Flink Stateful Functions,
>>>> > as follows:
>>>> > [ ] +1, Approve the release
>>>> > [ ] -1, Do not approve the release (please provide specific comments)
>>>> >
>>>> > **Testing Guideline**
>>>> >
>>>> > You can find here [1] a doc that we can use for collaborating testing
>>>> > efforts.
>>>> > The listed testing tasks in the doc also serve as a guideline in what
>>>> to
>>>> > test for this release.
>>>> > If you wish to take ownership of a testing task, simply put your name
>>>> down
>>>> > in the "Checked by" field of the task.
>>>> >
>>>> > **Release Overview**
>>>> >
>>>> > As an overview, the release consists of the following:
>>>> > a) Stateful Functions canonical source distribution, to be deployed
>>>> to the
>>>> > release repository at dist.apache.org
>>>> > b) Stateful Functions Python SDK distributions to be deployed to PyPI
>>>> > c) Maven artifacts to be deployed to the Maven Central Repository
>>>> >
>>>> > **Staging Areas to Review**
>>>> >
>>>> > The staging areas containing the above mentioned artifacts are as
>>>> follows,
>>>> > for your review:
>>>> > * All artifacts for a) and b) can be found in the corresponding dev
>>>> > repository at dist.apache.org [2]
>>>> > * All artifacts for c) can be found at the Apache Nexus Repository [3]
>>>> >
>>>> > All artifacts are singed with the
>>>> > key 1C1E2394D3194E1944613488F320986D35C33D6A [4]
>>>> >
>>>> > Other links for your review:
>>>> > * JIRA release notes [5]
>>>> > * source code tag "release-2.0.0-rc3" [6] [7]
>>>> >
>>>> > **Extra Remarks**
>>>> >
>>>> > * Part of the release is also official Docker images for Stateful
>>>> > Functions. This can be a separate process, since the creation of those
>>>> > relies on the fact that we have distribution jars already deployed to
>>>> > Maven. I will follow-up with this after these artifacts are officially
>>>> > released.
>>>> > In the meantime, there is this discussion [8] ongoing about where to
>>>> host
>>>> > the StateFun Dockerfiles.
>>>> > * The Flink Website and blog post is also being worked on (by Marta)
>>>> as
>>>> > part of the release, to incorporate the new Stateful Functions
>>>> project. We
>>>> > can follow up with a link to those changes afterwards in this vote
>>>> thread,
>>>> > but that would not block you to test and cast your votes already.
>>>> > * Since the Flink website changes are still being worked on, you will
>>>> not
>>>> > yet be able to find the Stateful Functions docs from there. Here are
>>>> the
>>>> > links [9] [10].
>>>> >
>>>> > **Vote Duration**
>>>> >
>>>> > The vote will be open for at least 72 hours starting Monday
>>>> > *(target end date is Wednesday, April 1st).*
>>>> > It is adopted by majority approval, with at least 3 PMC affirmative
>>>> votes.
>>>> >
>>>> > Thanks,
>>>> > Gordon
>>>> >
>>>> > [1]
>>>> >
>>>> >
>>>> https://docs.google.com/document/d/1P9yjwSbPQtul0z2AXMnVolWQbzhxs68suJvzR6xMjcs/edit?usp=sharing
>>>> > [2]
>>>> https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc3/
>>>> > [3]
>>>> >
>>>> https://repository.apache.org/content/repositories/orgapacheflink-1342/
>>>> > [4] https://dist.apache.org/repos/dist/release/flink/KEYS
>>>> > [5]
>>>> >
>>>> >
>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346878
>>>> > [6]
>>>> >
>>>> >
>>>> https://gitbox.apache.org/repos/asf?p=flink-statefun.git;a=commit;h=752e07fd9987ee430eb9d1c1d3fadff632ef9213
>>>> > [7] https://github.com/apache/flink-statefun/tree/release-2.0.0-rc3
>>>> > [8]
>>>> >
>>>> >
>>>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Creating-a-new-repo-to-host-Stateful-Functions-Dockerfiles-td39342.html
>>>> > [9] https://ci.apache.org/projects/flink/flink-statefun-docs-master/
>>>> > [10]
>>>> https://ci.apache.org/projects/flink/flink-statefun-docs-release-2.0/
>>>> >
>>>> > TIP: You can create a `settings.xml` file with these contents:
>>>> >
>>>> > """
>>>> > <settings>
>>>> >   <activeProfiles>
>>>> >     <activeProfile>flink-statefun-2.0.0</activeProfile>
>>>> >   </activeProfiles>
>>>> >   <profiles>
>>>> >     <profile>
>>>> >       <id>flink-statefun-2.0.0</id>
>>>> >       <repositories>
>>>> >         <repository>
>>>> >           <id>flink-statefun-2.0.0</id>
>>>> >           <url>
>>>> >
>>>> https://repository.apache.org/content/repositories/orgapacheflink-1342/
>>>> > </url>
>>>> >         </repository>
>>>> >         <repository>
>>>> >           <id>archetype</id>
>>>> >           <url>
>>>> >
>>>> https://repository.apache.org/content/repositories/orgapacheflink-1342/
>>>> > </url>
>>>> >         </repository>
>>>> >       </repositories>
>>>> >     </profile>
>>>> >   </profiles>
>>>> > </settings>
>>>> > """
>>>> >
>>>> > And reference that in you maven commands via `--settings
>>>> > path/to/settings.xml`.
>>>> > This is useful for creating a quickstart based on the staged release
>>>> and
>>>> > for building against the staged jars.
>>>> >
>>>>
>>>

[Konstantin Knauf-3]

Hi Gordon,

+1 (non-binding)

* built from sources...check
* build python SDK from sources...check
* went through walkthrough based on local builds...check

Cheers,

Konstantin


On Sun, Mar 29, 2020 at 6:30 PM Igal Shilman <[hidden email]> wrote:

> Hi @Hequn Cheng <[hidden email]>, and @Tzu-Li (Gordon) Tai
> <[hidden email]>
> Indeed the names are generated automatically and are following a
> convention.
>
> Cheers,
> Igal.
>
> On Sun, Mar 29, 2020 at 6:28 PM Tzu-Li (Gordon) Tai <[hidden email]>
> wrote:
>
> > @Hequn Cheng <[hidden email]>
> > On second thought I think it would not hurt to create a RC4 to fix the
> > version strings. Will fix those and create that now.
> >
> > On Mon, Mar 30, 2020 at 12:06 AM Tzu-Li (Gordon) Tai <
> [hidden email]>
> > wrote:
> >
> >>
> >>
> >> On Mon, Mar 30, 2020 at 12:00 AM Tzu-Li (Gordon) Tai <
> [hidden email]>
> >> wrote:
> >>
> >>> @Hequn Cheng <[hidden email]>
> >>> Good catches again!
> >>>
> >>> Regarding the incorrect versions:
> >>> I think technically those would not be hard blockers, since what
> matters
> >>> is their inclusion and licenses being acknowledged.
> >>> It would still be good to fix those though - could you open a ticket
> for
> >>> those?
> >>>
> >>
> >> Here, I mean to fix those in future bugfix releases (if this RC does
> >> indeed pass the vote as the official release).
> >>
> >>
> >>>
> >>> Regarding the names of the Python dists -
> >>> the name of those distributions are generated from the setup.py file,
> >>> and seems to be a convention used by PyPI.
> >>> @[hidden email] <[hidden email]>  can you confirm here?
> >>>
> >>> On Sun, Mar 29, 2020 at 11:36 PM Hequn Cheng <[hidden email]> wrote:
> >>>
> >>>> Hi Gordon,
> >>>>
> >>>> Thanks a lot for the new RC. I found some new blockers about licenses:
> >>>>
> >>>> - Module statefun-flink-distribution
> >>>> com.google.protobuf:protobuf-java:3.8.0 (The version should be 3.7.1)
> >>>>
> >>>> - Module statefun-ridesharing-example-simulator
> >>>> com.google.code.findbugs:jsr305:3.0.2:compile (Remove compile)
> >>>> org.hibernate.validator:hibernate-validator:6.0.17 (Version should be
> >>>> 6.0.17.Final)
> >>>> org.jboss.logging:jboss-logging:3.3.2  (Version should be 3.3.2.Final)
> >>>>
> >>>> Non-blocker feedback:
> >>>> - py3 is added in the name of "whl dist" but it is missing in the
> >>>> "source
> >>>> dist"[1]. Should we make them consistent?
> >>>>
> >>>> Best,
> >>>> Hequn
> >>>>
> >>>> [1]
> >>>>
> https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc3/
> >>>>
> >>>>
> >>>> On Sun, Mar 29, 2020 at 3:31 PM Tzu-Li (Gordon) Tai <
> >>>> [hidden email]>
> >>>> wrote:
> >>>>
> >>>> > Hi everyone,
> >>>> >
> >>>> > Please review and vote on the *release candidate #3* for the version
> >>>> 2.0.0
> >>>> > of Apache Flink Stateful Functions,
> >>>> > as follows:
> >>>> > [ ] +1, Approve the release
> >>>> > [ ] -1, Do not approve the release (please provide specific
> comments)
> >>>> >
> >>>> > **Testing Guideline**
> >>>> >
> >>>> > You can find here [1] a doc that we can use for collaborating
> testing
> >>>> > efforts.
> >>>> > The listed testing tasks in the doc also serve as a guideline in
> what
> >>>> to
> >>>> > test for this release.
> >>>> > If you wish to take ownership of a testing task, simply put your
> name
> >>>> down
> >>>> > in the "Checked by" field of the task.
> >>>> >
> >>>> > **Release Overview**
> >>>> >
> >>>> > As an overview, the release consists of the following:
> >>>> > a) Stateful Functions canonical source distribution, to be deployed
> >>>> to the
> >>>> > release repository at dist.apache.org
> >>>> > b) Stateful Functions Python SDK distributions to be deployed to
> PyPI
> >>>> > c) Maven artifacts to be deployed to the Maven Central Repository
> >>>> >
> >>>> > **Staging Areas to Review**
> >>>> >
> >>>> > The staging areas containing the above mentioned artifacts are as
> >>>> follows,
> >>>> > for your review:
> >>>> > * All artifacts for a) and b) can be found in the corresponding dev
> >>>> > repository at dist.apache.org [2]
> >>>> > * All artifacts for c) can be found at the Apache Nexus Repository
> [3]
> >>>> >
> >>>> > All artifacts are singed with the
> >>>> > key 1C1E2394D3194E1944613488F320986D35C33D6A [4]
> >>>> >
> >>>> > Other links for your review:
> >>>> > * JIRA release notes [5]
> >>>> > * source code tag "release-2.0.0-rc3" [6] [7]
> >>>> >
> >>>> > **Extra Remarks**
> >>>> >
> >>>> > * Part of the release is also official Docker images for Stateful
> >>>> > Functions. This can be a separate process, since the creation of
> those
> >>>> > relies on the fact that we have distribution jars already deployed
> to
> >>>> > Maven. I will follow-up with this after these artifacts are
> officially
> >>>> > released.
> >>>> > In the meantime, there is this discussion [8] ongoing about where to
> >>>> host
> >>>> > the StateFun Dockerfiles.
> >>>> > * The Flink Website and blog post is also being worked on (by Marta)
> >>>> as
> >>>> > part of the release, to incorporate the new Stateful Functions
> >>>> project. We
> >>>> > can follow up with a link to those changes afterwards in this vote
> >>>> thread,
> >>>> > but that would not block you to test and cast your votes already.
> >>>> > * Since the Flink website changes are still being worked on, you
> will
> >>>> not
> >>>> > yet be able to find the Stateful Functions docs from there. Here are
> >>>> the
> >>>> > links [9] [10].
> >>>> >
> >>>> > **Vote Duration**
> >>>> >
> >>>> > The vote will be open for at least 72 hours starting Monday
> >>>> > *(target end date is Wednesday, April 1st).*
> >>>> > It is adopted by majority approval, with at least 3 PMC affirmative
> >>>> votes.
> >>>> >
> >>>> > Thanks,
> >>>> > Gordon
> >>>> >
> >>>> > [1]
> >>>> >
> >>>> >
> >>>>
> https://docs.google.com/document/d/1P9yjwSbPQtul0z2AXMnVolWQbzhxs68suJvzR6xMjcs/edit?usp=sharing
> >>>> > [2]
> >>>>
> https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc3/
> >>>> > [3]
> >>>> >
> >>>>
> https://repository.apache.org/content/repositories/orgapacheflink-1342/
> >>>> > [4] https://dist.apache.org/repos/dist/release/flink/KEYS
> >>>> > [5]
> >>>> >
> >>>> >
> >>>>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346878
> >>>> > [6]
> >>>> >
> >>>> >
> >>>>
> https://gitbox.apache.org/repos/asf?p=flink-statefun.git;a=commit;h=752e07fd9987ee430eb9d1c1d3fadff632ef9213
> >>>> > [7] https://github.com/apache/flink-statefun/tree/release-2.0.0-rc3
> >>>> > [8]
> >>>> >
> >>>> >
> >>>>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Creating-a-new-repo-to-host-Stateful-Functions-Dockerfiles-td39342.html
> >>>> > [9]
> https://ci.apache.org/projects/flink/flink-statefun-docs-master/
> >>>> > [10]
> >>>> https://ci.apache.org/projects/flink/flink-statefun-docs-release-2.0/
> >>>> >
> >>>> > TIP: You can create a `settings.xml` file with these contents:
> >>>> >
> >>>> > """
> >>>> > <settings>
> >>>> >   <activeProfiles>
> >>>> >     <activeProfile>flink-statefun-2.0.0</activeProfile>
> >>>> >   </activeProfiles>
> >>>> >   <profiles>
> >>>> >     <profile>
> >>>> >       <id>flink-statefun-2.0.0</id>
> >>>> >       <repositories>
> >>>> >         <repository>
> >>>> >           <id>flink-statefun-2.0.0</id>
> >>>> >           <url>
> >>>> >
> >>>>
> https://repository.apache.org/content/repositories/orgapacheflink-1342/
> >>>> > </url>
> >>>> >         </repository>
> >>>> >         <repository>
> >>>> >           <id>archetype</id>
> >>>> >           <url>
> >>>> >
> >>>>
> https://repository.apache.org/content/repositories/orgapacheflink-1342/
> >>>> > </url>
> >>>> >         </repository>
> >>>> >       </repositories>
> >>>> >     </profile>
> >>>> >   </profiles>
> >>>> > </settings>
> >>>> > """
> >>>> >
> >>>> > And reference that in you maven commands via `--settings
> >>>> > path/to/settings.xml`.
> >>>> > This is useful for creating a quickstart based on the staged release
> >>>> and
> >>>> > for building against the staged jars.
> >>>> >
> >>>>
> >>>
>

--

Konstantin Knauf | Head of Product

[phone]


Follow us @VervericaData Ververica <https://www.ververica.com/>


--

Join Flink Forward <https://flink-forward.org/> - The Apache Flink
Conference

Stream Processing | Event Driven | Real Time

--

Ververica GmbH | Invalidenstrasse 115, 10115 Berlin, Germany

--
Ververica GmbH
Registered at Amtsgericht Charlottenburg: HRB 158244 B
Managing Directors: Timothy Alexander Steinert, Yip Park Tung Jason, Ji
(Tony) Cheng

[Hequn Cheng-2]

Hi,

@Gordon I have created the corresponding JIRAs and PRs for the license
problems:
- https://issues.apache.org/jira/browse/FLINK-16853
- https://issues.apache.org/jira/browse/FLINK-16854

@Igal @Gordon, Thanks a lot for the confirmation of the package name, that
addresses my concerns now.

Best,
Hequn

On Mon, Mar 30, 2020 at 4:10 AM Konstantin Knauf <[hidden email]>
wrote:

> Hi Gordon,
>
> +1 (non-binding)
>
> * built from sources...check
> * build python SDK from sources...check
> * went through walkthrough based on local builds...check
>
> Cheers,
>
> Konstantin
>
>
> On Sun, Mar 29, 2020 at 6:30 PM Igal Shilman <[hidden email]> wrote:
>
>> Hi @Hequn Cheng <[hidden email]>, and @Tzu-Li (Gordon) Tai
>> <[hidden email]>
>> Indeed the names are generated automatically and are following a
>> convention.
>>
>> Cheers,
>> Igal.
>>
>> On Sun, Mar 29, 2020 at 6:28 PM Tzu-Li (Gordon) Tai <[hidden email]>
>> wrote:
>>
>> > @Hequn Cheng <[hidden email]>
>> > On second thought I think it would not hurt to create a RC4 to fix the
>> > version strings. Will fix those and create that now.
>> >
>> > On Mon, Mar 30, 2020 at 12:06 AM Tzu-Li (Gordon) Tai <
>> [hidden email]>
>> > wrote:
>> >
>> >>
>> >>
>> >> On Mon, Mar 30, 2020 at 12:00 AM Tzu-Li (Gordon) Tai <
>> [hidden email]>
>> >> wrote:
>> >>
>> >>> @Hequn Cheng <[hidden email]>
>> >>> Good catches again!
>> >>>
>> >>> Regarding the incorrect versions:
>> >>> I think technically those would not be hard blockers, since what
>> matters
>> >>> is their inclusion and licenses being acknowledged.
>> >>> It would still be good to fix those though - could you open a ticket
>> for
>> >>> those?
>> >>>
>> >>
>> >> Here, I mean to fix those in future bugfix releases (if this RC does
>> >> indeed pass the vote as the official release).
>> >>
>> >>
>> >>>
>> >>> Regarding the names of the Python dists -
>> >>> the name of those distributions are generated from the setup.py file,
>> >>> and seems to be a convention used by PyPI.
>> >>> @[hidden email] <[hidden email]>  can you confirm here?
>> >>>
>> >>> On Sun, Mar 29, 2020 at 11:36 PM Hequn Cheng <[hidden email]>
>> wrote:
>> >>>
>> >>>> Hi Gordon,
>> >>>>
>> >>>> Thanks a lot for the new RC. I found some new blockers about
>> licenses:
>> >>>>
>> >>>> - Module statefun-flink-distribution
>> >>>> com.google.protobuf:protobuf-java:3.8.0 (The version should be 3.7.1)
>> >>>>
>> >>>> - Module statefun-ridesharing-example-simulator
>> >>>> com.google.code.findbugs:jsr305:3.0.2:compile (Remove compile)
>> >>>> org.hibernate.validator:hibernate-validator:6.0.17 (Version should be
>> >>>> 6.0.17.Final)
>> >>>> org.jboss.logging:jboss-logging:3.3.2  (Version should be
>> 3.3.2.Final)
>> >>>>
>> >>>> Non-blocker feedback:
>> >>>> - py3 is added in the name of "whl dist" but it is missing in the
>> >>>> "source
>> >>>> dist"[1]. Should we make them consistent?
>> >>>>
>> >>>> Best,
>> >>>> Hequn
>> >>>>
>> >>>> [1]
>> >>>>
>> https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc3/
>> >>>>
>> >>>>
>> >>>> On Sun, Mar 29, 2020 at 3:31 PM Tzu-Li (Gordon) Tai <
>> >>>> [hidden email]>
>> >>>> wrote:
>> >>>>
>> >>>> > Hi everyone,
>> >>>> >
>> >>>> > Please review and vote on the *release candidate #3* for the
>> version
>> >>>> 2.0.0
>> >>>> > of Apache Flink Stateful Functions,
>> >>>> > as follows:
>> >>>> > [ ] +1, Approve the release
>> >>>> > [ ] -1, Do not approve the release (please provide specific
>> comments)
>> >>>> >
>> >>>> > **Testing Guideline**
>> >>>> >
>> >>>> > You can find here [1] a doc that we can use for collaborating
>> testing
>> >>>> > efforts.
>> >>>> > The listed testing tasks in the doc also serve as a guideline in
>> what
>> >>>> to
>> >>>> > test for this release.
>> >>>> > If you wish to take ownership of a testing task, simply put your
>> name
>> >>>> down
>> >>>> > in the "Checked by" field of the task.
>> >>>> >
>> >>>> > **Release Overview**
>> >>>> >
>> >>>> > As an overview, the release consists of the following:
>> >>>> > a) Stateful Functions canonical source distribution, to be deployed
>> >>>> to the
>> >>>> > release repository at dist.apache.org
>> >>>> > b) Stateful Functions Python SDK distributions to be deployed to
>> PyPI
>> >>>> > c) Maven artifacts to be deployed to the Maven Central Repository
>> >>>> >
>> >>>> > **Staging Areas to Review**
>> >>>> >
>> >>>> > The staging areas containing the above mentioned artifacts are as
>> >>>> follows,
>> >>>> > for your review:
>> >>>> > * All artifacts for a) and b) can be found in the corresponding dev
>> >>>> > repository at dist.apache.org [2]
>> >>>> > * All artifacts for c) can be found at the Apache Nexus Repository
>> [3]
>> >>>> >
>> >>>> > All artifacts are singed with the
>> >>>> > key 1C1E2394D3194E1944613488F320986D35C33D6A [4]
>> >>>> >
>> >>>> > Other links for your review:
>> >>>> > * JIRA release notes [5]
>> >>>> > * source code tag "release-2.0.0-rc3" [6] [7]
>> >>>> >
>> >>>> > **Extra Remarks**
>> >>>> >
>> >>>> > * Part of the release is also official Docker images for Stateful
>> >>>> > Functions. This can be a separate process, since the creation of
>> those
>> >>>> > relies on the fact that we have distribution jars already deployed
>> to
>> >>>> > Maven. I will follow-up with this after these artifacts are
>> officially
>> >>>> > released.
>> >>>> > In the meantime, there is this discussion [8] ongoing about where
>> to
>> >>>> host
>> >>>> > the StateFun Dockerfiles.
>> >>>> > * The Flink Website and blog post is also being worked on (by
>> Marta)
>> >>>> as
>> >>>> > part of the release, to incorporate the new Stateful Functions
>> >>>> project. We
>> >>>> > can follow up with a link to those changes afterwards in this vote
>> >>>> thread,
>> >>>> > but that would not block you to test and cast your votes already.
>> >>>> > * Since the Flink website changes are still being worked on, you
>> will
>> >>>> not
>> >>>> > yet be able to find the Stateful Functions docs from there. Here
>> are
>> >>>> the
>> >>>> > links [9] [10].
>> >>>> >
>> >>>> > **Vote Duration**
>> >>>> >
>> >>>> > The vote will be open for at least 72 hours starting Monday
>> >>>> > *(target end date is Wednesday, April 1st).*
>> >>>> > It is adopted by majority approval, with at least 3 PMC affirmative
>> >>>> votes.
>> >>>> >
>> >>>> > Thanks,
>> >>>> > Gordon
>> >>>> >
>> >>>> > [1]
>> >>>> >
>> >>>> >
>> >>>>
>> https://docs.google.com/document/d/1P9yjwSbPQtul0z2AXMnVolWQbzhxs68suJvzR6xMjcs/edit?usp=sharing
>> >>>> > [2]
>> >>>>
>> https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc3/
>> >>>> > [3]
>> >>>> >
>> >>>>
>> https://repository.apache.org/content/repositories/orgapacheflink-1342/
>> >>>> > [4] https://dist.apache.org/repos/dist/release/flink/KEYS
>> >>>> > [5]
>> >>>> >
>> >>>> >
>> >>>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346878
>> >>>> > [6]
>> >>>> >
>> >>>> >
>> >>>>
>> https://gitbox.apache.org/repos/asf?p=flink-statefun.git;a=commit;h=752e07fd9987ee430eb9d1c1d3fadff632ef9213
>> >>>> > [7]
>> https://github.com/apache/flink-statefun/tree/release-2.0.0-rc3
>> >>>> > [8]
>> >>>> >
>> >>>> >
>> >>>>
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Creating-a-new-repo-to-host-Stateful-Functions-Dockerfiles-td39342.html
>> >>>> > [9]
>> https://ci.apache.org/projects/flink/flink-statefun-docs-master/
>> >>>> > [10]
>> >>>>
>> https://ci.apache.org/projects/flink/flink-statefun-docs-release-2.0/
>> >>>> >
>> >>>> > TIP: You can create a `settings.xml` file with these contents:
>> >>>> >
>> >>>> > """
>> >>>> > <settings>
>> >>>> >   <activeProfiles>
>> >>>> >     <activeProfile>flink-statefun-2.0.0</activeProfile>
>> >>>> >   </activeProfiles>
>> >>>> >   <profiles>
>> >>>> >     <profile>
>> >>>> >       <id>flink-statefun-2.0.0</id>
>> >>>> >       <repositories>
>> >>>> >         <repository>
>> >>>> >           <id>flink-statefun-2.0.0</id>
>> >>>> >           <url>
>> >>>> >
>> >>>>
>> https://repository.apache.org/content/repositories/orgapacheflink-1342/
>> >>>> > </url>
>> >>>> >         </repository>
>> >>>> >         <repository>
>> >>>> >           <id>archetype</id>
>> >>>> >           <url>
>> >>>> >
>> >>>>
>> https://repository.apache.org/content/repositories/orgapacheflink-1342/
>> >>>> > </url>
>> >>>> >         </repository>
>> >>>> >       </repositories>
>> >>>> >     </profile>
>> >>>> >   </profiles>
>> >>>> > </settings>
>> >>>> > """
>> >>>> >
>> >>>> > And reference that in you maven commands via `--settings
>> >>>> > path/to/settings.xml`.
>> >>>> > This is useful for creating a quickstart based on the staged
>> release
>> >>>> and
>> >>>> > for building against the staged jars.
>> >>>> >
>> >>>>
>> >>>
>>
>
>
> --
>
> Konstantin Knauf | Head of Product
>
> [phone]
>
>
> Follow us @VervericaData Ververica <https://www.ververica.com/>
>
>
> --
>
> Join Flink Forward <https://flink-forward.org/> - The Apache Flink
> Conference
>
> Stream Processing | Event Driven | Real Time
>
> --
>
> Ververica GmbH | Invalidenstrasse 115, 10115 Berlin, Germany
>
> --
> Ververica GmbH
> Registered at Amtsgericht Charlottenburg: HRB 158244 B
> Managing Directors: Timothy Alexander Steinert, Yip Park Tung Jason, Ji
> (Tony) Cheng
>

[Tzu-Li (Gordon) Tai]

Thanks.

The licensing issues that Hequn found are fixed in RC4:
http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/VOTE-Apache-Flink-Stateful-Functions-Release-2-0-0-release-candidate-4-td39453.html

This vote thread is hereby cancelled.
Since the new RC4 only fixes licensing issues and does not touch the code,
I'd like to keep with the original voting period of RC3 there (ending this
Wednesday).

For those that who have voted already, @Hequn @Konstantin
Could you "forward-port" your checks / votes on the new RC?

Thanks!

On Mon, Mar 30, 2020 at 10:13 AM Hequn Cheng <[hidden email]> wrote:

> Hi,
>
> @Gordon I have created the corresponding JIRAs and PRs for the license
> problems:
> - https://issues.apache.org/jira/browse/FLINK-16853
> - https://issues.apache.org/jira/browse/FLINK-16854
>
> @Igal @Gordon, Thanks a lot for the confirmation of the package name, that
> addresses my concerns now.
>
> Best,
> Hequn
>
> On Mon, Mar 30, 2020 at 4:10 AM Konstantin Knauf <[hidden email]>
> wrote:
>
>> Hi Gordon,
>>
>> +1 (non-binding)
>>
>> * built from sources...check
>> * build python SDK from sources...check
>> * went through walkthrough based on local builds...check
>>
>> Cheers,
>>
>> Konstantin
>>
>>
>> On Sun, Mar 29, 2020 at 6:30 PM Igal Shilman <[hidden email]> wrote:
>>
>>> Hi @Hequn Cheng <[hidden email]>, and @Tzu-Li (Gordon) Tai
>>> <[hidden email]>
>>> Indeed the names are generated automatically and are following a
>>> convention.
>>>
>>> Cheers,
>>> Igal.
>>>
>>> On Sun, Mar 29, 2020 at 6:28 PM Tzu-Li (Gordon) Tai <[hidden email]
>>> >
>>> wrote:
>>>
>>> > @Hequn Cheng <[hidden email]>
>>> > On second thought I think it would not hurt to create a RC4 to fix the
>>> > version strings. Will fix those and create that now.
>>> >
>>> > On Mon, Mar 30, 2020 at 12:06 AM Tzu-Li (Gordon) Tai <
>>> [hidden email]>
>>> > wrote:
>>> >
>>> >>
>>> >>
>>> >> On Mon, Mar 30, 2020 at 12:00 AM Tzu-Li (Gordon) Tai <
>>> [hidden email]>
>>> >> wrote:
>>> >>
>>> >>> @Hequn Cheng <[hidden email]>
>>> >>> Good catches again!
>>> >>>
>>> >>> Regarding the incorrect versions:
>>> >>> I think technically those would not be hard blockers, since what
>>> matters
>>> >>> is their inclusion and licenses being acknowledged.
>>> >>> It would still be good to fix those though - could you open a ticket
>>> for
>>> >>> those?
>>> >>>
>>> >>
>>> >> Here, I mean to fix those in future bugfix releases (if this RC does
>>> >> indeed pass the vote as the official release).
>>> >>
>>> >>
>>> >>>
>>> >>> Regarding the names of the Python dists -
>>> >>> the name of those distributions are generated from the setup.py file,
>>> >>> and seems to be a convention used by PyPI.
>>> >>> @[hidden email] <[hidden email]>  can you confirm here?
>>> >>>
>>> >>> On Sun, Mar 29, 2020 at 11:36 PM Hequn Cheng <[hidden email]>
>>> wrote:
>>> >>>
>>> >>>> Hi Gordon,
>>> >>>>
>>> >>>> Thanks a lot for the new RC. I found some new blockers about
>>> licenses:
>>> >>>>
>>> >>>> - Module statefun-flink-distribution
>>> >>>> com.google.protobuf:protobuf-java:3.8.0 (The version should be
>>> 3.7.1)
>>> >>>>
>>> >>>> - Module statefun-ridesharing-example-simulator
>>> >>>> com.google.code.findbugs:jsr305:3.0.2:compile (Remove compile)
>>> >>>> org.hibernate.validator:hibernate-validator:6.0.17 (Version should
>>> be
>>> >>>> 6.0.17.Final)
>>> >>>> org.jboss.logging:jboss-logging:3.3.2  (Version should be
>>> 3.3.2.Final)
>>> >>>>
>>> >>>> Non-blocker feedback:
>>> >>>> - py3 is added in the name of "whl dist" but it is missing in the
>>> >>>> "source
>>> >>>> dist"[1]. Should we make them consistent?
>>> >>>>
>>> >>>> Best,
>>> >>>> Hequn
>>> >>>>
>>> >>>> [1]
>>> >>>>
>>> https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc3/
>>> >>>>
>>> >>>>
>>> >>>> On Sun, Mar 29, 2020 at 3:31 PM Tzu-Li (Gordon) Tai <
>>> >>>> [hidden email]>
>>> >>>> wrote:
>>> >>>>
>>> >>>> > Hi everyone,
>>> >>>> >
>>> >>>> > Please review and vote on the *release candidate #3* for the
>>> version
>>> >>>> 2.0.0
>>> >>>> > of Apache Flink Stateful Functions,
>>> >>>> > as follows:
>>> >>>> > [ ] +1, Approve the release
>>> >>>> > [ ] -1, Do not approve the release (please provide specific
>>> comments)
>>> >>>> >
>>> >>>> > **Testing Guideline**
>>> >>>> >
>>> >>>> > You can find here [1] a doc that we can use for collaborating
>>> testing
>>> >>>> > efforts.
>>> >>>> > The listed testing tasks in the doc also serve as a guideline in
>>> what
>>> >>>> to
>>> >>>> > test for this release.
>>> >>>> > If you wish to take ownership of a testing task, simply put your
>>> name
>>> >>>> down
>>> >>>> > in the "Checked by" field of the task.
>>> >>>> >
>>> >>>> > **Release Overview**
>>> >>>> >
>>> >>>> > As an overview, the release consists of the following:
>>> >>>> > a) Stateful Functions canonical source distribution, to be
>>> deployed
>>> >>>> to the
>>> >>>> > release repository at dist.apache.org
>>> >>>> > b) Stateful Functions Python SDK distributions to be deployed to
>>> PyPI
>>> >>>> > c) Maven artifacts to be deployed to the Maven Central Repository
>>> >>>> >
>>> >>>> > **Staging Areas to Review**
>>> >>>> >
>>> >>>> > The staging areas containing the above mentioned artifacts are as
>>> >>>> follows,
>>> >>>> > for your review:
>>> >>>> > * All artifacts for a) and b) can be found in the corresponding
>>> dev
>>> >>>> > repository at dist.apache.org [2]
>>> >>>> > * All artifacts for c) can be found at the Apache Nexus
>>> Repository [3]
>>> >>>> >
>>> >>>> > All artifacts are singed with the
>>> >>>> > key 1C1E2394D3194E1944613488F320986D35C33D6A [4]
>>> >>>> >
>>> >>>> > Other links for your review:
>>> >>>> > * JIRA release notes [5]
>>> >>>> > * source code tag "release-2.0.0-rc3" [6] [7]
>>> >>>> >
>>> >>>> > **Extra Remarks**
>>> >>>> >
>>> >>>> > * Part of the release is also official Docker images for Stateful
>>> >>>> > Functions. This can be a separate process, since the creation of
>>> those
>>> >>>> > relies on the fact that we have distribution jars already
>>> deployed to
>>> >>>> > Maven. I will follow-up with this after these artifacts are
>>> officially
>>> >>>> > released.
>>> >>>> > In the meantime, there is this discussion [8] ongoing about where
>>> to
>>> >>>> host
>>> >>>> > the StateFun Dockerfiles.
>>> >>>> > * The Flink Website and blog post is also being worked on (by
>>> Marta)
>>> >>>> as
>>> >>>> > part of the release, to incorporate the new Stateful Functions
>>> >>>> project. We
>>> >>>> > can follow up with a link to those changes afterwards in this vote
>>> >>>> thread,
>>> >>>> > but that would not block you to test and cast your votes already.
>>> >>>> > * Since the Flink website changes are still being worked on, you
>>> will
>>> >>>> not
>>> >>>> > yet be able to find the Stateful Functions docs from there. Here
>>> are
>>> >>>> the
>>> >>>> > links [9] [10].
>>> >>>> >
>>> >>>> > **Vote Duration**
>>> >>>> >
>>> >>>> > The vote will be open for at least 72 hours starting Monday
>>> >>>> > *(target end date is Wednesday, April 1st).*
>>> >>>> > It is adopted by majority approval, with at least 3 PMC
>>> affirmative
>>> >>>> votes.
>>> >>>> >
>>> >>>> > Thanks,
>>> >>>> > Gordon
>>> >>>> >
>>> >>>> > [1]
>>> >>>> >
>>> >>>> >
>>> >>>>
>>> https://docs.google.com/document/d/1P9yjwSbPQtul0z2AXMnVolWQbzhxs68suJvzR6xMjcs/edit?usp=sharing
>>> >>>> > [2]
>>> >>>>
>>> https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc3/
>>> >>>> > [3]
>>> >>>> >
>>> >>>>
>>> https://repository.apache.org/content/repositories/orgapacheflink-1342/
>>> >>>> > [4] https://dist.apache.org/repos/dist/release/flink/KEYS
>>> >>>> > [5]
>>> >>>> >
>>> >>>> >
>>> >>>>
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346878
>>> >>>> > [6]
>>> >>>> >
>>> >>>> >
>>> >>>>
>>> https://gitbox.apache.org/repos/asf?p=flink-statefun.git;a=commit;h=752e07fd9987ee430eb9d1c1d3fadff632ef9213
>>> >>>> > [7]
>>> https://github.com/apache/flink-statefun/tree/release-2.0.0-rc3
>>> >>>> > [8]
>>> >>>> >
>>> >>>> >
>>> >>>>
>>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Creating-a-new-repo-to-host-Stateful-Functions-Dockerfiles-td39342.html
>>> >>>> > [9]
>>> https://ci.apache.org/projects/flink/flink-statefun-docs-master/
>>> >>>> > [10]
>>> >>>>
>>> https://ci.apache.org/projects/flink/flink-statefun-docs-release-2.0/
>>> >>>> >
>>> >>>> > TIP: You can create a `settings.xml` file with these contents:
>>> >>>> >
>>> >>>> > """
>>> >>>> > <settings>
>>> >>>> >   <activeProfiles>
>>> >>>> >     <activeProfile>flink-statefun-2.0.0</activeProfile>
>>> >>>> >   </activeProfiles>
>>> >>>> >   <profiles>
>>> >>>> >     <profile>
>>> >>>> >       <id>flink-statefun-2.0.0</id>
>>> >>>> >       <repositories>
>>> >>>> >         <repository>
>>> >>>> >           <id>flink-statefun-2.0.0</id>
>>> >>>> >           <url>
>>> >>>> >
>>> >>>>
>>> https://repository.apache.org/content/repositories/orgapacheflink-1342/
>>> >>>> > </url>
>>> >>>> >         </repository>
>>> >>>> >         <repository>
>>> >>>> >           <id>archetype</id>
>>> >>>> >           <url>
>>> >>>> >
>>> >>>>
>>> https://repository.apache.org/content/repositories/orgapacheflink-1342/
>>> >>>> > </url>
>>> >>>> >         </repository>
>>> >>>> >       </repositories>
>>> >>>> >     </profile>
>>> >>>> >   </profiles>
>>> >>>> > </settings>
>>> >>>> > """
>>> >>>> >
>>> >>>> > And reference that in you maven commands via `--settings
>>> >>>> > path/to/settings.xml`.
>>> >>>> > This is useful for creating a quickstart based on the staged
>>> release
>>> >>>> and
>>> >>>> > for building against the staged jars.
>>> >>>> >
>>> >>>>
>>> >>>
>>>
>>
>>
>> --
>>
>> Konstantin Knauf | Head of Product
>>
>> [phone]
>>
>>
>> Follow us @VervericaData Ververica <https://www.ververica.com/>
>>
>>
>> --
>>
>> Join Flink Forward <https://flink-forward.org/> - The Apache Flink
>> Conference
>>
>> Stream Processing | Event Driven | Real Time
>>
>> --
>>
>> Ververica GmbH | Invalidenstrasse 115, 10115 Berlin, Germany
>>
>> --
>> Ververica GmbH
>> Registered at Amtsgericht Charlottenburg: HRB 158244 B
>> Managing Directors: Timothy Alexander Steinert, Yip Park Tung Jason, Ji
>> (Tony) Cheng
>>
>