Switch to Scala 2.11 as a default build profile

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

Switch to Scala 2.11 as a default build profile

Piotr Nowojski
Hi,

I propose to switch to Scala 2.11 as a default and to have a Scala 2.10 build profile. Now it is other way around. The reason for that is poor support for build profiles in Intellij, I was unable to make it work after I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala 2.10).

As a side note, maybe we should also consider dropping Scala 2.10 support?

Piotrek
Reply | Threaded
Open this post in threaded view
|

Re: Switch to Scala 2.11 as a default build profile

Ted Yu
+1 on using Scale 2.11 as default. 
-------- Original message --------From: Piotr Nowojski <[hidden email]> Date: 6/28/17  5:36 AM  (GMT-08:00) To: [hidden email] Subject: Switch to Scala 2.11 as a default build profile
Hi,

I propose to switch to Scala 2.11 as a default and to have a Scala 2.10 build profile. Now it is other way around. The reason for that is poor support for build profiles in Intellij, I was unable to make it work after I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala 2.10).

As a side note, maybe we should also consider dropping Scala 2.10 support?

Piotrek
Reply | Threaded
Open this post in threaded view
|

Re: Switch to Scala 2.11 as a default build profile

Aljoscha Krettek-2
+1 For changing the default. I think a lot of systems don’t even support 2.10 anymore.

> On 28. Jun 2017, at 14:38, Ted Yu <[hidden email]> wrote:
>
> +1 on using Scale 2.11 as default.
> -------- Original message --------From: Piotr Nowojski <[hidden email]> Date: 6/28/17  5:36 AM  (GMT-08:00) To: [hidden email] Subject: Switch to Scala 2.11 as a default build profile
> Hi,
>
> I propose to switch to Scala 2.11 as a default and to have a Scala 2.10 build profile. Now it is other way around. The reason for that is poor support for build profiles in Intellij, I was unable to make it work after I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala 2.10).
>
> As a side note, maybe we should also consider dropping Scala 2.10 support?
>
> Piotrek

Reply | Threaded
Open this post in threaded view
|

Re: Switch to Scala 2.11 as a default build profile

Piotr Nowojski
I have created an issue for this:

https://issues.apache.org/jira/browse/FLINK-7030 <https://issues.apache.org/jira/browse/FLINK-7030>

and PR:

https://github.com/apache/flink/pull/4209 <https://github.com/apache/flink/pull/4209>

Piotrek

> On Jun 28, 2017, at 2:45 PM, Aljoscha Krettek <[hidden email]> wrote:
>
> +1 For changing the default. I think a lot of systems don’t even support 2.10 anymore.
>
>> On 28. Jun 2017, at 14:38, Ted Yu <[hidden email]> wrote:
>>
>> +1 on using Scale 2.11 as default.
>> -------- Original message --------From: Piotr Nowojski <[hidden email]> Date: 6/28/17  5:36 AM  (GMT-08:00) To: [hidden email] Subject: Switch to Scala 2.11 as a default build profile
>> Hi,
>>
>> I propose to switch to Scala 2.11 as a default and to have a Scala 2.10 build profile. Now it is other way around. The reason for that is poor support for build profiles in Intellij, I was unable to make it work after I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala 2.10).
>>
>> As a side note, maybe we should also consider dropping Scala 2.10 support?
>>
>> Piotrek
>

Reply | Threaded
Open this post in threaded view
|

Re: Switch to Scala 2.11 as a default build profile

Greg Hogan
In reply to this post by Piotr Nowojski
You don't need to use the build profile in IntelliJ, just change
scala.version and scala.binary.version in the parent pom (recent
refactorings made this possible without changing every pom).

What is the benefit for changing the default without dropping older
versions when contributions are still limited to the functionality of the
old version?

On Wed, Jun 28, 2017 at 8:36 AM, Piotr Nowojski <[hidden email]>
wrote:

> Hi,
>
> I propose to switch to Scala 2.11 as a default and to have a Scala 2.10
> build profile. Now it is other way around. The reason for that is poor
> support for build profiles in Intellij, I was unable to make it work after
> I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala 2.10).
>
> As a side note, maybe we should also consider dropping Scala 2.10 support?
>
> Piotrek
Reply | Threaded
Open this post in threaded view
|

Re: Switch to Scala 2.11 as a default build profile

Piotr Nowojski
Yes, I know and I’m proposing to change this in parent pom by default to scala-2.11.

Changing parent pom every time anyone wants to touch/build in Intellij Kafka 0.11 connector is not a great idea. This would require a developer to constantly stash those changes or commit and revert them before creating a pull request.

Piotrek

> On Jun 28, 2017, at 3:49 PM, Greg Hogan <[hidden email]> wrote:
>
> You don't need to use the build profile in IntelliJ, just change
> scala.version and scala.binary.version in the parent pom (recent
> refactorings made this possible without changing every pom).
>
> What is the benefit for changing the default without dropping older
> versions when contributions are still limited to the functionality of the
> old version?
>
> On Wed, Jun 28, 2017 at 8:36 AM, Piotr Nowojski <[hidden email]>
> wrote:
>
>> Hi,
>>
>> I propose to switch to Scala 2.11 as a default and to have a Scala 2.10
>> build profile. Now it is other way around. The reason for that is poor
>> support for build profiles in Intellij, I was unable to make it work after
>> I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala 2.10).
>>
>> As a side note, maybe we should also consider dropping Scala 2.10 support?
>>
>> Piotrek

Reply | Threaded
Open this post in threaded view
|

Re: Switch to Scala 2.11 as a default build profile

Ted Yu
Here is the KIP that drops support for Scala 2.10 in Kafka 0.11 :

https://cwiki.apache.org/confluence/display/KAFKA/KIP-119%3A+Drop+Support+for+Scala+2.10+in+Kafka+0.11

FYI

On Wed, Jun 28, 2017 at 7:23 AM, Piotr Nowojski <[hidden email]>
wrote:

> Yes, I know and I’m proposing to change this in parent pom by default to
> scala-2.11.
>
> Changing parent pom every time anyone wants to touch/build in Intellij
> Kafka 0.11 connector is not a great idea. This would require a developer to
> constantly stash those changes or commit and revert them before creating a
> pull request.
>
> Piotrek
>
> > On Jun 28, 2017, at 3:49 PM, Greg Hogan <[hidden email]> wrote:
> >
> > You don't need to use the build profile in IntelliJ, just change
> > scala.version and scala.binary.version in the parent pom (recent
> > refactorings made this possible without changing every pom).
> >
> > What is the benefit for changing the default without dropping older
> > versions when contributions are still limited to the functionality of the
> > old version?
> >
> > On Wed, Jun 28, 2017 at 8:36 AM, Piotr Nowojski <[hidden email]
> >
> > wrote:
> >
> >> Hi,
> >>
> >> I propose to switch to Scala 2.11 as a default and to have a Scala 2.10
> >> build profile. Now it is other way around. The reason for that is poor
> >> support for build profiles in Intellij, I was unable to make it work
> after
> >> I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala
> 2.10).
> >>
> >> As a side note, maybe we should also consider dropping Scala 2.10
> support?
> >>
> >> Piotrek
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Switch to Scala 2.11 as a default build profile

Till Rohrmann
I'm +1 for changing the profile and to start a discussion to drop Scala
2.10.

Scala 2.10 is already quite old and the current stable version is 2.12. I
would be surprised to see many people still using Scala 2.10.

Cheers,
Till

On Wed, Jun 28, 2017 at 4:53 PM, Ted Yu <[hidden email]> wrote:

> Here is the KIP that drops support for Scala 2.10 in Kafka 0.11 :
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 119%3A+Drop+Support+for+Scala+2.10+in+Kafka+0.11
>
> FYI
>
> On Wed, Jun 28, 2017 at 7:23 AM, Piotr Nowojski <[hidden email]>
> wrote:
>
> > Yes, I know and I’m proposing to change this in parent pom by default to
> > scala-2.11.
> >
> > Changing parent pom every time anyone wants to touch/build in Intellij
> > Kafka 0.11 connector is not a great idea. This would require a developer
> to
> > constantly stash those changes or commit and revert them before creating
> a
> > pull request.
> >
> > Piotrek
> >
> > > On Jun 28, 2017, at 3:49 PM, Greg Hogan <[hidden email]> wrote:
> > >
> > > You don't need to use the build profile in IntelliJ, just change
> > > scala.version and scala.binary.version in the parent pom (recent
> > > refactorings made this possible without changing every pom).
> > >
> > > What is the benefit for changing the default without dropping older
> > > versions when contributions are still limited to the functionality of
> the
> > > old version?
> > >
> > > On Wed, Jun 28, 2017 at 8:36 AM, Piotr Nowojski <
> [hidden email]
> > >
> > > wrote:
> > >
> > >> Hi,
> > >>
> > >> I propose to switch to Scala 2.11 as a default and to have a Scala
> 2.10
> > >> build profile. Now it is other way around. The reason for that is poor
> > >> support for build profiles in Intellij, I was unable to make it work
> > after
> > >> I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala
> > 2.10).
> > >>
> > >> As a side note, maybe we should also consider dropping Scala 2.10
> > support?
> > >>
> > >> Piotrek
> >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Switch to Scala 2.11 as a default build profile

Bowen Li
+1.

AWS EMR eco system is using Scala 2.11, and breaks with Scala 2.10. We had
to build several Flink components (e.g. flink-kinesis-connector) ourselves
in order to run on EMR. Defaulting to Scala 2.11 will greatly reduce
adoption cost for Flink on EMR


On Wed, Jun 28, 2017 at 9:34 AM, Till Rohrmann <[hidden email]> wrote:

> I'm +1 for changing the profile and to start a discussion to drop Scala
> 2.10.
>
> Scala 2.10 is already quite old and the current stable version is 2.12. I
> would be surprised to see many people still using Scala 2.10.
>
> Cheers,
> Till
>
> On Wed, Jun 28, 2017 at 4:53 PM, Ted Yu <[hidden email]> wrote:
>
> > Here is the KIP that drops support for Scala 2.10 in Kafka 0.11 :
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 119%3A+Drop+Support+for+Scala+2.10+in+Kafka+0.11
> >
> > FYI
> >
> > On Wed, Jun 28, 2017 at 7:23 AM, Piotr Nowojski <[hidden email]
> >
> > wrote:
> >
> > > Yes, I know and I’m proposing to change this in parent pom by default
> to
> > > scala-2.11.
> > >
> > > Changing parent pom every time anyone wants to touch/build in Intellij
> > > Kafka 0.11 connector is not a great idea. This would require a
> developer
> > to
> > > constantly stash those changes or commit and revert them before
> creating
> > a
> > > pull request.
> > >
> > > Piotrek
> > >
> > > > On Jun 28, 2017, at 3:49 PM, Greg Hogan <[hidden email]> wrote:
> > > >
> > > > You don't need to use the build profile in IntelliJ, just change
> > > > scala.version and scala.binary.version in the parent pom (recent
> > > > refactorings made this possible without changing every pom).
> > > >
> > > > What is the benefit for changing the default without dropping older
> > > > versions when contributions are still limited to the functionality of
> > the
> > > > old version?
> > > >
> > > > On Wed, Jun 28, 2017 at 8:36 AM, Piotr Nowojski <
> > [hidden email]
> > > >
> > > > wrote:
> > > >
> > > >> Hi,
> > > >>
> > > >> I propose to switch to Scala 2.11 as a default and to have a Scala
> > 2.10
> > > >> build profile. Now it is other way around. The reason for that is
> poor
> > > >> support for build profiles in Intellij, I was unable to make it work
> > > after
> > > >> I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala
> > > 2.10).
> > > >>
> > > >> As a side note, maybe we should also consider dropping Scala 2.10
> > > support?
> > > >>
> > > >> Piotrek
> > >
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Switch to Scala 2.11 as a default build profile

Jörn Franke
EMR has a flink package. Just go to advanced options and but a checkbox on flink. No need to build yourself.

> On 29. Jun 2017, at 05:56, Bowen Li <[hidden email]> wrote:
>
> +1.
>
> AWS EMR eco system is using Scala 2.11, and breaks with Scala 2.10. We had
> to build several Flink components (e.g. flink-kinesis-connector) ourselves
> in order to run on EMR. Defaulting to Scala 2.11 will greatly reduce
> adoption cost for Flink on EMR
>
>
>> On Wed, Jun 28, 2017 at 9:34 AM, Till Rohrmann <[hidden email]> wrote:
>>
>> I'm +1 for changing the profile and to start a discussion to drop Scala
>> 2.10.
>>
>> Scala 2.10 is already quite old and the current stable version is 2.12. I
>> would be surprised to see many people still using Scala 2.10.
>>
>> Cheers,
>> Till
>>
>>> On Wed, Jun 28, 2017 at 4:53 PM, Ted Yu <[hidden email]> wrote:
>>>
>>> Here is the KIP that drops support for Scala 2.10 in Kafka 0.11 :
>>>
>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>>> 119%3A+Drop+Support+for+Scala+2.10+in+Kafka+0.11
>>>
>>> FYI
>>>
>>> On Wed, Jun 28, 2017 at 7:23 AM, Piotr Nowojski <[hidden email]
>>>
>>> wrote:
>>>
>>>> Yes, I know and I’m proposing to change this in parent pom by default
>> to
>>>> scala-2.11.
>>>>
>>>> Changing parent pom every time anyone wants to touch/build in Intellij
>>>> Kafka 0.11 connector is not a great idea. This would require a
>> developer
>>> to
>>>> constantly stash those changes or commit and revert them before
>> creating
>>> a
>>>> pull request.
>>>>
>>>> Piotrek
>>>>
>>>>> On Jun 28, 2017, at 3:49 PM, Greg Hogan <[hidden email]> wrote:
>>>>>
>>>>> You don't need to use the build profile in IntelliJ, just change
>>>>> scala.version and scala.binary.version in the parent pom (recent
>>>>> refactorings made this possible without changing every pom).
>>>>>
>>>>> What is the benefit for changing the default without dropping older
>>>>> versions when contributions are still limited to the functionality of
>>> the
>>>>> old version?
>>>>>
>>>>> On Wed, Jun 28, 2017 at 8:36 AM, Piotr Nowojski <
>>> [hidden email]
>>>>>
>>>>> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I propose to switch to Scala 2.11 as a default and to have a Scala
>>> 2.10
>>>>>> build profile. Now it is other way around. The reason for that is
>> poor
>>>>>> support for build profiles in Intellij, I was unable to make it work
>>>> after
>>>>>> I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala
>>>> 2.10).
>>>>>>
>>>>>> As a side note, maybe we should also consider dropping Scala 2.10
>>>> support?
>>>>>>
>>>>>> Piotrek
>>>>
>>>>
>>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: Re: Switch to Scala 2.11 as a default build profile

郭健
In reply to this post by Piotr Nowojski
+1
Most of the time I need to build scala-2.11 version, although I can use the script tools/change-version.sh to change scala version in all poms, it breaks the code consistency with the  master branch.

Aegeaner


On 6/28/17, 22:23, "Piotr Nowojski" <[hidden email]> wrote:

    Yes, I know and I’m proposing to change this in parent pom by default to scala-2.11.
   
    Changing parent pom every time anyone wants to touch/build in Intellij Kafka 0.11 connector is not a great idea. This would require a developer to constantly stash those changes or commit and revert them before creating a pull request.
   
    Piotrek
   
    > On Jun 28, 2017, at 3:49 PM, Greg Hogan <[hidden email]> wrote:
    >
    > You don't need to use the build profile in IntelliJ, just change
    > scala.version and scala.binary.version in the parent pom (recent
    > refactorings made this possible without changing every pom).
    >
    > What is the benefit for changing the default without dropping older
    > versions when contributions are still limited to the functionality of the
    > old version?
    >
    > On Wed, Jun 28, 2017 at 8:36 AM, Piotr Nowojski <[hidden email]>
    > wrote:
    >
    >> Hi,
    >>
    >> I propose to switch to Scala 2.11 as a default and to have a Scala 2.10
    >> build profile. Now it is other way around. The reason for that is poor
    >> support for build profiles in Intellij, I was unable to make it work after
    >> I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala 2.10).
    >>
    >> As a side note, maybe we should also consider dropping Scala 2.10 support?
    >>
    >> Piotrek
   
   

Reply | Threaded
Open this post in threaded view
|

Re: Re: Switch to Scala 2.11 as a default build profile

Bowen Li
EMR's builtin Flink is always 1 or 2 versions behind Flink latest release.
We choose to install Flink on EMR ourselves.

On Thu, Jun 29, 2017 at 2:37 AM, 郭健 <[hidden email]> wrote:

> +1
> Most of the time I need to build scala-2.11 version, although I can use
> the script tools/change-version.sh to change scala version in all poms, it
> breaks the code consistency with the  master branch.
>
> Aegeaner
>
>
> On 6/28/17, 22:23, "Piotr Nowojski" <[hidden email]> wrote:
>
>     Yes, I know and I’m proposing to change this in parent pom by default
> to scala-2.11.
>
>     Changing parent pom every time anyone wants to touch/build in Intellij
> Kafka 0.11 connector is not a great idea. This would require a developer to
> constantly stash those changes or commit and revert them before creating a
> pull request.
>
>     Piotrek
>
>     > On Jun 28, 2017, at 3:49 PM, Greg Hogan <[hidden email]> wrote:
>     >
>     > You don't need to use the build profile in IntelliJ, just change
>     > scala.version and scala.binary.version in the parent pom (recent
>     > refactorings made this possible without changing every pom).
>     >
>     > What is the benefit for changing the default without dropping older
>     > versions when contributions are still limited to the functionality
> of the
>     > old version?
>     >
>     > On Wed, Jun 28, 2017 at 8:36 AM, Piotr Nowojski <
> [hidden email]>
>     > wrote:
>     >
>     >> Hi,
>     >>
>     >> I propose to switch to Scala 2.11 as a default and to have a Scala
> 2.10
>     >> build profile. Now it is other way around. The reason for that is
> poor
>     >> support for build profiles in Intellij, I was unable to make it
> work after
>     >> I added Kafka 0.11 dependency (Kafka 0.11 dropped support for Scala
> 2.10).
>     >>
>     >> As a side note, maybe we should also consider dropping Scala 2.10
> support?
>     >>
>     >> Piotrek
>
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Re: Switch to Scala 2.11 as a default build profile

Stavros Kontopoulos
+10 I think it makes sense spark is also using 2.11 as the default for
quite some time.

On Thu, Jun 29, 2017 at 8:14 PM, Bowen Li <[hidden email]> wrote:

> EMR's builtin Flink is always 1 or 2 versions behind Flink latest release.
> We choose to install Flink on EMR ourselves.
>
> On Thu, Jun 29, 2017 at 2:37 AM, 郭健 <[hidden email]> wrote:
>
> > +1
> > Most of the time I need to build scala-2.11 version, although I can use
> > the script tools/change-version.sh to change scala version in all poms,
> it
> > breaks the code consistency with the  master branch.
> >
> > Aegeaner
> >
> >
> > On 6/28/17, 22:23, "Piotr Nowojski" <[hidden email]> wrote:
> >
> >     Yes, I know and I’m proposing to change this in parent pom by default
> > to scala-2.11.
> >
> >     Changing parent pom every time anyone wants to touch/build in
> Intellij
> > Kafka 0.11 connector is not a great idea. This would require a developer
> to
> > constantly stash those changes or commit and revert them before creating
> a
> > pull request.
> >
> >     Piotrek
> >
> >     > On Jun 28, 2017, at 3:49 PM, Greg Hogan <[hidden email]>
> wrote:
> >     >
> >     > You don't need to use the build profile in IntelliJ, just change
> >     > scala.version and scala.binary.version in the parent pom (recent
> >     > refactorings made this possible without changing every pom).
> >     >
> >     > What is the benefit for changing the default without dropping older
> >     > versions when contributions are still limited to the functionality
> > of the
> >     > old version?
> >     >
> >     > On Wed, Jun 28, 2017 at 8:36 AM, Piotr Nowojski <
> > [hidden email]>
> >     > wrote:
> >     >
> >     >> Hi,
> >     >>
> >     >> I propose to switch to Scala 2.11 as a default and to have a Scala
> > 2.10
> >     >> build profile. Now it is other way around. The reason for that is
> > poor
> >     >> support for build profiles in Intellij, I was unable to make it
> > work after
> >     >> I added Kafka 0.11 dependency (Kafka 0.11 dropped support for
> Scala
> > 2.10).
> >     >>
> >     >> As a side note, maybe we should also consider dropping Scala 2.10
> > support?
> >     >>
> >     >> Piotrek
> >
> >
> >
> >
>