Scala Utils

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Scala Utils

Sachin Goel
Hi all

Currently, to use the Scala Data Set utility functions, one needs to import
import org.apache.flink.api.scala.DataSetUtils.utilsToDataSet

This is counter-intuitive, extra complicated and should be more in sync
with how Java utils are imported. I propose a package object which can
allow importing utils like
import org.apache.flink.api.scala.utils._

Since this will likely break existing code, I'm seeking opinion whether
this should be done or not. If yes, I will file a JIRA and submit a patch.

Regards
Sachin

-- Sachin Goel
Computer Science, IIT Delhi
m. +91-9871457685
Reply | Threaded
Open this post in threaded view
|

Re: Scala Utils

Aljoscha Krettek-2
I think the utils are a perfect case of for this pattern so I would suggest
to go ahead with this change. It is only about API, there we can use some
scala magic. :D

On Sat, 5 Sep 2015 at 15:39 Sachin Goel <[hidden email]> wrote:

> Hi all
>
> Currently, to use the Scala Data Set utility functions, one needs to import
> import org.apache.flink.api.scala.DataSetUtils.utilsToDataSet
>
> This is counter-intuitive, extra complicated and should be more in sync
> with how Java utils are imported. I propose a package object which can
> allow importing utils like
> import org.apache.flink.api.scala.utils._
>
> Since this will likely break existing code, I'm seeking opinion whether
> this should be done or not. If yes, I will file a JIRA and submit a patch.
>
> Regards
> Sachin
>
> -- Sachin Goel
> Computer Science, IIT Delhi
> m. +91-9871457685
>
Reply | Threaded
Open this post in threaded view
|

Re: Scala Utils

Sachin Goel
Olrite. I will file a JIRA for this.

Cheers!
Sachin

-- Sachin Goel
Computer Science, IIT Delhi
m. +91-9871457685

On Sat, Sep 5, 2015 at 10:14 PM, Aljoscha Krettek <[hidden email]>
wrote:

> I think the utils are a perfect case of for this pattern so I would suggest
> to go ahead with this change. It is only about API, there we can use some
> scala magic. :D
>
> On Sat, 5 Sep 2015 at 15:39 Sachin Goel <[hidden email]> wrote:
>
> > Hi all
> >
> > Currently, to use the Scala Data Set utility functions, one needs to
> import
> > import org.apache.flink.api.scala.DataSetUtils.utilsToDataSet
> >
> > This is counter-intuitive, extra complicated and should be more in sync
> > with how Java utils are imported. I propose a package object which can
> > allow importing utils like
> > import org.apache.flink.api.scala.utils._
> >
> > Since this will likely break existing code, I'm seeking opinion whether
> > this should be done or not. If yes, I will file a JIRA and submit a
> patch.
> >
> > Regards
> > Sachin
> >
> > -- Sachin Goel
> > Computer Science, IIT Delhi
> > m. +91-9871457685
> >
>