Savepoints seem to not work properly on release-1.1 branch

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Savepoints seem to not work properly on release-1.1 branch

Gyula Fóra
Hi,

I think something is not behaving correctly with savepoint/checkpoint
discard on the release-1.1 branch. If I build the release-1.1.4-rc branch
everything works correctly but on the latest 1.1 branch it seems like
savepoints are discarded like checkpoints and cannot be restored after the
job is stopped.

I can take a savepoints, I see it complete. But when I try to restore from
it doesnt find the checkpoint folder anymore. I know that there are tests
for this behaviour but it still seems to happen when I run it on yarn.

Cheers,
Gyula
Reply | Threaded
Open this post in threaded view
|

Re: Savepoints seem to not work properly on release-1.1 branch

Ufuk Celebi-2
Thanks for reporting this Gyula. A fix is available in #2930. We are going to merge that today.

– Ufuk

On 3 December 2016 at 09:56:21, Gyula Fóra ([hidden email]) wrote:

> Hi,
>  
> I think something is not behaving correctly with savepoint/checkpoint
> discard on the release-1.1 branch. If I build the release-1.1.4-rc branch
> everything works correctly but on the latest 1.1 branch it seems like
> savepoints are discarded like checkpoints and cannot be restored after the
> job is stopped.
>  
> I can take a savepoints, I see it complete. But when I try to restore from
> it doesnt find the checkpoint folder anymore. I know that there are tests
> for this behaviour but it still seems to happen when I run it on yarn.
>  
> Cheers,
> Gyula
>  

Reply | Threaded
Open this post in threaded view
|

Re: Savepoints seem to not work properly on release-1.1 branch

Gyula Fóra
Hi,
Thanks for being so quick, I will try the fix as soon as it is merged. :)
Gyula

Ufuk Celebi <[hidden email]> ezt írta (időpont: 2016. dec. 4., V, 12:02):

> Thanks for reporting this Gyula. A fix is available in #2930. We are going
> to merge that today.
>
> – Ufuk
>
> On 3 December 2016 at 09:56:21, Gyula Fóra ([hidden email]) wrote:
> > Hi,
> >
> > I think something is not behaving correctly with savepoint/checkpoint
> > discard on the release-1.1 branch. If I build the release-1.1.4-rc branch
> > everything works correctly but on the latest 1.1 branch it seems like
> > savepoints are discarded like checkpoints and cannot be restored after
> the
> > job is stopped.
> >
> > I can take a savepoints, I see it complete. But when I try to restore
> from
> > it doesnt find the checkpoint folder anymore. I know that there are tests
> > for this behaviour but it still seems to happen when I run it on yarn.
> >
> > Cheers,
> > Gyula
> >
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Savepoints seem to not work properly on release-1.1 branch

Ufuk Celebi-2
Thanks. It has been merged now. :-)

On 4 December 2016 at 17:24:30, Gyula Fóra ([hidden email]) wrote:

> Hi,
> Thanks for being so quick, I will try the fix as soon as it is merged. :)
> Gyula
>  
> Ufuk Celebi ezt írta (időpont: 2016. dec. 4., V, 12:02):
>  
> > Thanks for reporting this Gyula. A fix is available in #2930. We are going
> > to merge that today.
> >
> > – Ufuk
> >
> > On 3 December 2016 at 09:56:21, Gyula Fóra ([hidden email]) wrote:
> > > Hi,
> > >
> > > I think something is not behaving correctly with savepoint/checkpoint
> > > discard on the release-1.1 branch. If I build the release-1.1.4-rc branch
> > > everything works correctly but on the latest 1.1 branch it seems like
> > > savepoints are discarded like checkpoints and cannot be restored after
> > the
> > > job is stopped.
> > >
> > > I can take a savepoints, I see it complete. But when I try to restore
> > from
> > > it doesnt find the checkpoint folder anymore. I know that there are tests
> > > for this behaviour but it still seems to happen when I run it on yarn.
> > >
> > > Cheers,
> > > Gyula
> > >
> >
> >
>  

Reply | Threaded
Open this post in threaded view
|

Re: Savepoints seem to not work properly on release-1.1 branch

Gyula Fóra
I tried it, works fine!

Ufuk Celebi <[hidden email]> ezt írta (időpont: 2016. dec. 4., V, 18:52):

> Thanks. It has been merged now. :-)
>
> On 4 December 2016 at 17:24:30, Gyula Fóra ([hidden email]) wrote:
> > Hi,
> > Thanks for being so quick, I will try the fix as soon as it is merged. :)
> > Gyula
> >
> > Ufuk Celebi ezt írta (időpont: 2016. dec. 4., V, 12:02):
> >
> > > Thanks for reporting this Gyula. A fix is available in #2930. We are
> going
> > > to merge that today.
> > >
> > > – Ufuk
> > >
> > > On 3 December 2016 at 09:56:21, Gyula Fóra ([hidden email])
> wrote:
> > > > Hi,
> > > >
> > > > I think something is not behaving correctly with savepoint/checkpoint
> > > > discard on the release-1.1 branch. If I build the release-1.1.4-rc
> branch
> > > > everything works correctly but on the latest 1.1 branch it seems like
> > > > savepoints are discarded like checkpoints and cannot be restored
> after
> > > the
> > > > job is stopped.
> > > >
> > > > I can take a savepoints, I see it complete. But when I try to restore
> > > from
> > > > it doesnt find the checkpoint folder anymore. I know that there are
> tests
> > > > for this behaviour but it still seems to happen when I run it on
> yarn.
> > > >
> > > > Cheers,
> > > > Gyula
> > > >
> > >
> > >
> >
>
>