Yeah, I spotted a good amount of optimizer tests that depend on the Record
API. I implemented the last optimizer tests with the new API and would volunteer to port the other optimizer tests. 2015-03-10 16:32 GMT+01:00 Stephan Ewen (JIRA) <[hidden email]>: > > [ > https://issues.apache.org/jira/browse/FLINK-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355063#comment-14355063 > ] > > Stephan Ewen commented on FLINK-1106: > ------------------------------------- > > A bit of test coverage depends on the deprecated API. > > We would need to port at least some of the tests to the new API. > > We can probably drop some subsumed / obsolete tests. > > > Deprecate old Record API > > ------------------------ > > > > Key: FLINK-1106 > > URL: https://issues.apache.org/jira/browse/FLINK-1106 > > Project: Flink > > Issue Type: Task > > Components: Java API > > Affects Versions: 0.7.0-incubating > > Reporter: Robert Metzger > > Assignee: Robert Metzger > > Priority: Critical > > Fix For: 0.7.0-incubating > > > > > > For the upcoming 0.7 release, we should mark all user-facing methods > from the old Record Java API as deprecated, with a warning that we are > going to remove it at some point. > > I would suggest to wait one or two releases from the 0.7 release (given > our current release cycle). I'll start a mailing-list discussion at some > point regarding this. > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) > |
And I'm +1 for removing the old API with the next release.
2015-03-10 17:38 GMT+01:00 Fabian Hueske <[hidden email]>: > Yeah, I spotted a good amount of optimizer tests that depend on the Record > API. > I implemented the last optimizer tests with the new API and would > volunteer to port the other optimizer tests. > > 2015-03-10 16:32 GMT+01:00 Stephan Ewen (JIRA) <[hidden email]>: > >> >> [ >> https://issues.apache.org/jira/browse/FLINK-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355063#comment-14355063 >> ] >> >> Stephan Ewen commented on FLINK-1106: >> ------------------------------------- >> >> A bit of test coverage depends on the deprecated API. >> >> We would need to port at least some of the tests to the new API. >> >> We can probably drop some subsumed / obsolete tests. >> >> > Deprecate old Record API >> > ------------------------ >> > >> > Key: FLINK-1106 >> > URL: https://issues.apache.org/jira/browse/FLINK-1106 >> > Project: Flink >> > Issue Type: Task >> > Components: Java API >> > Affects Versions: 0.7.0-incubating >> > Reporter: Robert Metzger >> > Assignee: Robert Metzger >> > Priority: Critical >> > Fix For: 0.7.0-incubating >> > >> > >> > For the upcoming 0.7 release, we should mark all user-facing methods >> from the old Record Java API as deprecated, with a warning that we are >> going to remove it at some point. >> > I would suggest to wait one or two releases from the 0.7 release (given >> our current release cycle). I'll start a mailing-list discussion at some >> point regarding this. >> >> >> >> -- >> This message was sent by Atlassian JIRA >> (v6.3.4#6332) >> > > |
+1 for removal of old API
On Mar 10, 2015 5:41 PM, "Fabian Hueske" <[hidden email]> wrote: > And I'm +1 for removing the old API with the next release. > > 2015-03-10 17:38 GMT+01:00 Fabian Hueske <[hidden email]>: > > > Yeah, I spotted a good amount of optimizer tests that depend on the > Record > > API. > > I implemented the last optimizer tests with the new API and would > > volunteer to port the other optimizer tests. > > > > 2015-03-10 16:32 GMT+01:00 Stephan Ewen (JIRA) <[hidden email]>: > > > >> > >> [ > >> > https://issues.apache.org/jira/browse/FLINK-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355063#comment-14355063 > >> ] > >> > >> Stephan Ewen commented on FLINK-1106: > >> ------------------------------------- > >> > >> A bit of test coverage depends on the deprecated API. > >> > >> We would need to port at least some of the tests to the new API. > >> > >> We can probably drop some subsumed / obsolete tests. > >> > >> > Deprecate old Record API > >> > ------------------------ > >> > > >> > Key: FLINK-1106 > >> > URL: https://issues.apache.org/jira/browse/FLINK-1106 > >> > Project: Flink > >> > Issue Type: Task > >> > Components: Java API > >> > Affects Versions: 0.7.0-incubating > >> > Reporter: Robert Metzger > >> > Assignee: Robert Metzger > >> > Priority: Critical > >> > Fix For: 0.7.0-incubating > >> > > >> > > >> > For the upcoming 0.7 release, we should mark all user-facing methods > >> from the old Record Java API as deprecated, with a warning that we are > >> going to remove it at some point. > >> > I would suggest to wait one or two releases from the 0.7 release > (given > >> our current release cycle). I'll start a mailing-list discussion at some > >> point regarding this. > >> > >> > >> > >> -- > >> This message was sent by Atlassian JIRA > >> (v6.3.4#6332) > >> > > > > > |
Thanks guys,
I have filed FLINK-1681 [1] to track this issue. Maybe Fabian would like to take stab at this? [1] https://issues.apache.org/jira/browse/FLINK-1681 On Tue, Mar 10, 2015 at 12:28 PM, Till Rohrmann <[hidden email]> wrote: > +1 for removal of old API > On Mar 10, 2015 5:41 PM, "Fabian Hueske" <[hidden email]> wrote: > >> And I'm +1 for removing the old API with the next release. >> >> 2015-03-10 17:38 GMT+01:00 Fabian Hueske <[hidden email]>: >> >> > Yeah, I spotted a good amount of optimizer tests that depend on the >> Record >> > API. >> > I implemented the last optimizer tests with the new API and would >> > volunteer to port the other optimizer tests. >> > >> > 2015-03-10 16:32 GMT+01:00 Stephan Ewen (JIRA) <[hidden email]>: >> > >> >> >> >> [ >> >> >> https://issues.apache.org/jira/browse/FLINK-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355063#comment-14355063 >> >> ] >> >> >> >> Stephan Ewen commented on FLINK-1106: >> >> ------------------------------------- >> >> >> >> A bit of test coverage depends on the deprecated API. >> >> >> >> We would need to port at least some of the tests to the new API. >> >> >> >> We can probably drop some subsumed / obsolete tests. >> >> >> >> > Deprecate old Record API >> >> > ------------------------ >> >> > >> >> > Key: FLINK-1106 >> >> > URL: https://issues.apache.org/jira/browse/FLINK-1106 >> >> > Project: Flink >> >> > Issue Type: Task >> >> > Components: Java API >> >> > Affects Versions: 0.7.0-incubating >> >> > Reporter: Robert Metzger >> >> > Assignee: Robert Metzger >> >> > Priority: Critical >> >> > Fix For: 0.7.0-incubating >> >> > >> >> > >> >> > For the upcoming 0.7 release, we should mark all user-facing methods >> >> from the old Record Java API as deprecated, with a warning that we are >> >> going to remove it at some point. >> >> > I would suggest to wait one or two releases from the 0.7 release >> (given >> >> our current release cycle). I'll start a mailing-list discussion at some >> >> point regarding this. >> >> >> >> >> >> >> >> -- >> >> This message was sent by Atlassian JIRA >> >> (v6.3.4#6332) >> >> >> > >> > >> |
+1 I think it's a good idea to remove it and finish the deprecation. ;)
Thanks for looking into it Fabian. – Ufuk On 10 Mar 2015, at 20:42, Henry Saputra <[hidden email]> wrote: > Thanks guys, > > I have filed FLINK-1681 [1] to track this issue. > > Maybe Fabian would like to take stab at this? > > [1] https://issues.apache.org/jira/browse/FLINK-1681 > > On Tue, Mar 10, 2015 at 12:28 PM, Till Rohrmann <[hidden email]> wrote: >> +1 for removal of old API >> On Mar 10, 2015 5:41 PM, "Fabian Hueske" <[hidden email]> wrote: >> >>> And I'm +1 for removing the old API with the next release. >>> >>> 2015-03-10 17:38 GMT+01:00 Fabian Hueske <[hidden email]>: >>> >>>> Yeah, I spotted a good amount of optimizer tests that depend on the >>> Record >>>> API. >>>> I implemented the last optimizer tests with the new API and would >>>> volunteer to port the other optimizer tests. >>>> >>>> 2015-03-10 16:32 GMT+01:00 Stephan Ewen (JIRA) <[hidden email]>: >>>> >>>>> >>>>> [ >>>>> >>> https://issues.apache.org/jira/browse/FLINK-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355063#comment-14355063 >>>>> ] >>>>> >>>>> Stephan Ewen commented on FLINK-1106: >>>>> ------------------------------------- >>>>> >>>>> A bit of test coverage depends on the deprecated API. >>>>> >>>>> We would need to port at least some of the tests to the new API. >>>>> >>>>> We can probably drop some subsumed / obsolete tests. >>>>> >>>>>> Deprecate old Record API >>>>>> ------------------------ >>>>>> >>>>>> Key: FLINK-1106 >>>>>> URL: https://issues.apache.org/jira/browse/FLINK-1106 >>>>>> Project: Flink >>>>>> Issue Type: Task >>>>>> Components: Java API >>>>>> Affects Versions: 0.7.0-incubating >>>>>> Reporter: Robert Metzger >>>>>> Assignee: Robert Metzger >>>>>> Priority: Critical >>>>>> Fix For: 0.7.0-incubating >>>>>> >>>>>> >>>>>> For the upcoming 0.7 release, we should mark all user-facing methods >>>>> from the old Record Java API as deprecated, with a warning that we are >>>>> going to remove it at some point. >>>>>> I would suggest to wait one or two releases from the 0.7 release >>> (given >>>>> our current release cycle). I'll start a mailing-list discussion at some >>>>> point regarding this. >>>>> >>>>> >>>>> >>>>> -- >>>>> This message was sent by Atlassian JIRA >>>>> (v6.3.4#6332) >>>>> >>>> >>>> >>> |
+1
2015-03-12 9:23 GMT+01:00 Ufuk Celebi <[hidden email]>: > +1 I think it's a good idea to remove it and finish the deprecation. ;) > > Thanks for looking into it Fabian. > > – Ufuk > > On 10 Mar 2015, at 20:42, Henry Saputra <[hidden email]> wrote: > > > Thanks guys, > > > > I have filed FLINK-1681 [1] to track this issue. > > > > Maybe Fabian would like to take stab at this? > > > > [1] https://issues.apache.org/jira/browse/FLINK-1681 > > > > On Tue, Mar 10, 2015 at 12:28 PM, Till Rohrmann <[hidden email]> > wrote: > >> +1 for removal of old API > >> On Mar 10, 2015 5:41 PM, "Fabian Hueske" <[hidden email]> wrote: > >> > >>> And I'm +1 for removing the old API with the next release. > >>> > >>> 2015-03-10 17:38 GMT+01:00 Fabian Hueske <[hidden email]>: > >>> > >>>> Yeah, I spotted a good amount of optimizer tests that depend on the > >>> Record > >>>> API. > >>>> I implemented the last optimizer tests with the new API and would > >>>> volunteer to port the other optimizer tests. > >>>> > >>>> 2015-03-10 16:32 GMT+01:00 Stephan Ewen (JIRA) <[hidden email]>: > >>>> > >>>>> > >>>>> [ > >>>>> > >>> > https://issues.apache.org/jira/browse/FLINK-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355063#comment-14355063 > >>>>> ] > >>>>> > >>>>> Stephan Ewen commented on FLINK-1106: > >>>>> ------------------------------------- > >>>>> > >>>>> A bit of test coverage depends on the deprecated API. > >>>>> > >>>>> We would need to port at least some of the tests to the new API. > >>>>> > >>>>> We can probably drop some subsumed / obsolete tests. > >>>>> > >>>>>> Deprecate old Record API > >>>>>> ------------------------ > >>>>>> > >>>>>> Key: FLINK-1106 > >>>>>> URL: > https://issues.apache.org/jira/browse/FLINK-1106 > >>>>>> Project: Flink > >>>>>> Issue Type: Task > >>>>>> Components: Java API > >>>>>> Affects Versions: 0.7.0-incubating > >>>>>> Reporter: Robert Metzger > >>>>>> Assignee: Robert Metzger > >>>>>> Priority: Critical > >>>>>> Fix For: 0.7.0-incubating > >>>>>> > >>>>>> > >>>>>> For the upcoming 0.7 release, we should mark all user-facing methods > >>>>> from the old Record Java API as deprecated, with a warning that we > are > >>>>> going to remove it at some point. > >>>>>> I would suggest to wait one or two releases from the 0.7 release > >>> (given > >>>>> our current release cycle). I'll start a mailing-list discussion at > some > >>>>> point regarding this. > >>>>> > >>>>> > >>>>> > >>>>> -- > >>>>> This message was sent by Atlassian JIRA > >>>>> (v6.3.4#6332) > >>>>> > >>>> > >>>> > >>> > > |
Free forum by Nabble | Edit this page |