Re: [GitHub] incubator-flink pull request: [scala] Self-contained build for sca...

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] incubator-flink pull request: [scala] Self-contained build for sca...

Ufuk Celebi-2
I think separate Scala JARs don't add much value since we have the examples
already packaged. As source they make very much sense, but is there a
difference for users when trying out the system?

On Thu, Nov 13, 2014 at 10:21 AM, aljoscha <[hidden email]> wrote:

> Github user aljoscha commented on the pull request:
>
>
> https://github.com/apache/incubator-flink/pull/199#issuecomment-62862942
>
>     Right now there are no jar files since the scala examples depend on
> the example data of the java examples. I think this is a good solution, if
> we want to have the Scala examples as jars.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at [hidden email] or file a JIRA ticket
> with INFRA.
> ---
>
Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] incubator-flink pull request: [scala] Self-contained build for sca...

Ufuk Celebi-2
I think it makes very much sense to have this setup with the data classes.
+1 on that.

My question was only when *users* might want to run the Scala examples
instead of the Java examples since they do the same thing.

On Thu, Nov 13, 2014 at 11:14 AM, mbalassi <[hidden email]> wrote:

> Github user mbalassi commented on the pull request:
>
>
> https://github.com/apache/incubator-flink/pull/199#issuecomment-62869095
>
>     The commit does two things:
>       * Adds the default data classes to the examples package from the
> flink-java-examples packages
>       * Also creates separate jars for the examples
>
>     I suppose both makes it more convenient for the users to try out the
> programs on the cluster. Currently to see a scala example performing on the
> cluster you would have to add the flink-java-examples (as it is not in the
> lib of the distro) to the classpath and of course also provide the desired
> main class.
>
>     I would not say that this is difficult, just the option I'm providing
> is more user friendly.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at [hidden email] or file a JIRA ticket
> with INFRA.
> ---
>