Question on Streaming Dependency

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Question on Streaming Dependency

Stephan Ewen
I am currently going through the code checking that all license-related
issues are well (and cleaning up unused dependencies on the way).

I found that the streaming core project references the following
dependency, which seems never used in the code:

<groupId>org.apache.sling</groupId>
<artifactId>org.apache.sling.commons.json</artifactId>
<version>2.0.6</version>

Was this accidentally added? IIRC sling is a web framework, so I was also a
bit surprised to see it as a dependency in the streaming code.

Can anyone help me? Was this added because another dependency relies on it,
but does not include it by itself?

Greetings,
Stephan
Reply | Threaded
Open this post in threaded view
|

Re: Question on Streaming Dependency

Stephan Ewen
Just figured out that it is a transitive dependency of the streaming
connectors. Will move it there with a comment.

On Sat, Jan 10, 2015 at 4:43 PM, Stephan Ewen <[hidden email]> wrote:

> I am currently going through the code checking that all license-related
> issues are well (and cleaning up unused dependencies on the way).
>
> I found that the streaming core project references the following
> dependency, which seems never used in the code:
>
> <groupId>org.apache.sling</groupId>
> <artifactId>org.apache.sling.commons.json</artifactId>
> <version>2.0.6</version>
>
> Was this accidentally added? IIRC sling is a web framework, so I was also
> a bit surprised to see it as a dependency in the streaming code.
>
> Can anyone help me? Was this added because another dependency relies on
> it, but does not include it by itself?
>
> Greetings,
> Stephan
>
Reply | Threaded
Open this post in threaded view
|

Re: Question on Streaming Dependency

Hermann Gábor
Hey!

As I can see, it was mistakenly added there during summer (probably by
interns working on connectors).

Thanks for the fix!

Regards,
Gábor

On Sat, Jan 10, 2015 at 4:50 PM, Stephan Ewen <[hidden email]> wrote:

> Just figured out that it is a transitive dependency of the streaming
> connectors. Will move it there with a comment.
>
> On Sat, Jan 10, 2015 at 4:43 PM, Stephan Ewen <[hidden email]> wrote:
>
> > I am currently going through the code checking that all license-related
> > issues are well (and cleaning up unused dependencies on the way).
> >
> > I found that the streaming core project references the following
> > dependency, which seems never used in the code:
> >
> > <groupId>org.apache.sling</groupId>
> > <artifactId>org.apache.sling.commons.json</artifactId>
> > <version>2.0.6</version>
> >
> > Was this accidentally added? IIRC sling is a web framework, so I was also
> > a bit surprised to see it as a dependency in the streaming code.
> >
> > Can anyone help me? Was this added because another dependency relies on
> > it, but does not include it by itself?
> >
> > Greetings,
> > Stephan
> >
>