Pull request failed Travis...what's next?

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Pull request failed Travis...what's next?

Sourigna Phetsarath
All:

I created this pull request and it failed on the flink-ml module that I
didn't touch.  What are next steps?

https://github.com/apache/flink/pull/1920

Thank you for any help.

--


*Gna Phetsarath*System Architect // AOL Platforms // Data Services //
Applied Research Chapter
770 Broadway, 5th Floor, New York, NY 10003
o: 212.402.4871 // m: 917.373.7363
vvmr: 8890237 aim: sphetsarath20 t: @sourigna

* <http://www.aolplatforms.com>*
Reply | Threaded
Open this post in threaded view
|

Re: Pull request failed Travis...what's next?

Fabian Hueske-2
Hi Sourigna,

thanks for contributing!

Unrelated test failures are not a problem. We have some issues with build
stability on Travis.
We know which tests are failing from time to time and run the tests again
before merging.

Thanks

2016-04-21 23:18 GMT+02:00 Sourigna Phetsarath <[hidden email]>:

> All:
>
> I created this pull request and it failed on the flink-ml module that I
> didn't touch.  What are next steps?
>
> https://github.com/apache/flink/pull/1920
>
> Thank you for any help.
>
> --
>
>
> *Gna Phetsarath*System Architect // AOL Platforms // Data Services //
> Applied Research Chapter
> 770 Broadway, 5th Floor, New York, NY 10003
> o: 212.402.4871 // m: 917.373.7363
> vvmr: 8890237 aim: sphetsarath20 t: @sourigna
>
> * <http://www.aolplatforms.com>*
>
Reply | Threaded
Open this post in threaded view
|

Re: Pull request failed Travis...what's next?

Flavio Pompermaier
We just issued a PR about FLINK-1827 (
https://github.com/apache/flink/pull/1915) that improves test stability
except for the ml library that has still some problem to solve..
On 21 Apr 2016 23:59, "Fabian Hueske" <[hidden email]> wrote:

> Hi Sourigna,
>
> thanks for contributing!
>
> Unrelated test failures are not a problem. We have some issues with build
> stability on Travis.
> We know which tests are failing from time to time and run the tests again
> before merging.
>
> Thanks
>
> 2016-04-21 23:18 GMT+02:00 Sourigna Phetsarath <[hidden email]
> >:
>
> > All:
> >
> > I created this pull request and it failed on the flink-ml module that I
> > didn't touch.  What are next steps?
> >
> > https://github.com/apache/flink/pull/1920
> >
> > Thank you for any help.
> >
> > --
> >
> >
> > *Gna Phetsarath*System Architect // AOL Platforms // Data Services //
> > Applied Research Chapter
> > 770 Broadway, 5th Floor, New York, NY 10003
> > o: 212.402.4871 // m: 917.373.7363
> > vvmr: 8890237 aim: sphetsarath20 t: @sourigna
> >
> > * <http://www.aolplatforms.com>*
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Pull request failed Travis...what's next?

Sourigna Phetsarath
Who's responsible for merging the PRs?  What's the usual timeline for
feedback and/or merging?

Thank you.

On Thu, Apr 21, 2016 at 6:09 PM, Flavio Pompermaier <[hidden email]>
wrote:

> We just issued a PR about FLINK-1827 (
> https://github.com/apache/flink/pull/1915) that improves test stability
> except for the ml library that has still some problem to solve..
> On 21 Apr 2016 23:59, "Fabian Hueske" <[hidden email]> wrote:
>
> > Hi Sourigna,
> >
> > thanks for contributing!
> >
> > Unrelated test failures are not a problem. We have some issues with build
> > stability on Travis.
> > We know which tests are failing from time to time and run the tests again
> > before merging.
> >
> > Thanks
> >
> > 2016-04-21 23:18 GMT+02:00 Sourigna Phetsarath <
> [hidden email]
> > >:
> >
> > > All:
> > >
> > > I created this pull request and it failed on the flink-ml module that I
> > > didn't touch.  What are next steps?
> > >
> > > https://github.com/apache/flink/pull/1920
> > >
> > > Thank you for any help.
> > >
> > > --
> > >
> > >
> > > *Gna Phetsarath*System Architect // AOL Platforms // Data Services //
> > > Applied Research Chapter
> > > 770 Broadway, 5th Floor, New York, NY 10003
> > > o: 212.402.4871 // m: 917.373.7363
> > > vvmr: 8890237 aim: sphetsarath20 t: @sourigna
> > >
> > > * <http://www.aolplatforms.com>*
> > >
> >
>



--


*Gna Phetsarath*System Architect // AOL Platforms // Data Services //
Applied Research Chapter
770 Broadway, 5th Floor, New York, NY 10003
o: 212.402.4871 // m: 917.373.7363
vvmr: 8890237 aim: sphetsarath20 t: @sourigna

* <http://www.aolplatforms.com>*
Reply | Threaded
Open this post in threaded view
|

Re: Pull request failed Travis...what's next?

Fabian Hueske-2
Hi Sourigna,

usually a PR is picked up and reviewed by somebody from the community and
eventually merged by a committer.
Sometimes it takes a few days, but if nobody reacts it helps to ping just
like you did.
I'll have a look at your PR tomorrow.

Thanks, Fabian

2016-04-25 18:01 GMT+02:00 Sourigna Phetsarath <[hidden email]>:

> Who's responsible for merging the PRs?  What's the usual timeline for
> feedback and/or merging?
>
> Thank you.
>
> On Thu, Apr 21, 2016 at 6:09 PM, Flavio Pompermaier <[hidden email]>
> wrote:
>
> > We just issued a PR about FLINK-1827 (
> > https://github.com/apache/flink/pull/1915) that improves test stability
> > except for the ml library that has still some problem to solve..
> > On 21 Apr 2016 23:59, "Fabian Hueske" <[hidden email]> wrote:
> >
> > > Hi Sourigna,
> > >
> > > thanks for contributing!
> > >
> > > Unrelated test failures are not a problem. We have some issues with
> build
> > > stability on Travis.
> > > We know which tests are failing from time to time and run the tests
> again
> > > before merging.
> > >
> > > Thanks
> > >
> > > 2016-04-21 23:18 GMT+02:00 Sourigna Phetsarath <
> > [hidden email]
> > > >:
> > >
> > > > All:
> > > >
> > > > I created this pull request and it failed on the flink-ml module
> that I
> > > > didn't touch.  What are next steps?
> > > >
> > > > https://github.com/apache/flink/pull/1920
> > > >
> > > > Thank you for any help.
> > > >
> > > > --
> > > >
> > > >
> > > > *Gna Phetsarath*System Architect // AOL Platforms // Data Services //
> > > > Applied Research Chapter
> > > > 770 Broadway, 5th Floor, New York, NY 10003
> > > > o: 212.402.4871 // m: 917.373.7363
> > > > vvmr: 8890237 aim: sphetsarath20 t: @sourigna
> > > >
> > > > * <http://www.aolplatforms.com>*
> > > >
> > >
> >
>
>
>
> --
>
>
> *Gna Phetsarath*System Architect // AOL Platforms // Data Services //
> Applied Research Chapter
> 770 Broadway, 5th Floor, New York, NY 10003
> o: 212.402.4871 // m: 917.373.7363
> vvmr: 8890237 aim: sphetsarath20 t: @sourigna
>
> * <http://www.aolplatforms.com>*
>