New Jdbc XA sink - state serialization error.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

New Jdbc XA sink - state serialization error.

Maciej Obuchowski
Hey, while working with the new 1.13 JDBC XA sink I had state restoration
errors connected to XaSinkStateSerializer with it's implementation of
SNAPSHOT using anonymous inner class, which is not restorable due to not
being public.
When changed to implementation similar to
CheckpointAndXidSimpleTypeSerializerSnapshot state restores without problem.

Should I provide Jira ticket and patch for this error? Sorry if that's
obvious.

Thanks,
Maciej
Reply | Threaded
Open this post in threaded view
|

Re: New Jdbc XA sink - state serialization error.

roman
Hi,

Yes, please go ahead. Thanks!

Regards,
Roman


On Mon, Feb 22, 2021 at 12:18 PM Maciej Obuchowski <
[hidden email]> wrote:

> Hey, while working with the new 1.13 JDBC XA sink I had state restoration
> errors connected to XaSinkStateSerializer with it's implementation of
> SNAPSHOT using anonymous inner class, which is not restorable due to not
> being public.
> When changed to implementation similar to
> CheckpointAndXidSimpleTypeSerializerSnapshot state restores without
> problem.
>
> Should I provide Jira ticket and patch for this error? Sorry if that's
> obvious.
>
> Thanks,
> Maciej
>
Reply | Threaded
Open this post in threaded view
|

Re: New Jdbc XA sink - state serialization error.

Maciej Obuchowski
Hey Roman,
I've created Jira task and already provided PR.
https://issues.apache.org/jira/browse/FLINK-21442
I see that "tickets need to be assigned before starting with the
implementation work" but we already had the implementation in our fork.
Can you assign me to this task and provide code review?

Thanks,
Maciej

pon., 22 lut 2021 o 14:09 Roman Khachatryan <[hidden email]> napisaƂ(a):

> Hi,
>
> Yes, please go ahead. Thanks!
>
> Regards,
> Roman
>
>
> On Mon, Feb 22, 2021 at 12:18 PM Maciej Obuchowski <
> [hidden email]> wrote:
>
> > Hey, while working with the new 1.13 JDBC XA sink I had state restoration
> > errors connected to XaSinkStateSerializer with it's implementation of
> > SNAPSHOT using anonymous inner class, which is not restorable due to not
> > being public.
> > When changed to implementation similar to
> > CheckpointAndXidSimpleTypeSerializerSnapshot state restores without
> > problem.
> >
> > Should I provide Jira ticket and patch for this error? Sorry if that's
> > obvious.
> >
> > Thanks,
> > Maciej
> >
>