Looking for reviewer: FLINK-13127

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Looking for reviewer: FLINK-13127

David Morávek
Hi, I've prepared a small patch related to Yarn deployment. Would anyone
please have a time to take a look at it? Thanks

https://github.com/apache/flink/pull/9022

Regards,
D.
Reply | Threaded
Open this post in threaded view
|

Re: Looking for reviewer: FLINK-13127

tison
Hi David,

Just reviewed and left several comments. Thanks for your contribution!

Best,
tison.


David Morávek <[hidden email]> 于2019年7月22日周一 下午5:59写道:

> Hi, I've prepared a small patch related to Yarn deployment. Would anyone
> please have a time to take a look at it? Thanks
>
> https://github.com/apache/flink/pull/9022
>
> Regards,
> D.
>
Reply | Threaded
Open this post in threaded view
|

Re: Looking for reviewer: FLINK-13127

Xintong Song
David,

Thank you for opening this PR. I also left a few comments.

And I think we need a committer to assign this jira ticket to David. Maybe
Till or any other committer could look into this?


Thank you~

Xintong Song



On Mon, Jul 22, 2019 at 8:37 PM Zili Chen <[hidden email]> wrote:

> Hi David,
>
> Just reviewed and left several comments. Thanks for your contribution!
>
> Best,
> tison.
>
>
> David Morávek <[hidden email]> 于2019年7月22日周一 下午5:59写道:
>
> > Hi, I've prepared a small patch related to Yarn deployment. Would anyone
> > please have a time to take a look at it? Thanks
> >
> > https://github.com/apache/flink/pull/9022
> >
> > Regards,
> > D.
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Looking for reviewer: FLINK-13127

Till Rohrmann
I've assigned the issue to you David. I think this feature makes sense. The
only question I have is why we need to sort the values. But let's discuss
the issue on the Github PR.

@Tison and @Xintong, let me know once the PR is in mergeable state.

Cheers,
Till

On Tue, Jul 23, 2019 at 4:14 AM Xintong Song <[hidden email]> wrote:

> David,
>
> Thank you for opening this PR. I also left a few comments.
>
> And I think we need a committer to assign this jira ticket to David. Maybe
> Till or any other committer could look into this?
>
>
> Thank you~
>
> Xintong Song
>
>
>
> On Mon, Jul 22, 2019 at 8:37 PM Zili Chen <[hidden email]> wrote:
>
> > Hi David,
> >
> > Just reviewed and left several comments. Thanks for your contribution!
> >
> > Best,
> > tison.
> >
> >
> > David Morávek <[hidden email]> 于2019年7月22日周一 下午5:59写道:
> >
> > > Hi, I've prepared a small patch related to Yarn deployment. Would
> anyone
> > > please have a time to take a look at it? Thanks
> > >
> > > https://github.com/apache/flink/pull/9022
> > >
> > > Regards,
> > > D.
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Looking for reviewer: FLINK-13127

David Morávek-2
Hi Till, the PR should be ready ;) Can you please do the final check?

Best,
D.

On Tue, Jul 23, 2019 at 3:01 PM Till Rohrmann <[hidden email]> wrote:

> I've assigned the issue to you David. I think this feature makes sense. The
> only question I have is why we need to sort the values. But let's discuss
> the issue on the Github PR.
>
> @Tison and @Xintong, let me know once the PR is in mergeable state.
>
> Cheers,
> Till
>
> On Tue, Jul 23, 2019 at 4:14 AM Xintong Song <[hidden email]>
> wrote:
>
> > David,
> >
> > Thank you for opening this PR. I also left a few comments.
> >
> > And I think we need a committer to assign this jira ticket to David.
> Maybe
> > Till or any other committer could look into this?
> >
> >
> > Thank you~
> >
> > Xintong Song
> >
> >
> >
> > On Mon, Jul 22, 2019 at 8:37 PM Zili Chen <[hidden email]> wrote:
> >
> > > Hi David,
> > >
> > > Just reviewed and left several comments. Thanks for your contribution!
> > >
> > > Best,
> > > tison.
> > >
> > >
> > > David Morávek <[hidden email]> 于2019年7月22日周一 下午5:59写道:
> > >
> > > > Hi, I've prepared a small patch related to Yarn deployment. Would
> > anyone
> > > > please have a time to take a look at it? Thanks
> > > >
> > > > https://github.com/apache/flink/pull/9022
> > > >
> > > > Regards,
> > > > D.
> > > >
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Looking for reviewer: FLINK-13127

Till Rohrmann
Thanks for the pointer. I'll take a look later today.

Cheers,
Till

On Thu, Aug 1, 2019 at 8:00 AM David Morávek <[hidden email]>
wrote:

> Hi Till, the PR should be ready ;) Can you please do the final check?
>
> Best,
> D.
>
> On Tue, Jul 23, 2019 at 3:01 PM Till Rohrmann <[hidden email]>
> wrote:
>
> > I've assigned the issue to you David. I think this feature makes sense.
> The
> > only question I have is why we need to sort the values. But let's discuss
> > the issue on the Github PR.
> >
> > @Tison and @Xintong, let me know once the PR is in mergeable state.
> >
> > Cheers,
> > Till
> >
> > On Tue, Jul 23, 2019 at 4:14 AM Xintong Song <[hidden email]>
> > wrote:
> >
> > > David,
> > >
> > > Thank you for opening this PR. I also left a few comments.
> > >
> > > And I think we need a committer to assign this jira ticket to David.
> > Maybe
> > > Till or any other committer could look into this?
> > >
> > >
> > > Thank you~
> > >
> > > Xintong Song
> > >
> > >
> > >
> > > On Mon, Jul 22, 2019 at 8:37 PM Zili Chen <[hidden email]>
> wrote:
> > >
> > > > Hi David,
> > > >
> > > > Just reviewed and left several comments. Thanks for your
> contribution!
> > > >
> > > > Best,
> > > > tison.
> > > >
> > > >
> > > > David Morávek <[hidden email]> 于2019年7月22日周一 下午5:59写道:
> > > >
> > > > > Hi, I've prepared a small patch related to Yarn deployment. Would
> > > anyone
> > > > > please have a time to take a look at it? Thanks
> > > > >
> > > > > https://github.com/apache/flink/pull/9022
> > > > >
> > > > > Regards,
> > > > > D.
> > > > >
> > > >
> > >
> >
>