I create a hotfix pull request in `MiniCluster.java`, thanks!

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

I create a hotfix pull request in `MiniCluster.java`, thanks!

左元
The Pull Request Number is #14211.


Fix typo `dispatcherResourceManagreComponentRpcServiceFactory` -> `dispatcherResourceManagerComponentRpcServiceFactory` in `MiniCluster.java`


                                                                                                                                            Best Regards
                                                                                                                                            Yuan Zuo
Reply | Threaded
Open this post in threaded view
|

Re: I create a hotfix pull request in `MiniCluster.java`, thanks!

Jark Wu-2
Hi Yuan,

Thanks for contributing to Flink. I have helped to merge this PR.

For the pull requests without JIRA id, it would be better to ping/request
review
from the committers in the PR (there is a suggestion reviewer in the right
sidebar).
Because such pull requests usually can't be notified to committers in time.

Best,
Jark

On Wed, 25 Nov 2020 at 16:45, 左元 <[hidden email]> wrote:

> The Pull Request Number is #14211.
>
>
> Fix typo `dispatcherResourceManagreComponentRpcServiceFactory` ->
> `dispatcherResourceManagerComponentRpcServiceFactory` in `MiniCluster.java`
>
>
>
>                                                                   Best
> Regards
>
>                                                                   Yuan Zuo
Reply | Threaded
Open this post in threaded view
|

Re: I create a hotfix pull request in `MiniCluster.java`, thanks!

左元
Hi Jark


Thanks for advcing!Wish I can contribute more for flink project!


Yuan Zuo

| |
左元
|
|
邮箱:[hidden email]
|
On 11/26/2020 13:57, Jark Wu wrote:
Hi Yuan,

Thanks for contributing to Flink. I have helped to merge this PR.

For the pull requests without JIRA id, it would be better to ping/request
review
from the committers in the PR (there is a suggestion reviewer in the right
sidebar).
Because such pull requests usually can't be notified to committers in time.

Best,
Jark

On Wed, 25 Nov 2020 at 16:45, 左元 <[hidden email]> wrote:

> The Pull Request Number is #14211.
>
>
> Fix typo `dispatcherResourceManagreComponentRpcServiceFactory` ->
> `dispatcherResourceManagerComponentRpcServiceFactory` in `MiniCluster.java`
>
>
>
>                                                                   Best
> Regards
>
>                                                                   Yuan Zuo