Guidance to new Flink developers

[Feng LI]

Hello guys,

Sorry if this is already discussed question, is there some guidance in
place to help new Flink developers to integrate to the community ?

I’m new to the community and super happy after submitting my first pull
request ( https://github.com/apache/flink/pull/7726 ) after some
discussions and reached consensus on the mailing list. But now felt a bit
embarrassing since it’s been 7 days and I received little feedback and I
cannot move forward.

Just wondering if the community should come up with something to help new
Flink developers to better integrate to the community. It is generally a
very valuable thing to have.

(I can help on this process if help needed)

Cheers,
Feng
--
Feng (Sent from my phone)

[dwysakowicz]

Hi Feng,

Sorry to hear you feel that way. Our goal as a community is to make
people as welcome as possible, but you must not forget we are only
humans after all and we have limited capabilities ;)

We always try to improve our processes, so if you have any suggestions
what we could improve, feel free to post your ideas on ML. As for the
guidance for new contributors, have you checked this links [1][2][3]?
Are you missing something in those documents?

Regarding your particular contribution, I think it's worth to include it
in 1.8 release, therefore I marked it as a Blocker, will try to review
it next few days or find a person to do that.

Best,

Dawid

[1] https://flink.apache.org/how-to-contribute.html

[2] https://flink.apache.org/reviewing-prs.html

[3] https://flink.apache.org/contribute-code.html

On 25/02/2019 13:16, Feng LI wrote:

> Hello guys,
>
> Sorry if this is already discussed question, is there some guidance in
> place to help new Flink developers to integrate to the community ?
>
> I’m new to the community and super happy after submitting my first pull
> request ( https://github.com/apache/flink/pull/7726 ) after some
> discussions and reached consensus on the mailing list. But now felt a bit
> embarrassing since it’s been 7 days and I received little feedback and I
> cannot move forward.
>
> Just wondering if the community should come up with something to help new
> Flink developers to better integrate to the community. It is generally a
> very valuable thing to have.
>
> (I can help on this process if help needed)
>
> Cheers,
> Feng

[Tzu-Li (Gordon) Tai]

Hi Feng,

Regarding your particular contribution:
I think you did a good job in gathering consensus on how the fix should be
addressed.
The PR's changes also matches the original discussions, with good test
coverage and quality all in all.

The only thing lacking was more attention from reviewers to move it
forward; I'm sorry this didn't happen promptly after the PR was opened.
As Dawid mentioned, our goal as a community is to make people as welcome as
possible.
Sometimes it may simply be that the PR review was slower because committers
are already limited in their capacity; but it is good that you try to
remind them of critical fixes.

And thanks for the reminder on FLINK-10342!
I agree its something we should try to merge for 1.8.0.
I started a first pass review on the PR to get this going :)

Cheers,
Gordon


On Mon, Feb 25, 2019 at 8:51 PM Dawid Wysakowicz <[hidden email]>
wrote:

> Hi Feng,
>
> Sorry to hear you feel that way. Our goal as a community is to make
> people as welcome as possible, but you must not forget we are only
> humans after all and we have limited capabilities ;)
>
> We always try to improve our processes, so if you have any suggestions
> what we could improve, feel free to post your ideas on ML. As for the
> guidance for new contributors, have you checked this links [1][2][3]?
> Are you missing something in those documents?
>
> Regarding your particular contribution, I think it's worth to include it
> in 1.8 release, therefore I marked it as a Blocker, will try to review
> it next few days or find a person to do that.
>
> Best,
>
> Dawid
>
> [1] https://flink.apache.org/how-to-contribute.html
>
> [2] https://flink.apache.org/reviewing-prs.html
>
> [3] https://flink.apache.org/contribute-code.html
>
> On 25/02/2019 13:16, Feng LI wrote:
> > Hello guys,
> >
> > Sorry if this is already discussed question, is there some guidance in
> > place to help new Flink developers to integrate to the community ?
> >
> > I’m new to the community and super happy after submitting my first pull
> > request ( https://github.com/apache/flink/pull/7726 ) after some
> > discussions and reached consensus on the mailing list. But now felt a bit
> > embarrassing since it’s been 7 days and I received little feedback and I
> > cannot move forward.
> >
> > Just wondering if the community should come up with something to help new
> > Flink developers to better integrate to the community. It is generally a
> > very valuable thing to have.
> >
> > (I can help on this process if help needed)
> >
> > Cheers,
> > Feng
>
>

[Feng LI]

Hello Gordon, Dawid,

Thanks for putting that pull request in 1.8 release and helping on the
review.

I'm still in observe mode on the list :) Tried not to chip in too early
with new suggestions since they might have been proposed or already in the
process.

But here are my two cents:

The things I think might be good to have:

- Have one committer guiding in pair with new contributor:
  - Finding the first 2-3 JIRA issues/topics to work on
  - Helping to unblock whatever might blocks through the first few pull
requests/commits.

This will not take too much time, probably just need some special
attentions and a few welcoming and helping emails from the committer. But
the benefit for the community is huge.

Cheers,
Feng
Le lun. 25 févr. 2019 à 17:26, Tzu-Li (Gordon) Tai <[hidden email]> a
écrit :

> Hi Feng,
>
> Regarding your particular contribution:
> I think you did a good job in gathering consensus on how the fix should be
> addressed.
> The PR's changes also matches the original discussions, with good test
> coverage and quality all in all.
>
> The only thing lacking was more attention from reviewers to move it
> forward; I'm sorry this didn't happen promptly after the PR was opened.
> As Dawid mentioned, our goal as a community is to make people as welcome as
> possible.
> Sometimes it may simply be that the PR review was slower because committers
> are already limited in their capacity; but it is good that you try to
> remind them of critical fixes.
>
> And thanks for the reminder on FLINK-10342!
> I agree its something we should try to merge for 1.8.0.
> I started a first pass review on the PR to get this going :)
>
> Cheers,
> Gordon
>
>
> On Mon, Feb 25, 2019 at 8:51 PM Dawid Wysakowicz <[hidden email]>
> wrote:
>
> > Hi Feng,
> >
> > Sorry to hear you feel that way. Our goal as a community is to make
> > people as welcome as possible, but you must not forget we are only
> > humans after all and we have limited capabilities ;)
> >
> > We always try to improve our processes, so if you have any suggestions
> > what we could improve, feel free to post your ideas on ML. As for the
> > guidance for new contributors, have you checked this links [1][2][3]?
> > Are you missing something in those documents?
> >
> > Regarding your particular contribution, I think it's worth to include it
> > in 1.8 release, therefore I marked it as a Blocker, will try to review
> > it next few days or find a person to do that.
> >
> > Best,
> >
> > Dawid
> >
> > [1] https://flink.apache.org/how-to-contribute.html
> >
> > [2] https://flink.apache.org/reviewing-prs.html
> >
> > [3] https://flink.apache.org/contribute-code.html
> >
> > On 25/02/2019 13:16, Feng LI wrote:
> > > Hello guys,
> > >
> > > Sorry if this is already discussed question, is there some guidance in
> > > place to help new Flink developers to integrate to the community ?
> > >
> > > I’m new to the community and super happy after submitting my first pull
> > > request ( https://github.com/apache/flink/pull/7726 ) after some
> > > discussions and reached consensus on the mailing list. But now felt a
> bit
> > > embarrassing since it’s been 7 days and I received little feedback and
> I
> > > cannot move forward.
> > >
> > > Just wondering if the community should come up with something to help
> new
> > > Flink developers to better integrate to the community. It is generally
> a
> > > very valuable thing to have.
> > >
> > > (I can help on this process if help needed)
> > >
> > > Cheers,
> > > Feng
> >
> >
>