[GitHub] incubator-flink pull request: Serialized String comparison, Unicod...

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-flink pull request: Serialized String comparison, Unicod...

zentol
Github user StephanEwen commented on the pull request:

    https://github.com/apache/incubator-flink/pull/4#issuecomment-46468521
 
    That is very nice progress! And I think the numbers are good, actually.
   
    I was wondering whether it is possible to modify the encoding such that the comparison loop could still be something like:
    ```
    byte[] bytes1 = ...;
    byte[] bytes2 = ...;
   
    int len = min(bytes1.length, bytes2.length);
    int cmp = 0;
    for (int pos = 0; pos < len && (cmp = (bytes1[pos] & 0xff) - (bytes2[pos] & 0xff)) == 0; pos++);
    ```
   
    That would allow us to push the comparisons into the memory segments (eventually doing something like a memcmp()) and avoid repeatedly grabbing individual bytes.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---