[GitHub] incubator-flink pull request: Serialized String comparison, Unicod...

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-flink pull request: Serialized String comparison, Unicod...

zentol
Github user zentol commented on the pull request:

    https://github.com/apache/incubator-flink/pull/4#issuecomment-46012075
 
    the new serialization seems to take longer, but broke even due to faster deserialization.
   
    some comparison benchmarks:
   
    strings of length 90
    1000 repetitions
    code for New measurement:
    ```
    long startTime = System.nanoTime();
    cmp = StringValue.compareUnicode(in1, in2);
    long endTime = System.nanoTime();
    ```
    code for Old measurement:
    ```
    long startTime = System.nanoTime();
    cmp = StringValue.readString(in1).compareTo(StringValue.readString(in2));
    long endTime = System.nanoTime();
    ```
   
    result = SUM(endTime - startTime) / 1000
   
    equality
    New 26627
    Old 25782
   
    affix (difference in the beginning of the sring)
    New 4259
    Old 23431
   
    infix (difference in the middle of the string)
    New 13560
    Old 30757
   
    suffix (difference at the end of the string)
    New 29385
    Old 28293
   
    not particularly surprising results. no progress on the prefix-issue :/
   
    adding some more tests now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---