[GitHub] incubator-flink pull request: Serialized String comparison, Unicod...

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-flink pull request: Serialized String comparison, Unicod...

zentol
Github user StephanEwen commented on the pull request:

    https://github.com/apache/incubator-flink/pull/4#issuecomment-45997906
 
    This is a nice change. Do you have some micro-benchmark numbers on how the methods perform in comparison to the old `writeString()` methods?
   
    Also, it would be interesting what the benefit of doing binary comparisons is. So, a microbenchmark of sorting the strings with a normalizedKeySorter. And a case where all prefixes are equal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---