[GitHub] incubator-flink pull request: Rework of TypeExtractor for SAM supp...

[zentol]

GitHub user twalthr opened a pull request:

    https://github.com/apache/incubator-flink/pull/52

    Rework of TypeExtractor for SAM support [FLINK-701]

    In order to support Java 8 Lambdas the TypeExtractor has been adapted to support interface instead of classes as function bases.
   
    See also [FLINK-701].
   
    This PR also fixes a bug in the input validation for the new POJO types. I have reordered some methods and introduced some sections to improve code readability.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/incubator-flink TypeExtractorInterfaceSupport

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/52.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #52
   
----
commit da2bdc4f95810ae4187f6fc971245d6496d2eb61
Author: twalthr <[hidden email]>
Date:   2014-06-30T10:02:37Z

    Rework of TypeExtractor for SAM support

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user atsikiridis commented on the pull request:

    https://github.com/apache/incubator-flink/pull/52#issuecomment-47521024
 
    Hello,
    This will make #37 much cleaner in the handling of InputFormats by the hadoop client. This is the proper way to do it. So, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user twalthr commented on the pull request:

    https://github.com/apache/incubator-flink/pull/52#issuecomment-47521613
 
    @atsikiridis I haven't tested your use case but I think calling TypeExtractor.createTypeInfo(Class, Class, int, null, null) should work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---