Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
GitHub user JonathanH5 opened a pull request:
https://github.com/apache/incubator-flink/pull/23 Fixed JSON Bug for some plans. I was able to fix the Bug in the JSON file found while merging #15. I created an additional test case which tests all example jars which don't need arguments to verify our JSON build. You can merge this pull request into a Git repository by running: $ git pull https://github.com/JonathanH5/incubator-flink JsonValidationTest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-flink/pull/23.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #23 ---- commit b062397bfa1c687911fb90937c49813cca4ff2b2 Author: Jonathan <[hidden email]> Date: 2014-06-17T12:08:27Z Fixed JSON Bug for some plans. Added license Fixed Json Bug for some plans ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/23#issuecomment-46418267 Thank you for the pull request. I'm going to merge this soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
In reply to this post by zentol
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-flink/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
Loading... |
Reply to author |
Edit post |
Move post |
Delete this post |
Delete this post and replies |
Change post date |
Print post |
Permalink |
Raw mail |
In reply to this post by zentol
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/23#issuecomment-46468874 Btw, I did not merge the test included in this pull request, because there were already tests for the JSON generator of the optimizer. Please see this commit for that: https://github.com/apache/incubator-flink/commit/5484d58e56a7fdb5ff7a9e9edff8ef73e27e7c71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA. --- |
Free forum by Nabble | Disable Popup Ads | Edit this page |