[GitHub] incubator-flink pull request: FLINK-990 Scala API: Compiler Hints ...

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-flink pull request: FLINK-990 Scala API: Compiler Hints ...

zentol
GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/incubator-flink/pull/51

    FLINK-990 Scala API: Compiler Hints are not forwarded

    Added constant fields and combinable annotations forwarding to Scala API. The problem is that annotations information is not available when the Operators are created. Thus, we need a operator translation similar to the new Java API which triggers an update of the respective semantic information.  Furthermore, the Scala generated annotations are appended to the operator class, whereas the udf is checked for annotations. That's why Scala's combinableReduce operation does not generate a combinable operator.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/incubator-flink FLINK-990

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #51
   
----
commit 735e93cd17df35b7f7340c777d03e57f00562472
Author: Till Rohrmann <[hidden email]>
Date:   2014-06-30T09:45:49Z

    Added constant fields and combinable annotations forwarding to Scala API

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-flink pull request: FLINK-990 Scala API: Compiler Hints ...

zentol
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/incubator-flink/pull/51#issuecomment-47757737
 
    Changed so that all addCardinality calls will trigger an applyHints call.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---