[GitHub] incubator-flink pull request: Added Version and Revision of Strato...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-flink pull request: Added Version and Revision of Strato...

zentol
GitHub user JonathanH5 opened a pull request:

    https://github.com/apache/incubator-flink/pull/30

    Added Version and Revision of Stratosphere in Webinterface

    https://issues.apache.org/jira/browse/FLINK-946
   
    ![bildschirmfoto 2014-06-20 um 14 43 26](https://cloud.githubusercontent.com/assets/5738978/3340103/82d0485e-f878-11e3-9d15-617102ea40a3.png)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JonathanH5/incubator-flink wi_version

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #30
   
----
commit 28dc100d196505ca625cadaca51f56109b608645
Author: Jonathan <[hidden email]>
Date:   2014-06-20T12:42:23Z

    Added Version and Revision of Stratosphere in Webinterface

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-flink pull request: Added Version and Revision of Strato...

zentol
Github user twalthr commented on the pull request:

    https://github.com/apache/incubator-flink/pull/30#issuecomment-46679077
 
    I think it would be nicer not to show the commit identifier.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-flink pull request: Added Version and Revision of Strato...

zentol
In reply to this post by zentol
Github user rmetzger commented on the pull request:

    https://github.com/apache/incubator-flink/pull/30#issuecomment-46682447
 
    The ideal solution would be to show the commit identifier only for SNAPSHOT versions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-flink pull request: Added Version and Revision of Strato...

zentol
In reply to this post by zentol
Github user rmetzger commented on the pull request:

    https://github.com/apache/incubator-flink/pull/30#issuecomment-46687125
 
    Looks good, I'll merge it



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-flink pull request: Added Version and Revision of Strato...

zentol
In reply to this post by zentol
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-flink/pull/30


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---