Feel confused for the illustration of tumbling window

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Feel confused for the illustration of tumbling window

jincheng sun
Hi guys,
    Feel confused for the illustration of tumbling window, as follows:


     The Tumbling windows have a fiexd size and do not overlap, i,e., every element should be in one window. 
So, The illustration above may be confused flink user. 

      What do you think? Welcome anybody to feedback.

Thanks, 
Jincheng

Reply | Threaded
Open this post in threaded view
|

Re: Feel confused for the illustration of tumbling window

Aljoscha Krettek-2
Hi,

How do you mean? The windows in the illustration are not overlapping.

I’m very happy about suggestions for improving this, though, if anyone has one. 😃

Best,
Aljoscha

> On 13. Jul 2017, at 11:43, jincheng sun <[hidden email]> wrote:
>
> Hi guys,
>     Feel confused for the illustration of tumbling window, as follows:
>
>    
> ​https://ci.apache.org/projects/flink/flink-docs-release-1.3/dev/windows.html#tumbling-windows <x-msg://82/%E2%80%8Bhttps://ci.apache.org/projects/flink/flink-docs-release-1.3/dev/windows.html#tumbling-windows>
> https://ci.apache.org/projects/flink/flink-docs-release-1.3/fig/tumbling-windows.svg <https://ci.apache.org/projects/flink/flink-docs-release-1.3/fig/tumbling-windows.svg>
>
>      The Tumbling windows have a fiexd size and do not overlap, i,e., every element should be in one window.
> So, The illustration above may be confused flink user.
>
>       What do you think? Welcome anybody to feedback.
>
> Thanks,
> Jincheng
>

Reply | Threaded
Open this post in threaded view
|

Re: Feel confused for the illustration of tumbling window

jincheng sun
Hi Aljoscha,

I meant that delete the elements that I tag with the red grid, will be
better. What do you think?

Thanks,
Jincheng

2017-07-13 18:03 GMT+08:00 Aljoscha Krettek <[hidden email]>:

> Hi,
>
> How do you mean? The windows in the illustration are not overlapping.
>
> I’m very happy about suggestions for improving this, though, if anyone has
> one. 😃
>
> Best,
> Aljoscha
> > On 13. Jul 2017, at 11:43, jincheng sun <[hidden email]>
> wrote:
> >
> > Hi guys,
> >     Feel confused for the illustration of tumbling window, as follows:
> >
> >
> > ​https://ci.apache.org/projects/flink/flink-docs-
> release-1.3/dev/windows.html#tumbling-windows
> <x-msg://82/%E2%80%8Bhttps://ci.apache.org/projects/flink/
> flink-docs-release-1.3/dev/windows.html#tumbling-windows>
> > https://ci.apache.org/projects/flink/flink-docs-
> release-1.3/fig/tumbling-windows.svg <https://ci.apache.org/
> projects/flink/flink-docs-release-1.3/fig/tumbling-windows.svg>
> >
> >      The Tumbling windows have a fiexd size and do not overlap, i,e.,
> every element should be in one window.
> > So, The illustration above may be confused flink user.
> >
> >       What do you think? Welcome anybody to feedback.
> >
> > Thanks,
> > Jincheng
> >
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Feel confused for the illustration of tumbling window

Fabian Hueske-2
In reply to this post by Aljoscha Krettek-2
I think the point is that some elements are drawn on the window boundary.
So it is not clear to which window they would belong.

2017-07-13 12:03 GMT+02:00 Aljoscha Krettek <[hidden email]>:

> Hi,
>
> How do you mean? The windows in the illustration are not overlapping.
>
> I’m very happy about suggestions for improving this, though, if anyone has
> one. 😃
>
> Best,
> Aljoscha
> > On 13. Jul 2017, at 11:43, jincheng sun <[hidden email]>
> wrote:
> >
> > Hi guys,
> >     Feel confused for the illustration of tumbling window, as follows:
> >
> >
> > ​https://ci.apache.org/projects/flink/flink-docs-
> release-1.3/dev/windows.html#tumbling-windows
> <x-msg://82/%E2%80%8Bhttps://ci.apache.org/projects/flink/
> flink-docs-release-1.3/dev/windows.html#tumbling-windows>
> > https://ci.apache.org/projects/flink/flink-docs-
> release-1.3/fig/tumbling-windows.svg <https://ci.apache.org/
> projects/flink/flink-docs-release-1.3/fig/tumbling-windows.svg>
> >
> >      The Tumbling windows have a fiexd size and do not overlap, i,e.,
> every element should be in one window.
> > So, The illustration above may be confused flink user.
> >
> >       What do you think? Welcome anybody to feedback.
> >
> > Thanks,
> > Jincheng
> >
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Feel confused for the illustration of tumbling window

jincheng sun
Thanks Fabian, that's my meaning. -:)

2017-07-13 18:14 GMT+08:00 Fabian Hueske <[hidden email]>:

> I think the point is that some elements are drawn on the window boundary.
> So it is not clear to which window they would belong.
>
> 2017-07-13 12:03 GMT+02:00 Aljoscha Krettek <[hidden email]>:
>
> > Hi,
> >
> > How do you mean? The windows in the illustration are not overlapping.
> >
> > I’m very happy about suggestions for improving this, though, if anyone
> has
> > one. 😃
> >
> > Best,
> > Aljoscha
> > > On 13. Jul 2017, at 11:43, jincheng sun <[hidden email]>
> > wrote:
> > >
> > > Hi guys,
> > >     Feel confused for the illustration of tumbling window, as follows:
> > >
> > >
> > > ​https://ci.apache.org/projects/flink/flink-docs-
> > release-1.3/dev/windows.html#tumbling-windows
> > <x-msg://82/%E2%80%8Bhttps://ci.apache.org/projects/flink/
> > flink-docs-release-1.3/dev/windows.html#tumbling-windows>
> > > https://ci.apache.org/projects/flink/flink-docs-
> > release-1.3/fig/tumbling-windows.svg <https://ci.apache.org/
> > projects/flink/flink-docs-release-1.3/fig/tumbling-windows.svg>
> > >
> > >      The Tumbling windows have a fiexd size and do not overlap, i,e.,
> > every element should be in one window.
> > > So, The illustration above may be confused flink user.
> > >
> > >       What do you think? Welcome anybody to feedback.
> > >
> > > Thanks,
> > > Jincheng
> > >
> >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Feel confused for the illustration of tumbling window

Aljoscha Krettek-2
Ah I see, then we should fix that.

> On 13. Jul 2017, at 12:45, jincheng sun <[hidden email]> wrote:
>
> Thanks Fabian, that's my meaning. -:)
>
> 2017-07-13 18:14 GMT+08:00 Fabian Hueske <[hidden email]>:
>
>> I think the point is that some elements are drawn on the window boundary.
>> So it is not clear to which window they would belong.
>>
>> 2017-07-13 12:03 GMT+02:00 Aljoscha Krettek <[hidden email]>:
>>
>>> Hi,
>>>
>>> How do you mean? The windows in the illustration are not overlapping.
>>>
>>> I’m very happy about suggestions for improving this, though, if anyone
>> has
>>> one. 😃
>>>
>>> Best,
>>> Aljoscha
>>>> On 13. Jul 2017, at 11:43, jincheng sun <[hidden email]>
>>> wrote:
>>>>
>>>> Hi guys,
>>>>    Feel confused for the illustration of tumbling window, as follows:
>>>>
>>>>
>>>> ​https://ci.apache.org/projects/flink/flink-docs-
>>> release-1.3/dev/windows.html#tumbling-windows
>>> <x-msg://82/%E2%80%8Bhttps://ci.apache.org/projects/flink/
>>> flink-docs-release-1.3/dev/windows.html#tumbling-windows>
>>>> https://ci.apache.org/projects/flink/flink-docs-
>>> release-1.3/fig/tumbling-windows.svg <https://ci.apache.org/
>>> projects/flink/flink-docs-release-1.3/fig/tumbling-windows.svg>
>>>>
>>>>     The Tumbling windows have a fiexd size and do not overlap, i,e.,
>>> every element should be in one window.
>>>> So, The illustration above may be confused flink user.
>>>>
>>>>      What do you think? Welcome anybody to feedback.
>>>>
>>>> Thanks,
>>>> Jincheng
>>>>
>>>
>>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: Feel confused for the illustration of tumbling window

jincheng sun
I have opened PR#4322 <https://github.com/apache/flink/pull/4322> .@Aljoscha

Thanks,
Jincheng

2017-07-13 19:36 GMT+08:00 Aljoscha Krettek <[hidden email]>:

> Ah I see, then we should fix that.
>
> > On 13. Jul 2017, at 12:45, jincheng sun <[hidden email]>
> wrote:
> >
> > Thanks Fabian, that's my meaning. -:)
> >
> > 2017-07-13 18:14 GMT+08:00 Fabian Hueske <[hidden email]>:
> >
> >> I think the point is that some elements are drawn on the window
> boundary.
> >> So it is not clear to which window they would belong.
> >>
> >> 2017-07-13 12:03 GMT+02:00 Aljoscha Krettek <[hidden email]>:
> >>
> >>> Hi,
> >>>
> >>> How do you mean? The windows in the illustration are not overlapping.
> >>>
> >>> I’m very happy about suggestions for improving this, though, if anyone
> >> has
> >>> one. 😃
> >>>
> >>> Best,
> >>> Aljoscha
> >>>> On 13. Jul 2017, at 11:43, jincheng sun <[hidden email]>
> >>> wrote:
> >>>>
> >>>> Hi guys,
> >>>>    Feel confused for the illustration of tumbling window, as follows:
> >>>>
> >>>>
> >>>> ​https://ci.apache.org/projects/flink/flink-docs-
> >>> release-1.3/dev/windows.html#tumbling-windows
> >>> <x-msg://82/%E2%80%8Bhttps://ci.apache.org/projects/flink/
> >>> flink-docs-release-1.3/dev/windows.html#tumbling-windows>
> >>>> https://ci.apache.org/projects/flink/flink-docs-
> >>> release-1.3/fig/tumbling-windows.svg <https://ci.apache.org/
> >>> projects/flink/flink-docs-release-1.3/fig/tumbling-windows.svg>
> >>>>
> >>>>     The Tumbling windows have a fiexd size and do not overlap, i,e.,
> >>> every element should be in one window.
> >>>> So, The illustration above may be confused flink user.
> >>>>
> >>>>      What do you think? Welcome anybody to feedback.
> >>>>
> >>>> Thanks,
> >>>> Jincheng
> >>>>
> >>>
> >>>
> >>
>
>