FLIP 87: Primary key constraints in Table API

[dwysakowicz]

Hi everyone,

I would like to start a vote on FLIP-87.

Please vote for the following design document:

https://cwiki.apache.org/confluence/display/FLINK/FLIP+87%3A+Primary+key+constraints+in+Table+API

The discussion can be found at:

http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Primary-keys-in-Table-API-td35138.html

This voting will be open for at least 72 hours.

Best,
Dawid

[Kurt Young]

+1

Best,
Kurt


On Fri, Nov 22, 2019 at 8:51 PM Dawid Wysakowicz <[hidden email]>
wrote:

> Hi everyone,
>
> I would like to start a vote on FLIP-87.
>
> Please vote for the following design document:
> https://cwiki.apache.org/confluence/display/FLINK/FLIP+87%3A+Primary+key+constraints+in+Table+API
>
> The discussion can be found at:
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Primary-keys-in-Table-API-td35138.html
> This voting will be open for at least 72 hours.
>
> Best,
> Dawid
>
>

[Xuefu Z]

+1

On Fri, Nov 22, 2019 at 5:31 AM Kurt Young <[hidden email]> wrote:

> +1
>
> Best,
> Kurt
>
>
> On Fri, Nov 22, 2019 at 8:51 PM Dawid Wysakowicz <[hidden email]>
> wrote:
>
> > Hi everyone,
> >
> > I would like to start a vote on FLIP-87.
> >
> > Please vote for the following design document:
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP+87%3A+Primary+key+constraints+in+Table+API
> >
> > The discussion can be found at:
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Primary-keys-in-Table-API-td35138.html
> > This voting will be open for at least 72 hours.
> >
> > Best,
> > Dawid
> >
> >
>

--
Xuefu Zhang

"In Honey We Trust!"

[Timo Walther-2]

+1

Thanks,
Timo


On 23.11.19 00:28, Xuefu Z wrote:

> +1
>
> On Fri, Nov 22, 2019 at 5:31 AM Kurt Young <[hidden email]> wrote:
>
>> +1
>>
>> Best,
>> Kurt
>>
>>
>> On Fri, Nov 22, 2019 at 8:51 PM Dawid Wysakowicz <[hidden email]>
>> wrote:
>>
>>> Hi everyone,
>>>
>>> I would like to start a vote on FLIP-87.
>>>
>>> Please vote for the following design document:
>>>
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP+87%3A+Primary+key+constraints+in+Table+API
>>>
>>> The discussion can be found at:
>>>
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Primary-keys-in-Table-API-td35138.html
>>> This voting will be open for at least 72 hours.
>>>
>>> Best,
>>> Dawid
>>>
>>>
>>
>
>

[Jingsong Li]

+1 thanks dawid for driving this.

Best
Jingsong Lee

Timo Walther <[hidden email]>：

> +1
>
> Thanks,
> Timo
>
>
> On 23.11.19 00:28, Xuefu Z wrote:
> > +1
> >
> > On Fri, Nov 22, 2019 at 5:31 AM Kurt Young <[hidden email]> wrote:
> >
> >> +1
> >>
> >> Best,
> >> Kurt
> >>
> >>
> >> On Fri, Nov 22, 2019 at 8:51 PM Dawid Wysakowicz <
> [hidden email]>
> >> wrote:
> >>
> >>> Hi everyone,
> >>>
> >>> I would like to start a vote on FLIP-87.
> >>>
> >>> Please vote for the following design document:
> >>>
> >>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP+87%3A+Primary+key+constraints+in+Table+API
> >>>
> >>> The discussion can be found at:
> >>>
> >>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Primary-keys-in-Table-API-td35138.html
> >>> This voting will be open for at least 72 hours.
> >>>
> >>> Best,
> >>> Dawid
> >>>
> >>>
> >>
> >
> >
>
> --

Best, Jingsong Lee

[xingcanc]

Thanks for driving this, Dawid.

I’m +1 on it.

One minor suggestion: I think it’s better to override the `equals()` and `hashCode()` methods for `KeyConstraint`.

Thanks,
Xingcan

> On Nov 23, 2019, at 2:40 AM, Jingsong Li <[hidden email]> wrote:
>
> +1 thanks dawid for driving this.
>
> Best
> Jingsong Lee
>
> Timo Walther <[hidden email]>：
>
>> +1
>>
>> Thanks,
>> Timo
>>
>>
>> On 23.11.19 00:28, Xuefu Z wrote:
>>> +1
>>>
>>> On Fri, Nov 22, 2019 at 5:31 AM Kurt Young <[hidden email]> wrote:
>>>
>>>> +1
>>>>
>>>> Best,
>>>> Kurt
>>>>
>>>>
>>>> On Fri, Nov 22, 2019 at 8:51 PM Dawid Wysakowicz <
>> [hidden email]>
>>>> wrote:
>>>>
>>>>> Hi everyone,
>>>>>
>>>>> I would like to start a vote on FLIP-87.
>>>>>
>>>>> Please vote for the following design document:
>>>>>
>>>>
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP+87%3A+Primary+key+constraints+in+Table+API
>>>>>
>>>>> The discussion can be found at:
>>>>>
>>>>
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Primary-keys-in-Table-API-td35138.html
>>>>> This voting will be open for at least 72 hours.
>>>>>
>>>>> Best,
>>>>> Dawid
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>> --
> Best, Jingsong Lee

[Jark Wu-2]

+1 from my side.

Best,
Jark

On Sat, 23 Nov 2019 at 16:04, Xingcan Cui <[hidden email]> wrote:

> Thanks for driving this, Dawid.
>
> I’m +1 on it.
>
> One minor suggestion: I think it’s better to override the `equals()` and
> `hashCode()` methods for `KeyConstraint`.
>
> Thanks,
> Xingcan
>
> > On Nov 23, 2019, at 2:40 AM, Jingsong Li <[hidden email]> wrote:
> >
> > +1 thanks dawid for driving this.
> >
> > Best
> > Jingsong Lee
> >
> > Timo Walther <[hidden email]>：
> >
> >> +1
> >>
> >> Thanks,
> >> Timo
> >>
> >>
> >> On 23.11.19 00:28, Xuefu Z wrote:
> >>> +1
> >>>
> >>> On Fri, Nov 22, 2019 at 5:31 AM Kurt Young <[hidden email]> wrote:
> >>>
> >>>> +1
> >>>>
> >>>> Best,
> >>>> Kurt
> >>>>
> >>>>
> >>>> On Fri, Nov 22, 2019 at 8:51 PM Dawid Wysakowicz <
> >> [hidden email]>
> >>>> wrote:
> >>>>
> >>>>> Hi everyone,
> >>>>>
> >>>>> I would like to start a vote on FLIP-87.
> >>>>>
> >>>>> Please vote for the following design document:
> >>>>>
> >>>>
> >>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP+87%3A+Primary+key+constraints+in+Table+API
> >>>>>
> >>>>> The discussion can be found at:
> >>>>>
> >>>>
> >>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Primary-keys-in-Table-API-td35138.html
> >>>>> This voting will be open for at least 72 hours.
> >>>>>
> >>>>> Best,
> >>>>> Dawid
> >>>>>
> >>>>>
> >>>>
> >>>
> >>>
> >>
> >> --
> > Best, Jingsong Lee
>
>

[Danny Chan]

Thanks for the work, Dawid, a big + 1 !

Best,
Danny Chan
在 2019年11月22日 +0800 PM8:51，Dawid Wysakowicz <[hidden email]>，写道：

> Hi everyone,
>
> I would like to start a vote on FLIP-87.
>
> Please vote for the following design document:
>
> https://cwiki.apache.org/confluence/display/FLINK/FLIP+87%3A+Primary+key+constraints+in+Table+API
>
> The discussion can be found at:
>
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Primary-keys-in-Table-API-td35138.html
>
> This voting will be open for at least 72 hours.
>
> Best,
> Dawid

[dwysakowicz]

Thanks all for the voting. I'm closing the vote now.
So far, the votes received:

* +1 votes (4 binding, 3 non-binding):
- Kurt Young (binding)
- Timo (binding)
- Xingcan Cui (binding)
- Jark Wu (binding)

- Xuefu Z (non-binding)
- Jingsong Li (non-binding)
- Danny Chan (non-binding)

* 0/-1 votes: none

Thereby, the community accepted FLIP-87

BTW, Please, at least use your apache addresses in the future for voting
threads. Otherwise it is hard to verify if the vote is binding or not.

@Xingcan, Yes I will add a proper equals/hashCode implementations, thank
you for pointing that out. In FLIPs we need to list only the user facing
interfaces. Implementation in general does not necessarily has to be a
subject of a FLIP. That's why it's not mandatory to list it in the FLIP
imo, but you are right that if I included some of the implementation
already I should've listed that as well.

Best,
Dawid

On 25/11/2019 02:06, Danny Chan wrote:

> Thanks for the work, Dawid, a big + 1 !
>
> Best,
> Danny Chan
> 在 2019年11月22日 +0800 PM8:51，Dawid Wysakowicz <[hidden email]>，写道：
>> Hi everyone,
>>
>> I would like to start a vote on FLIP-87.
>>
>> Please vote for the following design document:
>>
>> https://cwiki.apache.org/confluence/display/FLINK/FLIP+87%3A+Primary+key+constraints+in+Table+API
>>
>> The discussion can be found at:
>>
>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Primary-keys-in-Table-API-td35138.html
>>
>> This voting will be open for at least 72 hours.
>>
>> Best,
>> Dawid