FLINK-2066

[Nuno Santos]

Hi guys.

I've been digging around the docs for the last few days and I am now ready
to have a go at my first contribution.

I chose FLINK-2066 <https://issues.apache.org/jira/browse/FLINK-2066> and I
am looking for some guidance.

I understand the change will be associated to the ExecutionConfig class,
which is reference by the Execution Environment.

I made my way through the code to the LocalEnvironment and LocalExecutor.

However, besides setters and getters, I do not see where the
numberOfExecutionRetries is used in the execution itself?

Any pointers on where to look will be appreciated, I will continue to make
my way through the code to see what else I can find.

Thanks,
Nuno.

[Márton Balassi]

Hey,

Thanks for picking up the issue. This value can be specified as
"execution-retries.delay" in the flink-conf.yaml. Hence you can check the
associated value in the ConfigConstants [1] and track the way it is used.
It is passed a couple of times, but is ultimately used in ExecutionGraph.
[2]

[1]
https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java#L54
[2]
https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java#L714

Best,

Marton


On Sun, Jun 28, 2015 at 1:56 PM, Nuno Santos <[hidden email]>
wrote:

> Hi guys.
>
> I've been digging around the docs for the last few days and I am now ready
> to have a go at my first contribution.
>
> I chose FLINK-2066 <https://issues.apache.org/jira/browse/FLINK-2066> and
> I
> am looking for some guidance.
>
> I understand the change will be associated to the ExecutionConfig class,
> which is reference by the Execution Environment.
>
> I made my way through the code to the LocalEnvironment and LocalExecutor.
>
> However, besides setters and getters, I do not see where the
> numberOfExecutionRetries is used in the execution itself?
>
> Any pointers on where to look will be appreciated, I will continue to make
> my way through the code to see what else I can find.
>
> Thanks,
> Nuno.
>

[Chiwan Park-2]

We should assign FLINK-2066 to Nuno. :)

Regards,
Chiwan Park

> On Jun 29, 2015, at 1:21 PM, Márton Balassi <[hidden email]> wrote:
>
> Hey,
>
> Thanks for picking up the issue. This value can be specified as
> "execution-retries.delay" in the flink-conf.yaml. Hence you can check the
> associated value in the ConfigConstants [1] and track the way it is used.
> It is passed a couple of times, but is ultimately used in ExecutionGraph.
> [2]
>
> [1]
> https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java#L54
> [2]
> https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java#L714
>
> Best,
>
> Marton
>
>
> On Sun, Jun 28, 2015 at 1:56 PM, Nuno Santos <[hidden email]>
> wrote:
>
>> Hi guys.
>>
>> I've been digging around the docs for the last few days and I am now ready
>> to have a go at my first contribution.
>>
>> I chose FLINK-2066 <https://issues.apache.org/jira/browse/FLINK-2066> and
>> I
>> am looking for some guidance.
>>
>> I understand the change will be associated to the ExecutionConfig class,
>> which is reference by the Execution Environment.
>>
>> I made my way through the code to the LocalEnvironment and LocalExecutor.
>>
>> However, besides setters and getters, I do not see where the
>> numberOfExecutionRetries is used in the execution itself?
>>
>> Any pointers on where to look will be appreciated, I will continue to make
>> my way through the code to see what else I can find.
>>
>> Thanks,
>> Nuno.
>>

[Till Rohrmann]

Done

On Mon, Jun 29, 2015 at 9:33 AM, Chiwan Park <[hidden email]> wrote:

> We should assign FLINK-2066 to Nuno. :)
>
> Regards,
> Chiwan Park
>
> > On Jun 29, 2015, at 1:21 PM, Márton Balassi <[hidden email]>
> wrote:
> >
> > Hey,
> >
> > Thanks for picking up the issue. This value can be specified as
> > "execution-retries.delay" in the flink-conf.yaml. Hence you can check the
> > associated value in the ConfigConstants [1] and track the way it is used.
> > It is passed a couple of times, but is ultimately used in ExecutionGraph.
> > [2]
> >
> > [1]
> >
> https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java#L54
> > [2]
> >
> https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java#L714
> >
> > Best,
> >
> > Marton
> >
> >
> > On Sun, Jun 28, 2015 at 1:56 PM, Nuno Santos <[hidden email]
> >
> > wrote:
> >
> >> Hi guys.
> >>
> >> I've been digging around the docs for the last few days and I am now
> ready
> >> to have a go at my first contribution.
> >>
> >> I chose FLINK-2066 <https://issues.apache.org/jira/browse/FLINK-2066>
> and
> >> I
> >> am looking for some guidance.
> >>
> >> I understand the change will be associated to the ExecutionConfig class,
> >> which is reference by the Execution Environment.
> >>
> >> I made my way through the code to the LocalEnvironment and
> LocalExecutor.
> >>
> >> However, besides setters and getters, I do not see where the
> >> numberOfExecutionRetries is used in the execution itself?
> >>
> >> Any pointers on where to look will be appreciated, I will continue to
> make
> >> my way through the code to see what else I can find.
> >>
> >> Thanks,
> >> Nuno.
> >>
>
>
>

[Stephan Ewen]

Hi Nuno!

Ultimately, the delay is a property of the ExecutionGraph. The
ExecutionGraph is the data structure on the master (JobManager) that tracks
the distributed execution.

The property is set in the method "JobManager.submitJob(...)", which is
called when a new job is sent to the cluster.

Hope that helps!

Greetings,
Stephan




On Mon, Jun 29, 2015 at 9:46 AM, Till Rohrmann <[hidden email]> wrote:

> Done
>
> On Mon, Jun 29, 2015 at 9:33 AM, Chiwan Park <[hidden email]>
> wrote:
>
> > We should assign FLINK-2066 to Nuno. :)
> >
> > Regards,
> > Chiwan Park
> >
> > > On Jun 29, 2015, at 1:21 PM, Márton Balassi <[hidden email]>
> > wrote:
> > >
> > > Hey,
> > >
> > > Thanks for picking up the issue. This value can be specified as
> > > "execution-retries.delay" in the flink-conf.yaml. Hence you can check
> the
> > > associated value in the ConfigConstants [1] and track the way it is
> used.
> > > It is passed a couple of times, but is ultimately used in
> ExecutionGraph.
> > > [2]
> > >
> > > [1]
> > >
> >
> https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java#L54
> > > [2]
> > >
> >
> https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java#L714
> > >
> > > Best,
> > >
> > > Marton
> > >
> > >
> > > On Sun, Jun 28, 2015 at 1:56 PM, Nuno Santos <
> [hidden email]
> > >
> > > wrote:
> > >
> > >> Hi guys.
> > >>
> > >> I've been digging around the docs for the last few days and I am now
> > ready
> > >> to have a go at my first contribution.
> > >>
> > >> I chose FLINK-2066 <https://issues.apache.org/jira/browse/FLINK-2066>
> > and
> > >> I
> > >> am looking for some guidance.
> > >>
> > >> I understand the change will be associated to the ExecutionConfig
> class,
> > >> which is reference by the Execution Environment.
> > >>
> > >> I made my way through the code to the LocalEnvironment and
> > LocalExecutor.
> > >>
> > >> However, besides setters and getters, I do not see where the
> > >> numberOfExecutionRetries is used in the execution itself?
> > >>
> > >> Any pointers on where to look will be appreciated, I will continue to
> > make
> > >> my way through the code to see what else I can find.
> > >>
> > >> Thanks,
> > >> Nuno.
> > >>
> >
> >
> >
>

[Nuno Santos]

Thank you all for the help, it is appreciated!

2015-06-29 9:12 GMT+01:00 Stephan Ewen <[hidden email]>:

> Hi Nuno!
>
> Ultimately, the delay is a property of the ExecutionGraph. The
> ExecutionGraph is the data structure on the master (JobManager) that tracks
> the distributed execution.
>
> The property is set in the method "JobManager.submitJob(...)", which is
> called when a new job is sent to the cluster.
>
> Hope that helps!
>
> Greetings,
> Stephan
>
>
>
>
> On Mon, Jun 29, 2015 at 9:46 AM, Till Rohrmann <[hidden email]>
> wrote:
>
> > Done
> >
> > On Mon, Jun 29, 2015 at 9:33 AM, Chiwan Park <[hidden email]>
> > wrote:
> >
> > > We should assign FLINK-2066 to Nuno. :)
> > >
> > > Regards,
> > > Chiwan Park
> > >
> > > > On Jun 29, 2015, at 1:21 PM, Márton Balassi <
> [hidden email]>
> > > wrote:
> > > >
> > > > Hey,
> > > >
> > > > Thanks for picking up the issue. This value can be specified as
> > > > "execution-retries.delay" in the flink-conf.yaml. Hence you can check
> > the
> > > > associated value in the ConfigConstants [1] and track the way it is
> > used.
> > > > It is passed a couple of times, but is ultimately used in
> > ExecutionGraph.
> > > > [2]
> > > >
> > > > [1]
> > > >
> > >
> >
> https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java#L54
> > > > [2]
> > > >
> > >
> >
> https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java#L714
> > > >
> > > > Best,
> > > >
> > > > Marton
> > > >
> > > >
> > > > On Sun, Jun 28, 2015 at 1:56 PM, Nuno Santos <
> > [hidden email]
> > > >
> > > > wrote:
> > > >
> > > >> Hi guys.
> > > >>
> > > >> I've been digging around the docs for the last few days and I am now
> > > ready
> > > >> to have a go at my first contribution.
> > > >>
> > > >> I chose FLINK-2066 <
> https://issues.apache.org/jira/browse/FLINK-2066>
> > > and
> > > >> I
> > > >> am looking for some guidance.
> > > >>
> > > >> I understand the change will be associated to the ExecutionConfig
> > class,
> > > >> which is reference by the Execution Environment.
> > > >>
> > > >> I made my way through the code to the LocalEnvironment and
> > > LocalExecutor.
> > > >>
> > > >> However, besides setters and getters, I do not see where the
> > > >> numberOfExecutionRetries is used in the execution itself?
> > > >>
> > > >> Any pointers on where to look will be appreciated, I will continue
> to
> > > make
> > > >> my way through the code to see what else I can find.
> > > >>
> > > >> Thanks,
> > > >> Nuno.
> > > >>
> > >
> > >
> > >
> >
>